net: Create and use new helper, neigh_output().
David S. Miller [Sun, 17 Jul 2011 00:26:00 +0000 (17:26 -0700)]
Signed-off-by: David S. Miller <davem@davemloft.net>

include/net/neighbour.h
net/ipv4/ip_output.c
net/ipv6/ip6_output.c

index bd8f9f0..337da24 100644 (file)
@@ -344,6 +344,15 @@ static inline int neigh_hh_output(struct hh_cache *hh, struct sk_buff *skb)
        return hh->hh_output(skb);
 }
 
+static inline int neigh_output(struct neighbour *n, struct sk_buff *skb)
+{
+       struct hh_cache *hh = &n->hh;
+       if (hh->hh_len)
+               return neigh_hh_output(hh, skb);
+       else
+               return n->output(skb);
+}
+
 static inline struct neighbour *
 __neigh_lookup(struct neigh_table *tbl, const void *pkey, struct net_device *dev, int creat)
 {
index 1ac674a..db296a9 100644 (file)
@@ -205,13 +205,9 @@ static inline int ip_finish_output2(struct sk_buff *skb)
        }
 
        neigh = dst->neighbour;
-       if (neigh) {
-               struct hh_cache *hh = &neigh->hh;
-               if (hh->hh_len)
-                       return neigh_hh_output(hh, skb);
-               else
-                       return neigh->output(skb);
-       }
+       if (neigh)
+               return neigh_output(neigh, skb);
+
        if (net_ratelimit())
                printk(KERN_DEBUG "ip_finish_output2: No header cache and no neighbour!\n");
        kfree_skb(skb);
index 36362e9..eb50bb0 100644 (file)
@@ -136,13 +136,9 @@ static int ip6_finish_output2(struct sk_buff *skb)
        }
 
        neigh = dst->neighbour;
-       if (neigh) {
-               struct hh_cache *hh = &neigh->hh;
-               if (hh->hh_len)
-                       return neigh_hh_output(hh, skb);
-               else
-                       return neigh->output(skb);
-       }
+       if (neigh)
+               return neigh_output(neigh, skb);
+
        IP6_INC_STATS_BH(dev_net(dst->dev),
                         ip6_dst_idev(dst), IPSTATS_MIB_OUTNOROUTES);
        kfree_skb(skb);