sdio_uart: Fix oops caused by the previous changeset
Nicolas Pitre [Thu, 5 Nov 2009 13:28:17 +0000 (13:28 +0000)]
Now... testing reveals that the very first patch "sdio_uart: use
tty_port" causes a segmentation fault in sdio_uart_open():

Unable to handle kernel NULL pointer dereference at virtual address 00000084
pgd = dfb44000 [00000084] *pgd=1fb99031, *pte=00000000, *ppte=00000000
Internal error: Oops: 17 [#1] PREEMPT
last sysfs file:
/sys/devices/platform/mvsdio/mmc_host/mmc0/mmc0:f111/uevent
Modules linked in:
CPU: 0    Not tainted  (2.6.32-rc5-next-20091102-00001-gb36eae9 #10)
PC is at sdio_uart_open+0x204/0x2cc
[...]

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

drivers/mmc/card/sdio_uart.c

index c2759db..671fe5e 100644 (file)
@@ -608,7 +608,7 @@ static int sdio_uart_startup(struct sdio_uart_port *port)
                if (!(sdio_uart_get_mctrl(port) & TIOCM_CTS))
                        tty->hw_stopped = 1;
 
-       clear_bit(TTY_IO_ERROR, &port->tty->flags);
+       clear_bit(TTY_IO_ERROR, &tty->flags);
 
        /* Kick the IRQ handler once while we're still holding the host lock */
        sdio_uart_irq(port->func);