rds: Make rds_sock_lock BH rather than IRQ safe.
authorDavid S. Miller <davem@davemloft.net>
Tue, 24 Jan 2012 22:03:44 +0000 (17:03 -0500)
committerSimone Willett <swillett@nvidia.com>
Wed, 8 Feb 2012 22:31:29 +0000 (14:31 -0800)
commitfd0ee4525f9cd149b960a1b33e86129eaede864c
tree6d7f425b6e18666a654e5d5f004e1a9fb7da13e4
parenta22276fb510bc511687c067dfbc9ec609efcae6a
rds: Make rds_sock_lock BH rather than IRQ safe.

[ Upstream commit efc3dbc37412c027e363736b4f4c74ee5e8ecffc ]

rds_sock_info() triggers locking warnings because we try to perform a
local_bh_enable() (via sock_i_ino()) while hardware interrupts are
disabled (via taking rds_sock_lock).

There is no reason for rds_sock_lock to be a hardware IRQ disabling
lock, none of these access paths run in hardware interrupt context.

Therefore making it a BH disabling lock is safe and sufficient to
fix this bug.

Reported-by: Kumar Sanghvi <kumaras@chelsio.com>
Reported-by: Josh Boyer <jwboyer@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Varun Wadekar <vwadekar@nvidia.com>
Change-Id: Ie8ac0fd3307c1d827994aa113764bc3ad96ab1a3
Reviewed-on: http://git-master/r/79695
Reviewed-by: Automatic_Commit_Validation_User
net/rds/af_rds.c