bonding: fix error handling if slave is busy (v2)
authorstephen hemminger <shemminger@vyatta.com>
Sat, 31 Dec 2011 13:26:46 +0000 (13:26 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 3 Jan 2012 17:49:16 +0000 (12:49 -0500)
commitf7d9821a6a9c83450ac35e76d3709e32fd38b76f
treed9cfb0a3ddba80a7d3fd6ed8064144d90f5ba8af
parentf872b237c1750221932e715da2552225afe4a95c
bonding: fix error handling if slave is busy (v2)

If slave device already has a receive handler registered, then the
error unwind of bonding device enslave function is broken.

The following will leave a pointer to freed memory in the slave
device list, causing a later kernel panic.
# modprobe dummy
# ip li add dummy0-1 link dummy0 type macvlan
# modprobe bonding
# echo +dummy0 >/sys/class/net/bond0/bonding/slaves

The fix is to detach the slave (which removes it from the list)
in the unwind path.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Reviewed-by: Nicolas de Peslo√ľan <nicolas.2p.debian@free.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_main.c