KEYS: Fix variable uninitialisation warnings
authorDavid Howells <dhowells@redhat.com>
Mon, 29 Dec 2008 00:41:51 +0000 (00:41 +0000)
committerJames Morris <jmorris@namei.org>
Mon, 29 Dec 2008 03:24:43 +0000 (14:24 +1100)
commiteca1bf5b4fab56d2feb1572d34d59fcd92ea7df3
tree58ce85049625d01d52f3b32a6035bce9dbbc4ebf
parent3c92ec8ae91ecf59d88c798301833d7cf83f2179
KEYS: Fix variable uninitialisation warnings

Fix variable uninitialisation warnings introduced in:

commit 8bbf4976b59fc9fc2861e79cab7beb3f6d647640
Author: David Howells <dhowells@redhat.com>
Date:   Fri Nov 14 10:39:14 2008 +1100

KEYS: Alter use of key instantiation link-to-keyring argument

As:

  security/keys/keyctl.c: In function 'keyctl_negate_key':
  security/keys/keyctl.c:976: warning: 'dest_keyring' may be used uninitialized in this function
  security/keys/keyctl.c: In function 'keyctl_instantiate_key':
  security/keys/keyctl.c:898: warning: 'dest_keyring' may be used uninitialized in this function

Some versions of gcc notice that get_instantiation_key() doesn't always set
*_dest_keyring, but fail to observe that if this happens then *_dest_keyring
will not be read by the caller.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>
security/keys/keyctl.c