perf: Fix static strings treated like dynamic ones
authorFrederic Weisbecker <fweisbec@gmail.com>
Wed, 5 May 2010 20:07:39 +0000 (22:07 +0200)
committerIngo Molnar <mingo@elte.hu>
Tue, 11 May 2010 07:14:24 +0000 (09:14 +0200)
commitde068ec048f807d4f62b7dda100c23a1365f086f
tree9d7d7be670747628e2e5ea93db5418ddeb7d739a
parent722154e4cacf015161efe60009ae9be23d492296
perf: Fix static strings treated like dynamic ones

The raw_field_ptr() helper, used to retrieve the address of a field
inside a trace event, treats every strings as if they were dynamic
ie: having a secondary level of indirection to retrieve their
contents.

FIELD_IS_STRING doesn't mean FIELD_IS_DYNAMIC, we only need to
compute the secondary dereference for the latter case.

This fixes perf sched segfaults, bad cmdline report and may be
some other bugs.

Reported-by: Jason Baron <jbaron@redhat.com>
Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Tom Zanussi <tzanussi@gmail.com>
tools/perf/util/trace-event-parse.c