xfs: unlock items before allowing the CIL to commit
authorDave Chinner <dchinner@redhat.com>
Tue, 24 Aug 2010 01:42:52 +0000 (11:42 +1000)
committerDave Chinner <david@fromorbit.com>
Tue, 24 Aug 2010 01:42:52 +0000 (11:42 +1000)
commitd17c701ce6a548a92f7f8a3cec20299465f36ee3
tree26a4e52b998edf3762baea43c0d9755118240c8d
parent76be97c1fc945db08aae1f1b746012662d643e97
xfs: unlock items before allowing the CIL to commit

When we commit a transaction using delayed logging, we need to
unlock the items in the transaciton before we unlock the CIL context
and allow it to be checkpointed. If we unlock them after we release
the CIl context lock, the CIL can checkpoint and complete before
we free the log items. This breaks stale buffer item unlock and
unpin processing as there is an implicit assumption that the unlock
will occur before the unpin.

Also, some log items need to store the LSN of the transaction commit
in the item (inodes and EFIs) and so can race with other transaction
completions if we don't prevent the CIL from checkpointing before
the unlock occurs.

Cc: <stable@kernel.org>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
fs/xfs/xfs_log_cil.c
fs/xfs/xfs_trans.c
fs/xfs/xfs_trans_priv.h