sysctl: fix write access to dmesg_restrict/kptr_restrict
authorKees Cook <keescook@chromium.org>
Wed, 4 Apr 2012 18:40:19 +0000 (11:40 -0700)
committerVarun Wadekar <vwadekar@nvidia.com>
Wed, 18 Apr 2012 13:26:09 +0000 (18:26 +0530)
commitd0f44b41062c60446fbd7eb07915cc180779c03f
tree91aa7760e6d72889d1d4c10f1f863a49c8f18df2
parent3b925bd3f04dc82c06bc2e8df62b338598b019a7
sysctl: fix write access to dmesg_restrict/kptr_restrict

Commit bfdc0b4 adds code to restrict access to dmesg_restrict,
however, it incorrectly alters kptr_restrict rather than
dmesg_restrict.

The original patch from Richard Weinberger
(https://lkml.org/lkml/2011/3/14/362) alters dmesg_restrict as
expected, and so the patch seems to have been misapplied.

This adds the CAP_SYS_ADMIN check to both dmesg_restrict and
kptr_restrict, since both are sensitive.

Reported-by: Phillip Lougher <plougher@redhat.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
Acked-by: Richard Weinberger <richard@nod.at>
Cc: stable@vger.kernel.org
Signed-off-by: James Morris <james.l.morris@oracle.com>
kernel/sysctl.c