ASoC: tlv320aic3x: Fix codec pll configure bug
authorHebbar, Gururaja <gururaja.hebbar@ti.com>
Tue, 26 Jun 2012 13:55:11 +0000 (18:55 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 16 Jul 2012 16:04:05 +0000 (09:04 -0700)
commitbecbf4ebbb41acee5c0dcf2851af6bd84964fc00
tree2eae992d071980059a99c3458d72a56c2ae9e729
parent78713ddf9b1d43729c9d497072b63f6dcee17d15
ASoC: tlv320aic3x: Fix codec pll configure bug

commit c9fe573a6584034670c1a55ee8162d623519cbbf upstream.

In sound/soc/codecs/tlv320aic3x.c

        data = snd_soc_read(codec, AIC3X_PLL_PROGA_REG);
        snd_soc_write(codec, AIC3X_PLL_PROGA_REG,
                      data | (pll_p << PLLP_SHIFT));

In the above code, pll-p value is OR'ed with previous value without
clearing it. Bug is not seen if pll-p value doesn't change across
Sampling frequency.

However on some platforms (like AM335x EVM-SK), pll-p may have different
values across different sampling frequencies. In such case, above code
configures the pll with a wrong value.
Because of this bug, when a audio stream is played with pll value
different from previous stream, audio is heard as differently(like its
stretched).

Signed-off-by: Hebbar, Gururaja <gururaja.hebbar@ti.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/codecs/tlv320aic3x.c
sound/soc/codecs/tlv320aic3x.h