watchdog: cpwd: Fix buffer-overflow
authorWim Van Sebroeck <wim@iguana.be>
Mon, 21 Feb 2011 10:52:43 +0000 (10:52 +0000)
committerWim Van Sebroeck <wim@iguana.be>
Mon, 14 Mar 2011 10:39:27 +0000 (10:39 +0000)
commitbbd562d717a84c6464211e8bd5efa0d9e25edc6d
tree7dd79ba99653747dc9b9aa5b776c94859ec9a64c
parentc44ed965be7a84afaa07543c04eb97a5dfe93422
watchdog: cpwd: Fix buffer-overflow

cppcheck-1.47 reports:
[drivers/watchdog/cpwd.c:650]: (error) Buffer access out-of-bounds: p.devs

The source code is
for (i = 0; i < 4; i++) {
misc_deregister(&p->devs[i].misc);

where devs is defined as WD_NUMDEVS big and WD_NUMDEVS is equal to 3.
So the 4 should be a 3 or WD_NUMDEVS.

Reported-By: David Binderman
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/cpwd.c