dynamic debug: move ddebug_remove_module() down into free_module()
authorJason Baron <jbaron@redhat.com>
Tue, 27 Jul 2010 20:18:01 +0000 (13:18 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 27 Jul 2010 21:32:06 +0000 (14:32 -0700)
commitb82bab4bbe9efa7bc7177fc20620fff19bd95484
treec033a090fbd3caa61f2f3b6ece52c0b4dffeb229
parentd15aa2cc641bd193596382357de917b32f1b40cb
dynamic debug: move ddebug_remove_module() down into free_module()

The command

echo "file ec.c +p" >/sys/kernel/debug/dynamic_debug/control

causes an oops.

Move the call to ddebug_remove_module() down into free_module().  In this
way it should be called from all error paths.  Currently, we are missing
the remove if the module init routine fails.

Signed-off-by: Jason Baron <jbaron@redhat.com>
Reported-by: Thomas Renninger <trenn@suse.de>
Tested-by: Thomas Renninger <trenn@suse.de>
Cc: <stable@kernel.org> [2.6.32+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/module.c