FS-Cache: Fix __fscache_uncache_all_inode_pages()'s outer loop
authorJan Beulich <JBeulich@novell.com>
Thu, 21 Jul 2011 14:02:43 +0000 (15:02 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 21 Jul 2011 17:59:16 +0000 (10:59 -0700)
commitb307d4655a71749ac3f91c6dbe33d28cc026ceeb
tree4d00cd36cf277da7e45333d2a0574bf4a523cc58
parentcf6ace16a3cd8b728fb0afa68368fd40bbeae19f
FS-Cache: Fix __fscache_uncache_all_inode_pages()'s outer loop

The compiler, at least for ix86 and m68k, validly warns that the
comparison:

next <= (loff_t)-1

is always true (and it's always true also for x86-64 and probably all
other arches - as long as pgoff_t isn't wider than loff_t).  The
intention appears to be to avoid wrapping of "next", so rather than
eliminating the pointless comparison, fix the loop to indeed get exited
when "next" would otherwise wrap.

On m68k the following warning is observed:

  fs/fscache/page.c: In function '__fscache_uncache_all_inode_pages':
  fs/fscache/page.c:979: warning: comparison is always false due to limited range of data type

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reported-by: Jan Beulich <jbeulich@novell.com>
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Cc: Suresh Jayaraman <sjayaraman@suse.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/fscache/page.c