rtc: stmp3xxx: Initialize drvdata before registering device
authorWolfram Sang <w.sang@pengutronix.de>
Wed, 25 May 2011 10:56:51 +0000 (12:56 +0200)
committerJohn Stultz <john.stultz@linaro.org>
Sat, 2 Jul 2011 01:09:55 +0000 (18:09 -0700)
commita91d2bab355f3a5caa767d7316f80422bfcd2ad6
treed195bca36a8b606c58280011ef06cd6c5ec616bc
parent46b21218145ecef0936eb4338a9e0ffef84f00cf
rtc: stmp3xxx: Initialize drvdata before registering device

Commit f44f7f96a20 ("RTC: Initialize kernel state from RTC") uncovered
an issue in a number of RTC drivers, where the drivers call
rtc_device_register before initializing the device or platform drvdata.

This frequently results in null pointer dereferences when the
rtc_device_register immediately makes use of the rtc device, calling
rtc_read_alarm.

The solution is to ensure the drvdata is initialized prior to registering
the rtc device.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Tested-by: Shawn Guo <shawn.guo@freescale.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
drivers/rtc/rtc-stmp3xxx.c