powerpc/numa: Remove double of_node_put in hot_add_node_scn_to_nid
authorAnton Blanchard <anton@samba.org>
Wed, 10 Aug 2011 20:44:21 +0000 (20:44 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 11 Nov 2011 17:44:39 +0000 (09:44 -0800)
commit9d99c1d2bd6aedb02a70d2cb9f1edb0b416a443e
tree6306500ce2f39b9995af1ea5be9ba7660612d57f
parent8981e86717bf2d682bf08db846d7daafd9fb6a45
powerpc/numa: Remove double of_node_put in hot_add_node_scn_to_nid

commit 6083184269fd723affca4f6340e491950267622a upstream.

During memory hotplug testing, I got the following warning:

ERROR: Bad of_node_put() on /memory@0

of_node_release
kref_put
of_node_put
of_find_node_by_type
hot_add_node_scn_to_nid
hot_add_scn_to_nid
memory_add_physaddr_to_nid
...

of_find_node_by_type() loop does the of_node_put for us so we only
need the handle the case where we terminate the loop early.

As suggested by Stephen Rothwell we can do the of_node_put
unconditionally outside of the loop since of_node_put handles a
NULL argument fine.

Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/powerpc/mm/numa.c