e1000e: fix double initialization in blink path
authorHolger Eitzenberger <holger@eitzenberger.org>
Wed, 17 Nov 2010 15:43:52 +0000 (15:43 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Sat, 11 Dec 2010 06:13:01 +0000 (22:13 -0800)
commit9633e63bb1d82c02950983d5d3317e6656b11c8e
treefb13f79801a120a73a2e72c78c60df3cdc30ec44
parent9fe93afdd07aba52a018eb52784124579a80470e
e1000e: fix double initialization in blink path

The kernel goes BUG() at the time 'ethtool -p eth0 3' comes
back, which is due to adapter->led_blink_task initialized
several times.  At the time it is still running this results
in a corrupted task_list of the associated workqueue.

The fix is to move the workqueue initialization to the
probe function instead.

Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Emil Tantilov <emil.s.tantilov@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/e1000e/e1000.h
drivers/net/e1000e/ethtool.c
drivers/net/e1000e/netdev.c