watchdog: sp5100_tco.c: Check if firmware has set correct value in tcobase.
authorYinghai Lu <yinghai@kernel.org>
Thu, 17 Mar 2011 03:01:07 +0000 (20:01 -0700)
committerWim Van Sebroeck <wim@iguana.be>
Tue, 29 Mar 2011 11:05:57 +0000 (11:05 +0000)
commit90d241edd13bdeef70f264b569f7e150bf23621e
tree2d7ac02fec4664fee64c578c43603d02dc2dc4af
parentf712eacf02ecfbf4f1686addb8c569841549b0b7
watchdog: sp5100_tco.c: Check if firmware has set correct value in tcobase.

Stefano found SP5100 TCO watchdog driver using wrong address.

[    9.148536] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01
[    9.148628] DEBUG __ioremap_caller WARNING address=b8fe00 size=8 valid=1 reserved=1

and e820 said that range is RAM.

We should check if we can use that reading out. BIOS could just program wrong address there.

Reported-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by:Yinghai Lu <yinghai@kernel.org>
Acked-by: Mike Waychison <mikew@google.com>
Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Cc: stable <stable@kernel.org>
drivers/watchdog/sp5100_tco.c