virtio-pci: fix use after free
authorMichael S. Tsirkin <mst@redhat.com>
Mon, 7 Nov 2011 16:37:05 +0000 (18:37 +0200)
committerRusty Russell <rusty@rustcorp.com.au>
Mon, 14 Nov 2011 00:46:26 +0000 (10:46 +1030)
commit72103bd1285211440621f2c46f4fce377584de54
tree5bde795c7150c0802fb5a9c9e8603580e6febeae
parent1ea6b8f48918282bdca0b32a34095504ee65bab5
virtio-pci: fix use after free

Commit 31a3ddda166cda86d2b5111e09ba4bda5239fae6 introduced
a use after free in virtio-pci. The main issue is
that the release method signals removal of the virtio device,
while remove signals removal of the pci device.

For example, on driver removal or hot-unplug,
virtio_pci_release_dev is called before virtio_pci_remove.
We then might get a crash as virtio_pci_remove tries to use the
device freed by virtio_pci_release_dev.

We allocate/free all resources together with the
pci device, so we can leave the release method empty.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: stable@kernel.org
drivers/virtio/virtio_pci.c