net: Compute protocol sequence numbers and fragment IDs using MD5.
authorDavid S. Miller <davem@davemloft.net>
Thu, 4 Aug 2011 03:50:44 +0000 (20:50 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 7 Aug 2011 01:33:19 +0000 (18:33 -0700)
commit6e5714eaf77d79ae1c8b47e3e040ff5411b717ec
tree30bd0d7a6a0a6ff0ace6da1835ae7b7167cce5e4
parentbc0b96b54a21246e377122d54569eef71cec535f
net: Compute protocol sequence numbers and fragment IDs using MD5.

Computers have become a lot faster since we compromised on the
partial MD4 hash which we use currently for performance reasons.

MD5 is a much safer choice, and is inline with both RFC1948 and
other ISS generators (OpenBSD, Solaris, etc.)

Furthermore, only having 24-bits of the sequence number be truly
unpredictable is a very serious limitation.  So the periodic
regeneration and 8-bit counter have been removed.  We compute and
use a full 32-bit sequence number.

For ipv6, DCCP was found to use a 32-bit truncated initial sequence
number (it needs 43-bits) and that is fixed here as well.

Reported-by: Dan Kaminsky <dan@doxpara.com>
Tested-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: David S. Miller <davem@davemloft.net>
14 files changed:
drivers/char/random.c
include/linux/random.h
include/net/secure_seq.h [new file with mode: 0644]
net/core/Makefile
net/core/secure_seq.c [new file with mode: 0644]
net/dccp/ipv4.c
net/dccp/ipv6.c
net/ipv4/inet_hashtables.c
net/ipv4/inetpeer.c
net/ipv4/netfilter/nf_nat_proto_common.c
net/ipv4/route.c
net/ipv4/tcp_ipv4.c
net/ipv6/inet6_hashtables.c
net/ipv6/tcp_ipv6.c