powerpc/gamecube/wii: Fix off-by-one error in ugecon/usbgecko_udbg
authorAlbert Herranz <albert_herranz@yahoo.es>
Thu, 17 Dec 2009 08:33:41 +0000 (08:33 +0000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Fri, 18 Dec 2009 04:13:57 +0000 (15:13 +1100)
commit698cd335a782561b79504d4e98c7df62b08e7abd
tree44b3056c81ff1032ffd6c6681cf9e08c12746af8
parent38e1313fc753482b93aa6c6f11cfbd43a5bcd963
powerpc/gamecube/wii: Fix off-by-one error in ugecon/usbgecko_udbg

The retry logic in ug_putc() is broken.

If the TX fifo is not ready and the counter runs out it will have a
value of -1 and no transfer should be attempted. Also, a counter
with a value of 0 means that the TX fifo got ready in the last try
and the transfer should be attempted.

Reported-by: "Juha Leppanen" <juha_motorsportcom@luukku.com>
Signed-off-by: "Juha Leppanen" <juha_motorsportcom@luukku.com>
Signed-off-by: Albert Herranz <albert_herranz@yahoo.es>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/boot/ugecon.c
arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c