cpu-hotplug: CPUx should be active before it is marked online
authorVarun Wadekar <vwadekar@nvidia.com>
Mon, 26 Dec 2011 11:20:05 +0000 (16:20 +0530)
committerVarun Wadekar <vwadekar@nvidia.com>
Tue, 27 Dec 2011 05:28:19 +0000 (21:28 -0800)
commit66fa0f6523f8013b9f60af94bebbcc216f367a67
tree350ccddfac1080d8ca9988b2b9b80c3db4672991
parent456363b8d52925d43f9255b2152935cf0d39aabe
cpu-hotplug: CPUx should be active before it is marked online

CPU0 CPUn

_cpu_up()
  __cpu_up()

boostrap()
  notify_cpu_starting()
  set_cpu_online()
  while (!cpu_active())
    cpu_relax()

<PREEMPT-out>

smp_call_function(.wait=1)
  /* we find cpu_online() is true */
  arch_send_call_function_ipi_mask()
  /* wait-forever-more */
<PREEMPT-in>
  local_irq_enable()

  cpu_notify(CPU_ONLINE)
    sched_cpu_active()
      set_cpu_active()

Now the purpose of cpu_active is mostly with bringing down a cpu, where
we mark it !active to avoid the load-balancer from moving tasks to it
while we tear down the cpu. This is required because we only update the
sched_domain tree after we brought the cpu-down. And this is needed so
that some tasks can still run while we bring it down, we just don't want
new tasks to appear.

On cpu-up however the sched_domain tree doesn't yet include the new cpu,
so its invisible to the load-balancer, regardless of the active state.
So instead of setting the active state after we boot the new cpu (and
consequently having to wait for it before enabling interrupts) set the
cpu active before we set it online and avoid the whole mess.

Bug 916986

Original Patch: https://lkml.org/lkml/2011/12/15/255

Change-Id: Ia1c07bdc1b3eb07a7cd4d69756fa7bec509c9400
Reported-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Varun Wadekar <vwadekar@nvidia.com>
Reviewed-on: http://git-master/r/72130
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: Mayuresh Kulkarni <mkulkarni@nvidia.com>
arch/arm/kernel/smp.c
arch/s390/kernel/smp.c
arch/x86/kernel/smpboot.c
kernel/sched.c