tg3: Report invalid link from tg3_get_settings()
authorMatt Carlson <mcarlson@broadcom.com>
Thu, 14 Oct 2010 10:37:44 +0000 (10:37 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 17 Oct 2010 20:57:45 +0000 (13:57 -0700)
commit64c2218266996b562a8e940a95a887fc432daced
tree0546b538923bdac20ff3accbf3996b4e1e2e2e9e
parent4803572815feea2dca9485a343a8556c9037e36e
tg3: Report invalid link from tg3_get_settings()

Currently the tg3 driver leaves the speed and duplex fields
uninitialized in tg3_get_settings() if the device is not up.  This can
lead to some strange deductions in certain versions of ethtool.  When
the device is up and the link is down, the driver reports SPEED_INVALID
and DUPLEX_INVALID for these fields.  This patch makes the presentation
consistent by returning SPEED_INVALID and DUPLEX_INVALID when the device
has not been brought up as well.

Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tg3.c