rtnetlink: propagate error from dev_change_flags in do_setlink()
authorJohannes Berg <johannes@sipsolutions.net>
Mon, 17 Nov 2008 07:20:31 +0000 (23:20 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Nov 2008 07:20:31 +0000 (23:20 -0800)
commit5f9021cfdc3524a4c5e3d7ae2d049eb7adcd6776
tree53e42bd9bb7db0858af5c1de4dd47e0af3ad3c47
parent584c650b4e6fa16f9ab45d382f86ad6d9c625227
rtnetlink: propagate error from dev_change_flags in do_setlink()

Unlike ifconfig, iproute doesn't report an error when setting
an interface up fails:

(example: put wireless network mac80211 interface into repeater mode
with iwconfig but do not set a peer MAC address, it should fail with
-ENOLINK)

without patch:
# ip link set wlan0 up ; echo $?
0
#

with patch:
# ip link set wlan0 up ; echo $?
RTNETLINK answers: Link has been severed
2
#

Propagate the return value from dev_change_flags() to fix this.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Tested-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c