NFSv4: Fix unnecessary delegation returns in nfs4_do_open
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Fri, 8 Jun 2012 14:58:09 +0000 (10:58 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 22 Jun 2012 18:36:54 +0000 (11:36 -0700)
commit5e74cfe1feb56745cecce815adf6fd2c7dfb6a58
tree9057b07d5378285f5d650e0f0f1582915317ac7b
parent5f1d81e9fb6c05e8ab89a610bb63cdc8f0f66d81
NFSv4: Fix unnecessary delegation returns in nfs4_do_open

commit 2d0dbc6ae8a5194aaecb9cfffb9053f38fce8b86 upstream.

While nfs4_do_open() expects the fmode argument to be restricted to
combinations of FMODE_READ and FMODE_WRITE, both nfs4_atomic_open()
and nfs4_proc_create will pass the nfs_open_context->mode,
which contains the full fmode_t.

This patch ensures that nfs4_do_open strips the other fmode_t bits,
fixing a problem in which the nfs4_do_open call would result in an
unnecessary delegation return.

Reported-by: Fred Isaman <iisaman@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfs/nfs4proc.c