parport_pc: make sure to release IO ports after probing for IT87XX
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 4 Apr 2008 21:30:31 +0000 (14:30 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 4 Apr 2008 21:30:31 +0000 (14:30 -0700)
commit4ed919014eb2b591eb8fdd4dd00226a65faddef4
tree468102fffdd30bb3110389b042df11e16235f29a
parente315c121a858499d84dc88c499046b9f10bb61ec
parport_pc: make sure to release IO ports after probing for IT87XX

Commit f63fd7e299ee13da071ecfce2b90b58c5e1562b1 ("parport_pc: detection
for SuperIO IT87XX POST") only released the IO port region on success,
not when the probe for the IT87XX chip failed.

That caused not only a reserved region to leak, but also caused an oops
when the driver module was unloaded and somebody tried to cat
/proc/ioports - because the string that was assigned to the IO port
region was a static string in the module virtual address area.

Reported-by: Lubos Lunak <l.lunak@suse.cz>
Cc: Jan Kara <jack@suse.cz>
Cc: Petr Cvek <petr.cvek@tul.cz>
Acked-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/parport/parport_pc.c