[PATCH] configfs+dlm: Rename config_group_find_obj and state semantics clearly
authorSatyam Sharma <ssatyam@cse.iitk.ac.in>
Wed, 4 Jul 2007 11:07:16 +0000 (16:07 +0530)
committerMark Fasheh <mark.fasheh@oracle.com>
Wed, 11 Jul 2007 00:02:31 +0000 (17:02 -0700)
commit3fe6c5ce1176cf661dbe71fc43b627c1a742a89a
treebe94563e2ba49f7116e866e57253b5ed82fb85ee
parent9b1d9aa4e9c5cafe73b9df21d758b50b5d75264d
[PATCH] configfs+dlm: Rename config_group_find_obj and state semantics clearly

Configfs being based upon sysfs code, config_group_find_obj() is probably
so named because of the similar kset_find_obj() in sysfs. However,
"kobject"s in sysfs become "config_item"s in configfs, so let's call it
config_group_find_item() instead, for sake of uniformity, and make
corresponding change in the users of this function.

BTW a crucial difference between kset_find_obj and config_group_find_item
is in locking expectations. kset_find_obj does its locking by itself, but
config_group_find_item expects the *caller* to do the locking. The reason
for this: kset's have their own locks, config_group's don't but instead
rely on the subsystem mutex. And, subsystem needn't necessarily be around
when config_group_find_item() is called.

So let's state these locking semantics explicitly, and rectify the comment,
otherwise bugs could continue to occur in future, as they did in the past
(refer commit d82b8191e238 in gfs2-2.6-fixes.git).

[ I also took the opportunity to fix some bad whitespace and
double-empty lines. --Joel ]

[ Conflict in fs/dlm/config.c with commit
  3168b0780d06ace875696f8a648d04d6089654e5 manually resolved. --Mark ]

Signed-off-by: Satyam Sharma <ssatyam@cse.iitk.ac.in>
Cc: David Teigland <teigland@redhat.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
fs/configfs/item.c
fs/dlm/config.c
include/linux/configfs.h