floppy: Cleanup disk->queue before caling put_disk() if add_disk() was never called
authorVivek Goyal <vgoyal@redhat.com>
Wed, 8 Feb 2012 19:03:38 +0000 (20:03 +0100)
committerJens Axboe <axboe@kernel.dk>
Wed, 8 Feb 2012 19:03:38 +0000 (20:03 +0100)
commit3f9a5aabd0a9fe0e0cd308506f48963d79169aa7
tree89dd32775e498dcb50da8cfc5388400c637725c5
parentcdccaa9467b982d57b139818d15e1e994feca372
floppy: Cleanup disk->queue before caling put_disk() if add_disk() was never called

add_disk() takes gendisk reference on request queue. If driver failed during
initialization and never called add_disk() then that extra reference is not
taken. That reference is put in put_disk(). floppy driver allocates the
disk, allocates queue, sets disk->queue and then relizes that floppy
controller is not present. It tries to tear down everything and tries to
put a reference down in put_disk() which was never taken.

In such error cases cleanup disk->queue before calling put_disk() so that
we never try to put down a reference which was never taken in first place.

Reported-and-tested-by: Suresh Jayaraman <sjayaraman@suse.com>
Tested-by: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/floppy.c