module: fix reference to mod->percpu after freeing module.
authorRusty Russell <rusty@rustcorp.com.au>
Mon, 31 May 2010 10:23:50 +0000 (19:23 +0930)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 31 May 2010 18:21:32 +0000 (11:21 -0700)
commit293a7cfeedc2b2380a7c7274902323c3cf5f7575
tree00576870400cb640fe92ea3f525338e6e3733a2e
parent67a3e12b05e055c0415c556a315a3d3eb637e29e
module: fix reference to mod->percpu after freeing module.

Rafael sees a sometimes crash at precpu_modfree from kernel/module.c; it
only occurred with another (since-reverted) patch, but that patch simply
changed timing to uncover this bug, it was otherwise unrelated.

The comment about the mod being freed is self-explanatory, but neither
Tejun nor I read it.  This bug was introduced in 259354deaa, after it
had previously been fixed in 6e2b75740b.  How embarrassing.

Reported-by: "Rafael J. Wysocki" <rjw@sisk.pl>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Embarrassingly-Acked-by: Tejun Heo <tj@kernel.org>
Cc: Masami Hiramatsu <mhiramat@redhat.com>
Tested-by: "Rafael J. Wysocki" <rjw@sisk.pl>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/module.c