restore pinning the victim dentry in vfs_rmdir()/vfs_rename_dir()
authorAl Viro <viro@ZenIV.linux.org.uk>
Wed, 14 Sep 2011 17:55:41 +0000 (18:55 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 14 Sep 2011 18:31:55 +0000 (11:31 -0700)
commit1d2ef5901483004d74947bbf78d5146c24038fe7
treeadd2cc75116bf7588434f212bb8dd52d32b320d5
parent003f6c9df54970d8b19578d195b3e2b398cdbde2
restore pinning the victim dentry in vfs_rmdir()/vfs_rename_dir()

We used to get the victim pinned by dentry_unhash() prior to commit
64252c75a219 ("vfs: remove dget() from dentry_unhash()") and ->rmdir()
and ->rename() instances relied on that; most of them don't care, but
ones that used d_delete() themselves do.  As the result, we are getting
rmdir() oopses on NFS now.

Just grab the reference before locking the victim and drop it explicitly
after unlocking, same as vfs_rename_other() does.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Tested-by: Simon Kirby <sim@hostway.ca>
Cc: stable@kernel.org (3.0.x)
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/namei.c