Input: ff-memless - another fix for signed to unsigned overflow
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 25 Dec 2009 05:44:19 +0000 (21:44 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 25 Dec 2009 05:54:09 +0000 (21:54 -0800)
commit1b11c88d3e8f55dc9d193d19de11e3f7abc1b7d7
tree51adca3f94ca3a1a31d249faa9da8b6b0d3f8e6b
parent25ae08317647c68ed9276f7bdc07d0d5fd042628
Input: ff-memless - another fix for signed to unsigned overflow

The commit 9e68177ef93b2f34eee5a1e1707bceef4b9ba69c changed 'gain' from
signed to unsigned to fix an issue with rumble effect calculation, however
it introduced problems when calculating constant effects. Having 'gain'
being unsigned int was an unfortunate choice since it dominates all
implicit type conversions causing everything to be treated as unsigned
int.

Let's change it back to signed int and simply add proper casts to rumble
effect calculations.

Reported-by: Gary Stein <lordcnidarian@gmail.com>
Acked-by: Anssi Hannula <anssi.hannula@iki.fi>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
drivers/input/ff-memless.c