mm_for_maps: simplify, use ptrace_may_access()
authorOleg Nesterov <oleg@redhat.com>
Tue, 23 Jun 2009 19:25:32 +0000 (21:25 +0200)
committerJames Morris <jmorris@namei.org>
Mon, 10 Aug 2009 10:47:42 +0000 (20:47 +1000)
commit13f0feafa6b8aead57a2a328e2fca6a5828bf286
treefb396118339319406daf7f6782782eaef31b3b53
parentf4b9a988685da6386d7f9a72df3098bcc3270526
mm_for_maps: simplify, use ptrace_may_access()

It would be nice to kill __ptrace_may_access(). It requires task_lock(),
but this lock is only needed to read mm->flags in the middle.

Convert mm_for_maps() to use ptrace_may_access(), this also simplifies
the code a little bit.

Also, we do not need to take ->mmap_sem in advance. In fact I think
mm_for_maps() should not play with ->mmap_sem at all, the caller should
take this lock.

With or without this patch, without ->cred_guard_mutex held we can race
with exec() and get the new ->mm but check old creds.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Serge Hallyn <serue@us.ibm.com>
Signed-off-by: James Morris <jmorris@namei.org>
fs/proc/base.c