ext4: init timer earlier to avoid a kernel panic in __save_error_info
authorTao Ma <boyu.mt@taobao.com>
Tue, 5 Apr 2011 23:55:28 +0000 (19:55 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 5 Apr 2011 23:55:28 +0000 (19:55 -0400)
commit0449641130f5652b344ef6fa39fa019d7e94660a
treed24779d75a6d3fafff8082591b3572a5fdb32858
parent6cba611e600ded15f642552ce6b5f7ee243bacf0
ext4: init timer earlier to avoid a kernel panic in __save_error_info

During mount, when we fail to open journal inode or root inode, the
__save_error_info will mod_timer. But actually s_err_report isn't
initialized yet and the kernel oops. The detailed information can
be found https://bugzilla.kernel.org/show_bug.cgi?id=32082.

The best way is to check whether the timer s_err_report is initialized
or not. But it seems that in include/linux/timer.h, we can't find a
good function to check the status of this timer, so this patch just
move the initializtion of s_err_report earlier so that we can avoid
the kernel panic. The corresponding del_timer is also added in the
error path.

Reported-by: Sami Liedes <sliedes@cc.hut.fi>
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/super.c