ALSA: echoaudio: Remove incorrect part of assertion
authorMark Hills <mark@pogo.org.uk>
Mon, 30 Apr 2012 18:39:22 +0000 (19:39 +0100)
committerVarun Wadekar <vwadekar@nvidia.com>
Fri, 18 May 2012 10:34:36 +0000 (15:34 +0530)
commit321b0ef30308575af1358c430a16cbd8fdc56746
treea319246310a9fe3f16b9f6e145b1b000cf9d33b6
parent3d605b29daedfa10e424b752bd4f5c07775bbb46
ALSA: echoaudio: Remove incorrect part of assertion

This assertion seems to imply that chip->dsp_code_to_load is a pointer.
It's actually an integer handle on the actual firmware, and 0 has no
special meaning.

The assertion prevents initialisation of a Darla20 card, but would also
affect other models. It seems it was introduced in commit dd7b254d.

ALSA sound/pci/echoaudio/echoaudio.c:2061 Echoaudio driver starting...
ALSA sound/pci/echoaudio/echoaudio.c:1969 chip=ebe4e000
ALSA sound/pci/echoaudio/echoaudio.c:2007 pci=ed568000 irq=19 subdev=0010 Init hardware...
ALSA sound/pci/echoaudio/darla20_dsp.c:36 init_hw() - Darla20
------------[ cut here ]------------
WARNING: at sound/pci/echoaudio/echoaudio_dsp.c:478 init_hw+0x1d1/0x86c [snd_darla20]()
Hardware name: Dell DM051
BUG? (!chip->dsp_code_to_load || !chip->comm_page)

Signed-off-by: Mark Hills <mark@pogo.org.uk>
Cc: <stable@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/echoaudio/echoaudio_dsp.c