irq: Fix check for already initialized irq_domain in irq_domain_add
authorRob Herring <robherring2@gmail.com>
Wed, 14 Sep 2011 16:31:37 +0000 (11:31 -0500)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 20 Sep 2011 10:16:22 +0000 (12:16 +0200)
commiteef24afb28561a5a9f4be8f8da97735b7e6a826f
tree0014317465c4aac43d40fe0cc7f1b269a5a5b95d
parent5bd078dda4d4fbdb4bd138a6bd5b6e274c019ed2
irq: Fix check for already initialized irq_domain in irq_domain_add

The sanity check in irq_domain_add() tests desc->irq_data != NULL or
irq_data->domain != NULL. This prevents adding an irq_domain to a irq
descriptor when irq_data exists, which true when the irq descriptor
exists.

This went unnoticed so far as the simple domain code did not enter
this code path because domain->nr_irqs is always 0 for the simple domains.

Split the check for irq_data == NULL out and have a separate warning
for it.

[ tglx: Made the check for irq_data == NULL separate ]

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: marc.zyngier@arm.com
Cc: thomas.abraham@linaro.org
Cc: jamie@jamieiles.com
Cc: b-cousson@ti.com
Cc: shawn.guo@linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: devicetree-discuss@lists.ozlabs.org
Link: http://lkml.kernel.org/r/1316017900-19918-3-git-send-email-robherring2@gmail.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/irq/irqdomain.c