[ALSA] sound/: possible cleanups
[linux-2.6.git] / sound / pci / hda / patch_cmedia.c
index e64e29d..9a69811 100644 (file)
@@ -44,13 +44,13 @@ enum {
 
 struct cmi_spec {
        int board_config;
-       unsigned int surr_switch: 1;    /* switchable line,mic */
        unsigned int no_line_in: 1;     /* no line-in (5-jack) */
        unsigned int front_panel: 1;    /* has front-panel 2-jack */
 
        /* playback */
        struct hda_multi_out multiout;
        hda_nid_t dac_nids[4];          /* NID for each DAC */
+       int num_dacs;
 
        /* capture */
        hda_nid_t *adc_nids;
@@ -61,9 +61,8 @@ struct cmi_spec {
        unsigned int cur_mux[2];
 
        /* channel mode */
-       unsigned int num_ch_modes;
-       unsigned int cur_ch_mode;
-       const struct cmi_channel_mode *channel_modes;
+       int num_channel_modes;
+       const struct hda_channel_mode *channel_modes;
 
        struct hda_pcm pcm_rec[2];      /* PCM information */
 
@@ -80,14 +79,14 @@ struct cmi_spec {
 /*
  * input MUX
  */
-static int cmi_mux_enum_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t *uinfo)
+static int cmi_mux_enum_info(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
        struct cmi_spec *spec = codec->spec;
        return snd_hda_input_mux_info(spec->input_mux, uinfo);
 }
 
-static int cmi_mux_enum_get(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
+static int cmi_mux_enum_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
        struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
        struct cmi_spec *spec = codec->spec;
@@ -97,7 +96,7 @@ static int cmi_mux_enum_get(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucon
        return 0;
 }
 
-static int cmi_mux_enum_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
+static int cmi_mux_enum_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
        struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
        struct cmi_spec *spec = codec->spec;
@@ -114,9 +113,9 @@ static int cmi_mux_enum_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucon
 /* 3-stack / 2 channel */
 static struct hda_verb cmi9880_ch2_init[] = {
        /* set line-in PIN for input */
-       { 0x0c, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x20 },
+       { 0x0c, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN },
        /* set mic PIN for input, also enable vref */
-       { 0x0d, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x24 },
+       { 0x0d, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREF80 },
        /* route front PCM (DAC1) to HP */
        { 0x0f, AC_VERB_SET_CONNECT_SEL, 0x00 },
        {}
@@ -125,9 +124,9 @@ static struct hda_verb cmi9880_ch2_init[] = {
 /* 3-stack / 6 channel */
 static struct hda_verb cmi9880_ch6_init[] = {
        /* set line-in PIN for output */
-       { 0x0c, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x40 },
+       { 0x0c, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT },
        /* set mic PIN for output */
-       { 0x0d, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x40 },
+       { 0x0d, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT },
        /* route front PCM (DAC1) to HP */
        { 0x0f, AC_VERB_SET_CONNECT_SEL, 0x00 },
        {}
@@ -136,71 +135,47 @@ static struct hda_verb cmi9880_ch6_init[] = {
 /* 3-stack+front / 8 channel */
 static struct hda_verb cmi9880_ch8_init[] = {
        /* set line-in PIN for output */
-       { 0x0c, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x40 },
+       { 0x0c, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT },
        /* set mic PIN for output */
-       { 0x0d, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x40 },
+       { 0x0d, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_OUT },
        /* route rear-surround PCM (DAC4) to HP */
        { 0x0f, AC_VERB_SET_CONNECT_SEL, 0x03 },
        {}
 };
 
-struct cmi_channel_mode {
-       unsigned int channels;
-       const struct hda_verb *sequence;
-};
-
-static struct cmi_channel_mode cmi9880_channel_modes[3] = {
+static struct hda_channel_mode cmi9880_channel_modes[3] = {
        { 2, cmi9880_ch2_init },
        { 6, cmi9880_ch6_init },
        { 8, cmi9880_ch8_init },
 };
 
-static int cmi_ch_mode_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t *uinfo)
+static int cmi_ch_mode_info(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_info *uinfo)
 {
        struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
        struct cmi_spec *spec = codec->spec;
-
-       snd_assert(spec->channel_modes, return -EINVAL);
-       uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
-       uinfo->count = 1;
-       uinfo->value.enumerated.items = spec->num_ch_modes;
-       if (uinfo->value.enumerated.item >= uinfo->value.enumerated.items)
-               uinfo->value.enumerated.item = uinfo->value.enumerated.items - 1;
-       sprintf(uinfo->value.enumerated.name, "%dch",
-               spec->channel_modes[uinfo->value.enumerated.item].channels);
-       return 0;
+       return snd_hda_ch_mode_info(codec, uinfo, spec->channel_modes,
+                                   spec->num_channel_modes);
 }
 
-static int cmi_ch_mode_get(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
+static int cmi_ch_mode_get(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
        struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
        struct cmi_spec *spec = codec->spec;
-
-       ucontrol->value.enumerated.item[0] = spec->cur_ch_mode;
-       return 0;
+       return snd_hda_ch_mode_get(codec, ucontrol, spec->channel_modes,
+                                  spec->num_channel_modes, spec->multiout.max_channels);
 }
 
-static int cmi_ch_mode_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
+static int cmi_ch_mode_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol)
 {
        struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
        struct cmi_spec *spec = codec->spec;
-
-       snd_assert(spec->channel_modes, return -EINVAL);
-       if (ucontrol->value.enumerated.item[0] >= spec->num_ch_modes)
-               ucontrol->value.enumerated.item[0] = spec->num_ch_modes;
-       if (ucontrol->value.enumerated.item[0] == spec->cur_ch_mode &&
-           ! codec->in_resume)
-               return 0;
-
-       spec->cur_ch_mode = ucontrol->value.enumerated.item[0];
-       snd_hda_sequence_write(codec, spec->channel_modes[spec->cur_ch_mode].sequence);
-       spec->multiout.max_channels = spec->channel_modes[spec->cur_ch_mode].channels;
-       return 1;
+       return snd_hda_ch_mode_put(codec, ucontrol, spec->channel_modes,
+                                  spec->num_channel_modes, &spec->multiout.max_channels);
 }
 
 /*
  */
-static snd_kcontrol_new_t cmi9880_basic_mixer[] = {
+static struct snd_kcontrol_new cmi9880_basic_mixer[] = {
        /* CMI9880 has no playback volumes! */
        HDA_CODEC_MUTE("PCM Playback Switch", 0x03, 0x0, HDA_OUTPUT), /* front */
        HDA_CODEC_MUTE("Surround Playback Switch", 0x04, 0x0, HDA_OUTPUT),
@@ -232,7 +207,7 @@ static snd_kcontrol_new_t cmi9880_basic_mixer[] = {
 /*
  * shared I/O pins
  */
-static snd_kcontrol_new_t cmi9880_ch_mode_mixer[] = {
+static struct snd_kcontrol_new cmi9880_ch_mode_mixer[] = {
        {
                .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
                .name = "Channel Mode",
@@ -281,27 +256,27 @@ static hda_nid_t cmi9880_adc_nids[2] = {
  */
 static struct hda_verb cmi9880_basic_init[] = {
        /* port-D for line out (rear panel) */
-       { 0x0b, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+       { 0x0b, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP },
        /* port-E for HP out (front panel) */
-       { 0x0f, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+       { 0x0f, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP },
        /* route front PCM to HP */
        { 0x0f, AC_VERB_SET_CONNECT_SEL, 0x00 },
        /* port-A for surround (rear panel) */
-       { 0x0e, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+       { 0x0e, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP },
        /* port-G for CLFE (rear panel) */
-       { 0x1f, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+       { 0x1f, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP },
        { 0x1f, AC_VERB_SET_CONNECT_SEL, 0x02 },
        /* port-H for side (rear panel) */
-       { 0x20, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+       { 0x20, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP },
        { 0x20, AC_VERB_SET_CONNECT_SEL, 0x01 },
        /* port-C for line-in (rear panel) */
-       { 0x0c, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x20 },
+       { 0x0c, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN },
        /* port-B for mic-in (rear panel) with vref */
-       { 0x0d, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x24 },
+       { 0x0d, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREF80 },
        /* port-F for mic-in (front panel) with vref */
-       { 0x10, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x24 },
+       { 0x10, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREF80 },
        /* CD-in */
-       { 0x11, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x20 },
+       { 0x11, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN },
        /* route front mic to ADC1/2 */
        { 0x08, AC_VERB_SET_CONNECT_SEL, 0x05 },
        { 0x09, AC_VERB_SET_CONNECT_SEL, 0x05 },
@@ -310,27 +285,27 @@ static struct hda_verb cmi9880_basic_init[] = {
 
 static struct hda_verb cmi9880_allout_init[] = {
        /* port-D for line out (rear panel) */
-       { 0x0b, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+       { 0x0b, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP },
        /* port-E for HP out (front panel) */
-       { 0x0f, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+       { 0x0f, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP },
        /* route front PCM to HP */
        { 0x0f, AC_VERB_SET_CONNECT_SEL, 0x00 },
        /* port-A for side (rear panel) */
-       { 0x0e, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+       { 0x0e, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP },
        /* port-G for CLFE (rear panel) */
-       { 0x1f, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+       { 0x1f, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP },
        { 0x1f, AC_VERB_SET_CONNECT_SEL, 0x02 },
        /* port-H for side (rear panel) */
-       { 0x20, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+       { 0x20, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP },
        { 0x20, AC_VERB_SET_CONNECT_SEL, 0x01 },
        /* port-C for surround (rear panel) */
-       { 0x0c, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+       { 0x0c, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_HP },
        /* port-B for mic-in (rear panel) with vref */
-       { 0x0d, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x24 },
+       { 0x0d, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREF80 },
        /* port-F for mic-in (front panel) with vref */
-       { 0x10, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x24 },
+       { 0x10, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_VREF80 },
        /* CD-in */
-       { 0x11, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x20 },
+       { 0x11, AC_VERB_SET_PIN_WIDGET_CONTROL, PIN_IN },
        /* route front mic to ADC1/2 */
        { 0x08, AC_VERB_SET_CONNECT_SEL, 0x05 },
        { 0x09, AC_VERB_SET_CONNECT_SEL, 0x05 },
@@ -347,7 +322,7 @@ static int cmi9880_build_controls(struct hda_codec *codec)
        err = snd_hda_add_new_ctls(codec, cmi9880_basic_mixer);
        if (err < 0)
                return err;
-       if (spec->surr_switch) {
+       if (spec->channel_modes) {
                err = snd_hda_add_new_ctls(codec, cmi9880_ch_mode_mixer);
                if (err < 0)
                        return err;
@@ -365,102 +340,9 @@ static int cmi9880_build_controls(struct hda_codec *codec)
        return 0;
 }
 
-#define AC_DEFCFG_ASSOC_SHIFT          4
-#define get_defcfg_connect(cfg) ((cfg & AC_DEFCFG_PORT_CONN) >> AC_DEFCFG_PORT_CONN_SHIFT)
-#define get_defcfg_association(cfg) ((cfg & AC_DEFCFG_DEF_ASSOC) >> AC_DEFCFG_ASSOC_SHIFT)
-#define get_defcfg_sequence(cfg) (cfg & AC_DEFCFG_SEQUENCE)
-
-/* get all pin default configuration in def_conf */
-static int cmi9880_get_pin_def_config(struct hda_codec *codec)
-{
-       struct cmi_spec *spec = codec->spec;
-       hda_nid_t nid, nid_start;
-       int i = 0, nodes;
-
-       nodes = snd_hda_get_sub_nodes(codec, codec->afg, &nid_start);
-       for (nid = nid_start; nid < nodes + nid_start; nid++) {
-               unsigned int wid_caps = snd_hda_param_read(codec, nid,
-                                                  AC_PAR_AUDIO_WIDGET_CAP);
-               unsigned int wid_type = (wid_caps & AC_WCAP_TYPE) >> AC_WCAP_TYPE_SHIFT;
-               /* read all default configuration for pin complex */
-               if (wid_type == AC_WID_PIN) {
-                       spec->pin_nid[i] = nid;
-                       spec->def_conf[i] = 
-                               snd_hda_codec_read(codec, nid, 0,
-                                       AC_VERB_GET_CONFIG_DEFAULT, 0);
-                       i++;
-               }
-       }
-       spec->pin_def_confs = i;
-       return 0;
-}
-
-/* get a pin default configuration of nid in def_conf */
-static unsigned int cmi9880_get_def_config(struct hda_codec *codec, hda_nid_t nid)
-{
-       struct cmi_spec *spec = codec->spec;
-       int i = 0;
-
-       while (spec->pin_nid[i] != nid && i < spec->pin_def_confs)
-               i++;
-       if (i == spec->pin_def_confs)
-               return (unsigned int) -1;
-       else
-               return spec->def_conf[i];
-}
-
-/* decide what pins to use for multichannel playback */
-static int cmi9880_get_multich_pins(struct hda_codec *codec)
-{
-       struct cmi_spec *spec = codec->spec;
-       int i, j, pins, seq[4];
-       int max_channel = 0;
-       unsigned int def_conf, sequence;
-       hda_nid_t nid;
-
-       memset(spec->multich_pin, 0, sizeof(spec->multich_pin));
-       for (pins = 0, i = 0; i < spec->pin_def_confs && pins < 4; i++) {
-               def_conf = spec->def_conf[i];
-               /* skip pin not connected */
-               if (get_defcfg_connect(def_conf) == AC_JACK_PORT_NONE)
-                       continue;
-               /* get the sequence if association == 1 */
-               /* the other pins have association = 0, incorrect in spec 1.0 */
-               if (get_defcfg_association(def_conf) == 1) {
-                       sequence = get_defcfg_sequence(def_conf);
-                       seq[pins] = sequence;
-                       spec->multich_pin[pins] = spec->pin_nid[i];
-                       pins++; // ready for next slot
-                       max_channel += 2;
-               }
-       }
-       /* sort by sequence, data collected here will be for Windows */ 
-       for (i = 0; i < pins; i++) {
-               for (j = i + 1; j < pins; j++) {
-                       if (seq[j] < seq[i]) {
-                               sequence = seq[j];
-                               nid = spec->multich_pin[j];
-                               seq[j] = seq[i];
-                               spec->multich_pin[j] = spec->multich_pin[i];
-                               seq[i] = sequence;
-                               spec->multich_pin[i] = nid;
-                       }
-               }
-       }
-       /* the pin assignment is for front, C/LFE, surround and back */
-       if (max_channel >= 6) {
-               hda_nid_t temp;
-               /* exchange pin of C/LFE and surround */
-               temp = spec->multich_pin[1];
-               spec->multich_pin[1] = spec->multich_pin[2];
-               spec->multich_pin[2] = temp;
-       }
-       return max_channel;
-}
-
 /* fill in the multi_dac_nids table, which will decide
    which audio widget to use for each channel */
-static int cmi9880_fill_multi_dac_nids(struct hda_codec *codec)
+static int cmi9880_fill_multi_dac_nids(struct hda_codec *codec, const struct auto_pin_cfg *cfg)
 {
        struct cmi_spec *spec = codec->spec;
        hda_nid_t nid;
@@ -471,32 +353,34 @@ static int cmi9880_fill_multi_dac_nids(struct hda_codec *codec)
        memset(spec->dac_nids, 0, sizeof(spec->dac_nids));
        memset(assigned, 0, sizeof(assigned));
        /* check the pins we found */
-       for (i = 0; i < spec->multiout.max_channels / 2; i++) {
-               nid = spec->multich_pin[i];
+       for (i = 0; i < cfg->line_outs; i++) {
+               nid = cfg->line_out_pins[i];
                /* nid 0x0b~0x0e is hardwired to audio widget 0x3~0x6 */
-               if (nid <= 0x0e && nid >= 0x0b) {
-                       spec->dac_nids[i] = nid - 0x08;
+               if (nid >= 0x0b && nid <= 0x0e) {
+                       spec->dac_nids[i] = (nid - 0x0b) + 0x03;
                        assigned[nid - 0x0b] = 1;
                }
        }
        /* left pin can be connect to any audio widget */
-       for (i = 0; i < spec->multiout.max_channels / 2; i++) {
-               if (!assigned[i]) {
-                       /* search for an empty channel */
-                       /* I should also check the pin type */
-                       for (j = 0; j < ARRAY_SIZE(spec->dac_nids); j++)
-                               if (! spec->dac_nids[j]) {
-                                       spec->dac_nids[j] = i + 3;
-                                       assigned[i] = 1;
-                                       break;
-                               }
+       for (i = 0; i < cfg->line_outs; i++) {
+               nid = cfg->line_out_pins[i];
+               if (nid <= 0x0e)
+                       continue;
+               /* search for an empty channel */
+               for (j = 0; j < cfg->line_outs; j++) {
+                       if (! assigned[j]) {
+                               spec->dac_nids[i] = j + 0x03;
+                               assigned[j] = 1;
+                               break;
+                       }
                }
        }
+       spec->num_dacs = cfg->line_outs;
        return 0;
 }
 
 /* create multi_init table, which is used for multichannel initialization */
-static int cmi9880_fill_multi_init(struct hda_codec *codec)
+static int cmi9880_fill_multi_init(struct hda_codec *codec, const struct auto_pin_cfg *cfg)
 {
        struct cmi_spec *spec = codec->spec;
        hda_nid_t nid;
@@ -504,31 +388,27 @@ static int cmi9880_fill_multi_init(struct hda_codec *codec)
 
        /* clear the table, only one c-media dac assumed here */
        memset(spec->multi_init, 0, sizeof(spec->multi_init));
-       for (j = 0, i = 0; i < spec->multiout.max_channels / 2; i++) {
+       for (j = 0, i = 0; i < cfg->line_outs; i++) {
                hda_nid_t conn[4];
-               nid = spec->multich_pin[i];
+               nid = cfg->line_out_pins[i];
                /* set as output */
                spec->multi_init[j].nid = nid;
                spec->multi_init[j].verb = AC_VERB_SET_PIN_WIDGET_CONTROL;
-               spec->multi_init[j].param = 0xc0;
+               spec->multi_init[j].param = PIN_OUT;
                j++;
-               /* nid 0x0f,0x10,0x1f,0x20 are needed to set connection */
-               switch (nid) {
-               case 0x0f:
-               case 0x10:
-               case 0x1f:
-               case 0x20:
+               if (nid > 0x0e) {
                        /* set connection */
                        spec->multi_init[j].nid = nid;
                        spec->multi_init[j].verb = AC_VERB_SET_CONNECT_SEL;
+                       spec->multi_init[j].param = 0;
                        /* find the index in connect list */
                        len = snd_hda_get_connections(codec, nid, conn, 4);
                        for (k = 0; k < len; k++)
-                               if (conn[k] == spec->dac_nids[i])
+                               if (conn[k] == spec->dac_nids[i]) {
+                                       spec->multi_init[j].param = k;
                                        break;
-                       spec->multi_init[j].param = k < len ? k : 0;
+                               }
                        j++;
-                       break;
                }
        }
        return 0;
@@ -556,7 +436,7 @@ static int cmi9880_resume(struct hda_codec *codec)
 
        cmi9880_init(codec);
        snd_hda_resume_ctls(codec, cmi9880_basic_mixer);
-       if (spec->surr_switch)
+       if (spec->channel_modes)
                snd_hda_resume_ctls(codec, cmi9880_ch_mode_mixer);
        if (spec->multiout.dig_out_nid)
                snd_hda_resume_spdif_out(codec);
@@ -572,7 +452,7 @@ static int cmi9880_resume(struct hda_codec *codec)
  */
 static int cmi9880_playback_pcm_open(struct hda_pcm_stream *hinfo,
                                     struct hda_codec *codec,
-                                    snd_pcm_substream_t *substream)
+                                    struct snd_pcm_substream *substream)
 {
        struct cmi_spec *spec = codec->spec;
        return snd_hda_multi_out_analog_open(codec, &spec->multiout, substream);
@@ -582,7 +462,7 @@ static int cmi9880_playback_pcm_prepare(struct hda_pcm_stream *hinfo,
                                        struct hda_codec *codec,
                                        unsigned int stream_tag,
                                        unsigned int format,
-                                       snd_pcm_substream_t *substream)
+                                       struct snd_pcm_substream *substream)
 {
        struct cmi_spec *spec = codec->spec;
        return snd_hda_multi_out_analog_prepare(codec, &spec->multiout, stream_tag,
@@ -591,7 +471,7 @@ static int cmi9880_playback_pcm_prepare(struct hda_pcm_stream *hinfo,
 
 static int cmi9880_playback_pcm_cleanup(struct hda_pcm_stream *hinfo,
                                       struct hda_codec *codec,
-                                      snd_pcm_substream_t *substream)
+                                      struct snd_pcm_substream *substream)
 {
        struct cmi_spec *spec = codec->spec;
        return snd_hda_multi_out_analog_cleanup(codec, &spec->multiout);
@@ -602,7 +482,7 @@ static int cmi9880_playback_pcm_cleanup(struct hda_pcm_stream *hinfo,
  */
 static int cmi9880_dig_playback_pcm_open(struct hda_pcm_stream *hinfo,
                                         struct hda_codec *codec,
-                                        snd_pcm_substream_t *substream)
+                                        struct snd_pcm_substream *substream)
 {
        struct cmi_spec *spec = codec->spec;
        return snd_hda_multi_out_dig_open(codec, &spec->multiout);
@@ -610,7 +490,7 @@ static int cmi9880_dig_playback_pcm_open(struct hda_pcm_stream *hinfo,
 
 static int cmi9880_dig_playback_pcm_close(struct hda_pcm_stream *hinfo,
                                          struct hda_codec *codec,
-                                         snd_pcm_substream_t *substream)
+                                         struct snd_pcm_substream *substream)
 {
        struct cmi_spec *spec = codec->spec;
        return snd_hda_multi_out_dig_close(codec, &spec->multiout);
@@ -623,7 +503,7 @@ static int cmi9880_capture_pcm_prepare(struct hda_pcm_stream *hinfo,
                                      struct hda_codec *codec,
                                      unsigned int stream_tag,
                                      unsigned int format,
-                                     snd_pcm_substream_t *substream)
+                                     struct snd_pcm_substream *substream)
 {
        struct cmi_spec *spec = codec->spec;
 
@@ -634,7 +514,7 @@ static int cmi9880_capture_pcm_prepare(struct hda_pcm_stream *hinfo,
 
 static int cmi9880_capture_pcm_cleanup(struct hda_pcm_stream *hinfo,
                                      struct hda_codec *codec,
-                                     snd_pcm_substream_t *substream)
+                                     struct snd_pcm_substream *substream)
 {
        struct cmi_spec *spec = codec->spec;
 
@@ -728,6 +608,7 @@ static struct hda_board_config cmi9880_cfg_tbl[] = {
        { .modelname = "min_fp", .config = CMI_MIN_FP },
        { .modelname = "full", .config = CMI_FULL },
        { .modelname = "full_dig", .config = CMI_FULL_DIG },
+       { .pci_subvendor = 0x1043, .pci_subdevice = 0x813d, .config = CMI_FULL_DIG }, /* ASUS P5AD2 */
        { .modelname = "allout", .config = CMI_ALLOUT },
        { .modelname = "auto", .config = CMI_AUTO },
        {} /* terminator */
@@ -747,7 +628,7 @@ static int patch_cmi9880(struct hda_codec *codec)
 {
        struct cmi_spec *spec;
 
-       spec = kcalloc(1, sizeof(*spec), GFP_KERNEL);
+       spec = kzalloc(sizeof(*spec), GFP_KERNEL);
        if (spec == NULL)
                return -ENOMEM;
 
@@ -760,18 +641,18 @@ static int patch_cmi9880(struct hda_codec *codec)
 
        /* copy default DAC NIDs */
        memcpy(spec->dac_nids, cmi9880_dac_nids, sizeof(spec->dac_nids));
+       spec->num_dacs = 4;
 
        switch (spec->board_config) {
        case CMI_MINIMAL:
        case CMI_MIN_FP:
-               spec->surr_switch = 1;
+               spec->channel_modes = cmi9880_channel_modes;
                if (spec->board_config == CMI_MINIMAL)
-                       spec->num_ch_modes = 2;
+                       spec->num_channel_modes = 2;
                else {
                        spec->front_panel = 1;
-                       spec->num_ch_modes = 3;
+                       spec->num_channel_modes = 3;
                }
-               spec->channel_modes = cmi9880_channel_modes;
                spec->multiout.max_channels = cmi9880_channel_modes[0].channels;
                spec->input_mux = &cmi9880_basic_mux;
                break;
@@ -796,45 +677,52 @@ static int patch_cmi9880(struct hda_codec *codec)
                {
                unsigned int port_e, port_f, port_g, port_h;
                unsigned int port_spdifi, port_spdifo;
+               struct auto_pin_cfg cfg;
+
                /* collect pin default configuration */
-               cmi9880_get_pin_def_config(codec);
-               port_e = cmi9880_get_def_config(codec, 0x0f);
-               port_f = cmi9880_get_def_config(codec, 0x10);
-               port_g = cmi9880_get_def_config(codec, 0x1f);
-               port_h = cmi9880_get_def_config(codec, 0x20);
-               port_spdifi = cmi9880_get_def_config(codec, 0x13);
-               port_spdifo = cmi9880_get_def_config(codec, 0x12);
+               port_e = snd_hda_codec_read(codec, 0x0f, 0, AC_VERB_GET_CONFIG_DEFAULT, 0);
+               port_f = snd_hda_codec_read(codec, 0x10, 0, AC_VERB_GET_CONFIG_DEFAULT, 0);
                spec->front_panel = 1;
-               if ((get_defcfg_connect(port_e) == AC_JACK_PORT_NONE)
-               || (get_defcfg_connect(port_f) == AC_JACK_PORT_NONE)) {
-                       spec->surr_switch = 1;
+               if (get_defcfg_connect(port_e) == AC_JACK_PORT_NONE ||
+                   get_defcfg_connect(port_f) == AC_JACK_PORT_NONE) {
+                       port_g = snd_hda_codec_read(codec, 0x1f, 0, AC_VERB_GET_CONFIG_DEFAULT, 0);
+                       port_h = snd_hda_codec_read(codec, 0x20, 0, AC_VERB_GET_CONFIG_DEFAULT, 0);
+                       spec->channel_modes = cmi9880_channel_modes;
                        /* no front panel */
-                       if ((get_defcfg_connect(port_g) == AC_JACK_PORT_NONE)
-                       || (get_defcfg_connect(port_h) == AC_JACK_PORT_NONE)) {
+                       if (get_defcfg_connect(port_g) == AC_JACK_PORT_NONE ||
+                           get_defcfg_connect(port_h) == AC_JACK_PORT_NONE) {
                                /* no optional rear panel */
                                spec->board_config = CMI_MINIMAL;
                                spec->front_panel = 0;
-                               spec->num_ch_modes = 2;
-                       } else
+                               spec->num_channel_modes = 2;
+                       } else {
                                spec->board_config = CMI_MIN_FP;
-                               spec->num_ch_modes = 3;
-                       spec->channel_modes = cmi9880_channel_modes;
+                               spec->num_channel_modes = 3;
+                       }
                        spec->input_mux = &cmi9880_basic_mux;
+                       spec->multiout.max_channels = cmi9880_channel_modes[0].channels;
                } else {
                        spec->input_mux = &cmi9880_basic_mux;
-                       if (get_defcfg_connect(port_spdifo) != 1)
+                       port_spdifi = snd_hda_codec_read(codec, 0x13, 0, AC_VERB_GET_CONFIG_DEFAULT, 0);
+                       port_spdifo = snd_hda_codec_read(codec, 0x12, 0, AC_VERB_GET_CONFIG_DEFAULT, 0);
+                       if (get_defcfg_connect(port_spdifo) != AC_JACK_PORT_NONE)
                                spec->multiout.dig_out_nid = CMI_DIG_OUT_NID;
-                       if (get_defcfg_connect(port_spdifi) != 1)
+                       if (get_defcfg_connect(port_spdifi) != AC_JACK_PORT_NONE)
                                spec->dig_in_nid = CMI_DIG_IN_NID;
+                       spec->multiout.max_channels = 8;
                }
-               spec->multiout.max_channels = cmi9880_get_multich_pins(codec);
-               cmi9880_fill_multi_dac_nids(codec);
-               cmi9880_fill_multi_init(codec);
-               }
+               snd_hda_parse_pin_def_config(codec, &cfg);
+               if (cfg.line_outs) {
+                       spec->multiout.max_channels = cfg.line_outs * 2;
+                       cmi9880_fill_multi_dac_nids(codec, &cfg);
+                       cmi9880_fill_multi_init(codec, &cfg);
+               } else
+                       snd_printd("patch_cmedia: cannot detect association in defcfg\n");
                break;
+               }
        }
 
-       spec->multiout.num_dacs = 4;
+       spec->multiout.num_dacs = spec->num_dacs;
        spec->multiout.dac_nids = spec->dac_nids;
 
        spec->adc_nids = cmi9880_adc_nids;