]> nv-tegra.nvidia Code Review - linux-2.6.git/blobdiff - net/xfrm/xfrm_user.c
xfrm: SA lookups with mark
[linux-2.6.git] / net / xfrm / xfrm_user.c
index c06883bf620ee21fa896654847fc4ee85f445e33..331ae731080ab1bbd23d42606b3a371bbd0cf651 100644 (file)
@@ -19,7 +19,6 @@
 #include <linux/string.h>
 #include <linux/net.h>
 #include <linux/skbuff.h>
-#include <linux/rtnetlink.h>
 #include <linux/pfkeyv2.h>
 #include <linux/ipsec.h>
 #include <linux/init.h>
 #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
 #include <linux/in6.h>
 #endif
-#include <linux/audit.h>
 
-static int verify_one_alg(struct rtattr **xfrma, enum xfrm_attr_type_t type)
+#define DUMMY_MARK 0
+static struct xfrm_mark dummy_mark = {0, 0};
+
+static inline int aead_len(struct xfrm_algo_aead *alg)
+{
+       return sizeof(*alg) + ((alg->alg_key_len + 7) / 8);
+}
+
+static int verify_one_alg(struct nlattr **attrs, enum xfrm_attr_type_t type)
 {
-       struct rtattr *rt = xfrma[type - 1];
+       struct nlattr *rt = attrs[type];
        struct xfrm_algo *algp;
-       int len;
 
        if (!rt)
                return 0;
 
-       len = (rt->rta_len - sizeof(*rt)) - sizeof(*algp);
-       if (len < 0)
-               return -EINVAL;
-
-       algp = RTA_DATA(rt);
-
-       len -= (algp->alg_key_len + 7U) / 8;
-       if (len < 0)
+       algp = nla_data(rt);
+       if (nla_len(rt) < xfrm_alg_len(algp))
                return -EINVAL;
 
        switch (type) {
        case XFRMA_ALG_AUTH:
-               if (!algp->alg_key_len &&
-                   strcmp(algp->alg_name, "digest_null") != 0)
-                       return -EINVAL;
-               break;
-
        case XFRMA_ALG_CRYPT:
-               if (!algp->alg_key_len &&
-                   strcmp(algp->alg_name, "cipher_null") != 0)
-                       return -EINVAL;
-               break;
-
        case XFRMA_ALG_COMP:
-               /* Zero length keys are legal.  */
                break;
 
        default:
@@ -77,55 +65,57 @@ static int verify_one_alg(struct rtattr **xfrma, enum xfrm_attr_type_t type)
        return 0;
 }
 
-static int verify_encap_tmpl(struct rtattr **xfrma)
+static int verify_auth_trunc(struct nlattr **attrs)
 {
-       struct rtattr *rt = xfrma[XFRMA_ENCAP - 1];
-       struct xfrm_encap_tmpl *encap;
+       struct nlattr *rt = attrs[XFRMA_ALG_AUTH_TRUNC];
+       struct xfrm_algo_auth *algp;
 
        if (!rt)
                return 0;
 
-       if ((rt->rta_len - sizeof(*rt)) < sizeof(*encap))
+       algp = nla_data(rt);
+       if (nla_len(rt) < xfrm_alg_auth_len(algp))
                return -EINVAL;
 
+       algp->alg_name[CRYPTO_MAX_ALG_NAME - 1] = '\0';
        return 0;
 }
 
-static int verify_one_addr(struct rtattr **xfrma, enum xfrm_attr_type_t type,
-                          xfrm_address_t **addrp)
+static int verify_aead(struct nlattr **attrs)
 {
-       struct rtattr *rt = xfrma[type - 1];
+       struct nlattr *rt = attrs[XFRMA_ALG_AEAD];
+       struct xfrm_algo_aead *algp;
 
        if (!rt)
                return 0;
 
-       if ((rt->rta_len - sizeof(*rt)) < sizeof(**addrp))
+       algp = nla_data(rt);
+       if (nla_len(rt) < aead_len(algp))
                return -EINVAL;
 
-       if (addrp)
-               *addrp = RTA_DATA(rt);
-
+       algp->alg_name[CRYPTO_MAX_ALG_NAME - 1] = '\0';
        return 0;
 }
 
-static inline int verify_sec_ctx_len(struct rtattr **xfrma)
+static void verify_one_addr(struct nlattr **attrs, enum xfrm_attr_type_t type,
+                          xfrm_address_t **addrp)
+{
+       struct nlattr *rt = attrs[type];
+
+       if (rt && addrp)
+               *addrp = nla_data(rt);
+}
+
+static inline int verify_sec_ctx_len(struct nlattr **attrs)
 {
-       struct rtattr *rt = xfrma[XFRMA_SEC_CTX - 1];
+       struct nlattr *rt = attrs[XFRMA_SEC_CTX];
        struct xfrm_user_sec_ctx *uctx;
-       int len = 0;
 
        if (!rt)
                return 0;
 
-       if (rt->rta_len < sizeof(*uctx))
-               return -EINVAL;
-
-       uctx = RTA_DATA(rt);
-
-       len += sizeof(struct xfrm_user_sec_ctx);
-       len += uctx->ctx_len;
-
-       if (uctx->len != len)
+       uctx = nla_data(rt);
+       if (uctx->len != (sizeof(struct xfrm_user_sec_ctx) + uctx->ctx_len))
                return -EINVAL;
 
        return 0;
@@ -133,7 +123,7 @@ static inline int verify_sec_ctx_len(struct rtattr **xfrma)
 
 
 static int verify_newsa_info(struct xfrm_usersa_info *p,
-                            struct rtattr **xfrma)
+                            struct nlattr **attrs)
 {
        int err;
 
@@ -157,35 +147,49 @@ static int verify_newsa_info(struct xfrm_usersa_info *p,
        err = -EINVAL;
        switch (p->id.proto) {
        case IPPROTO_AH:
-               if (!xfrma[XFRMA_ALG_AUTH-1]    ||
-                   xfrma[XFRMA_ALG_CRYPT-1]    ||
-                   xfrma[XFRMA_ALG_COMP-1])
+               if ((!attrs[XFRMA_ALG_AUTH]     &&
+                    !attrs[XFRMA_ALG_AUTH_TRUNC]) ||
+                   attrs[XFRMA_ALG_AEAD]       ||
+                   attrs[XFRMA_ALG_CRYPT]      ||
+                   attrs[XFRMA_ALG_COMP])
                        goto out;
                break;
 
        case IPPROTO_ESP:
-               if ((!xfrma[XFRMA_ALG_AUTH-1] &&
-                    !xfrma[XFRMA_ALG_CRYPT-1]) ||
-                   xfrma[XFRMA_ALG_COMP-1])
+               if (attrs[XFRMA_ALG_COMP])
+                       goto out;
+               if (!attrs[XFRMA_ALG_AUTH] &&
+                   !attrs[XFRMA_ALG_AUTH_TRUNC] &&
+                   !attrs[XFRMA_ALG_CRYPT] &&
+                   !attrs[XFRMA_ALG_AEAD])
+                       goto out;
+               if ((attrs[XFRMA_ALG_AUTH] ||
+                    attrs[XFRMA_ALG_AUTH_TRUNC] ||
+                    attrs[XFRMA_ALG_CRYPT]) &&
+                   attrs[XFRMA_ALG_AEAD])
                        goto out;
                break;
 
        case IPPROTO_COMP:
-               if (!xfrma[XFRMA_ALG_COMP-1]    ||
-                   xfrma[XFRMA_ALG_AUTH-1]     ||
-                   xfrma[XFRMA_ALG_CRYPT-1])
+               if (!attrs[XFRMA_ALG_COMP]      ||
+                   attrs[XFRMA_ALG_AEAD]       ||
+                   attrs[XFRMA_ALG_AUTH]       ||
+                   attrs[XFRMA_ALG_AUTH_TRUNC] ||
+                   attrs[XFRMA_ALG_CRYPT])
                        goto out;
                break;
 
 #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
        case IPPROTO_DSTOPTS:
        case IPPROTO_ROUTING:
-               if (xfrma[XFRMA_ALG_COMP-1]     ||
-                   xfrma[XFRMA_ALG_AUTH-1]     ||
-                   xfrma[XFRMA_ALG_CRYPT-1]    ||
-                   xfrma[XFRMA_ENCAP-1]        ||
-                   xfrma[XFRMA_SEC_CTX-1]      ||
-                   !xfrma[XFRMA_COADDR-1])
+               if (attrs[XFRMA_ALG_COMP]       ||
+                   attrs[XFRMA_ALG_AUTH]       ||
+                   attrs[XFRMA_ALG_AUTH_TRUNC] ||
+                   attrs[XFRMA_ALG_AEAD]       ||
+                   attrs[XFRMA_ALG_CRYPT]      ||
+                   attrs[XFRMA_ENCAP]          ||
+                   attrs[XFRMA_SEC_CTX]        ||
+                   !attrs[XFRMA_COADDR])
                        goto out;
                break;
 #endif
@@ -194,17 +198,17 @@ static int verify_newsa_info(struct xfrm_usersa_info *p,
                goto out;
        }
 
-       if ((err = verify_one_alg(xfrma, XFRMA_ALG_AUTH)))
+       if ((err = verify_aead(attrs)))
                goto out;
-       if ((err = verify_one_alg(xfrma, XFRMA_ALG_CRYPT)))
+       if ((err = verify_auth_trunc(attrs)))
                goto out;
-       if ((err = verify_one_alg(xfrma, XFRMA_ALG_COMP)))
+       if ((err = verify_one_alg(attrs, XFRMA_ALG_AUTH)))
                goto out;
-       if ((err = verify_encap_tmpl(xfrma)))
+       if ((err = verify_one_alg(attrs, XFRMA_ALG_CRYPT)))
                goto out;
-       if ((err = verify_sec_ctx_len(xfrma)))
+       if ((err = verify_one_alg(attrs, XFRMA_ALG_COMP)))
                goto out;
-       if ((err = verify_one_addr(xfrma, XFRMA_COADDR, NULL)))
+       if ((err = verify_sec_ctx_len(attrs)))
                goto out;
 
        err = -EINVAL;
@@ -227,25 +231,22 @@ out:
 
 static int attach_one_algo(struct xfrm_algo **algpp, u8 *props,
                           struct xfrm_algo_desc *(*get_byname)(char *, int),
-                          struct rtattr *u_arg)
+                          struct nlattr *rta)
 {
-       struct rtattr *rta = u_arg;
        struct xfrm_algo *p, *ualg;
        struct xfrm_algo_desc *algo;
-       int len;
 
        if (!rta)
                return 0;
 
-       ualg = RTA_DATA(rta);
+       ualg = nla_data(rta);
 
        algo = get_byname(ualg->alg_name, 1);
        if (!algo)
                return -ENOSYS;
        *props = algo->desc.sadb_alg_id;
 
-       len = sizeof(*ualg) + (ualg->alg_key_len + 7U) / 8;
-       p = kmemdup(ualg, len, GFP_KERNEL);
+       p = kmemdup(ualg, xfrm_alg_len(ualg), GFP_KERNEL);
        if (!p)
                return -ENOMEM;
 
@@ -254,63 +255,102 @@ static int attach_one_algo(struct xfrm_algo **algpp, u8 *props,
        return 0;
 }
 
-static int attach_encap_tmpl(struct xfrm_encap_tmpl **encapp, struct rtattr *u_arg)
+static int attach_auth(struct xfrm_algo_auth **algpp, u8 *props,
+                      struct nlattr *rta)
 {
-       struct rtattr *rta = u_arg;
-       struct xfrm_encap_tmpl *p, *uencap;
+       struct xfrm_algo *ualg;
+       struct xfrm_algo_auth *p;
+       struct xfrm_algo_desc *algo;
 
        if (!rta)
                return 0;
 
-       uencap = RTA_DATA(rta);
-       p = kmemdup(uencap, sizeof(*p), GFP_KERNEL);
+       ualg = nla_data(rta);
+
+       algo = xfrm_aalg_get_byname(ualg->alg_name, 1);
+       if (!algo)
+               return -ENOSYS;
+       *props = algo->desc.sadb_alg_id;
+
+       p = kmalloc(sizeof(*p) + (ualg->alg_key_len + 7) / 8, GFP_KERNEL);
        if (!p)
                return -ENOMEM;
 
-       *encapp = p;
+       strcpy(p->alg_name, algo->name);
+       p->alg_key_len = ualg->alg_key_len;
+       p->alg_trunc_len = algo->uinfo.auth.icv_truncbits;
+       memcpy(p->alg_key, ualg->alg_key, (ualg->alg_key_len + 7) / 8);
+
+       *algpp = p;
        return 0;
 }
 
-
-static inline int xfrm_user_sec_ctx_size(struct xfrm_sec_ctx *xfrm_ctx)
+static int attach_auth_trunc(struct xfrm_algo_auth **algpp, u8 *props,
+                            struct nlattr *rta)
 {
-       int len = 0;
+       struct xfrm_algo_auth *p, *ualg;
+       struct xfrm_algo_desc *algo;
 
-       if (xfrm_ctx) {
-               len += sizeof(struct xfrm_user_sec_ctx);
-               len += xfrm_ctx->ctx_len;
-       }
-       return len;
-}
+       if (!rta)
+               return 0;
 
-static int attach_sec_ctx(struct xfrm_state *x, struct rtattr *u_arg)
-{
-       struct xfrm_user_sec_ctx *uctx;
+       ualg = nla_data(rta);
 
-       if (!u_arg)
-               return 0;
+       algo = xfrm_aalg_get_byname(ualg->alg_name, 1);
+       if (!algo)
+               return -ENOSYS;
+       if (ualg->alg_trunc_len > algo->uinfo.auth.icv_fullbits)
+               return -EINVAL;
+       *props = algo->desc.sadb_alg_id;
 
-       uctx = RTA_DATA(u_arg);
-       return security_xfrm_state_alloc(x, uctx);
+       p = kmemdup(ualg, xfrm_alg_auth_len(ualg), GFP_KERNEL);
+       if (!p)
+               return -ENOMEM;
+
+       strcpy(p->alg_name, algo->name);
+       if (!p->alg_trunc_len)
+               p->alg_trunc_len = algo->uinfo.auth.icv_truncbits;
+
+       *algpp = p;
+       return 0;
 }
 
-static int attach_one_addr(xfrm_address_t **addrpp, struct rtattr *u_arg)
+static int attach_aead(struct xfrm_algo_aead **algpp, u8 *props,
+                      struct nlattr *rta)
 {
-       struct rtattr *rta = u_arg;
-       xfrm_address_t *p, *uaddrp;
+       struct xfrm_algo_aead *p, *ualg;
+       struct xfrm_algo_desc *algo;
 
        if (!rta)
                return 0;
 
-       uaddrp = RTA_DATA(rta);
-       p = kmemdup(uaddrp, sizeof(*p), GFP_KERNEL);
+       ualg = nla_data(rta);
+
+       algo = xfrm_aead_get_byname(ualg->alg_name, ualg->alg_icv_len, 1);
+       if (!algo)
+               return -ENOSYS;
+       *props = algo->desc.sadb_alg_id;
+
+       p = kmemdup(ualg, aead_len(ualg), GFP_KERNEL);
        if (!p)
                return -ENOMEM;
 
-       *addrpp = p;
+       strcpy(p->alg_name, algo->name);
+       *algpp = p;
        return 0;
 }
 
+static inline int xfrm_user_sec_ctx_size(struct xfrm_sec_ctx *xfrm_ctx)
+{
+       int len = 0;
+
+       if (xfrm_ctx) {
+               len += sizeof(struct xfrm_user_sec_ctx);
+               len += xfrm_ctx->ctx_len;
+       }
+       return len;
+}
+
 static void copy_from_user_state(struct xfrm_state *x, struct xfrm_usersa_info *p)
 {
        memcpy(&x->id, &p->id, sizeof(x->id));
@@ -322,6 +362,9 @@ static void copy_from_user_state(struct xfrm_state *x, struct xfrm_usersa_info *
        x->props.family = p->family;
        memcpy(&x->props.saddr, &p->saddr, sizeof(x->props.saddr));
        x->props.flags = p->flags;
+
+       if (!x->sel.family && !(p->flags & XFRM_STATE_AF_UNSPEC))
+               x->sel.family = p->family;
 }
 
 /*
@@ -329,56 +372,42 @@ static void copy_from_user_state(struct xfrm_state *x, struct xfrm_usersa_info *
  * somehow made shareable and move it to xfrm_state.c - JHS
  *
 */
-static int xfrm_update_ae_params(struct xfrm_state *x, struct rtattr **xfrma)
+static void xfrm_update_ae_params(struct xfrm_state *x, struct nlattr **attrs)
 {
-       int err = - EINVAL;
-       struct rtattr *rp = xfrma[XFRMA_REPLAY_VAL-1];
-       struct rtattr *lt = xfrma[XFRMA_LTIME_VAL-1];
-       struct rtattr *et = xfrma[XFRMA_ETIMER_THRESH-1];
-       struct rtattr *rt = xfrma[XFRMA_REPLAY_THRESH-1];
+       struct nlattr *rp = attrs[XFRMA_REPLAY_VAL];
+       struct nlattr *lt = attrs[XFRMA_LTIME_VAL];
+       struct nlattr *et = attrs[XFRMA_ETIMER_THRESH];
+       struct nlattr *rt = attrs[XFRMA_REPLAY_THRESH];
 
        if (rp) {
                struct xfrm_replay_state *replay;
-               if (RTA_PAYLOAD(rp) < sizeof(*replay))
-                       goto error;
-               replay = RTA_DATA(rp);
+               replay = nla_data(rp);
                memcpy(&x->replay, replay, sizeof(*replay));
                memcpy(&x->preplay, replay, sizeof(*replay));
        }
 
        if (lt) {
                struct xfrm_lifetime_cur *ltime;
-               if (RTA_PAYLOAD(lt) < sizeof(*ltime))
-                       goto error;
-               ltime = RTA_DATA(lt);
+               ltime = nla_data(lt);
                x->curlft.bytes = ltime->bytes;
                x->curlft.packets = ltime->packets;
                x->curlft.add_time = ltime->add_time;
                x->curlft.use_time = ltime->use_time;
        }
 
-       if (et) {
-               if (RTA_PAYLOAD(et) < sizeof(u32))
-                       goto error;
-               x->replay_maxage = *(u32*)RTA_DATA(et);
-       }
-
-       if (rt) {
-               if (RTA_PAYLOAD(rt) < sizeof(u32))
-                       goto error;
-               x->replay_maxdiff = *(u32*)RTA_DATA(rt);
-       }
+       if (et)
+               x->replay_maxage = nla_get_u32(et);
 
-       return 0;
-error:
-       return err;
+       if (rt)
+               x->replay_maxdiff = nla_get_u32(rt);
 }
 
-static struct xfrm_state *xfrm_state_construct(struct xfrm_usersa_info *p,
-                                              struct rtattr **xfrma,
+static struct xfrm_state *xfrm_state_construct(struct net *net,
+                                              struct xfrm_usersa_info *p,
+                                              struct nlattr **attrs,
                                               int *errp)
 {
-       struct xfrm_state *x = xfrm_state_alloc();
+       struct xfrm_state *x = xfrm_state_alloc(net);
        int err = -ENOMEM;
 
        if (!x)
@@ -386,42 +415,59 @@ static struct xfrm_state *xfrm_state_construct(struct xfrm_usersa_info *p,
 
        copy_from_user_state(x, p);
 
-       if ((err = attach_one_algo(&x->aalg, &x->props.aalgo,
-                                  xfrm_aalg_get_byname,
-                                  xfrma[XFRMA_ALG_AUTH-1])))
+       if ((err = attach_aead(&x->aead, &x->props.ealgo,
+                              attrs[XFRMA_ALG_AEAD])))
                goto error;
+       if ((err = attach_auth_trunc(&x->aalg, &x->props.aalgo,
+                                    attrs[XFRMA_ALG_AUTH_TRUNC])))
+               goto error;
+       if (!x->props.aalgo) {
+               if ((err = attach_auth(&x->aalg, &x->props.aalgo,
+                                      attrs[XFRMA_ALG_AUTH])))
+                       goto error;
+       }
        if ((err = attach_one_algo(&x->ealg, &x->props.ealgo,
                                   xfrm_ealg_get_byname,
-                                  xfrma[XFRMA_ALG_CRYPT-1])))
+                                  attrs[XFRMA_ALG_CRYPT])))
                goto error;
        if ((err = attach_one_algo(&x->calg, &x->props.calgo,
                                   xfrm_calg_get_byname,
-                                  xfrma[XFRMA_ALG_COMP-1])))
-               goto error;
-       if ((err = attach_encap_tmpl(&x->encap, xfrma[XFRMA_ENCAP-1])))
-               goto error;
-       if ((err = attach_one_addr(&x->coaddr, xfrma[XFRMA_COADDR-1])))
+                                  attrs[XFRMA_ALG_COMP])))
                goto error;
+
+       if (attrs[XFRMA_ENCAP]) {
+               x->encap = kmemdup(nla_data(attrs[XFRMA_ENCAP]),
+                                  sizeof(*x->encap), GFP_KERNEL);
+               if (x->encap == NULL)
+                       goto error;
+       }
+
+       if (attrs[XFRMA_COADDR]) {
+               x->coaddr = kmemdup(nla_data(attrs[XFRMA_COADDR]),
+                                   sizeof(*x->coaddr), GFP_KERNEL);
+               if (x->coaddr == NULL)
+                       goto error;
+       }
+
        err = xfrm_init_state(x);
        if (err)
                goto error;
 
-       if ((err = attach_sec_ctx(x, xfrma[XFRMA_SEC_CTX-1])))
+       if (attrs[XFRMA_SEC_CTX] &&
+           security_xfrm_state_alloc(x, nla_data(attrs[XFRMA_SEC_CTX])))
                goto error;
 
        x->km.seq = p->seq;
-       x->replay_maxdiff = sysctl_xfrm_aevent_rseqth;
+       x->replay_maxdiff = net->xfrm.sysctl_aevent_rseqth;
        /* sysctl_xfrm_aevent_etime is in 100ms units */
-       x->replay_maxage = (sysctl_xfrm_aevent_etime*HZ)/XFRM_AE_ETH_M;
+       x->replay_maxage = (net->xfrm.sysctl_aevent_etime*HZ)/XFRM_AE_ETH_M;
        x->preplay.bitmap = 0;
        x->preplay.seq = x->replay.seq+x->replay_maxdiff;
        x->preplay.oseq = x->replay.oseq +x->replay_maxdiff;
 
        /* override default values from above */
 
-       err = xfrm_update_ae_params(x, (struct rtattr **)xfrma);
-       if (err < 0)
-               goto error;
+       xfrm_update_ae_params(x, attrs);
 
        return x;
 
@@ -434,18 +480,22 @@ error_no_put:
 }
 
 static int xfrm_add_sa(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
-       struct xfrm_usersa_info *p = NLMSG_DATA(nlh);
+       struct net *net = sock_net(skb->sk);
+       struct xfrm_usersa_info *p = nlmsg_data(nlh);
        struct xfrm_state *x;
        int err;
        struct km_event c;
+       uid_t loginuid = NETLINK_CB(skb).loginuid;
+       u32 sessionid = NETLINK_CB(skb).sessionid;
+       u32 sid = NETLINK_CB(skb).sid;
 
-       err = verify_newsa_info(p, xfrma);
+       err = verify_newsa_info(p, attrs);
        if (err)
                return err;
 
-       x = xfrm_state_construct(p, xfrma, &err);
+       x = xfrm_state_construct(net, p, attrs, &err);
        if (!x)
                return err;
 
@@ -455,8 +505,7 @@ static int xfrm_add_sa(struct sk_buff *skb, struct nlmsghdr *nlh,
        else
                err = xfrm_state_update(x);
 
-       xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid,
-                      AUDIT_MAC_IPSEC_ADDSA, err ? 0 : 1, NULL, x);
+       xfrm_audit_state_add(x, err ? 0 : 1, loginuid, sessionid, sid);
 
        if (err < 0) {
                x->km.state = XFRM_STATE_DEAD;
@@ -474,8 +523,9 @@ out:
        return err;
 }
 
-static struct xfrm_state *xfrm_user_state_lookup(struct xfrm_usersa_id *p,
-                                                struct rtattr **xfrma,
+static struct xfrm_state *xfrm_user_state_lookup(struct net *net,
+                                                struct xfrm_usersa_id *p,
+                                                struct nlattr **attrs,
                                                 int *errp)
 {
        struct xfrm_state *x = NULL;
@@ -483,22 +533,19 @@ static struct xfrm_state *xfrm_user_state_lookup(struct xfrm_usersa_id *p,
 
        if (xfrm_id_proto_match(p->proto, IPSEC_PROTO_ANY)) {
                err = -ESRCH;
-               x = xfrm_state_lookup(&p->daddr, p->spi, p->proto, p->family);
+               x = xfrm_state_lookup(net, DUMMY_MARK, &p->daddr, p->spi, p->proto, p->family);
        } else {
                xfrm_address_t *saddr = NULL;
 
-               err = verify_one_addr(xfrma, XFRMA_SRCADDR, &saddr);
-               if (err)
-                       goto out;
-
+               verify_one_addr(attrs, XFRMA_SRCADDR, &saddr);
                if (!saddr) {
                        err = -EINVAL;
                        goto out;
                }
 
                err = -ESRCH;
-               x = xfrm_state_lookup_byaddr(&p->daddr, saddr, p->proto,
-                                            p->family);
+               x = xfrm_state_lookup_byaddr(net, DUMMY_MARK, &p->daddr, saddr,
+                                            p->proto, p->family);
        }
 
  out:
@@ -508,14 +555,18 @@ static struct xfrm_state *xfrm_user_state_lookup(struct xfrm_usersa_id *p,
 }
 
 static int xfrm_del_sa(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
+       struct net *net = sock_net(skb->sk);
        struct xfrm_state *x;
        int err = -ESRCH;
        struct km_event c;
-       struct xfrm_usersa_id *p = NLMSG_DATA(nlh);
+       struct xfrm_usersa_id *p = nlmsg_data(nlh);
+       uid_t loginuid = NETLINK_CB(skb).loginuid;
+       u32 sessionid = NETLINK_CB(skb).sessionid;
+       u32 sid = NETLINK_CB(skb).sid;
 
-       x = xfrm_user_state_lookup(p, xfrma, &err);
+       x = xfrm_user_state_lookup(net, p, attrs, &err);
        if (x == NULL)
                return err;
 
@@ -538,8 +589,7 @@ static int xfrm_del_sa(struct sk_buff *skb, struct nlmsghdr *nlh,
        km_state_notify(x, &c);
 
 out:
-       xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid,
-                      AUDIT_MAC_IPSEC_DELSA, err ? 0 : 1, NULL, x);
+       xfrm_audit_state_delete(x, err ? 0 : 1, loginuid, sessionid, sid);
        xfrm_state_put(x);
        return err;
 }
@@ -565,85 +615,141 @@ struct xfrm_dump_info {
        struct sk_buff *out_skb;
        u32 nlmsg_seq;
        u16 nlmsg_flags;
-       int start_idx;
-       int this_idx;
 };
 
-static int dump_one_state(struct xfrm_state *x, int count, void *ptr)
+static int copy_sec_ctx(struct xfrm_sec_ctx *s, struct sk_buff *skb)
 {
-       struct xfrm_dump_info *sp = ptr;
-       struct sk_buff *in_skb = sp->in_skb;
-       struct sk_buff *skb = sp->out_skb;
-       struct xfrm_usersa_info *p;
-       struct nlmsghdr *nlh;
-       unsigned char *b = skb_tail_pointer(skb);
+       struct xfrm_user_sec_ctx *uctx;
+       struct nlattr *attr;
+       int ctx_size = sizeof(*uctx) + s->ctx_len;
 
-       if (sp->this_idx < sp->start_idx)
-               goto out;
+       attr = nla_reserve(skb, XFRMA_SEC_CTX, ctx_size);
+       if (attr == NULL)
+               return -EMSGSIZE;
+
+       uctx = nla_data(attr);
+       uctx->exttype = XFRMA_SEC_CTX;
+       uctx->len = ctx_size;
+       uctx->ctx_doi = s->ctx_doi;
+       uctx->ctx_alg = s->ctx_alg;
+       uctx->ctx_len = s->ctx_len;
+       memcpy(uctx + 1, s->ctx_str, s->ctx_len);
+
+       return 0;
+}
+
+static int copy_to_user_auth(struct xfrm_algo_auth *auth, struct sk_buff *skb)
+{
+       struct xfrm_algo *algo;
+       struct nlattr *nla;
 
-       nlh = NLMSG_PUT(skb, NETLINK_CB(in_skb).pid,
-                       sp->nlmsg_seq,
-                       XFRM_MSG_NEWSA, sizeof(*p));
-       nlh->nlmsg_flags = sp->nlmsg_flags;
+       nla = nla_reserve(skb, XFRMA_ALG_AUTH,
+                         sizeof(*algo) + (auth->alg_key_len + 7) / 8);
+       if (!nla)
+               return -EMSGSIZE;
+
+       algo = nla_data(nla);
+       strcpy(algo->alg_name, auth->alg_name);
+       memcpy(algo->alg_key, auth->alg_key, (auth->alg_key_len + 7) / 8);
+       algo->alg_key_len = auth->alg_key_len;
 
-       p = NLMSG_DATA(nlh);
+       return 0;
+}
+
+/* Don't change this without updating xfrm_sa_len! */
+static int copy_to_user_state_extra(struct xfrm_state *x,
+                                   struct xfrm_usersa_info *p,
+                                   struct sk_buff *skb)
+{
        copy_to_user_state(x, p);
 
-       if (x->aalg)
-               RTA_PUT(skb, XFRMA_ALG_AUTH,
-                       sizeof(*(x->aalg))+(x->aalg->alg_key_len+7)/8, x->aalg);
+       if (x->coaddr)
+               NLA_PUT(skb, XFRMA_COADDR, sizeof(*x->coaddr), x->coaddr);
+
+       if (x->lastused)
+               NLA_PUT_U64(skb, XFRMA_LASTUSED, x->lastused);
+
+       if (x->aead)
+               NLA_PUT(skb, XFRMA_ALG_AEAD, aead_len(x->aead), x->aead);
+       if (x->aalg) {
+               if (copy_to_user_auth(x->aalg, skb))
+                       goto nla_put_failure;
+
+               NLA_PUT(skb, XFRMA_ALG_AUTH_TRUNC,
+                       xfrm_alg_auth_len(x->aalg), x->aalg);
+       }
        if (x->ealg)
-               RTA_PUT(skb, XFRMA_ALG_CRYPT,
-                       sizeof(*(x->ealg))+(x->ealg->alg_key_len+7)/8, x->ealg);
+               NLA_PUT(skb, XFRMA_ALG_CRYPT, xfrm_alg_len(x->ealg), x->ealg);
        if (x->calg)
-               RTA_PUT(skb, XFRMA_ALG_COMP, sizeof(*(x->calg)), x->calg);
+               NLA_PUT(skb, XFRMA_ALG_COMP, sizeof(*(x->calg)), x->calg);
 
        if (x->encap)
-               RTA_PUT(skb, XFRMA_ENCAP, sizeof(*x->encap), x->encap);
+               NLA_PUT(skb, XFRMA_ENCAP, sizeof(*x->encap), x->encap);
 
-       if (x->security) {
-               int ctx_size = sizeof(struct xfrm_sec_ctx) +
-                               x->security->ctx_len;
-               struct rtattr *rt = __RTA_PUT(skb, XFRMA_SEC_CTX, ctx_size);
-               struct xfrm_user_sec_ctx *uctx = RTA_DATA(rt);
-
-               uctx->exttype = XFRMA_SEC_CTX;
-               uctx->len = ctx_size;
-               uctx->ctx_doi = x->security->ctx_doi;
-               uctx->ctx_alg = x->security->ctx_alg;
-               uctx->ctx_len = x->security->ctx_len;
-               memcpy(uctx + 1, x->security->ctx_str, x->security->ctx_len);
-       }
+       if (x->security && copy_sec_ctx(x->security, skb) < 0)
+               goto nla_put_failure;
 
-       if (x->coaddr)
-               RTA_PUT(skb, XFRMA_COADDR, sizeof(*x->coaddr), x->coaddr);
+       return 0;
 
-       if (x->lastused)
-               RTA_PUT(skb, XFRMA_LASTUSED, sizeof(x->lastused), &x->lastused);
+nla_put_failure:
+       return -EMSGSIZE;
+}
 
-       nlh->nlmsg_len = skb_tail_pointer(skb) - b;
-out:
-       sp->this_idx++;
+static int dump_one_state(struct xfrm_state *x, int count, void *ptr)
+{
+       struct xfrm_dump_info *sp = ptr;
+       struct sk_buff *in_skb = sp->in_skb;
+       struct sk_buff *skb = sp->out_skb;
+       struct xfrm_usersa_info *p;
+       struct nlmsghdr *nlh;
+       int err;
+
+       nlh = nlmsg_put(skb, NETLINK_CB(in_skb).pid, sp->nlmsg_seq,
+                       XFRM_MSG_NEWSA, sizeof(*p), sp->nlmsg_flags);
+       if (nlh == NULL)
+               return -EMSGSIZE;
+
+       p = nlmsg_data(nlh);
+
+       err = copy_to_user_state_extra(x, p, skb);
+       if (err)
+               goto nla_put_failure;
+
+       nlmsg_end(skb, nlh);
        return 0;
 
-nlmsg_failure:
-rtattr_failure:
-       nlmsg_trim(skb, b);
-       return -1;
+nla_put_failure:
+       nlmsg_cancel(skb, nlh);
+       return err;
+}
+
+static int xfrm_dump_sa_done(struct netlink_callback *cb)
+{
+       struct xfrm_state_walk *walk = (struct xfrm_state_walk *) &cb->args[1];
+       xfrm_state_walk_done(walk);
+       return 0;
 }
 
 static int xfrm_dump_sa(struct sk_buff *skb, struct netlink_callback *cb)
 {
+       struct net *net = sock_net(skb->sk);
+       struct xfrm_state_walk *walk = (struct xfrm_state_walk *) &cb->args[1];
        struct xfrm_dump_info info;
 
+       BUILD_BUG_ON(sizeof(struct xfrm_state_walk) >
+                    sizeof(cb->args) - sizeof(cb->args[0]));
+
        info.in_skb = cb->skb;
        info.out_skb = skb;
        info.nlmsg_seq = cb->nlh->nlmsg_seq;
        info.nlmsg_flags = NLM_F_MULTI;
-       info.this_idx = 0;
-       info.start_idx = cb->args[0];
-       (void) xfrm_state_walk(0, dump_one_state, &info);
-       cb->args[0] = info.this_idx;
+
+       if (!cb->args[0]) {
+               cb->args[0] = 1;
+               xfrm_state_walk_init(walk, 0);
+       }
+
+       (void) xfrm_state_walk(net, walk, dump_one_state, &info);
 
        return skb->len;
 }
@@ -654,7 +760,7 @@ static struct sk_buff *xfrm_state_netlink(struct sk_buff *in_skb,
        struct xfrm_dump_info info;
        struct sk_buff *skb;
 
-       skb = alloc_skb(NLMSG_GOODSIZE, GFP_ATOMIC);
+       skb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_ATOMIC);
        if (!skb)
                return ERR_PTR(-ENOMEM);
 
@@ -662,7 +768,6 @@ static struct sk_buff *xfrm_state_netlink(struct sk_buff *in_skb,
        info.out_skb = skb;
        info.nlmsg_seq = seq;
        info.nlmsg_flags = 0;
-       info.this_idx = info.start_idx = 0;
 
        if (dump_one_state(x, 0, &info)) {
                kfree_skb(skb);
@@ -672,7 +777,15 @@ static struct sk_buff *xfrm_state_netlink(struct sk_buff *in_skb,
        return skb;
 }
 
-static int build_spdinfo(struct sk_buff *skb, u32 pid, u32 seq, u32 flags)
+static inline size_t xfrm_spdinfo_msgsize(void)
+{
+       return NLMSG_ALIGN(4)
+              + nla_total_size(sizeof(struct xfrmu_spdinfo))
+              + nla_total_size(sizeof(struct xfrmu_spdhinfo));
+}
+
+static int build_spdinfo(struct sk_buff *skb, struct net *net,
+                        u32 pid, u32 seq, u32 flags)
 {
        struct xfrmk_spdinfo si;
        struct xfrmu_spdinfo spc;
@@ -686,7 +799,7 @@ static int build_spdinfo(struct sk_buff *skb, u32 pid, u32 seq, u32 flags)
 
        f = nlmsg_data(nlh);
        *f = flags;
-       xfrm_spd_getinfo(&si);
+       xfrm_spd_getinfo(net, &si);
        spc.incnt = si.incnt;
        spc.outcnt = si.outcnt;
        spc.fwdcnt = si.fwdcnt;
@@ -707,28 +820,33 @@ nla_put_failure:
 }
 
 static int xfrm_get_spdinfo(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
+       struct net *net = sock_net(skb->sk);
        struct sk_buff *r_skb;
-       u32 *flags = NLMSG_DATA(nlh);
+       u32 *flags = nlmsg_data(nlh);
        u32 spid = NETLINK_CB(skb).pid;
        u32 seq = nlh->nlmsg_seq;
-       int len = NLMSG_LENGTH(sizeof(u32));
 
-       len += RTA_SPACE(sizeof(struct xfrmu_spdinfo));
-       len += RTA_SPACE(sizeof(struct xfrmu_spdhinfo));
-
-       r_skb = alloc_skb(len, GFP_ATOMIC);
+       r_skb = nlmsg_new(xfrm_spdinfo_msgsize(), GFP_ATOMIC);
        if (r_skb == NULL)
                return -ENOMEM;
 
-       if (build_spdinfo(r_skb, spid, seq, *flags) < 0)
+       if (build_spdinfo(r_skb, net, spid, seq, *flags) < 0)
                BUG();
 
-       return nlmsg_unicast(xfrm_nl, r_skb, spid);
+       return nlmsg_unicast(net->xfrm.nlsk, r_skb, spid);
 }
 
-static int build_sadinfo(struct sk_buff *skb, u32 pid, u32 seq, u32 flags)
+static inline size_t xfrm_sadinfo_msgsize(void)
+{
+       return NLMSG_ALIGN(4)
+              + nla_total_size(sizeof(struct xfrmu_sadhinfo))
+              + nla_total_size(4); /* XFRMA_SAD_CNT */
+}
+
+static int build_sadinfo(struct sk_buff *skb, struct net *net,
+                        u32 pid, u32 seq, u32 flags)
 {
        struct xfrmk_sadinfo si;
        struct xfrmu_sadhinfo sh;
@@ -741,7 +859,7 @@ static int build_sadinfo(struct sk_buff *skb, u32 pid, u32 seq, u32 flags)
 
        f = nlmsg_data(nlh);
        *f = flags;
-       xfrm_sad_getinfo(&si);
+       xfrm_sad_getinfo(net, &si);
 
        sh.sadhmcnt = si.sadhmcnt;
        sh.sadhcnt = si.sadhcnt;
@@ -757,37 +875,34 @@ nla_put_failure:
 }
 
 static int xfrm_get_sadinfo(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
+       struct net *net = sock_net(skb->sk);
        struct sk_buff *r_skb;
-       u32 *flags = NLMSG_DATA(nlh);
+       u32 *flags = nlmsg_data(nlh);
        u32 spid = NETLINK_CB(skb).pid;
        u32 seq = nlh->nlmsg_seq;
-       int len = NLMSG_LENGTH(sizeof(u32));
-
-       len += RTA_SPACE(sizeof(struct xfrmu_sadhinfo));
-       len += RTA_SPACE(sizeof(u32));
-
-       r_skb = alloc_skb(len, GFP_ATOMIC);
 
+       r_skb = nlmsg_new(xfrm_sadinfo_msgsize(), GFP_ATOMIC);
        if (r_skb == NULL)
                return -ENOMEM;
 
-       if (build_sadinfo(r_skb, spid, seq, *flags) < 0)
+       if (build_sadinfo(r_skb, net, spid, seq, *flags) < 0)
                BUG();
 
-       return nlmsg_unicast(xfrm_nl, r_skb, spid);
+       return nlmsg_unicast(net->xfrm.nlsk, r_skb, spid);
 }
 
 static int xfrm_get_sa(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
-       struct xfrm_usersa_id *p = NLMSG_DATA(nlh);
+       struct net *net = sock_net(skb->sk);
+       struct xfrm_usersa_id *p = nlmsg_data(nlh);
        struct xfrm_state *x;
        struct sk_buff *resp_skb;
        int err = -ESRCH;
 
-       x = xfrm_user_state_lookup(p, xfrma, &err);
+       x = xfrm_user_state_lookup(net, p, attrs, &err);
        if (x == NULL)
                goto out_noput;
 
@@ -795,8 +910,7 @@ static int xfrm_get_sa(struct sk_buff *skb, struct nlmsghdr *nlh,
        if (IS_ERR(resp_skb)) {
                err = PTR_ERR(resp_skb);
        } else {
-               err = netlink_unicast(xfrm_nl, resp_skb,
-                                     NETLINK_CB(skb).pid, MSG_DONTWAIT);
+               err = nlmsg_unicast(net->xfrm.nlsk, resp_skb, NETLINK_CB(skb).pid);
        }
        xfrm_state_put(x);
 out_noput:
@@ -827,8 +941,9 @@ static int verify_userspi_info(struct xfrm_userspi_info *p)
 }
 
 static int xfrm_alloc_userspi(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
+       struct net *net = sock_net(skb->sk);
        struct xfrm_state *x;
        struct xfrm_userspi_info *p;
        struct sk_buff *resp_skb;
@@ -836,7 +951,7 @@ static int xfrm_alloc_userspi(struct sk_buff *skb, struct nlmsghdr *nlh,
        int family;
        int err;
 
-       p = NLMSG_DATA(nlh);
+       p = nlmsg_data(nlh);
        err = verify_userspi_info(p);
        if (err)
                goto out_noput;
@@ -846,7 +961,7 @@ static int xfrm_alloc_userspi(struct sk_buff *skb, struct nlmsghdr *nlh,
 
        x = NULL;
        if (p->info.seq) {
-               x = xfrm_find_acq_byseq(p->info.seq);
+               x = xfrm_find_acq_byseq(net, DUMMY_MARK, p->info.seq);
                if (x && xfrm_addr_cmp(&x->id.daddr, daddr, family)) {
                        xfrm_state_put(x);
                        x = NULL;
@@ -854,7 +969,7 @@ static int xfrm_alloc_userspi(struct sk_buff *skb, struct nlmsghdr *nlh,
        }
 
        if (!x)
-               x = xfrm_find_acq(p->info.mode, p->info.reqid,
+               x = xfrm_find_acq(net, &dummy_mark, p->info.mode, p->info.reqid,
                                  p->info.id.proto, daddr,
                                  &p->info.saddr, 1,
                                  family);
@@ -862,23 +977,17 @@ static int xfrm_alloc_userspi(struct sk_buff *skb, struct nlmsghdr *nlh,
        if (x == NULL)
                goto out_noput;
 
-       resp_skb = ERR_PTR(-ENOENT);
-
-       spin_lock_bh(&x->lock);
-       if (x->km.state != XFRM_STATE_DEAD) {
-               xfrm_alloc_spi(x, htonl(p->min), htonl(p->max));
-               if (x->id.spi)
-                       resp_skb = xfrm_state_netlink(skb, x, nlh->nlmsg_seq);
-       }
-       spin_unlock_bh(&x->lock);
+       err = xfrm_alloc_spi(x, p->min, p->max);
+       if (err)
+               goto out;
 
+       resp_skb = xfrm_state_netlink(skb, x, nlh->nlmsg_seq);
        if (IS_ERR(resp_skb)) {
                err = PTR_ERR(resp_skb);
                goto out;
        }
 
-       err = netlink_unicast(xfrm_nl, resp_skb,
-                             NETLINK_CB(skb).pid, MSG_DONTWAIT);
+       err = nlmsg_unicast(net->xfrm.nlsk, resp_skb, NETLINK_CB(skb).pid);
 
 out:
        xfrm_state_put(x);
@@ -957,16 +1066,16 @@ static int verify_newpolicy_info(struct xfrm_userpolicy_info *p)
        return verify_policy_dir(p->dir);
 }
 
-static int copy_from_user_sec_ctx(struct xfrm_policy *pol, struct rtattr **xfrma)
+static int copy_from_user_sec_ctx(struct xfrm_policy *pol, struct nlattr **attrs)
 {
-       struct rtattr *rt = xfrma[XFRMA_SEC_CTX-1];
+       struct nlattr *rt = attrs[XFRMA_SEC_CTX];
        struct xfrm_user_sec_ctx *uctx;
 
        if (!rt)
                return 0;
 
-       uctx = RTA_DATA(rt);
-       return security_xfrm_policy_alloc(pol, uctx);
+       uctx = nla_data(rt);
+       return security_xfrm_policy_alloc(&pol->security, uctx);
 }
 
 static void copy_templates(struct xfrm_policy *xp, struct xfrm_user_tmpl *ut,
@@ -988,6 +1097,8 @@ static void copy_templates(struct xfrm_policy *xp, struct xfrm_user_tmpl *ut,
                t->aalgos = ut->aalgos;
                t->ealgos = ut->ealgos;
                t->calgos = ut->calgos;
+               /* If all masks are ~0, then we allow all algorithms. */
+               t->allalgs = !~(t->aalgos & t->ealgos & t->calgos);
                t->encap_family = ut->family;
        }
 }
@@ -1025,38 +1136,35 @@ static int validate_tmpl(int nr, struct xfrm_user_tmpl *ut, u16 family)
        return 0;
 }
 
-static int copy_from_user_tmpl(struct xfrm_policy *pol, struct rtattr **xfrma)
+static int copy_from_user_tmpl(struct xfrm_policy *pol, struct nlattr **attrs)
 {
-       struct rtattr *rt = xfrma[XFRMA_TMPL-1];
+       struct nlattr *rt = attrs[XFRMA_TMPL];
 
        if (!rt) {
                pol->xfrm_nr = 0;
        } else {
-               struct xfrm_user_tmpl *utmpl = RTA_DATA(rt);
-               int nr = (rt->rta_len - sizeof(*rt)) / sizeof(*utmpl);
+               struct xfrm_user_tmpl *utmpl = nla_data(rt);
+               int nr = nla_len(rt) / sizeof(*utmpl);
                int err;
 
                err = validate_tmpl(nr, utmpl, pol->family);
                if (err)
                        return err;
 
-               copy_templates(pol, RTA_DATA(rt), nr);
+               copy_templates(pol, utmpl, nr);
        }
        return 0;
 }
 
-static int copy_from_user_policy_type(u8 *tp, struct rtattr **xfrma)
+static int copy_from_user_policy_type(u8 *tp, struct nlattr **attrs)
 {
-       struct rtattr *rt = xfrma[XFRMA_POLICY_TYPE-1];
+       struct nlattr *rt = attrs[XFRMA_POLICY_TYPE];
        struct xfrm_userpolicy_type *upt;
        u8 type = XFRM_POLICY_TYPE_MAIN;
        int err;
 
        if (rt) {
-               if (rt->rta_len < sizeof(*upt))
-                       return -EINVAL;
-
-               upt = RTA_DATA(rt);
+               upt = nla_data(rt);
                type = upt->type;
        }
 
@@ -1094,9 +1202,9 @@ static void copy_to_user_policy(struct xfrm_policy *xp, struct xfrm_userpolicy_i
        p->share = XFRM_SHARE_ANY; /* XXX xp->share */
 }
 
-static struct xfrm_policy *xfrm_policy_construct(struct xfrm_userpolicy_info *p, struct rtattr **xfrma, int *errp)
+static struct xfrm_policy *xfrm_policy_construct(struct net *net, struct xfrm_userpolicy_info *p, struct nlattr **attrs, int *errp)
 {
-       struct xfrm_policy *xp = xfrm_policy_alloc(GFP_KERNEL);
+       struct xfrm_policy *xp = xfrm_policy_alloc(net, GFP_KERNEL);
        int err;
 
        if (!xp) {
@@ -1106,39 +1214,44 @@ static struct xfrm_policy *xfrm_policy_construct(struct xfrm_userpolicy_info *p,
 
        copy_from_user_policy(xp, p);
 
-       err = copy_from_user_policy_type(&xp->type, xfrma);
+       err = copy_from_user_policy_type(&xp->type, attrs);
        if (err)
                goto error;
 
-       if (!(err = copy_from_user_tmpl(xp, xfrma)))
-               err = copy_from_user_sec_ctx(xp, xfrma);
+       if (!(err = copy_from_user_tmpl(xp, attrs)))
+               err = copy_from_user_sec_ctx(xp, attrs);
        if (err)
                goto error;
 
        return xp;
  error:
        *errp = err;
-       kfree(xp);
+       xp->walk.dead = 1;
+       xfrm_policy_destroy(xp);
        return NULL;
 }
 
 static int xfrm_add_policy(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
-       struct xfrm_userpolicy_info *p = NLMSG_DATA(nlh);
+       struct net *net = sock_net(skb->sk);
+       struct xfrm_userpolicy_info *p = nlmsg_data(nlh);
        struct xfrm_policy *xp;
        struct km_event c;
        int err;
        int excl;
+       uid_t loginuid = NETLINK_CB(skb).loginuid;
+       u32 sessionid = NETLINK_CB(skb).sessionid;
+       u32 sid = NETLINK_CB(skb).sid;
 
        err = verify_newpolicy_info(p);
        if (err)
                return err;
-       err = verify_sec_ctx_len(xfrma);
+       err = verify_sec_ctx_len(attrs);
        if (err)
                return err;
 
-       xp = xfrm_policy_construct(p, xfrma, &err);
+       xp = xfrm_policy_construct(net, p, attrs, &err);
        if (!xp)
                return err;
 
@@ -1148,11 +1261,10 @@ static int xfrm_add_policy(struct sk_buff *skb, struct nlmsghdr *nlh,
         * a type XFRM_MSG_UPDPOLICY - JHS */
        excl = nlh->nlmsg_type == XFRM_MSG_NEWPOLICY;
        err = xfrm_policy_insert(p->dir, xp, excl);
-       xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid,
-                      AUDIT_MAC_IPSEC_DELSPD, err ? 0 : 1, xp, NULL);
+       xfrm_audit_policy_add(xp, err ? 0 : 1, loginuid, sessionid, sid);
 
        if (err) {
-               security_xfrm_policy_free(xp);
+               security_xfrm_policy_free(xp->security);
                kfree(xp);
                return err;
        }
@@ -1190,32 +1302,9 @@ static int copy_to_user_tmpl(struct xfrm_policy *xp, struct sk_buff *skb)
                up->ealgos = kp->ealgos;
                up->calgos = kp->calgos;
        }
-       RTA_PUT(skb, XFRMA_TMPL,
-               (sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr),
-               vec);
-
-       return 0;
-
-rtattr_failure:
-       return -1;
-}
-
-static int copy_sec_ctx(struct xfrm_sec_ctx *s, struct sk_buff *skb)
-{
-       int ctx_size = sizeof(struct xfrm_sec_ctx) + s->ctx_len;
-       struct rtattr *rt = __RTA_PUT(skb, XFRMA_SEC_CTX, ctx_size);
-       struct xfrm_user_sec_ctx *uctx = RTA_DATA(rt);
-
-       uctx->exttype = XFRMA_SEC_CTX;
-       uctx->len = ctx_size;
-       uctx->ctx_doi = s->ctx_doi;
-       uctx->ctx_alg = s->ctx_alg;
-       uctx->ctx_len = s->ctx_len;
-       memcpy(uctx + 1, s->ctx_str, s->ctx_len);
-       return 0;
 
- rtattr_failure:
-       return -1;
+       return nla_put(skb, XFRMA_TMPL,
+                      sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr, vec);
 }
 
 static inline int copy_to_user_state_sec_ctx(struct xfrm_state *x, struct sk_buff *skb)
@@ -1233,21 +1322,23 @@ static inline int copy_to_user_sec_ctx(struct xfrm_policy *xp, struct sk_buff *s
        }
        return 0;
 }
+static inline size_t userpolicy_type_attrsize(void)
+{
+#ifdef CONFIG_XFRM_SUB_POLICY
+       return nla_total_size(sizeof(struct xfrm_userpolicy_type));
+#else
+       return 0;
+#endif
+}
 
 #ifdef CONFIG_XFRM_SUB_POLICY
 static int copy_to_user_policy_type(u8 type, struct sk_buff *skb)
 {
-       struct xfrm_userpolicy_type upt;
-
-       memset(&upt, 0, sizeof(upt));
-       upt.type = type;
+       struct xfrm_userpolicy_type upt = {
+               .type = type,
+       };
 
-       RTA_PUT(skb, XFRMA_POLICY_TYPE, sizeof(upt), &upt);
-
-       return 0;
-
-rtattr_failure:
-       return -1;
+       return nla_put(skb, XFRMA_POLICY_TYPE, sizeof(upt), &upt);
 }
 
 #else
@@ -1264,17 +1355,13 @@ static int dump_one_policy(struct xfrm_policy *xp, int dir, int count, void *ptr
        struct sk_buff *in_skb = sp->in_skb;
        struct sk_buff *skb = sp->out_skb;
        struct nlmsghdr *nlh;
-       unsigned char *b = skb_tail_pointer(skb);
 
-       if (sp->this_idx < sp->start_idx)
-               goto out;
-
-       nlh = NLMSG_PUT(skb, NETLINK_CB(in_skb).pid,
-                       sp->nlmsg_seq,
-                       XFRM_MSG_NEWPOLICY, sizeof(*p));
-       p = NLMSG_DATA(nlh);
-       nlh->nlmsg_flags = sp->nlmsg_flags;
+       nlh = nlmsg_put(skb, NETLINK_CB(in_skb).pid, sp->nlmsg_seq,
+                       XFRM_MSG_NEWPOLICY, sizeof(*p), sp->nlmsg_flags);
+       if (nlh == NULL)
+               return -EMSGSIZE;
 
+       p = nlmsg_data(nlh);
        copy_to_user_policy(xp, p, dir);
        if (copy_to_user_tmpl(xp, skb) < 0)
                goto nlmsg_failure;
@@ -1283,31 +1370,42 @@ static int dump_one_policy(struct xfrm_policy *xp, int dir, int count, void *ptr
        if (copy_to_user_policy_type(xp->type, skb) < 0)
                goto nlmsg_failure;
 
-       nlh->nlmsg_len = skb_tail_pointer(skb) - b;
-out:
-       sp->this_idx++;
+       nlmsg_end(skb, nlh);
        return 0;
 
 nlmsg_failure:
-       nlmsg_trim(skb, b);
-       return -1;
+       nlmsg_cancel(skb, nlh);
+       return -EMSGSIZE;
+}
+
+static int xfrm_dump_policy_done(struct netlink_callback *cb)
+{
+       struct xfrm_policy_walk *walk = (struct xfrm_policy_walk *) &cb->args[1];
+
+       xfrm_policy_walk_done(walk);
+       return 0;
 }
 
 static int xfrm_dump_policy(struct sk_buff *skb, struct netlink_callback *cb)
 {
+       struct net *net = sock_net(skb->sk);
+       struct xfrm_policy_walk *walk = (struct xfrm_policy_walk *) &cb->args[1];
        struct xfrm_dump_info info;
 
+       BUILD_BUG_ON(sizeof(struct xfrm_policy_walk) >
+                    sizeof(cb->args) - sizeof(cb->args[0]));
+
        info.in_skb = cb->skb;
        info.out_skb = skb;
        info.nlmsg_seq = cb->nlh->nlmsg_seq;
        info.nlmsg_flags = NLM_F_MULTI;
-       info.this_idx = 0;
-       info.start_idx = cb->args[0];
-       (void) xfrm_policy_walk(XFRM_POLICY_TYPE_MAIN, dump_one_policy, &info);
-#ifdef CONFIG_XFRM_SUB_POLICY
-       (void) xfrm_policy_walk(XFRM_POLICY_TYPE_SUB, dump_one_policy, &info);
-#endif
-       cb->args[0] = info.this_idx;
+
+       if (!cb->args[0]) {
+               cb->args[0] = 1;
+               xfrm_policy_walk_init(walk, XFRM_POLICY_TYPE_ANY);
+       }
+
+       (void) xfrm_policy_walk(net, walk, dump_one_policy, &info);
 
        return skb->len;
 }
@@ -1319,7 +1417,7 @@ static struct sk_buff *xfrm_policy_netlink(struct sk_buff *in_skb,
        struct xfrm_dump_info info;
        struct sk_buff *skb;
 
-       skb = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL);
+       skb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
        if (!skb)
                return ERR_PTR(-ENOMEM);
 
@@ -1327,7 +1425,6 @@ static struct sk_buff *xfrm_policy_netlink(struct sk_buff *in_skb,
        info.out_skb = skb;
        info.nlmsg_seq = seq;
        info.nlmsg_flags = 0;
-       info.this_idx = info.start_idx = 0;
 
        if (dump_one_policy(xp, dir, 0, &info) < 0) {
                kfree_skb(skb);
@@ -1338,8 +1435,9 @@ static struct sk_buff *xfrm_policy_netlink(struct sk_buff *in_skb,
 }
 
 static int xfrm_get_policy(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
+       struct net *net = sock_net(skb->sk);
        struct xfrm_policy *xp;
        struct xfrm_userpolicy_id *p;
        u8 type = XFRM_POLICY_TYPE_MAIN;
@@ -1347,10 +1445,10 @@ static int xfrm_get_policy(struct sk_buff *skb, struct nlmsghdr *nlh,
        struct km_event c;
        int delete;
 
-       p = NLMSG_DATA(nlh);
+       p = nlmsg_data(nlh);
        delete = nlh->nlmsg_type == XFRM_MSG_DELPOLICY;
 
-       err = copy_from_user_policy_type(&type, xfrma);
+       err = copy_from_user_policy_type(&type, attrs);
        if (err)
                return err;
 
@@ -1359,25 +1457,26 @@ static int xfrm_get_policy(struct sk_buff *skb, struct nlmsghdr *nlh,
                return err;
 
        if (p->index)
-               xp = xfrm_policy_byid(type, p->dir, p->index, delete, &err);
+               xp = xfrm_policy_byid(net, type, p->dir, p->index, delete, &err);
        else {
-               struct rtattr *rt = xfrma[XFRMA_SEC_CTX-1];
-               struct xfrm_policy tmp;
+               struct nlattr *rt = attrs[XFRMA_SEC_CTX];
+               struct xfrm_sec_ctx *ctx;
 
-               err = verify_sec_ctx_len(xfrma);
+               err = verify_sec_ctx_len(attrs);
                if (err)
                        return err;
 
-               memset(&tmp, 0, sizeof(struct xfrm_policy));
+               ctx = NULL;
                if (rt) {
-                       struct xfrm_user_sec_ctx *uctx = RTA_DATA(rt);
+                       struct xfrm_user_sec_ctx *uctx = nla_data(rt);
 
-                       if ((err = security_xfrm_policy_alloc(&tmp, uctx)))
+                       err = security_xfrm_policy_alloc(&ctx, uctx);
+                       if (err)
                                return err;
                }
-               xp = xfrm_policy_bysel_ctx(type, p->dir, &p->sel, tmp.security,
+               xp = xfrm_policy_bysel_ctx(net, type, p->dir, &p->sel, ctx,
                                           delete, &err);
-               security_xfrm_policy_free(&tmp);
+               security_xfrm_policy_free(ctx);
        }
        if (xp == NULL)
                return -ENOENT;
@@ -1389,13 +1488,16 @@ static int xfrm_get_policy(struct sk_buff *skb, struct nlmsghdr *nlh,
                if (IS_ERR(resp_skb)) {
                        err = PTR_ERR(resp_skb);
                } else {
-                       err = netlink_unicast(xfrm_nl, resp_skb,
-                                             NETLINK_CB(skb).pid,
-                                             MSG_DONTWAIT);
+                       err = nlmsg_unicast(net->xfrm.nlsk, resp_skb,
+                                           NETLINK_CB(skb).pid);
                }
        } else {
-               xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid,
-                              AUDIT_MAC_IPSEC_DELSPD, err ? 0 : 1, xp, NULL);
+               uid_t loginuid = NETLINK_CB(skb).loginuid;
+               u32 sessionid = NETLINK_CB(skb).sessionid;
+               u32 sid = NETLINK_CB(skb).sid;
+
+               xfrm_audit_policy_delete(xp, err ? 0 : 1, loginuid, sessionid,
+                                        sid);
 
                if (err != 0)
                        goto out;
@@ -1413,39 +1515,52 @@ out:
 }
 
 static int xfrm_flush_sa(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
+       struct net *net = sock_net(skb->sk);
        struct km_event c;
-       struct xfrm_usersa_flush *p = NLMSG_DATA(nlh);
+       struct xfrm_usersa_flush *p = nlmsg_data(nlh);
        struct xfrm_audit audit_info;
        int err;
 
        audit_info.loginuid = NETLINK_CB(skb).loginuid;
+       audit_info.sessionid = NETLINK_CB(skb).sessionid;
        audit_info.secid = NETLINK_CB(skb).sid;
-       err = xfrm_state_flush(p->proto, &audit_info);
-       if (err)
+       err = xfrm_state_flush(net, p->proto, &audit_info);
+       if (err) {
+               if (err == -ESRCH) /* empty table */
+                       return 0;
                return err;
+       }
        c.data.proto = p->proto;
        c.event = nlh->nlmsg_type;
        c.seq = nlh->nlmsg_seq;
        c.pid = nlh->nlmsg_pid;
+       c.net = net;
        km_state_notify(NULL, &c);
 
        return 0;
 }
 
+static inline size_t xfrm_aevent_msgsize(void)
+{
+       return NLMSG_ALIGN(sizeof(struct xfrm_aevent_id))
+              + nla_total_size(sizeof(struct xfrm_replay_state))
+              + nla_total_size(sizeof(struct xfrm_lifetime_cur))
+              + nla_total_size(4) /* XFRM_AE_RTHR */
+              + nla_total_size(4); /* XFRM_AE_ETHR */
+}
 
 static int build_aevent(struct sk_buff *skb, struct xfrm_state *x, struct km_event *c)
 {
        struct xfrm_aevent_id *id;
        struct nlmsghdr *nlh;
-       struct xfrm_lifetime_cur ltime;
-       unsigned char *b = skb_tail_pointer(skb);
 
-       nlh = NLMSG_PUT(skb, c->pid, c->seq, XFRM_MSG_NEWAE, sizeof(*id));
-       id = NLMSG_DATA(nlh);
-       nlh->nlmsg_flags = 0;
+       nlh = nlmsg_put(skb, c->pid, c->seq, XFRM_MSG_NEWAE, sizeof(*id), 0);
+       if (nlh == NULL)
+               return -EMSGSIZE;
 
+       id = nlmsg_data(nlh);
        memcpy(&id->sa_id.daddr, &x->id.daddr,sizeof(x->id.daddr));
        id->sa_id.spi = x->id.spi;
        id->sa_id.family = x->props.family;
@@ -1454,58 +1569,39 @@ static int build_aevent(struct sk_buff *skb, struct xfrm_state *x, struct km_eve
        id->reqid = x->props.reqid;
        id->flags = c->data.aevent;
 
-       RTA_PUT(skb, XFRMA_REPLAY_VAL, sizeof(x->replay), &x->replay);
+       NLA_PUT(skb, XFRMA_REPLAY_VAL, sizeof(x->replay), &x->replay);
+       NLA_PUT(skb, XFRMA_LTIME_VAL, sizeof(x->curlft), &x->curlft);
 
-       ltime.bytes = x->curlft.bytes;
-       ltime.packets = x->curlft.packets;
-       ltime.add_time = x->curlft.add_time;
-       ltime.use_time = x->curlft.use_time;
+       if (id->flags & XFRM_AE_RTHR)
+               NLA_PUT_U32(skb, XFRMA_REPLAY_THRESH, x->replay_maxdiff);
 
-       RTA_PUT(skb, XFRMA_LTIME_VAL, sizeof(struct xfrm_lifetime_cur), &ltime);
+       if (id->flags & XFRM_AE_ETHR)
+               NLA_PUT_U32(skb, XFRMA_ETIMER_THRESH,
+                           x->replay_maxage * 10 / HZ);
 
-       if (id->flags&XFRM_AE_RTHR) {
-               RTA_PUT(skb,XFRMA_REPLAY_THRESH,sizeof(u32),&x->replay_maxdiff);
-       }
-
-       if (id->flags&XFRM_AE_ETHR) {
-               u32 etimer = x->replay_maxage*10/HZ;
-               RTA_PUT(skb,XFRMA_ETIMER_THRESH,sizeof(u32),&etimer);
-       }
-
-       nlh->nlmsg_len = skb_tail_pointer(skb) - b;
-       return skb->len;
+       return nlmsg_end(skb, nlh);
 
-rtattr_failure:
-nlmsg_failure:
-       nlmsg_trim(skb, b);
-       return -1;
+nla_put_failure:
+       nlmsg_cancel(skb, nlh);
+       return -EMSGSIZE;
 }
 
 static int xfrm_get_ae(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
+       struct net *net = sock_net(skb->sk);
        struct xfrm_state *x;
        struct sk_buff *r_skb;
        int err;
        struct km_event c;
-       struct xfrm_aevent_id *p = NLMSG_DATA(nlh);
-       int len = NLMSG_LENGTH(sizeof(struct xfrm_aevent_id));
+       struct xfrm_aevent_id *p = nlmsg_data(nlh);
        struct xfrm_usersa_id *id = &p->sa_id;
 
-       len += RTA_SPACE(sizeof(struct xfrm_replay_state));
-       len += RTA_SPACE(sizeof(struct xfrm_lifetime_cur));
-
-       if (p->flags&XFRM_AE_RTHR)
-               len+=RTA_SPACE(sizeof(u32));
-
-       if (p->flags&XFRM_AE_ETHR)
-               len+=RTA_SPACE(sizeof(u32));
-
-       r_skb = alloc_skb(len, GFP_ATOMIC);
+       r_skb = nlmsg_new(xfrm_aevent_msgsize(), GFP_ATOMIC);
        if (r_skb == NULL)
                return -ENOMEM;
 
-       x = xfrm_state_lookup(&id->daddr, id->spi, id->proto, id->family);
+       x = xfrm_state_lookup(net, DUMMY_MARK, &id->daddr, id->spi, id->proto, id->family);
        if (x == NULL) {
                kfree_skb(r_skb);
                return -ESRCH;
@@ -1523,22 +1619,22 @@ static int xfrm_get_ae(struct sk_buff *skb, struct nlmsghdr *nlh,
 
        if (build_aevent(r_skb, x, &c) < 0)
                BUG();
-       err = netlink_unicast(xfrm_nl, r_skb,
-                             NETLINK_CB(skb).pid, MSG_DONTWAIT);
+       err = nlmsg_unicast(net->xfrm.nlsk, r_skb, NETLINK_CB(skb).pid);
        spin_unlock_bh(&x->lock);
        xfrm_state_put(x);
        return err;
 }
 
 static int xfrm_new_ae(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
+       struct net *net = sock_net(skb->sk);
        struct xfrm_state *x;
        struct km_event c;
        int err = - EINVAL;
-       struct xfrm_aevent_id *p = NLMSG_DATA(nlh);
-       struct rtattr *rp = xfrma[XFRMA_REPLAY_VAL-1];
-       struct rtattr *lt = xfrma[XFRMA_LTIME_VAL-1];
+       struct xfrm_aevent_id *p = nlmsg_data(nlh);
+       struct nlattr *rp = attrs[XFRMA_REPLAY_VAL];
+       struct nlattr *lt = attrs[XFRMA_LTIME_VAL];
 
        if (!lt && !rp)
                return err;
@@ -1547,7 +1643,7 @@ static int xfrm_new_ae(struct sk_buff *skb, struct nlmsghdr *nlh,
        if (!(nlh->nlmsg_flags&NLM_F_REPLACE))
                return err;
 
-       x = xfrm_state_lookup(&p->sa_id.daddr, p->sa_id.spi, p->sa_id.proto, p->sa_id.family);
+       x = xfrm_state_lookup(net, DUMMY_MARK, &p->sa_id.daddr, p->sa_id.spi, p->sa_id.proto, p->sa_id.family);
        if (x == NULL)
                return -ESRCH;
 
@@ -1555,10 +1651,8 @@ static int xfrm_new_ae(struct sk_buff *skb, struct nlmsghdr *nlh,
                goto out;
 
        spin_lock_bh(&x->lock);
-       err = xfrm_update_ae_params(x, xfrma);
+       xfrm_update_ae_params(x, attrs);
        spin_unlock_bh(&x->lock);
-       if (err < 0)
-               goto out;
 
        c.event = nlh->nlmsg_type;
        c.seq = nlh->nlmsg_seq;
@@ -1572,69 +1666,77 @@ out:
 }
 
 static int xfrm_flush_policy(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
+       struct net *net = sock_net(skb->sk);
        struct km_event c;
        u8 type = XFRM_POLICY_TYPE_MAIN;
        int err;
        struct xfrm_audit audit_info;
 
-       err = copy_from_user_policy_type(&type, xfrma);
+       err = copy_from_user_policy_type(&type, attrs);
        if (err)
                return err;
 
        audit_info.loginuid = NETLINK_CB(skb).loginuid;
+       audit_info.sessionid = NETLINK_CB(skb).sessionid;
        audit_info.secid = NETLINK_CB(skb).sid;
-       err = xfrm_policy_flush(type, &audit_info);
-       if (err)
+       err = xfrm_policy_flush(net, type, &audit_info);
+       if (err) {
+               if (err == -ESRCH) /* empty table */
+                       return 0;
                return err;
+       }
+
        c.data.type = type;
        c.event = nlh->nlmsg_type;
        c.seq = nlh->nlmsg_seq;
        c.pid = nlh->nlmsg_pid;
+       c.net = net;
        km_policy_notify(NULL, 0, &c);
        return 0;
 }
 
 static int xfrm_add_pol_expire(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
+       struct net *net = sock_net(skb->sk);
        struct xfrm_policy *xp;
-       struct xfrm_user_polexpire *up = NLMSG_DATA(nlh);
+       struct xfrm_user_polexpire *up = nlmsg_data(nlh);
        struct xfrm_userpolicy_info *p = &up->pol;
        u8 type = XFRM_POLICY_TYPE_MAIN;
        int err = -ENOENT;
 
-       err = copy_from_user_policy_type(&type, xfrma);
+       err = copy_from_user_policy_type(&type, attrs);
        if (err)
                return err;
 
        if (p->index)
-               xp = xfrm_policy_byid(type, p->dir, p->index, 0, &err);
+               xp = xfrm_policy_byid(net, type, p->dir, p->index, 0, &err);
        else {
-               struct rtattr *rt = xfrma[XFRMA_SEC_CTX-1];
-               struct xfrm_policy tmp;
+               struct nlattr *rt = attrs[XFRMA_SEC_CTX];
+               struct xfrm_sec_ctx *ctx;
 
-               err = verify_sec_ctx_len(xfrma);
+               err = verify_sec_ctx_len(attrs);
                if (err)
                        return err;
 
-               memset(&tmp, 0, sizeof(struct xfrm_policy));
+               ctx = NULL;
                if (rt) {
-                       struct xfrm_user_sec_ctx *uctx = RTA_DATA(rt);
+                       struct xfrm_user_sec_ctx *uctx = nla_data(rt);
 
-                       if ((err = security_xfrm_policy_alloc(&tmp, uctx)))
+                       err = security_xfrm_policy_alloc(&ctx, uctx);
+                       if (err)
                                return err;
                }
-               xp = xfrm_policy_bysel_ctx(type, p->dir, &p->sel, tmp.security,
-                                          0, &err);
-               security_xfrm_policy_free(&tmp);
+               xp = xfrm_policy_bysel_ctx(net, type, p->dir, &p->sel, ctx, 0, &err);
+               security_xfrm_policy_free(ctx);
        }
-
        if (xp == NULL)
                return -ENOENT;
+
        read_lock(&xp->lock);
-       if (xp->dead) {
+       if (xp->walk.dead) {
                read_unlock(&xp->lock);
                goto out;
        }
@@ -1642,9 +1744,11 @@ static int xfrm_add_pol_expire(struct sk_buff *skb, struct nlmsghdr *nlh,
        read_unlock(&xp->lock);
        err = 0;
        if (up->hard) {
+               uid_t loginuid = NETLINK_CB(skb).loginuid;
+               uid_t sessionid = NETLINK_CB(skb).sessionid;
+               u32 sid = NETLINK_CB(skb).sid;
                xfrm_policy_delete(xp, p->dir);
-               xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid,
-                               AUDIT_MAC_IPSEC_DELSPD, 1, xp, NULL);
+               xfrm_audit_policy_delete(xp, 1, loginuid, sessionid, sid);
 
        } else {
                // reset the timers here?
@@ -1658,14 +1762,15 @@ out:
 }
 
 static int xfrm_add_sa_expire(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
+       struct net *net = sock_net(skb->sk);
        struct xfrm_state *x;
        int err;
-       struct xfrm_user_expire *ue = NLMSG_DATA(nlh);
+       struct xfrm_user_expire *ue = nlmsg_data(nlh);
        struct xfrm_usersa_info *p = &ue->state;
 
-       x = xfrm_state_lookup(&p->id.daddr, p->id.spi, p->id.proto, p->family);
+       x = xfrm_state_lookup(net, DUMMY_MARK, &p->id.daddr, p->id.spi, p->id.proto, p->family);
 
        err = -ENOENT;
        if (x == NULL)
@@ -1678,9 +1783,11 @@ static int xfrm_add_sa_expire(struct sk_buff *skb, struct nlmsghdr *nlh,
        km_state_expired(x, ue->hard, current->pid);
 
        if (ue->hard) {
+               uid_t loginuid = NETLINK_CB(skb).loginuid;
+               uid_t sessionid = NETLINK_CB(skb).sessionid;
+               u32 sid = NETLINK_CB(skb).sid;
                __xfrm_state_delete(x);
-               xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid,
-                              AUDIT_MAC_IPSEC_DELSA, 1, NULL, x);
+               xfrm_audit_state_delete(x, 1, loginuid, sessionid, sid);
        }
        err = 0;
 out:
@@ -1690,39 +1797,35 @@ out:
 }
 
 static int xfrm_add_acquire(struct sk_buff *skb, struct nlmsghdr *nlh,
-               struct rtattr **xfrma)
+               struct nlattr **attrs)
 {
+       struct net *net = sock_net(skb->sk);
        struct xfrm_policy *xp;
        struct xfrm_user_tmpl *ut;
        int i;
-       struct rtattr *rt = xfrma[XFRMA_TMPL-1];
+       struct nlattr *rt = attrs[XFRMA_TMPL];
 
-       struct xfrm_user_acquire *ua = NLMSG_DATA(nlh);
-       struct xfrm_state *x = xfrm_state_alloc();
+       struct xfrm_user_acquire *ua = nlmsg_data(nlh);
+       struct xfrm_state *x = xfrm_state_alloc(net);
        int err = -ENOMEM;
 
        if (!x)
-               return err;
+               goto nomem;
 
        err = verify_newpolicy_info(&ua->policy);
-       if (err) {
-               printk("BAD policy passed\n");
-               kfree(x);
-               return err;
-       }
+       if (err)
+               goto bad_policy;
 
        /*   build an XP */
-       xp = xfrm_policy_construct(&ua->policy, (struct rtattr **) xfrma, &err);
-       if (!xp) {
-               kfree(x);
-               return err;
-       }
+       xp = xfrm_policy_construct(net, &ua->policy, attrs, &err);
+       if (!xp)
+               goto free_state;
 
        memcpy(&x->id, &ua->id, sizeof(ua->id));
        memcpy(&x->props.saddr, &ua->saddr, sizeof(ua->saddr));
        memcpy(&x->sel, &ua->sel, sizeof(ua->sel));
 
-       ut = RTA_DATA(rt);
+       ut = nla_data(rt);
        /* extract the templates and for each call km_key */
        for (i = 0; i < xp->xfrm_nr; i++, ut++) {
                struct xfrm_tmpl *t = &xp->xfrm_vec[i];
@@ -1741,32 +1844,36 @@ static int xfrm_add_acquire(struct sk_buff *skb, struct nlmsghdr *nlh,
        kfree(xp);
 
        return 0;
-}
-
-#ifdef CONFIG_XFRM_MIGRATE
-static int verify_user_migrate(struct rtattr **xfrma)
-{
-       struct rtattr *rt = xfrma[XFRMA_MIGRATE-1];
-       struct xfrm_user_migrate *um;
 
-       if (!rt)
-               return -EINVAL;
-
-       if ((rt->rta_len - sizeof(*rt)) < sizeof(*um))
-               return -EINVAL;
-
-       return 0;
+bad_policy:
+       printk("BAD policy passed\n");
+free_state:
+       kfree(x);
+nomem:
+       return err;
 }
 
+#ifdef CONFIG_XFRM_MIGRATE
 static int copy_from_user_migrate(struct xfrm_migrate *ma,
-                                 struct rtattr **xfrma, int *num)
+                                 struct xfrm_kmaddress *k,
+                                 struct nlattr **attrs, int *num)
 {
-       struct rtattr *rt = xfrma[XFRMA_MIGRATE-1];
+       struct nlattr *rt = attrs[XFRMA_MIGRATE];
        struct xfrm_user_migrate *um;
        int i, num_migrate;
 
-       um = RTA_DATA(rt);
-       num_migrate = (rt->rta_len - sizeof(*rt)) / sizeof(*um);
+       if (k != NULL) {
+               struct xfrm_user_kmaddress *uk;
+
+               uk = nla_data(attrs[XFRMA_KMADDRESS]);
+               memcpy(&k->local, &uk->local, sizeof(k->local));
+               memcpy(&k->remote, &uk->remote, sizeof(k->remote));
+               k->family = uk->family;
+               k->reserved = uk->reserved;
+       }
+
+       um = nla_data(rt);
+       num_migrate = nla_len(rt) / sizeof(*um);
 
        if (num_migrate <= 0 || num_migrate > XFRM_MAX_DEPTH)
                return -EINVAL;
@@ -1790,37 +1897,38 @@ static int copy_from_user_migrate(struct xfrm_migrate *ma,
 }
 
 static int xfrm_do_migrate(struct sk_buff *skb, struct nlmsghdr *nlh,
-                          struct rtattr **xfrma)
+                          struct nlattr **attrs)
 {
-       struct xfrm_userpolicy_id *pi = NLMSG_DATA(nlh);
+       struct xfrm_userpolicy_id *pi = nlmsg_data(nlh);
        struct xfrm_migrate m[XFRM_MAX_DEPTH];
+       struct xfrm_kmaddress km, *kmp;
        u8 type;
        int err;
        int n = 0;
 
-       err = verify_user_migrate((struct rtattr **)xfrma);
-       if (err)
-               return err;
+       if (attrs[XFRMA_MIGRATE] == NULL)
+               return -EINVAL;
+
+       kmp = attrs[XFRMA_KMADDRESS] ? &km : NULL;
 
-       err = copy_from_user_policy_type(&type, (struct rtattr **)xfrma);
+       err = copy_from_user_policy_type(&type, attrs);
        if (err)
                return err;
 
-       err = copy_from_user_migrate((struct xfrm_migrate *)m,
-                                    (struct rtattr **)xfrma, &n);
+       err = copy_from_user_migrate((struct xfrm_migrate *)m, kmp, attrs, &n);
        if (err)
                return err;
 
        if (!n)
                return 0;
 
-       xfrm_migrate(&pi->sel, pi->dir, type, m, n);
+       xfrm_migrate(&pi->sel, pi->dir, type, m, n, kmp);
 
        return 0;
 }
 #else
 static int xfrm_do_migrate(struct sk_buff *skb, struct nlmsghdr *nlh,
-                          struct rtattr **xfrma)
+                          struct nlattr **attrs)
 {
        return -ENOPROTOOPT;
 }
@@ -1842,32 +1950,52 @@ static int copy_to_user_migrate(struct xfrm_migrate *m, struct sk_buff *skb)
        memcpy(&um.new_daddr, &m->new_daddr, sizeof(um.new_daddr));
        memcpy(&um.new_saddr, &m->new_saddr, sizeof(um.new_saddr));
 
-       RTA_PUT(skb, XFRMA_MIGRATE, sizeof(um), &um);
-       return 0;
+       return nla_put(skb, XFRMA_MIGRATE, sizeof(um), &um);
+}
 
-rtattr_failure:
-       return -1;
+static int copy_to_user_kmaddress(struct xfrm_kmaddress *k, struct sk_buff *skb)
+{
+       struct xfrm_user_kmaddress uk;
+
+       memset(&uk, 0, sizeof(uk));
+       uk.family = k->family;
+       uk.reserved = k->reserved;
+       memcpy(&uk.local, &k->local, sizeof(uk.local));
+       memcpy(&uk.remote, &k->remote, sizeof(uk.remote));
+
+       return nla_put(skb, XFRMA_KMADDRESS, sizeof(uk), &uk);
+}
+
+static inline size_t xfrm_migrate_msgsize(int num_migrate, int with_kma)
+{
+       return NLMSG_ALIGN(sizeof(struct xfrm_userpolicy_id))
+             + (with_kma ? nla_total_size(sizeof(struct xfrm_kmaddress)) : 0)
+             + nla_total_size(sizeof(struct xfrm_user_migrate) * num_migrate)
+             + userpolicy_type_attrsize();
 }
 
 static int build_migrate(struct sk_buff *skb, struct xfrm_migrate *m,
-                        int num_migrate, struct xfrm_selector *sel,
-                        u8 dir, u8 type)
+                        int num_migrate, struct xfrm_kmaddress *k,
+                        struct xfrm_selector *sel, u8 dir, u8 type)
 {
        struct xfrm_migrate *mp;
        struct xfrm_userpolicy_id *pol_id;
        struct nlmsghdr *nlh;
-       unsigned char *b = skb_tail_pointer(skb);
        int i;
 
-       nlh = NLMSG_PUT(skb, 0, 0, XFRM_MSG_MIGRATE, sizeof(*pol_id));
-       pol_id = NLMSG_DATA(nlh);
-       nlh->nlmsg_flags = 0;
+       nlh = nlmsg_put(skb, 0, 0, XFRM_MSG_MIGRATE, sizeof(*pol_id), 0);
+       if (nlh == NULL)
+               return -EMSGSIZE;
 
+       pol_id = nlmsg_data(nlh);
        /* copy data from selector, dir, and type to the pol_id */
        memset(pol_id, 0, sizeof(*pol_id));
        memcpy(&pol_id->sel, sel, sizeof(pol_id->sel));
        pol_id->dir = dir;
 
+       if (k != NULL && (copy_to_user_kmaddress(k, skb) < 0))
+                       goto nlmsg_failure;
+
        if (copy_to_user_policy_type(type, skb) < 0)
                goto nlmsg_failure;
 
@@ -1876,45 +2004,39 @@ static int build_migrate(struct sk_buff *skb, struct xfrm_migrate *m,
                        goto nlmsg_failure;
        }
 
-       nlh->nlmsg_len = skb_tail_pointer(skb) - b;
-       return skb->len;
+       return nlmsg_end(skb, nlh);
 nlmsg_failure:
-       nlmsg_trim(skb, b);
-       return -1;
+       nlmsg_cancel(skb, nlh);
+       return -EMSGSIZE;
 }
 
 static int xfrm_send_migrate(struct xfrm_selector *sel, u8 dir, u8 type,
-                            struct xfrm_migrate *m, int num_migrate)
+                            struct xfrm_migrate *m, int num_migrate,
+                            struct xfrm_kmaddress *k)
 {
+       struct net *net = &init_net;
        struct sk_buff *skb;
-       size_t len;
 
-       len = RTA_SPACE(sizeof(struct xfrm_user_migrate) * num_migrate);
-       len += NLMSG_SPACE(sizeof(struct xfrm_userpolicy_id));
-#ifdef CONFIG_XFRM_SUB_POLICY
-       len += RTA_SPACE(sizeof(struct xfrm_userpolicy_type));
-#endif
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(xfrm_migrate_msgsize(num_migrate, !!k), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
        /* build migrate */
-       if (build_migrate(skb, m, num_migrate, sel, dir, type) < 0)
+       if (build_migrate(skb, m, num_migrate, k, sel, dir, type) < 0)
                BUG();
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_MIGRATE;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_MIGRATE,
-                                GFP_ATOMIC);
+       return nlmsg_multicast(net->xfrm.nlsk, skb, 0, XFRMNLGRP_MIGRATE, GFP_ATOMIC);
 }
 #else
 static int xfrm_send_migrate(struct xfrm_selector *sel, u8 dir, u8 type,
-                            struct xfrm_migrate *m, int num_migrate)
+                            struct xfrm_migrate *m, int num_migrate,
+                            struct xfrm_kmaddress *k)
 {
        return -ENOPROTOOPT;
 }
 #endif
 
-#define XMSGSIZE(type) NLMSG_LENGTH(sizeof(struct type))
+#define XMSGSIZE(type) sizeof(struct type)
 
 static const int xfrm_msg_min[XFRM_NR_MSGTYPES] = {
        [XFRM_MSG_NEWSA       - XFRM_MSG_BASE] = XMSGSIZE(xfrm_usersa_info),
@@ -1930,29 +2052,55 @@ static const int xfrm_msg_min[XFRM_NR_MSGTYPES] = {
        [XFRM_MSG_UPDSA       - XFRM_MSG_BASE] = XMSGSIZE(xfrm_usersa_info),
        [XFRM_MSG_POLEXPIRE   - XFRM_MSG_BASE] = XMSGSIZE(xfrm_user_polexpire),
        [XFRM_MSG_FLUSHSA     - XFRM_MSG_BASE] = XMSGSIZE(xfrm_usersa_flush),
-       [XFRM_MSG_FLUSHPOLICY - XFRM_MSG_BASE] = NLMSG_LENGTH(0),
+       [XFRM_MSG_FLUSHPOLICY - XFRM_MSG_BASE] = 0,
        [XFRM_MSG_NEWAE       - XFRM_MSG_BASE] = XMSGSIZE(xfrm_aevent_id),
        [XFRM_MSG_GETAE       - XFRM_MSG_BASE] = XMSGSIZE(xfrm_aevent_id),
        [XFRM_MSG_REPORT      - XFRM_MSG_BASE] = XMSGSIZE(xfrm_user_report),
        [XFRM_MSG_MIGRATE     - XFRM_MSG_BASE] = XMSGSIZE(xfrm_userpolicy_id),
-       [XFRM_MSG_GETSADINFO  - XFRM_MSG_BASE] = NLMSG_LENGTH(sizeof(u32)),
-       [XFRM_MSG_GETSPDINFO  - XFRM_MSG_BASE] = NLMSG_LENGTH(sizeof(u32)),
+       [XFRM_MSG_GETSADINFO  - XFRM_MSG_BASE] = sizeof(u32),
+       [XFRM_MSG_GETSPDINFO  - XFRM_MSG_BASE] = sizeof(u32),
 };
 
 #undef XMSGSIZE
 
+static const struct nla_policy xfrma_policy[XFRMA_MAX+1] = {
+       [XFRMA_SA]              = { .len = sizeof(struct xfrm_usersa_info)},
+       [XFRMA_POLICY]          = { .len = sizeof(struct xfrm_userpolicy_info)},
+       [XFRMA_LASTUSED]        = { .type = NLA_U64},
+       [XFRMA_ALG_AUTH_TRUNC]  = { .len = sizeof(struct xfrm_algo_auth)},
+       [XFRMA_ALG_AEAD]        = { .len = sizeof(struct xfrm_algo_aead) },
+       [XFRMA_ALG_AUTH]        = { .len = sizeof(struct xfrm_algo) },
+       [XFRMA_ALG_CRYPT]       = { .len = sizeof(struct xfrm_algo) },
+       [XFRMA_ALG_COMP]        = { .len = sizeof(struct xfrm_algo) },
+       [XFRMA_ENCAP]           = { .len = sizeof(struct xfrm_encap_tmpl) },
+       [XFRMA_TMPL]            = { .len = sizeof(struct xfrm_user_tmpl) },
+       [XFRMA_SEC_CTX]         = { .len = sizeof(struct xfrm_sec_ctx) },
+       [XFRMA_LTIME_VAL]       = { .len = sizeof(struct xfrm_lifetime_cur) },
+       [XFRMA_REPLAY_VAL]      = { .len = sizeof(struct xfrm_replay_state) },
+       [XFRMA_REPLAY_THRESH]   = { .type = NLA_U32 },
+       [XFRMA_ETIMER_THRESH]   = { .type = NLA_U32 },
+       [XFRMA_SRCADDR]         = { .len = sizeof(xfrm_address_t) },
+       [XFRMA_COADDR]          = { .len = sizeof(xfrm_address_t) },
+       [XFRMA_POLICY_TYPE]     = { .len = sizeof(struct xfrm_userpolicy_type)},
+       [XFRMA_MIGRATE]         = { .len = sizeof(struct xfrm_user_migrate) },
+       [XFRMA_KMADDRESS]       = { .len = sizeof(struct xfrm_user_kmaddress) },
+};
+
 static struct xfrm_link {
-       int (*doit)(struct sk_buff *, struct nlmsghdr *, struct rtattr **);
+       int (*doit)(struct sk_buff *, struct nlmsghdr *, struct nlattr **);
        int (*dump)(struct sk_buff *, struct netlink_callback *);
+       int (*done)(struct netlink_callback *);
 } xfrm_dispatch[XFRM_NR_MSGTYPES] = {
        [XFRM_MSG_NEWSA       - XFRM_MSG_BASE] = { .doit = xfrm_add_sa        },
        [XFRM_MSG_DELSA       - XFRM_MSG_BASE] = { .doit = xfrm_del_sa        },
        [XFRM_MSG_GETSA       - XFRM_MSG_BASE] = { .doit = xfrm_get_sa,
-                                                  .dump = xfrm_dump_sa       },
+                                                  .dump = xfrm_dump_sa,
+                                                  .done = xfrm_dump_sa_done  },
        [XFRM_MSG_NEWPOLICY   - XFRM_MSG_BASE] = { .doit = xfrm_add_policy    },
        [XFRM_MSG_DELPOLICY   - XFRM_MSG_BASE] = { .doit = xfrm_get_policy    },
        [XFRM_MSG_GETPOLICY   - XFRM_MSG_BASE] = { .doit = xfrm_get_policy,
-                                                  .dump = xfrm_dump_policy   },
+                                                  .dump = xfrm_dump_policy,
+                                                  .done = xfrm_dump_policy_done },
        [XFRM_MSG_ALLOCSPI    - XFRM_MSG_BASE] = { .doit = xfrm_alloc_userspi },
        [XFRM_MSG_ACQUIRE     - XFRM_MSG_BASE] = { .doit = xfrm_add_acquire   },
        [XFRM_MSG_EXPIRE      - XFRM_MSG_BASE] = { .doit = xfrm_add_sa_expire },
@@ -1970,9 +2118,10 @@ static struct xfrm_link {
 
 static int xfrm_user_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
 {
-       struct rtattr *xfrma[XFRMA_MAX];
+       struct net *net = sock_net(skb->sk);
+       struct nlattr *attrs[XFRMA_MAX+1];
        struct xfrm_link *link;
-       int type, min_len;
+       int type, err;
 
        type = nlh->nlmsg_type;
        if (type > XFRM_MSG_MAX)
@@ -1991,205 +2140,184 @@ static int xfrm_user_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
                if (link->dump == NULL)
                        return -EINVAL;
 
-               return netlink_dump_start(xfrm_nl, skb, nlh, link->dump, NULL);
+               return netlink_dump_start(net->xfrm.nlsk, skb, nlh, link->dump, link->done);
        }
 
-       memset(xfrma, 0, sizeof(xfrma));
-
-       if (nlh->nlmsg_len < (min_len = xfrm_msg_min[type]))
-               return -EINVAL;
-
-       if (nlh->nlmsg_len > min_len) {
-               int attrlen = nlh->nlmsg_len - NLMSG_ALIGN(min_len);
-               struct rtattr *attr = (void *) nlh + NLMSG_ALIGN(min_len);
-
-               while (RTA_OK(attr, attrlen)) {
-                       unsigned short flavor = attr->rta_type;
-                       if (flavor) {
-                               if (flavor > XFRMA_MAX)
-                                       return -EINVAL;
-                               xfrma[flavor - 1] = attr;
-                       }
-                       attr = RTA_NEXT(attr, attrlen);
-               }
-       }
+       err = nlmsg_parse(nlh, xfrm_msg_min[type], attrs, XFRMA_MAX,
+                         xfrma_policy);
+       if (err < 0)
+               return err;
 
        if (link->doit == NULL)
                return -EINVAL;
 
-       return link->doit(skb, nlh, xfrma);
+       return link->doit(skb, nlh, attrs);
 }
 
-static void xfrm_netlink_rcv(struct sock *sk, int len)
+static void xfrm_netlink_rcv(struct sk_buff *skb)
 {
-       unsigned int qlen = 0;
-
-       do {
-               mutex_lock(&xfrm_cfg_mutex);
-               netlink_run_queue(sk, &qlen, &xfrm_user_rcv_msg);
-               mutex_unlock(&xfrm_cfg_mutex);
+       mutex_lock(&xfrm_cfg_mutex);
+       netlink_rcv_skb(skb, &xfrm_user_rcv_msg);
+       mutex_unlock(&xfrm_cfg_mutex);
+}
 
-       } while (qlen);
+static inline size_t xfrm_expire_msgsize(void)
+{
+       return NLMSG_ALIGN(sizeof(struct xfrm_user_expire));
 }
 
 static int build_expire(struct sk_buff *skb, struct xfrm_state *x, struct km_event *c)
 {
        struct xfrm_user_expire *ue;
        struct nlmsghdr *nlh;
-       unsigned char *b = skb_tail_pointer(skb);
 
-       nlh = NLMSG_PUT(skb, c->pid, 0, XFRM_MSG_EXPIRE,
-                       sizeof(*ue));
-       ue = NLMSG_DATA(nlh);
-       nlh->nlmsg_flags = 0;
+       nlh = nlmsg_put(skb, c->pid, 0, XFRM_MSG_EXPIRE, sizeof(*ue), 0);
+       if (nlh == NULL)
+               return -EMSGSIZE;
 
+       ue = nlmsg_data(nlh);
        copy_to_user_state(x, &ue->state);
        ue->hard = (c->data.hard != 0) ? 1 : 0;
 
-       nlh->nlmsg_len = skb_tail_pointer(skb) - b;
-       return skb->len;
-
-nlmsg_failure:
-       nlmsg_trim(skb, b);
-       return -1;
+       return nlmsg_end(skb, nlh);
 }
 
 static int xfrm_exp_state_notify(struct xfrm_state *x, struct km_event *c)
 {
+       struct net *net = xs_net(x);
        struct sk_buff *skb;
-       int len = NLMSG_LENGTH(sizeof(struct xfrm_user_expire));
 
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(xfrm_expire_msgsize(), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
        if (build_expire(skb, x, c) < 0)
                BUG();
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_EXPIRE;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_EXPIRE, GFP_ATOMIC);
+       return nlmsg_multicast(net->xfrm.nlsk, skb, 0, XFRMNLGRP_EXPIRE, GFP_ATOMIC);
 }
 
 static int xfrm_aevent_state_notify(struct xfrm_state *x, struct km_event *c)
 {
+       struct net *net = xs_net(x);
        struct sk_buff *skb;
-       int len = NLMSG_LENGTH(sizeof(struct xfrm_aevent_id));
 
-       len += RTA_SPACE(sizeof(struct xfrm_replay_state));
-       len += RTA_SPACE(sizeof(struct xfrm_lifetime_cur));
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(xfrm_aevent_msgsize(), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
        if (build_aevent(skb, x, c) < 0)
                BUG();
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_AEVENTS;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_AEVENTS, GFP_ATOMIC);
+       return nlmsg_multicast(net->xfrm.nlsk, skb, 0, XFRMNLGRP_AEVENTS, GFP_ATOMIC);
 }
 
 static int xfrm_notify_sa_flush(struct km_event *c)
 {
+       struct net *net = c->net;
        struct xfrm_usersa_flush *p;
        struct nlmsghdr *nlh;
        struct sk_buff *skb;
-       sk_buff_data_t b;
-       int len = NLMSG_LENGTH(sizeof(struct xfrm_usersa_flush));
+       int len = NLMSG_ALIGN(sizeof(struct xfrm_usersa_flush));
 
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(len, GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
-       b = skb->tail;
 
-       nlh = NLMSG_PUT(skb, c->pid, c->seq,
-                       XFRM_MSG_FLUSHSA, sizeof(*p));
-       nlh->nlmsg_flags = 0;
+       nlh = nlmsg_put(skb, c->pid, c->seq, XFRM_MSG_FLUSHSA, sizeof(*p), 0);
+       if (nlh == NULL) {
+               kfree_skb(skb);
+               return -EMSGSIZE;
+       }
 
-       p = NLMSG_DATA(nlh);
+       p = nlmsg_data(nlh);
        p->proto = c->data.proto;
 
-       nlh->nlmsg_len = skb->tail - b;
+       nlmsg_end(skb, nlh);
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_SA;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_SA, GFP_ATOMIC);
-
-nlmsg_failure:
-       kfree_skb(skb);
-       return -1;
+       return nlmsg_multicast(net->xfrm.nlsk, skb, 0, XFRMNLGRP_SA, GFP_ATOMIC);
 }
 
-static inline int xfrm_sa_len(struct xfrm_state *x)
+static inline size_t xfrm_sa_len(struct xfrm_state *x)
 {
-       int l = 0;
-       if (x->aalg)
-               l += RTA_SPACE(sizeof(*x->aalg) + (x->aalg->alg_key_len+7)/8);
+       size_t l = 0;
+       if (x->aead)
+               l += nla_total_size(aead_len(x->aead));
+       if (x->aalg) {
+               l += nla_total_size(sizeof(struct xfrm_algo) +
+                                   (x->aalg->alg_key_len + 7) / 8);
+               l += nla_total_size(xfrm_alg_auth_len(x->aalg));
+       }
        if (x->ealg)
-               l += RTA_SPACE(sizeof(*x->ealg) + (x->ealg->alg_key_len+7)/8);
+               l += nla_total_size(xfrm_alg_len(x->ealg));
        if (x->calg)
-               l += RTA_SPACE(sizeof(*x->calg));
+               l += nla_total_size(sizeof(*x->calg));
        if (x->encap)
-               l += RTA_SPACE(sizeof(*x->encap));
+               l += nla_total_size(sizeof(*x->encap));
+       if (x->security)
+               l += nla_total_size(sizeof(struct xfrm_user_sec_ctx) +
+                                   x->security->ctx_len);
+       if (x->coaddr)
+               l += nla_total_size(sizeof(*x->coaddr));
+
+       /* Must count x->lastused as it may become non-zero behind our back. */
+       l += nla_total_size(sizeof(u64));
 
        return l;
 }
 
 static int xfrm_notify_sa(struct xfrm_state *x, struct km_event *c)
 {
+       struct net *net = xs_net(x);
        struct xfrm_usersa_info *p;
        struct xfrm_usersa_id *id;
        struct nlmsghdr *nlh;
        struct sk_buff *skb;
-       sk_buff_data_t b;
        int len = xfrm_sa_len(x);
        int headlen;
 
        headlen = sizeof(*p);
        if (c->event == XFRM_MSG_DELSA) {
-               len += RTA_SPACE(headlen);
+               len += nla_total_size(headlen);
                headlen = sizeof(*id);
        }
-       len += NLMSG_SPACE(headlen);
+       len += NLMSG_ALIGN(headlen);
 
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(len, GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
-       b = skb->tail;
 
-       nlh = NLMSG_PUT(skb, c->pid, c->seq, c->event, headlen);
-       nlh->nlmsg_flags = 0;
+       nlh = nlmsg_put(skb, c->pid, c->seq, c->event, headlen, 0);
+       if (nlh == NULL)
+               goto nla_put_failure;
 
-       p = NLMSG_DATA(nlh);
+       p = nlmsg_data(nlh);
        if (c->event == XFRM_MSG_DELSA) {
-               id = NLMSG_DATA(nlh);
+               struct nlattr *attr;
+
+               id = nlmsg_data(nlh);
                memcpy(&id->daddr, &x->id.daddr, sizeof(id->daddr));
                id->spi = x->id.spi;
                id->family = x->props.family;
                id->proto = x->id.proto;
 
-               p = RTA_DATA(__RTA_PUT(skb, XFRMA_SA, sizeof(*p)));
-       }
-
-       copy_to_user_state(x, p);
+               attr = nla_reserve(skb, XFRMA_SA, sizeof(*p));
+               if (attr == NULL)
+                       goto nla_put_failure;
 
-       if (x->aalg)
-               RTA_PUT(skb, XFRMA_ALG_AUTH,
-                       sizeof(*(x->aalg))+(x->aalg->alg_key_len+7)/8, x->aalg);
-       if (x->ealg)
-               RTA_PUT(skb, XFRMA_ALG_CRYPT,
-                       sizeof(*(x->ealg))+(x->ealg->alg_key_len+7)/8, x->ealg);
-       if (x->calg)
-               RTA_PUT(skb, XFRMA_ALG_COMP, sizeof(*(x->calg)), x->calg);
+               p = nla_data(attr);
+       }
 
-       if (x->encap)
-               RTA_PUT(skb, XFRMA_ENCAP, sizeof(*x->encap), x->encap);
+       if (copy_to_user_state_extra(x, p, skb))
+               goto nla_put_failure;
 
-       nlh->nlmsg_len = skb->tail - b;
+       nlmsg_end(skb, nlh);
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_SA;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_SA, GFP_ATOMIC);
+       return nlmsg_multicast(net->xfrm.nlsk, skb, 0, XFRMNLGRP_SA, GFP_ATOMIC);
 
-nlmsg_failure:
-rtattr_failure:
+nla_put_failure:
+       /* Somebody screwed up with xfrm_sa_len! */
+       WARN_ON(1);
        kfree_skb(skb);
        return -1;
 }
@@ -2217,20 +2345,28 @@ static int xfrm_send_state_notify(struct xfrm_state *x, struct km_event *c)
 
 }
 
+static inline size_t xfrm_acquire_msgsize(struct xfrm_state *x,
+                                         struct xfrm_policy *xp)
+{
+       return NLMSG_ALIGN(sizeof(struct xfrm_user_acquire))
+              + nla_total_size(sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr)
+              + nla_total_size(xfrm_user_sec_ctx_size(x->security))
+              + userpolicy_type_attrsize();
+}
+
 static int build_acquire(struct sk_buff *skb, struct xfrm_state *x,
                         struct xfrm_tmpl *xt, struct xfrm_policy *xp,
                         int dir)
 {
        struct xfrm_user_acquire *ua;
        struct nlmsghdr *nlh;
-       unsigned char *b = skb_tail_pointer(skb);
        __u32 seq = xfrm_get_acqseq();
 
-       nlh = NLMSG_PUT(skb, 0, 0, XFRM_MSG_ACQUIRE,
-                       sizeof(*ua));
-       ua = NLMSG_DATA(nlh);
-       nlh->nlmsg_flags = 0;
+       nlh = nlmsg_put(skb, 0, 0, XFRM_MSG_ACQUIRE, sizeof(*ua), 0);
+       if (nlh == NULL)
+               return -EMSGSIZE;
 
+       ua = nlmsg_data(nlh);
        memcpy(&ua->id, &x->id, sizeof(ua->id));
        memcpy(&ua->saddr, &x->props.saddr, sizeof(ua->saddr));
        memcpy(&ua->sel, &x->sel, sizeof(ua->sel));
@@ -2247,35 +2383,27 @@ static int build_acquire(struct sk_buff *skb, struct xfrm_state *x,
        if (copy_to_user_policy_type(xp->type, skb) < 0)
                goto nlmsg_failure;
 
-       nlh->nlmsg_len = skb_tail_pointer(skb) - b;
-       return skb->len;
+       return nlmsg_end(skb, nlh);
 
 nlmsg_failure:
-       nlmsg_trim(skb, b);
-       return -1;
+       nlmsg_cancel(skb, nlh);
+       return -EMSGSIZE;
 }
 
 static int xfrm_send_acquire(struct xfrm_state *x, struct xfrm_tmpl *xt,
                             struct xfrm_policy *xp, int dir)
 {
+       struct net *net = xs_net(x);
        struct sk_buff *skb;
-       size_t len;
 
-       len = RTA_SPACE(sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr);
-       len += NLMSG_SPACE(sizeof(struct xfrm_user_acquire));
-       len += RTA_SPACE(xfrm_user_sec_ctx_size(x->security));
-#ifdef CONFIG_XFRM_SUB_POLICY
-       len += RTA_SPACE(sizeof(struct xfrm_userpolicy_type));
-#endif
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(xfrm_acquire_msgsize(x, xp), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
        if (build_acquire(skb, x, xt, xp, dir) < 0)
                BUG();
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_ACQUIRE;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_ACQUIRE, GFP_ATOMIC);
+       return nlmsg_multicast(net->xfrm.nlsk, skb, 0, XFRMNLGRP_ACQUIRE, GFP_ATOMIC);
 }
 
 /* User gives us xfrm_user_policy_info followed by an array of 0
@@ -2284,6 +2412,7 @@ static int xfrm_send_acquire(struct xfrm_state *x, struct xfrm_tmpl *xt,
 static struct xfrm_policy *xfrm_compile_policy(struct sock *sk, int opt,
                                               u8 *data, int len, int *dir)
 {
+       struct net *net = sock_net(sk);
        struct xfrm_userpolicy_info *p = (struct xfrm_userpolicy_info *)data;
        struct xfrm_user_tmpl *ut = (struct xfrm_user_tmpl *) (p + 1);
        struct xfrm_policy *xp;
@@ -2322,7 +2451,7 @@ static struct xfrm_policy *xfrm_compile_policy(struct sock *sk, int opt,
        if (p->dir > XFRM_POLICY_OUT)
                return NULL;
 
-       xp = xfrm_policy_alloc(GFP_KERNEL);
+       xp = xfrm_policy_alloc(net, GFP_KERNEL);
        if (xp == NULL) {
                *dir = -ENOBUFS;
                return NULL;
@@ -2337,18 +2466,26 @@ static struct xfrm_policy *xfrm_compile_policy(struct sock *sk, int opt,
        return xp;
 }
 
+static inline size_t xfrm_polexpire_msgsize(struct xfrm_policy *xp)
+{
+       return NLMSG_ALIGN(sizeof(struct xfrm_user_polexpire))
+              + nla_total_size(sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr)
+              + nla_total_size(xfrm_user_sec_ctx_size(xp->security))
+              + userpolicy_type_attrsize();
+}
+
 static int build_polexpire(struct sk_buff *skb, struct xfrm_policy *xp,
                           int dir, struct km_event *c)
 {
        struct xfrm_user_polexpire *upe;
        struct nlmsghdr *nlh;
        int hard = c->data.hard;
-       unsigned char *b = skb_tail_pointer(skb);
 
-       nlh = NLMSG_PUT(skb, c->pid, 0, XFRM_MSG_POLEXPIRE, sizeof(*upe));
-       upe = NLMSG_DATA(nlh);
-       nlh->nlmsg_flags = 0;
+       nlh = nlmsg_put(skb, c->pid, 0, XFRM_MSG_POLEXPIRE, sizeof(*upe), 0);
+       if (nlh == NULL)
+               return -EMSGSIZE;
 
+       upe = nlmsg_data(nlh);
        copy_to_user_policy(xp, &upe->pol, dir);
        if (copy_to_user_tmpl(xp, skb) < 0)
                goto nlmsg_failure;
@@ -2358,66 +2495,59 @@ static int build_polexpire(struct sk_buff *skb, struct xfrm_policy *xp,
                goto nlmsg_failure;
        upe->hard = !!hard;
 
-       nlh->nlmsg_len = skb_tail_pointer(skb) - b;
-       return skb->len;
+       return nlmsg_end(skb, nlh);
 
 nlmsg_failure:
-       nlmsg_trim(skb, b);
-       return -1;
+       nlmsg_cancel(skb, nlh);
+       return -EMSGSIZE;
 }
 
 static int xfrm_exp_policy_notify(struct xfrm_policy *xp, int dir, struct km_event *c)
 {
+       struct net *net = xp_net(xp);
        struct sk_buff *skb;
-       size_t len;
 
-       len = RTA_SPACE(sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr);
-       len += NLMSG_SPACE(sizeof(struct xfrm_user_polexpire));
-       len += RTA_SPACE(xfrm_user_sec_ctx_size(xp->security));
-#ifdef CONFIG_XFRM_SUB_POLICY
-       len += RTA_SPACE(sizeof(struct xfrm_userpolicy_type));
-#endif
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(xfrm_polexpire_msgsize(xp), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
        if (build_polexpire(skb, xp, dir, c) < 0)
                BUG();
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_EXPIRE;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_EXPIRE, GFP_ATOMIC);
+       return nlmsg_multicast(net->xfrm.nlsk, skb, 0, XFRMNLGRP_EXPIRE, GFP_ATOMIC);
 }
 
 static int xfrm_notify_policy(struct xfrm_policy *xp, int dir, struct km_event *c)
 {
+       struct net *net = xp_net(xp);
        struct xfrm_userpolicy_info *p;
        struct xfrm_userpolicy_id *id;
        struct nlmsghdr *nlh;
        struct sk_buff *skb;
-       sk_buff_data_t b;
-       int len = RTA_SPACE(sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr);
+       int len = nla_total_size(sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr);
        int headlen;
 
        headlen = sizeof(*p);
        if (c->event == XFRM_MSG_DELPOLICY) {
-               len += RTA_SPACE(headlen);
+               len += nla_total_size(headlen);
                headlen = sizeof(*id);
        }
-#ifdef CONFIG_XFRM_SUB_POLICY
-       len += RTA_SPACE(sizeof(struct xfrm_userpolicy_type));
-#endif
-       len += NLMSG_SPACE(headlen);
+       len += userpolicy_type_attrsize();
+       len += NLMSG_ALIGN(headlen);
 
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(len, GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
-       b = skb->tail;
 
-       nlh = NLMSG_PUT(skb, c->pid, c->seq, c->event, headlen);
+       nlh = nlmsg_put(skb, c->pid, c->seq, c->event, headlen, 0);
+       if (nlh == NULL)
+               goto nlmsg_failure;
 
-       p = NLMSG_DATA(nlh);
+       p = nlmsg_data(nlh);
        if (c->event == XFRM_MSG_DELPOLICY) {
-               id = NLMSG_DATA(nlh);
+               struct nlattr *attr;
+
+               id = nlmsg_data(nlh);
                memset(id, 0, sizeof(*id));
                id->dir = dir;
                if (c->data.byid)
@@ -2425,10 +2555,12 @@ static int xfrm_notify_policy(struct xfrm_policy *xp, int dir, struct km_event *
                else
                        memcpy(&id->sel, &xp->selector, sizeof(id->sel));
 
-               p = RTA_DATA(__RTA_PUT(skb, XFRMA_POLICY, sizeof(*p)));
-       }
+               attr = nla_reserve(skb, XFRMA_POLICY, sizeof(*p));
+               if (attr == NULL)
+                       goto nlmsg_failure;
 
-       nlh->nlmsg_flags = 0;
+               p = nla_data(attr);
+       }
 
        copy_to_user_policy(xp, p, dir);
        if (copy_to_user_tmpl(xp, skb) < 0)
@@ -2436,43 +2568,34 @@ static int xfrm_notify_policy(struct xfrm_policy *xp, int dir, struct km_event *
        if (copy_to_user_policy_type(xp->type, skb) < 0)
                goto nlmsg_failure;
 
-       nlh->nlmsg_len = skb->tail - b;
+       nlmsg_end(skb, nlh);
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_POLICY;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_POLICY, GFP_ATOMIC);
+       return nlmsg_multicast(net->xfrm.nlsk, skb, 0, XFRMNLGRP_POLICY, GFP_ATOMIC);
 
 nlmsg_failure:
-rtattr_failure:
        kfree_skb(skb);
        return -1;
 }
 
 static int xfrm_notify_policy_flush(struct km_event *c)
 {
+       struct net *net = c->net;
        struct nlmsghdr *nlh;
        struct sk_buff *skb;
-       sk_buff_data_t b;
-       int len = 0;
-#ifdef CONFIG_XFRM_SUB_POLICY
-       len += RTA_SPACE(sizeof(struct xfrm_userpolicy_type));
-#endif
-       len += NLMSG_LENGTH(0);
 
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(userpolicy_type_attrsize(), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
-       b = skb->tail;
 
-
-       nlh = NLMSG_PUT(skb, c->pid, c->seq, XFRM_MSG_FLUSHPOLICY, 0);
-       nlh->nlmsg_flags = 0;
+       nlh = nlmsg_put(skb, c->pid, c->seq, XFRM_MSG_FLUSHPOLICY, 0, 0);
+       if (nlh == NULL)
+               goto nlmsg_failure;
        if (copy_to_user_policy_type(c->data.type, skb) < 0)
                goto nlmsg_failure;
 
-       nlh->nlmsg_len = skb->tail - b;
+       nlmsg_end(skb, nlh);
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_POLICY;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_POLICY, GFP_ATOMIC);
+       return nlmsg_multicast(net->xfrm.nlsk, skb, 0, XFRMNLGRP_POLICY, GFP_ATOMIC);
 
 nlmsg_failure:
        kfree_skb(skb);
@@ -2499,48 +2622,100 @@ static int xfrm_send_policy_notify(struct xfrm_policy *xp, int dir, struct km_ev
 
 }
 
+static inline size_t xfrm_report_msgsize(void)
+{
+       return NLMSG_ALIGN(sizeof(struct xfrm_user_report));
+}
+
 static int build_report(struct sk_buff *skb, u8 proto,
                        struct xfrm_selector *sel, xfrm_address_t *addr)
 {
        struct xfrm_user_report *ur;
        struct nlmsghdr *nlh;
-       unsigned char *b = skb_tail_pointer(skb);
 
-       nlh = NLMSG_PUT(skb, 0, 0, XFRM_MSG_REPORT, sizeof(*ur));
-       ur = NLMSG_DATA(nlh);
-       nlh->nlmsg_flags = 0;
+       nlh = nlmsg_put(skb, 0, 0, XFRM_MSG_REPORT, sizeof(*ur), 0);
+       if (nlh == NULL)
+               return -EMSGSIZE;
 
+       ur = nlmsg_data(nlh);
        ur->proto = proto;
        memcpy(&ur->sel, sel, sizeof(ur->sel));
 
        if (addr)
-               RTA_PUT(skb, XFRMA_COADDR, sizeof(*addr), addr);
+               NLA_PUT(skb, XFRMA_COADDR, sizeof(*addr), addr);
 
-       nlh->nlmsg_len = skb_tail_pointer(skb) - b;
-       return skb->len;
+       return nlmsg_end(skb, nlh);
 
-nlmsg_failure:
-rtattr_failure:
-       nlmsg_trim(skb, b);
-       return -1;
+nla_put_failure:
+       nlmsg_cancel(skb, nlh);
+       return -EMSGSIZE;
 }
 
-static int xfrm_send_report(u8 proto, struct xfrm_selector *sel,
-                           xfrm_address_t *addr)
+static int xfrm_send_report(struct net *net, u8 proto,
+                           struct xfrm_selector *sel, xfrm_address_t *addr)
 {
        struct sk_buff *skb;
-       size_t len;
 
-       len = NLMSG_ALIGN(NLMSG_LENGTH(sizeof(struct xfrm_user_report)));
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(xfrm_report_msgsize(), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
        if (build_report(skb, proto, sel, addr) < 0)
                BUG();
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_REPORT;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_REPORT, GFP_ATOMIC);
+       return nlmsg_multicast(net->xfrm.nlsk, skb, 0, XFRMNLGRP_REPORT, GFP_ATOMIC);
+}
+
+static inline size_t xfrm_mapping_msgsize(void)
+{
+       return NLMSG_ALIGN(sizeof(struct xfrm_user_mapping));
+}
+
+static int build_mapping(struct sk_buff *skb, struct xfrm_state *x,
+                        xfrm_address_t *new_saddr, __be16 new_sport)
+{
+       struct xfrm_user_mapping *um;
+       struct nlmsghdr *nlh;
+
+       nlh = nlmsg_put(skb, 0, 0, XFRM_MSG_MAPPING, sizeof(*um), 0);
+       if (nlh == NULL)
+               return -EMSGSIZE;
+
+       um = nlmsg_data(nlh);
+
+       memcpy(&um->id.daddr, &x->id.daddr, sizeof(um->id.daddr));
+       um->id.spi = x->id.spi;
+       um->id.family = x->props.family;
+       um->id.proto = x->id.proto;
+       memcpy(&um->new_saddr, new_saddr, sizeof(um->new_saddr));
+       memcpy(&um->old_saddr, &x->props.saddr, sizeof(um->old_saddr));
+       um->new_sport = new_sport;
+       um->old_sport = x->encap->encap_sport;
+       um->reqid = x->props.reqid;
+
+       return nlmsg_end(skb, nlh);
+}
+
+static int xfrm_send_mapping(struct xfrm_state *x, xfrm_address_t *ipaddr,
+                            __be16 sport)
+{
+       struct net *net = xs_net(x);
+       struct sk_buff *skb;
+
+       if (x->id.proto != IPPROTO_ESP)
+               return -EINVAL;
+
+       if (!x->encap)
+               return -EINVAL;
+
+       skb = nlmsg_new(xfrm_mapping_msgsize(), GFP_ATOMIC);
+       if (skb == NULL)
+               return -ENOMEM;
+
+       if (build_mapping(skb, x, ipaddr, sport) < 0)
+               BUG();
+
+       return nlmsg_multicast(net->xfrm.nlsk, skb, 0, XFRMNLGRP_MAPPING, GFP_ATOMIC);
 }
 
 static struct xfrm_mgr netlink_mgr = {
@@ -2551,33 +2726,56 @@ static struct xfrm_mgr netlink_mgr = {
        .notify_policy  = xfrm_send_policy_notify,
        .report         = xfrm_send_report,
        .migrate        = xfrm_send_migrate,
+       .new_mapping    = xfrm_send_mapping,
 };
 
-static int __init xfrm_user_init(void)
+static int __net_init xfrm_user_net_init(struct net *net)
 {
        struct sock *nlsk;
 
-       printk(KERN_INFO "Initializing XFRM netlink socket\n");
-
-       nlsk = netlink_kernel_create(NETLINK_XFRM, XFRMNLGRP_MAX,
+       nlsk = netlink_kernel_create(net, NETLINK_XFRM, XFRMNLGRP_MAX,
                                     xfrm_netlink_rcv, NULL, THIS_MODULE);
        if (nlsk == NULL)
                return -ENOMEM;
-       rcu_assign_pointer(xfrm_nl, nlsk);
+       net->xfrm.nlsk_stash = nlsk; /* Don't set to NULL */
+       rcu_assign_pointer(net->xfrm.nlsk, nlsk);
+       return 0;
+}
 
-       xfrm_register_km(&netlink_mgr);
+static void __net_exit xfrm_user_net_exit(struct list_head *net_exit_list)
+{
+       struct net *net;
+       list_for_each_entry(net, net_exit_list, exit_list)
+               rcu_assign_pointer(net->xfrm.nlsk, NULL);
+       synchronize_net();
+       list_for_each_entry(net, net_exit_list, exit_list)
+               netlink_kernel_release(net->xfrm.nlsk_stash);
+}
 
-       return 0;
+static struct pernet_operations xfrm_user_net_ops = {
+       .init       = xfrm_user_net_init,
+       .exit_batch = xfrm_user_net_exit,
+};
+
+static int __init xfrm_user_init(void)
+{
+       int rv;
+
+       printk(KERN_INFO "Initializing XFRM netlink socket\n");
+
+       rv = register_pernet_subsys(&xfrm_user_net_ops);
+       if (rv < 0)
+               return rv;
+       rv = xfrm_register_km(&netlink_mgr);
+       if (rv < 0)
+               unregister_pernet_subsys(&xfrm_user_net_ops);
+       return rv;
 }
 
 static void __exit xfrm_user_exit(void)
 {
-       struct sock *nlsk = xfrm_nl;
-
        xfrm_unregister_km(&netlink_mgr);
-       rcu_assign_pointer(xfrm_nl, NULL);
-       synchronize_rcu();
-       sock_release(nlsk->sk_socket);
+       unregister_pernet_subsys(&xfrm_user_net_ops);
 }
 
 module_init(xfrm_user_init);