]> nv-tegra.nvidia Code Review - linux-2.6.git/blobdiff - kernel/time/tick-broadcast.c
sched: Enable might_sleep before initializing drivers.
[linux-2.6.git] / kernel / time / tick-broadcast.c
index 2f5a38294bf9ffc8639a5e623760c5242e96629b..c7218d13273861dd65f5a484852001f88d8ce819 100644 (file)
@@ -18,7 +18,6 @@
 #include <linux/percpu.h>
 #include <linux/profile.h>
 #include <linux/sched.h>
-#include <linux/tick.h>
 
 #include "tick-internal.h"
 
  * timer stops in C3 state.
  */
 
-struct tick_device tick_broadcast_device;
-static cpumask_t tick_broadcast_mask;
-static DEFINE_SPINLOCK(tick_broadcast_lock);
+static struct tick_device tick_broadcast_device;
+/* FIXME: Use cpumask_var_t. */
+static DECLARE_BITMAP(tick_broadcast_mask, NR_CPUS);
+static DECLARE_BITMAP(tmpmask, NR_CPUS);
+static DEFINE_RAW_SPINLOCK(tick_broadcast_lock);
 static int tick_broadcast_force;
 
 #ifdef CONFIG_TICK_ONESHOT
@@ -46,9 +47,9 @@ struct tick_device *tick_get_broadcast_device(void)
        return &tick_broadcast_device;
 }
 
-cpumask_t *tick_get_broadcast_mask(void)
+struct cpumask *tick_get_broadcast_mask(void)
 {
-       return &tick_broadcast_mask;
+       return to_cpumask(tick_broadcast_mask);
 }
 
 /*
@@ -72,7 +73,7 @@ int tick_check_broadcast_device(struct clock_event_device *dev)
 
        clockevents_exchange_device(NULL, dev);
        tick_broadcast_device.evtdev = dev;
-       if (!cpus_empty(tick_broadcast_mask))
+       if (!cpumask_empty(tick_get_broadcast_mask()))
                tick_broadcast_start_periodic(dev);
        return 1;
 }
@@ -94,7 +95,7 @@ int tick_device_uses_broadcast(struct clock_event_device *dev, int cpu)
        unsigned long flags;
        int ret = 0;
 
-       spin_lock_irqsave(&tick_broadcast_lock, flags);
+       raw_spin_lock_irqsave(&tick_broadcast_lock, flags);
 
        /*
         * Devices might be registered with both periodic and oneshot
@@ -104,7 +105,7 @@ int tick_device_uses_broadcast(struct clock_event_device *dev, int cpu)
         */
        if (!tick_device_is_functional(dev)) {
                dev->event_handler = tick_handle_periodic;
-               cpu_set(cpu, tick_broadcast_mask);
+               cpumask_set_cpu(cpu, tick_get_broadcast_mask());
                tick_broadcast_start_periodic(tick_broadcast_device.evtdev);
                ret = 1;
        } else {
@@ -116,18 +117,18 @@ int tick_device_uses_broadcast(struct clock_event_device *dev, int cpu)
                if (!(dev->features & CLOCK_EVT_FEAT_C3STOP)) {
                        int cpu = smp_processor_id();
 
-                       cpu_clear(cpu, tick_broadcast_mask);
+                       cpumask_clear_cpu(cpu, tick_get_broadcast_mask());
                        tick_broadcast_clear_oneshot(cpu);
                }
        }
-       spin_unlock_irqrestore(&tick_broadcast_lock, flags);
+       raw_spin_unlock_irqrestore(&tick_broadcast_lock, flags);
        return ret;
 }
 
 /*
- * Broadcast the event to the cpus, which are set in the mask
+ * Broadcast the event to the cpus, which are set in the mask (mangled).
  */
-static void tick_do_broadcast(cpumask_t mask)
+static void tick_do_broadcast(struct cpumask *mask)
 {
        int cpu = smp_processor_id();
        struct tick_device *td;
@@ -135,21 +136,20 @@ static void tick_do_broadcast(cpumask_t mask)
        /*
         * Check, if the current cpu is in the mask
         */
-       if (cpu_isset(cpu, mask)) {
-               cpu_clear(cpu, mask);
+       if (cpumask_test_cpu(cpu, mask)) {
+               cpumask_clear_cpu(cpu, mask);
                td = &per_cpu(tick_cpu_device, cpu);
                td->evtdev->event_handler(td->evtdev);
        }
 
-       if (!cpus_empty(mask)) {
+       if (!cpumask_empty(mask)) {
                /*
                 * It might be necessary to actually check whether the devices
                 * have different broadcast functions. For now, just use the
                 * one of the first device. This works as long as we have this
                 * misfeature only on x86 (lapic)
                 */
-               cpu = first_cpu(mask);
-               td = &per_cpu(tick_cpu_device, cpu);
+               td = &per_cpu(tick_cpu_device, cpumask_first(mask));
                td->evtdev->broadcast(mask);
        }
 }
@@ -160,14 +160,13 @@ static void tick_do_broadcast(cpumask_t mask)
  */
 static void tick_do_periodic_broadcast(void)
 {
-       cpumask_t mask;
-
-       spin_lock(&tick_broadcast_lock);
+       raw_spin_lock(&tick_broadcast_lock);
 
-       cpus_and(mask, cpu_online_map, tick_broadcast_mask);
-       tick_do_broadcast(mask);
+       cpumask_and(to_cpumask(tmpmask),
+                   cpu_online_mask, tick_get_broadcast_mask());
+       tick_do_broadcast(to_cpumask(tmpmask));
 
-       spin_unlock(&tick_broadcast_lock);
+       raw_spin_unlock(&tick_broadcast_lock);
 }
 
 /*
@@ -188,7 +187,7 @@ static void tick_handle_periodic_broadcast(struct clock_event_device *dev)
        /*
         * Setup the next period for devices, which do not have
         * periodic mode. We read dev->next_event first and add to it
-        * when the event alrady expired. clockevents_program_event()
+        * when the event already expired. clockevents_program_event()
         * sets dev->next_event only when the event is really
         * programmed to the device.
         */
@@ -205,14 +204,14 @@ static void tick_handle_periodic_broadcast(struct clock_event_device *dev)
  * Powerstate information: The system enters/leaves a state, where
  * affected devices might stop
  */
-static void tick_do_broadcast_on_off(void *why)
+static void tick_do_broadcast_on_off(unsigned long *reason)
 {
        struct clock_event_device *bc, *dev;
        struct tick_device *td;
-       unsigned long flags, *reason = why;
+       unsigned long flags;
        int cpu, bc_stopped;
 
-       spin_lock_irqsave(&tick_broadcast_lock, flags);
+       raw_spin_lock_irqsave(&tick_broadcast_lock, flags);
 
        cpu = smp_processor_id();
        td = &per_cpu(tick_cpu_device, cpu);
@@ -228,33 +227,34 @@ static void tick_do_broadcast_on_off(void *why)
        if (!tick_device_is_functional(dev))
                goto out;
 
-       bc_stopped = cpus_empty(tick_broadcast_mask);
+       bc_stopped = cpumask_empty(tick_get_broadcast_mask());
 
        switch (*reason) {
        case CLOCK_EVT_NOTIFY_BROADCAST_ON:
        case CLOCK_EVT_NOTIFY_BROADCAST_FORCE:
-               if (!cpu_isset(cpu, tick_broadcast_mask)) {
-                       cpu_set(cpu, tick_broadcast_mask);
-                       if (td->mode == TICKDEV_MODE_PERIODIC)
-                               clockevents_set_mode(dev,
-                                                    CLOCK_EVT_MODE_SHUTDOWN);
+               if (!cpumask_test_cpu(cpu, tick_get_broadcast_mask())) {
+                       cpumask_set_cpu(cpu, tick_get_broadcast_mask());
+                       if (tick_broadcast_device.mode ==
+                           TICKDEV_MODE_PERIODIC)
+                               clockevents_shutdown(dev);
                }
                if (*reason == CLOCK_EVT_NOTIFY_BROADCAST_FORCE)
                        tick_broadcast_force = 1;
                break;
        case CLOCK_EVT_NOTIFY_BROADCAST_OFF:
                if (!tick_broadcast_force &&
-                   cpu_isset(cpu, tick_broadcast_mask)) {
-                       cpu_clear(cpu, tick_broadcast_mask);
-                       if (td->mode == TICKDEV_MODE_PERIODIC)
+                   cpumask_test_cpu(cpu, tick_get_broadcast_mask())) {
+                       cpumask_clear_cpu(cpu, tick_get_broadcast_mask());
+                       if (tick_broadcast_device.mode ==
+                           TICKDEV_MODE_PERIODIC)
                                tick_setup_periodic(dev, 0);
                }
                break;
        }
 
-       if (cpus_empty(tick_broadcast_mask)) {
+       if (cpumask_empty(tick_get_broadcast_mask())) {
                if (!bc_stopped)
-                       clockevents_set_mode(bc, CLOCK_EVT_MODE_SHUTDOWN);
+                       clockevents_shutdown(bc);
        } else if (bc_stopped) {
                if (tick_broadcast_device.mode == TICKDEV_MODE_PERIODIC)
                        tick_broadcast_start_periodic(bc);
@@ -262,7 +262,7 @@ static void tick_do_broadcast_on_off(void *why)
                        tick_broadcast_setup_oneshot(bc);
        }
 out:
-       spin_unlock_irqrestore(&tick_broadcast_lock, flags);
+       raw_spin_unlock_irqrestore(&tick_broadcast_lock, flags);
 }
 
 /*
@@ -271,12 +271,11 @@ out:
  */
 void tick_broadcast_on_off(unsigned long reason, int *oncpu)
 {
-       if (!cpu_isset(*oncpu, cpu_online_map))
+       if (!cpumask_test_cpu(*oncpu, cpu_online_mask))
                printk(KERN_ERR "tick-broadcast: ignoring broadcast for "
                       "offline CPU #%d\n", *oncpu);
        else
-               smp_call_function_single(*oncpu, tick_do_broadcast_on_off,
-                                        &reason, 1);
+               tick_do_broadcast_on_off(&reason);
 }
 
 /*
@@ -299,17 +298,17 @@ void tick_shutdown_broadcast(unsigned int *cpup)
        unsigned long flags;
        unsigned int cpu = *cpup;
 
-       spin_lock_irqsave(&tick_broadcast_lock, flags);
+       raw_spin_lock_irqsave(&tick_broadcast_lock, flags);
 
        bc = tick_broadcast_device.evtdev;
-       cpu_clear(cpu, tick_broadcast_mask);
+       cpumask_clear_cpu(cpu, tick_get_broadcast_mask());
 
        if (tick_broadcast_device.mode == TICKDEV_MODE_PERIODIC) {
-               if (bc && cpus_empty(tick_broadcast_mask))
-                       clockevents_set_mode(bc, CLOCK_EVT_MODE_SHUTDOWN);
+               if (bc && cpumask_empty(tick_get_broadcast_mask()))
+                       clockevents_shutdown(bc);
        }
 
-       spin_unlock_irqrestore(&tick_broadcast_lock, flags);
+       raw_spin_unlock_irqrestore(&tick_broadcast_lock, flags);
 }
 
 void tick_suspend_broadcast(void)
@@ -317,13 +316,13 @@ void tick_suspend_broadcast(void)
        struct clock_event_device *bc;
        unsigned long flags;
 
-       spin_lock_irqsave(&tick_broadcast_lock, flags);
+       raw_spin_lock_irqsave(&tick_broadcast_lock, flags);
 
        bc = tick_broadcast_device.evtdev;
        if (bc)
-               clockevents_set_mode(bc, CLOCK_EVT_MODE_SHUTDOWN);
+               clockevents_shutdown(bc);
 
-       spin_unlock_irqrestore(&tick_broadcast_lock, flags);
+       raw_spin_unlock_irqrestore(&tick_broadcast_lock, flags);
 }
 
 int tick_resume_broadcast(void)
@@ -332,7 +331,7 @@ int tick_resume_broadcast(void)
        unsigned long flags;
        int broadcast = 0;
 
-       spin_lock_irqsave(&tick_broadcast_lock, flags);
+       raw_spin_lock_irqsave(&tick_broadcast_lock, flags);
 
        bc = tick_broadcast_device.evtdev;
 
@@ -341,17 +340,17 @@ int tick_resume_broadcast(void)
 
                switch (tick_broadcast_device.mode) {
                case TICKDEV_MODE_PERIODIC:
-                       if(!cpus_empty(tick_broadcast_mask))
+                       if (!cpumask_empty(tick_get_broadcast_mask()))
                                tick_broadcast_start_periodic(bc);
-                       broadcast = cpu_isset(smp_processor_id(),
-                                             tick_broadcast_mask);
+                       broadcast = cpumask_test_cpu(smp_processor_id(),
+                                                    tick_get_broadcast_mask());
                        break;
                case TICKDEV_MODE_ONESHOT:
                        broadcast = tick_resume_broadcast_oneshot(bc);
                        break;
                }
        }
-       spin_unlock_irqrestore(&tick_broadcast_lock, flags);
+       raw_spin_unlock_irqrestore(&tick_broadcast_lock, flags);
 
        return broadcast;
 }
@@ -359,14 +358,15 @@ int tick_resume_broadcast(void)
 
 #ifdef CONFIG_TICK_ONESHOT
 
-static cpumask_t tick_broadcast_oneshot_mask;
+/* FIXME: use cpumask_var_t. */
+static DECLARE_BITMAP(tick_broadcast_oneshot_mask, NR_CPUS);
 
 /*
- * Debugging: see timer_list.c
+ * Exposed for debugging: see timer_list.c
  */
-cpumask_t *tick_get_broadcast_oneshot_mask(void)
+struct cpumask *tick_get_broadcast_oneshot_mask(void)
 {
-       return &tick_broadcast_oneshot_mask;
+       return to_cpumask(tick_broadcast_oneshot_mask);
 }
 
 static int tick_broadcast_set_event(ktime_t expires, int force)
@@ -382,27 +382,39 @@ int tick_resume_broadcast_oneshot(struct clock_event_device *bc)
        return 0;
 }
 
+/*
+ * Called from irq_enter() when idle was interrupted to reenable the
+ * per cpu device.
+ */
+void tick_check_oneshot_broadcast(int cpu)
+{
+       if (cpumask_test_cpu(cpu, to_cpumask(tick_broadcast_oneshot_mask))) {
+               struct tick_device *td = &per_cpu(tick_cpu_device, cpu);
+
+               clockevents_set_mode(td->evtdev, CLOCK_EVT_MODE_ONESHOT);
+       }
+}
+
 /*
  * Handle oneshot mode broadcasting
  */
 static void tick_handle_oneshot_broadcast(struct clock_event_device *dev)
 {
        struct tick_device *td;
-       cpumask_t mask;
        ktime_t now, next_event;
        int cpu;
 
-       spin_lock(&tick_broadcast_lock);
+       raw_spin_lock(&tick_broadcast_lock);
 again:
        dev->next_event.tv64 = KTIME_MAX;
        next_event.tv64 = KTIME_MAX;
-       mask = CPU_MASK_NONE;
+       cpumask_clear(to_cpumask(tmpmask));
        now = ktime_get();
        /* Find all expired events */
-       for_each_cpu_mask_nr(cpu, tick_broadcast_oneshot_mask) {
+       for_each_cpu(cpu, tick_get_broadcast_oneshot_mask()) {
                td = &per_cpu(tick_cpu_device, cpu);
                if (td->evtdev->next_event.tv64 <= now.tv64)
-                       cpu_set(cpu, mask);
+                       cpumask_set_cpu(cpu, to_cpumask(tmpmask));
                else if (td->evtdev->next_event.tv64 < next_event.tv64)
                        next_event.tv64 = td->evtdev->next_event.tv64;
        }
@@ -410,7 +422,7 @@ again:
        /*
         * Wakeup the cpus which have an expired event.
         */
-       tick_do_broadcast(mask);
+       tick_do_broadcast(to_cpumask(tmpmask));
 
        /*
         * Two reasons for reprogram:
@@ -430,7 +442,7 @@ again:
                if (tick_broadcast_set_event(next_event, 0))
                        goto again;
        }
-       spin_unlock(&tick_broadcast_lock);
+       raw_spin_unlock(&tick_broadcast_lock);
 }
 
 /*
@@ -444,41 +456,44 @@ void tick_broadcast_oneshot_control(unsigned long reason)
        unsigned long flags;
        int cpu;
 
-       spin_lock_irqsave(&tick_broadcast_lock, flags);
-
        /*
         * Periodic mode does not care about the enter/exit of power
         * states
         */
        if (tick_broadcast_device.mode == TICKDEV_MODE_PERIODIC)
-               goto out;
+               return;
 
-       bc = tick_broadcast_device.evtdev;
+       /*
+        * We are called with preemtion disabled from the depth of the
+        * idle code, so we can't be moved away.
+        */
        cpu = smp_processor_id();
        td = &per_cpu(tick_cpu_device, cpu);
        dev = td->evtdev;
 
        if (!(dev->features & CLOCK_EVT_FEAT_C3STOP))
-               goto out;
+               return;
+
+       bc = tick_broadcast_device.evtdev;
 
+       raw_spin_lock_irqsave(&tick_broadcast_lock, flags);
        if (reason == CLOCK_EVT_NOTIFY_BROADCAST_ENTER) {
-               if (!cpu_isset(cpu, tick_broadcast_oneshot_mask)) {
-                       cpu_set(cpu, tick_broadcast_oneshot_mask);
+               if (!cpumask_test_cpu(cpu, tick_get_broadcast_oneshot_mask())) {
+                       cpumask_set_cpu(cpu, tick_get_broadcast_oneshot_mask());
                        clockevents_set_mode(dev, CLOCK_EVT_MODE_SHUTDOWN);
                        if (dev->next_event.tv64 < bc->next_event.tv64)
                                tick_broadcast_set_event(dev->next_event, 1);
                }
        } else {
-               if (cpu_isset(cpu, tick_broadcast_oneshot_mask)) {
-                       cpu_clear(cpu, tick_broadcast_oneshot_mask);
+               if (cpumask_test_cpu(cpu, tick_get_broadcast_oneshot_mask())) {
+                       cpumask_clear_cpu(cpu,
+                                         tick_get_broadcast_oneshot_mask());
                        clockevents_set_mode(dev, CLOCK_EVT_MODE_ONESHOT);
                        if (dev->next_event.tv64 != KTIME_MAX)
                                tick_program_event(dev->next_event, 1);
                }
        }
-
-out:
-       spin_unlock_irqrestore(&tick_broadcast_lock, flags);
+       raw_spin_unlock_irqrestore(&tick_broadcast_lock, flags);
 }
 
 /*
@@ -488,15 +503,16 @@ out:
  */
 static void tick_broadcast_clear_oneshot(int cpu)
 {
-       cpu_clear(cpu, tick_broadcast_oneshot_mask);
+       cpumask_clear_cpu(cpu, tick_get_broadcast_oneshot_mask());
 }
 
-static void tick_broadcast_init_next_event(cpumask_t *mask, ktime_t expires)
+static void tick_broadcast_init_next_event(struct cpumask *mask,
+                                          ktime_t expires)
 {
        struct tick_device *td;
        int cpu;
 
-       for_each_cpu_mask_nr(cpu, *mask) {
+       for_each_cpu(cpu, mask) {
                td = &per_cpu(tick_cpu_device, cpu);
                if (td->evtdev)
                        td->evtdev->next_event = expires;
@@ -508,11 +524,11 @@ static void tick_broadcast_init_next_event(cpumask_t *mask, ktime_t expires)
  */
 void tick_broadcast_setup_oneshot(struct clock_event_device *bc)
 {
+       int cpu = smp_processor_id();
+
        /* Set it up only once ! */
        if (bc->event_handler != tick_handle_oneshot_broadcast) {
                int was_periodic = bc->mode == CLOCK_EVT_MODE_PERIODIC;
-               int cpu = smp_processor_id();
-               cpumask_t mask;
 
                bc->event_handler = tick_handle_oneshot_broadcast;
                clockevents_set_mode(bc, CLOCK_EVT_MODE_ONESHOT);
@@ -526,16 +542,27 @@ void tick_broadcast_setup_oneshot(struct clock_event_device *bc)
                 * oneshot_mask bits for those and program the
                 * broadcast device to fire.
                 */
-               mask = tick_broadcast_mask;
-               cpu_clear(cpu, mask);
-               cpus_or(tick_broadcast_oneshot_mask,
-                       tick_broadcast_oneshot_mask, mask);
-
-               if (was_periodic && !cpus_empty(mask)) {
-                       tick_broadcast_init_next_event(&mask, tick_next_period);
+               cpumask_copy(to_cpumask(tmpmask), tick_get_broadcast_mask());
+               cpumask_clear_cpu(cpu, to_cpumask(tmpmask));
+               cpumask_or(tick_get_broadcast_oneshot_mask(),
+                          tick_get_broadcast_oneshot_mask(),
+                          to_cpumask(tmpmask));
+
+               if (was_periodic && !cpumask_empty(to_cpumask(tmpmask))) {
+                       tick_broadcast_init_next_event(to_cpumask(tmpmask),
+                                                      tick_next_period);
                        tick_broadcast_set_event(tick_next_period, 1);
                } else
                        bc->next_event.tv64 = KTIME_MAX;
+       } else {
+               /*
+                * The first cpu which switches to oneshot mode sets
+                * the bit for all other cpus which are in the general
+                * (periodic) broadcast mask. So the bit is set and
+                * would prevent the first broadcast enter after this
+                * to program the bc device.
+                */
+               tick_broadcast_clear_oneshot(cpu);
        }
 }
 
@@ -547,13 +574,13 @@ void tick_broadcast_switch_to_oneshot(void)
        struct clock_event_device *bc;
        unsigned long flags;
 
-       spin_lock_irqsave(&tick_broadcast_lock, flags);
+       raw_spin_lock_irqsave(&tick_broadcast_lock, flags);
 
        tick_broadcast_device.mode = TICKDEV_MODE_ONESHOT;
        bc = tick_broadcast_device.evtdev;
        if (bc)
                tick_broadcast_setup_oneshot(bc);
-       spin_unlock_irqrestore(&tick_broadcast_lock, flags);
+       raw_spin_unlock_irqrestore(&tick_broadcast_lock, flags);
 }
 
 
@@ -565,15 +592,33 @@ void tick_shutdown_broadcast_oneshot(unsigned int *cpup)
        unsigned long flags;
        unsigned int cpu = *cpup;
 
-       spin_lock_irqsave(&tick_broadcast_lock, flags);
+       raw_spin_lock_irqsave(&tick_broadcast_lock, flags);
 
        /*
         * Clear the broadcast mask flag for the dead cpu, but do not
         * stop the broadcast device!
         */
-       cpu_clear(cpu, tick_broadcast_oneshot_mask);
+       cpumask_clear_cpu(cpu, tick_get_broadcast_oneshot_mask());
+
+       raw_spin_unlock_irqrestore(&tick_broadcast_lock, flags);
+}
+
+/*
+ * Check, whether the broadcast device is in one shot mode
+ */
+int tick_broadcast_oneshot_active(void)
+{
+       return tick_broadcast_device.mode == TICKDEV_MODE_ONESHOT;
+}
+
+/*
+ * Check whether the broadcast device supports oneshot.
+ */
+bool tick_broadcast_oneshot_available(void)
+{
+       struct clock_event_device *bc = tick_broadcast_device.evtdev;
 
-       spin_unlock_irqrestore(&tick_broadcast_lock, flags);
+       return bc ? bc->features & CLOCK_EVT_FEAT_ONESHOT : false;
 }
 
 #endif