]> nv-tegra.nvidia Code Review - linux-2.6.git/blobdiff - drivers/misc/apds9802als.c
Update copyrights
[linux-2.6.git] / drivers / misc / apds9802als.c
index f9b91ba8900c96f027a284185b97fc9dd1e755b0..81db7811cf68ca349b6778ca5a8bff99db535f3e 100644 (file)
@@ -123,7 +123,7 @@ static ssize_t als_sensing_range_store(struct device *dev,
 {
        struct i2c_client *client = to_i2c_client(dev);
        struct als_data *data = i2c_get_clientdata(client);
-       unsigned int ret_val;
+       int ret_val;
        unsigned long val;
 
        if (strict_strtoul(buf, 10, &val))
@@ -245,23 +245,28 @@ static int apds9802als_probe(struct i2c_client *client,
        als_set_default_config(client);
        mutex_init(&data->mutex);
 
+       pm_runtime_set_active(&client->dev);
        pm_runtime_enable(&client->dev);
-       pm_runtime_get(&client->dev);
-       pm_runtime_put(&client->dev);
 
        return res;
 als_error1:
-       i2c_set_clientdata(client, NULL);
        kfree(data);
        return res;
 }
 
-static int apds9802als_remove(struct i2c_client *client)
+static int __devexit apds9802als_remove(struct i2c_client *client)
 {
        struct als_data *data = i2c_get_clientdata(client);
 
+       pm_runtime_get_sync(&client->dev);
+
        als_set_power_state(client, false);
        sysfs_remove_group(&client->dev.kobj, &m_als_gr);
+
+       pm_runtime_disable(&client->dev);
+       pm_runtime_set_suspended(&client->dev);
+       pm_runtime_put_noidle(&client->dev);
+
        kfree(data);
        return 0;
 }
@@ -276,9 +281,6 @@ static int apds9802als_suspend(struct i2c_client *client, pm_message_t mesg)
 static int apds9802als_resume(struct i2c_client *client)
 {
        als_set_default_config(client);
-
-       pm_runtime_get(&client->dev);
-       pm_runtime_put(&client->dev);
        return 0;
 }
 
@@ -324,7 +326,7 @@ static struct i2c_driver apds9802als_driver = {
                .pm = APDS9802ALS_PM_OPS,
        },
        .probe = apds9802als_probe,
-       .remove = apds9802als_remove,
+       .remove = __devexit_p(apds9802als_remove),
        .suspend = apds9802als_suspend,
        .resume = apds9802als_resume,
        .id_table = apds9802als_id,