]> nv-tegra.nvidia Code Review - linux-2.6.git/blobdiff - drivers/dma/ste_dma40.c
dmaengine/ste_dma40: add a separate queue for pending requests
[linux-2.6.git] / drivers / dma / ste_dma40.c
index 7bc535ee0a0851c4b17b80a1db649e574f024691..91d5ed7c79ba183c3c7ce2bf624b19fe07157329 100644 (file)
@@ -1,5 +1,6 @@
 /*
- * Copyright (C) ST-Ericsson SA 2007-2010
+ * Copyright (C) Ericsson AB 2007-2008
+ * Copyright (C) ST-Ericsson SA 2008-2010
  * Author: Per Forlin <per.forlin@stericsson.com> for ST-Ericsson
  * Author: Jonas Aaberg <jonas.aberg@stericsson.com> for ST-Ericsson
  * License terms: GNU General Public License (GPL) version 2
@@ -67,6 +68,7 @@ enum d40_command {
  * @base: Pointer to memory area when the pre_alloc_lli's are not large
  * enough, IE bigger than the most common case, 1 dst and 1 src. NULL if
  * pre_alloc_lli is used.
+ * @dma_addr: DMA address, if mapped
  * @size: The size in bytes of the memory at base or the size of pre_alloc_lli.
  * @pre_alloc_lli: Pre allocated area for the most common case of transfers,
  * one buffer to one buffer.
@@ -74,6 +76,7 @@ enum d40_command {
 struct d40_lli_pool {
        void    *base;
        int      size;
+       dma_addr_t      dma_addr;
        /* Space for dst and src, plus an extra for padding */
        u8       pre_alloc_lli[3 * sizeof(struct d40_phy_lli)];
 };
@@ -87,13 +90,12 @@ struct d40_lli_pool {
  * @lli_log: Same as above but for logical channels.
  * @lli_pool: The pool with two entries pre-allocated.
  * @lli_len: Number of llis of current descriptor.
- * @lli_current: Number of transfered llis.
+ * @lli_current: Number of transferred llis.
  * @lcla_alloc: Number of LCLA entries allocated.
  * @txd: DMA engine struct. Used for among other things for communication
  * during a transfer.
  * @node: List entry.
  * @is_in_client_list: true if the client owns this descriptor.
- * @is_hw_linked: true if this job will automatically be continued for
  * the previous one.
  *
  * This descriptor is used for both logical and physical transfers.
@@ -113,7 +115,7 @@ struct d40_desc {
        struct list_head                 node;
 
        bool                             is_in_client_list;
-       bool                             is_hw_linked;
+       bool                             cyclic;
 };
 
 /**
@@ -129,6 +131,7 @@ struct d40_desc {
  */
 struct d40_lcla_pool {
        void            *base;
+       dma_addr_t      dma_addr;
        void            *base_unaligned;
        int              pages;
        spinlock_t       lock;
@@ -196,6 +199,7 @@ struct d40_chan {
        struct dma_chan                  chan;
        struct tasklet_struct            tasklet;
        struct list_head                 client;
+       struct list_head                 pending_queue;
        struct list_head                 active;
        struct list_head                 queue;
        struct stedma40_chan_cfg         dma_cfg;
@@ -302,9 +306,37 @@ struct d40_reg_val {
        unsigned int val;
 };
 
-static int d40_pool_lli_alloc(struct d40_desc *d40d,
-                             int lli_len, bool is_log)
+static struct device *chan2dev(struct d40_chan *d40c)
 {
+       return &d40c->chan.dev->device;
+}
+
+static bool chan_is_physical(struct d40_chan *chan)
+{
+       return chan->log_num == D40_PHY_CHAN;
+}
+
+static bool chan_is_logical(struct d40_chan *chan)
+{
+       return !chan_is_physical(chan);
+}
+
+static void __iomem *chan_base(struct d40_chan *chan)
+{
+       return chan->base->virtbase + D40_DREG_PCBASE +
+              chan->phy_chan->num * D40_DREG_PCDELTA;
+}
+
+#define d40_err(dev, format, arg...)           \
+       dev_err(dev, "[%s] " format, __func__, ## arg)
+
+#define chan_err(d40c, format, arg...)         \
+       d40_err(chan2dev(d40c), format, ## arg)
+
+static int d40_pool_lli_alloc(struct d40_chan *d40c, struct d40_desc *d40d,
+                             int lli_len)
+{
+       bool is_log = chan_is_logical(d40c);
        u32 align;
        void *base;
 
@@ -318,7 +350,7 @@ static int d40_pool_lli_alloc(struct d40_desc *d40d,
                d40d->lli_pool.size = sizeof(d40d->lli_pool.pre_alloc_lli);
                d40d->lli_pool.base = NULL;
        } else {
-               d40d->lli_pool.size = ALIGN(lli_len * 2 * align, align);
+               d40d->lli_pool.size = lli_len * 2 * align;
 
                base = kmalloc(d40d->lli_pool.size + align, GFP_NOWAIT);
                d40d->lli_pool.base = base;
@@ -328,22 +360,37 @@ static int d40_pool_lli_alloc(struct d40_desc *d40d,
        }
 
        if (is_log) {
-               d40d->lli_log.src = PTR_ALIGN((struct d40_log_lli *) base,
-                                             align);
-               d40d->lli_log.dst = PTR_ALIGN(d40d->lli_log.src + lli_len,
-                                             align);
+               d40d->lli_log.src = PTR_ALIGN(base, align);
+               d40d->lli_log.dst = d40d->lli_log.src + lli_len;
+
+               d40d->lli_pool.dma_addr = 0;
        } else {
-               d40d->lli_phy.src = PTR_ALIGN((struct d40_phy_lli *)base,
-                                             align);
-               d40d->lli_phy.dst = PTR_ALIGN(d40d->lli_phy.src + lli_len,
-                                             align);
+               d40d->lli_phy.src = PTR_ALIGN(base, align);
+               d40d->lli_phy.dst = d40d->lli_phy.src + lli_len;
+
+               d40d->lli_pool.dma_addr = dma_map_single(d40c->base->dev,
+                                                        d40d->lli_phy.src,
+                                                        d40d->lli_pool.size,
+                                                        DMA_TO_DEVICE);
+
+               if (dma_mapping_error(d40c->base->dev,
+                                     d40d->lli_pool.dma_addr)) {
+                       kfree(d40d->lli_pool.base);
+                       d40d->lli_pool.base = NULL;
+                       d40d->lli_pool.dma_addr = 0;
+                       return -ENOMEM;
+               }
        }
 
        return 0;
 }
 
-static void d40_pool_lli_free(struct d40_desc *d40d)
+static void d40_pool_lli_free(struct d40_chan *d40c, struct d40_desc *d40d)
 {
+       if (d40d->lli_pool.dma_addr)
+               dma_unmap_single(d40c->base->dev, d40d->lli_pool.dma_addr,
+                                d40d->lli_pool.size, DMA_TO_DEVICE);
+
        kfree(d40d->lli_pool.base);
        d40d->lli_pool.base = NULL;
        d40d->lli_pool.size = 0;
@@ -390,7 +437,7 @@ static int d40_lcla_free_all(struct d40_chan *d40c,
        int i;
        int ret = -EINVAL;
 
-       if (d40c->log_num == D40_PHY_CHAN)
+       if (chan_is_physical(d40c))
                return 0;
 
        spin_lock_irqsave(&d40c->base->lcla_pool.lock, flags);
@@ -429,7 +476,7 @@ static struct d40_desc *d40_desc_get(struct d40_chan *d40c)
 
                list_for_each_entry_safe(d, _d, &d40c->client, node)
                        if (async_tx_test_ack(&d->txd)) {
-                               d40_pool_lli_free(d);
+                               d40_pool_lli_free(d40c, d);
                                d40_desc_remove(d);
                                desc = d;
                                memset(desc, 0, sizeof(*desc));
@@ -449,6 +496,7 @@ static struct d40_desc *d40_desc_get(struct d40_chan *d40c)
 static void d40_desc_free(struct d40_chan *d40c, struct d40_desc *d40d)
 {
 
+       d40_pool_lli_free(d40c, d40d);
        d40_lcla_free_all(d40c, d40d);
        kmem_cache_free(d40c->base->desc_slab, d40d);
 }
@@ -458,57 +506,128 @@ static void d40_desc_submit(struct d40_chan *d40c, struct d40_desc *desc)
        list_add_tail(&desc->node, &d40c->active);
 }
 
-static void d40_desc_load(struct d40_chan *d40c, struct d40_desc *d40d)
+static void d40_phy_lli_load(struct d40_chan *chan, struct d40_desc *desc)
 {
-       int curr_lcla = -EINVAL, next_lcla;
+       struct d40_phy_lli *lli_dst = desc->lli_phy.dst;
+       struct d40_phy_lli *lli_src = desc->lli_phy.src;
+       void __iomem *base = chan_base(chan);
+
+       writel(lli_src->reg_cfg, base + D40_CHAN_REG_SSCFG);
+       writel(lli_src->reg_elt, base + D40_CHAN_REG_SSELT);
+       writel(lli_src->reg_ptr, base + D40_CHAN_REG_SSPTR);
+       writel(lli_src->reg_lnk, base + D40_CHAN_REG_SSLNK);
+
+       writel(lli_dst->reg_cfg, base + D40_CHAN_REG_SDCFG);
+       writel(lli_dst->reg_elt, base + D40_CHAN_REG_SDELT);
+       writel(lli_dst->reg_ptr, base + D40_CHAN_REG_SDPTR);
+       writel(lli_dst->reg_lnk, base + D40_CHAN_REG_SDLNK);
+}
 
-       if (d40c->log_num == D40_PHY_CHAN) {
-               d40_phy_lli_write(d40c->base->virtbase,
-                                 d40c->phy_chan->num,
-                                 d40d->lli_phy.dst,
-                                 d40d->lli_phy.src);
-               d40d->lli_current = d40d->lli_len;
-       } else {
+static void d40_log_lli_to_lcxa(struct d40_chan *chan, struct d40_desc *desc)
+{
+       struct d40_lcla_pool *pool = &chan->base->lcla_pool;
+       struct d40_log_lli_bidir *lli = &desc->lli_log;
+       int lli_current = desc->lli_current;
+       int lli_len = desc->lli_len;
+       bool cyclic = desc->cyclic;
+       int curr_lcla = -EINVAL;
+       int first_lcla = 0;
+       bool linkback;
 
-               if ((d40d->lli_len - d40d->lli_current) > 1)
-                       curr_lcla = d40_lcla_alloc_one(d40c, d40d);
+       /*
+        * We may have partially running cyclic transfers, in case we did't get
+        * enough LCLA entries.
+        */
+       linkback = cyclic && lli_current == 0;
 
-               d40_log_lli_lcpa_write(d40c->lcpa,
-                                      &d40d->lli_log.dst[d40d->lli_current],
-                                      &d40d->lli_log.src[d40d->lli_current],
-                                      curr_lcla);
+       /*
+        * For linkback, we need one LCLA even with only one link, because we
+        * can't link back to the one in LCPA space
+        */
+       if (linkback || (lli_len - lli_current > 1)) {
+               curr_lcla = d40_lcla_alloc_one(chan, desc);
+               first_lcla = curr_lcla;
+       }
 
-               d40d->lli_current++;
-               for (; d40d->lli_current < d40d->lli_len; d40d->lli_current++) {
-                       struct d40_log_lli *lcla;
+       /*
+        * For linkback, we normally load the LCPA in the loop since we need to
+        * link it to the second LCLA and not the first.  However, if we
+        * couldn't even get a first LCLA, then we have to run in LCPA and
+        * reload manually.
+        */
+       if (!linkback || curr_lcla == -EINVAL) {
+               unsigned int flags = 0;
 
-                       if (d40d->lli_current + 1 < d40d->lli_len)
-                               next_lcla = d40_lcla_alloc_one(d40c, d40d);
-                       else
-                               next_lcla = -EINVAL;
+               if (curr_lcla == -EINVAL)
+                       flags |= LLI_TERM_INT;
 
-                       lcla = d40c->base->lcla_pool.base +
-                               d40c->phy_chan->num * 1024 +
-                               8 * curr_lcla * 2;
+               d40_log_lli_lcpa_write(chan->lcpa,
+                                      &lli->dst[lli_current],
+                                      &lli->src[lli_current],
+                                      curr_lcla,
+                                      flags);
+               lli_current++;
+       }
 
-                       d40_log_lli_lcla_write(lcla,
-                                              &d40d->lli_log.dst[d40d->lli_current],
-                                              &d40d->lli_log.src[d40d->lli_current],
-                                              next_lcla);
+       if (curr_lcla < 0)
+               goto out;
 
-                       (void) dma_map_single(d40c->base->dev, lcla,
-                                             2 * sizeof(struct d40_log_lli),
-                                             DMA_TO_DEVICE);
+       for (; lli_current < lli_len; lli_current++) {
+               unsigned int lcla_offset = chan->phy_chan->num * 1024 +
+                                          8 * curr_lcla * 2;
+               struct d40_log_lli *lcla = pool->base + lcla_offset;
+               unsigned int flags = 0;
+               int next_lcla;
 
-                       curr_lcla = next_lcla;
+               if (lli_current + 1 < lli_len)
+                       next_lcla = d40_lcla_alloc_one(chan, desc);
+               else
+                       next_lcla = linkback ? first_lcla : -EINVAL;
 
-                       if (curr_lcla == -EINVAL) {
-                               d40d->lli_current++;
-                               break;
-                       }
+               if (cyclic || next_lcla == -EINVAL)
+                       flags |= LLI_TERM_INT;
 
+               if (linkback && curr_lcla == first_lcla) {
+                       /* First link goes in both LCPA and LCLA */
+                       d40_log_lli_lcpa_write(chan->lcpa,
+                                              &lli->dst[lli_current],
+                                              &lli->src[lli_current],
+                                              next_lcla, flags);
+               }
+
+               /*
+                * One unused LCLA in the cyclic case if the very first
+                * next_lcla fails...
+                */
+               d40_log_lli_lcla_write(lcla,
+                                      &lli->dst[lli_current],
+                                      &lli->src[lli_current],
+                                      next_lcla, flags);
+
+               dma_sync_single_range_for_device(chan->base->dev,
+                                       pool->dma_addr, lcla_offset,
+                                       2 * sizeof(struct d40_log_lli),
+                                       DMA_TO_DEVICE);
+
+               curr_lcla = next_lcla;
+
+               if (curr_lcla == -EINVAL || curr_lcla == first_lcla) {
+                       lli_current++;
+                       break;
                }
        }
+
+out:
+       desc->lli_current = lli_current;
+}
+
+static void d40_desc_load(struct d40_chan *d40c, struct d40_desc *d40d)
+{
+       if (chan_is_physical(d40c)) {
+               d40_phy_lli_load(d40c, d40d);
+               d40d->lli_current = d40d->lli_len;
+       } else
+               d40_log_lli_to_lcxa(d40c, d40d);
 }
 
 static struct d40_desc *d40_first_active_get(struct d40_chan *d40c)
@@ -526,36 +645,95 @@ static struct d40_desc *d40_first_active_get(struct d40_chan *d40c)
 
 static void d40_desc_queue(struct d40_chan *d40c, struct d40_desc *desc)
 {
-       list_add_tail(&desc->node, &d40c->queue);
+       list_add_tail(&desc->node, &d40c->pending_queue);
 }
 
-static struct d40_desc *d40_first_queued(struct d40_chan *d40c)
+static struct d40_desc *d40_first_pending(struct d40_chan *d40c)
 {
        struct d40_desc *d;
 
-       if (list_empty(&d40c->queue))
+       if (list_empty(&d40c->pending_queue))
                return NULL;
 
-       d = list_first_entry(&d40c->queue,
+       d = list_first_entry(&d40c->pending_queue,
                             struct d40_desc,
                             node);
        return d;
 }
 
-static struct d40_desc *d40_last_queued(struct d40_chan *d40c)
+static struct d40_desc *d40_first_queued(struct d40_chan *d40c)
 {
        struct d40_desc *d;
 
        if (list_empty(&d40c->queue))
                return NULL;
-       list_for_each_entry(d, &d40c->queue, node)
-               if (list_is_last(&d->node, &d40c->queue))
-                       break;
+
+       d = list_first_entry(&d40c->queue,
+                            struct d40_desc,
+                            node);
        return d;
 }
 
-/* Support functions for logical channels */
+static int d40_psize_2_burst_size(bool is_log, int psize)
+{
+       if (is_log) {
+               if (psize == STEDMA40_PSIZE_LOG_1)
+                       return 1;
+       } else {
+               if (psize == STEDMA40_PSIZE_PHY_1)
+                       return 1;
+       }
+
+       return 2 << psize;
+}
+
+/*
+ * The dma only supports transmitting packages up to
+ * STEDMA40_MAX_SEG_SIZE << data_width. Calculate the total number of
+ * dma elements required to send the entire sg list
+ */
+static int d40_size_2_dmalen(int size, u32 data_width1, u32 data_width2)
+{
+       int dmalen;
+       u32 max_w = max(data_width1, data_width2);
+       u32 min_w = min(data_width1, data_width2);
+       u32 seg_max = ALIGN(STEDMA40_MAX_SEG_SIZE << min_w, 1 << max_w);
 
+       if (seg_max > STEDMA40_MAX_SEG_SIZE)
+               seg_max -= (1 << max_w);
+
+       if (!IS_ALIGNED(size, 1 << max_w))
+               return -EINVAL;
+
+       if (size <= seg_max)
+               dmalen = 1;
+       else {
+               dmalen = size / seg_max;
+               if (dmalen * seg_max < size)
+                       dmalen++;
+       }
+       return dmalen;
+}
+
+static int d40_sg_2_dmalen(struct scatterlist *sgl, int sg_len,
+                          u32 data_width1, u32 data_width2)
+{
+       struct scatterlist *sg;
+       int i;
+       int len = 0;
+       int ret;
+
+       for_each_sg(sgl, sg, sg_len, i) {
+               ret = d40_size_2_dmalen(sg_dma_len(sg),
+                                       data_width1, data_width2);
+               if (ret < 0)
+                       return ret;
+               len += ret;
+       }
+       return len;
+}
+
+/* Support functions for logical channels */
 
 static int d40_channel_execute_command(struct d40_chan *d40c,
                                       enum d40_command command)
@@ -607,9 +785,9 @@ static int d40_channel_execute_command(struct d40_chan *d40c,
                }
 
                if (i == D40_SUSPEND_MAX_IT) {
-                       dev_err(&d40c->chan.dev->device,
-                               "[%s]: unable to suspend the chl %d (log: %d) status %x\n",
-                               __func__, d40c->phy_chan->num, d40c->log_num,
+                       chan_err(d40c,
+                               "unable to suspend the chl %d (log: %d) status %x\n",
+                               d40c->phy_chan->num, d40c->log_num,
                                status);
                        dump_stack();
                        ret = -EBUSY;
@@ -637,22 +815,55 @@ static void d40_term_all(struct d40_chan *d40c)
                d40_desc_free(d40c, d40d);
        }
 
+       /* Release pending descriptors */
+       while ((d40d = d40_first_pending(d40c))) {
+               d40_desc_remove(d40d);
+               d40_desc_free(d40c, d40d);
+       }
 
        d40c->pending_tx = 0;
        d40c->busy = false;
 }
 
+static void __d40_config_set_event(struct d40_chan *d40c, bool enable,
+                                  u32 event, int reg)
+{
+       void __iomem *addr = chan_base(d40c) + reg;
+       int tries;
+
+       if (!enable) {
+               writel((D40_DEACTIVATE_EVENTLINE << D40_EVENTLINE_POS(event))
+                      | ~D40_EVENTLINE_MASK(event), addr);
+               return;
+       }
+
+       /*
+        * The hardware sometimes doesn't register the enable when src and dst
+        * event lines are active on the same logical channel.  Retry to ensure
+        * it does.  Usually only one retry is sufficient.
+        */
+       tries = 100;
+       while (--tries) {
+               writel((D40_ACTIVATE_EVENTLINE << D40_EVENTLINE_POS(event))
+                      | ~D40_EVENTLINE_MASK(event), addr);
+
+               if (readl(addr) & D40_EVENTLINE_MASK(event))
+                       break;
+       }
+
+       if (tries != 99)
+               dev_dbg(chan2dev(d40c),
+                       "[%s] workaround enable S%cLNK (%d tries)\n",
+                       __func__, reg == D40_CHAN_REG_SSLNK ? 'S' : 'D',
+                       100 - tries);
+
+       WARN_ON(!tries);
+}
+
 static void d40_config_set_event(struct d40_chan *d40c, bool do_enable)
 {
-       u32 val;
        unsigned long flags;
 
-       /* Notice, that disable requires the physical channel to be stopped */
-       if (do_enable)
-               val = D40_ACTIVATE_EVENTLINE;
-       else
-               val = D40_DEACTIVATE_EVENTLINE;
-
        spin_lock_irqsave(&d40c->phy_chan->lock, flags);
 
        /* Enable event line connected to device (or memcpy) */
@@ -660,20 +871,15 @@ static void d40_config_set_event(struct d40_chan *d40c, bool do_enable)
            (d40c->dma_cfg.dir == STEDMA40_PERIPH_TO_PERIPH)) {
                u32 event = D40_TYPE_TO_EVENT(d40c->dma_cfg.src_dev_type);
 
-               writel((val << D40_EVENTLINE_POS(event)) |
-                      ~D40_EVENTLINE_MASK(event),
-                      d40c->base->virtbase + D40_DREG_PCBASE +
-                      d40c->phy_chan->num * D40_DREG_PCDELTA +
-                      D40_CHAN_REG_SSLNK);
+               __d40_config_set_event(d40c, do_enable, event,
+                                      D40_CHAN_REG_SSLNK);
        }
+
        if (d40c->dma_cfg.dir !=  STEDMA40_PERIPH_TO_MEM) {
                u32 event = D40_TYPE_TO_EVENT(d40c->dma_cfg.dst_dev_type);
 
-               writel((val << D40_EVENTLINE_POS(event)) |
-                      ~D40_EVENTLINE_MASK(event),
-                      d40c->base->virtbase + D40_DREG_PCBASE +
-                      d40c->phy_chan->num * D40_DREG_PCDELTA +
-                      D40_CHAN_REG_SDLNK);
+               __d40_config_set_event(d40c, do_enable, event,
+                                      D40_CHAN_REG_SDLNK);
        }
 
        spin_unlock_irqrestore(&d40c->phy_chan->lock, flags);
@@ -681,18 +887,40 @@ static void d40_config_set_event(struct d40_chan *d40c, bool do_enable)
 
 static u32 d40_chan_has_events(struct d40_chan *d40c)
 {
+       void __iomem *chanbase = chan_base(d40c);
        u32 val;
 
-       val = readl(d40c->base->virtbase + D40_DREG_PCBASE +
-                   d40c->phy_chan->num * D40_DREG_PCDELTA +
-                   D40_CHAN_REG_SSLNK);
+       val = readl(chanbase + D40_CHAN_REG_SSLNK);
+       val |= readl(chanbase + D40_CHAN_REG_SDLNK);
 
-       val |= readl(d40c->base->virtbase + D40_DREG_PCBASE +
-                    d40c->phy_chan->num * D40_DREG_PCDELTA +
-                    D40_CHAN_REG_SDLNK);
        return val;
 }
 
+static u32 d40_get_prmo(struct d40_chan *d40c)
+{
+       static const unsigned int phy_map[] = {
+               [STEDMA40_PCHAN_BASIC_MODE]
+                       = D40_DREG_PRMO_PCHAN_BASIC,
+               [STEDMA40_PCHAN_MODULO_MODE]
+                       = D40_DREG_PRMO_PCHAN_MODULO,
+               [STEDMA40_PCHAN_DOUBLE_DST_MODE]
+                       = D40_DREG_PRMO_PCHAN_DOUBLE_DST,
+       };
+       static const unsigned int log_map[] = {
+               [STEDMA40_LCHAN_SRC_PHY_DST_LOG]
+                       = D40_DREG_PRMO_LCHAN_SRC_PHY_DST_LOG,
+               [STEDMA40_LCHAN_SRC_LOG_DST_PHY]
+                       = D40_DREG_PRMO_LCHAN_SRC_LOG_DST_PHY,
+               [STEDMA40_LCHAN_SRC_LOG_DST_LOG]
+                       = D40_DREG_PRMO_LCHAN_SRC_LOG_DST_LOG,
+       };
+
+       if (chan_is_physical(d40c))
+               return phy_map[d40c->dma_cfg.mode_opt];
+       else
+               return log_map[d40c->dma_cfg.mode_opt];
+}
+
 static void d40_config_write(struct d40_chan *d40c)
 {
        u32 addr_base;
@@ -701,40 +929,27 @@ static void d40_config_write(struct d40_chan *d40c)
        /* Odd addresses are even addresses + 4 */
        addr_base = (d40c->phy_chan->num % 2) * 4;
        /* Setup channel mode to logical or physical */
-       var = ((u32)(d40c->log_num != D40_PHY_CHAN) + 1) <<
+       var = ((u32)(chan_is_logical(d40c)) + 1) <<
                D40_CHAN_POS(d40c->phy_chan->num);
        writel(var, d40c->base->virtbase + D40_DREG_PRMSE + addr_base);
 
        /* Setup operational mode option register */
-       var = ((d40c->dma_cfg.channel_type >> STEDMA40_INFO_CH_MODE_OPT_POS) &
-              0x3) << D40_CHAN_POS(d40c->phy_chan->num);
+       var = d40_get_prmo(d40c) << D40_CHAN_POS(d40c->phy_chan->num);
 
        writel(var, d40c->base->virtbase + D40_DREG_PRMOE + addr_base);
 
-       if (d40c->log_num != D40_PHY_CHAN) {
+       if (chan_is_logical(d40c)) {
+               int lidx = (d40c->phy_chan->num << D40_SREG_ELEM_LOG_LIDX_POS)
+                          & D40_SREG_ELEM_LOG_LIDX_MASK;
+               void __iomem *chanbase = chan_base(d40c);
+
                /* Set default config for CFG reg */
-               writel(d40c->src_def_cfg,
-                      d40c->base->virtbase + D40_DREG_PCBASE +
-                      d40c->phy_chan->num * D40_DREG_PCDELTA +
-                      D40_CHAN_REG_SSCFG);
-               writel(d40c->dst_def_cfg,
-                      d40c->base->virtbase + D40_DREG_PCBASE +
-                      d40c->phy_chan->num * D40_DREG_PCDELTA +
-                      D40_CHAN_REG_SDCFG);
+               writel(d40c->src_def_cfg, chanbase + D40_CHAN_REG_SSCFG);
+               writel(d40c->dst_def_cfg, chanbase + D40_CHAN_REG_SDCFG);
 
                /* Set LIDX for lcla */
-               writel((d40c->phy_chan->num << D40_SREG_ELEM_LOG_LIDX_POS) &
-                      D40_SREG_ELEM_LOG_LIDX_MASK,
-                      d40c->base->virtbase + D40_DREG_PCBASE +
-                      d40c->phy_chan->num * D40_DREG_PCDELTA +
-                      D40_CHAN_REG_SDELT);
-
-               writel((d40c->phy_chan->num << D40_SREG_ELEM_LOG_LIDX_POS) &
-                      D40_SREG_ELEM_LOG_LIDX_MASK,
-                      d40c->base->virtbase + D40_DREG_PCBASE +
-                      d40c->phy_chan->num * D40_DREG_PCDELTA +
-                      D40_CHAN_REG_SSELT);
-
+               writel(lidx, chanbase + D40_CHAN_REG_SSELT);
+               writel(lidx, chanbase + D40_CHAN_REG_SDELT);
        }
 }
 
@@ -742,15 +957,15 @@ static u32 d40_residue(struct d40_chan *d40c)
 {
        u32 num_elt;
 
-       if (d40c->log_num != D40_PHY_CHAN)
+       if (chan_is_logical(d40c))
                num_elt = (readl(&d40c->lcpa->lcsp2) & D40_MEM_LCSP2_ECNT_MASK)
                        >> D40_MEM_LCSP2_ECNT_POS;
-       else
-               num_elt = (readl(d40c->base->virtbase + D40_DREG_PCBASE +
-                                d40c->phy_chan->num * D40_DREG_PCDELTA +
-                                D40_CHAN_REG_SDELT) &
-                          D40_SREG_ELEM_PHY_ECNT_MASK) >>
-                       D40_SREG_ELEM_PHY_ECNT_POS;
+       else {
+               u32 val = readl(chan_base(d40c) + D40_CHAN_REG_SDELT);
+               num_elt = (val & D40_SREG_ELEM_PHY_ECNT_MASK)
+                         >> D40_SREG_ELEM_PHY_ECNT_POS;
+       }
+
        return num_elt * (1 << d40c->dma_cfg.dst_info.data_width);
 }
 
@@ -758,20 +973,17 @@ static bool d40_tx_is_linked(struct d40_chan *d40c)
 {
        bool is_link;
 
-       if (d40c->log_num != D40_PHY_CHAN)
+       if (chan_is_logical(d40c))
                is_link = readl(&d40c->lcpa->lcsp3) &  D40_MEM_LCSP3_DLOS_MASK;
        else
-               is_link = readl(d40c->base->virtbase + D40_DREG_PCBASE +
-                               d40c->phy_chan->num * D40_DREG_PCDELTA +
-                               D40_CHAN_REG_SDLNK) &
-                       D40_SREG_LNK_PHYS_LNK_MASK;
+               is_link = readl(chan_base(d40c) + D40_CHAN_REG_SDLNK)
+                         & D40_SREG_LNK_PHYS_LNK_MASK;
+
        return is_link;
 }
 
-static int d40_pause(struct dma_chan *chan)
+static int d40_pause(struct d40_chan *d40c)
 {
-       struct d40_chan *d40c =
-               container_of(chan, struct d40_chan, chan);
        int res = 0;
        unsigned long flags;
 
@@ -782,7 +994,7 @@ static int d40_pause(struct dma_chan *chan)
 
        res = d40_channel_execute_command(d40c, D40_DMA_SUSPEND_REQ);
        if (res == 0) {
-               if (d40c->log_num != D40_PHY_CHAN) {
+               if (chan_is_logical(d40c)) {
                        d40_config_set_event(d40c, false);
                        /* Resume the other logical channels if any */
                        if (d40_chan_has_events(d40c))
@@ -795,10 +1007,8 @@ static int d40_pause(struct dma_chan *chan)
        return res;
 }
 
-static int d40_resume(struct dma_chan *chan)
+static int d40_resume(struct d40_chan *d40c)
 {
-       struct d40_chan *d40c =
-               container_of(chan, struct d40_chan, chan);
        int res = 0;
        unsigned long flags;
 
@@ -808,7 +1018,7 @@ static int d40_resume(struct dma_chan *chan)
        spin_lock_irqsave(&d40c->lock, flags);
 
        if (d40c->base->rev == 0)
-               if (d40c->log_num != D40_PHY_CHAN) {
+               if (chan_is_logical(d40c)) {
                        res = d40_channel_execute_command(d40c,
                                                          D40_DMA_SUSPEND_REQ);
                        goto no_suspend;
@@ -817,7 +1027,7 @@ static int d40_resume(struct dma_chan *chan)
        /* If bytes left to transfer or linked tx resume job */
        if (d40_residue(d40c) || d40_tx_is_linked(d40c)) {
 
-               if (d40c->log_num != D40_PHY_CHAN)
+               if (chan_is_logical(d40c))
                        d40_config_set_event(d40c, true);
 
                res = d40_channel_execute_command(d40c, D40_DMA_RUN);
@@ -828,75 +1038,20 @@ no_suspend:
        return res;
 }
 
-static void d40_tx_submit_log(struct d40_chan *d40c, struct d40_desc *d40d)
+static int d40_terminate_all(struct d40_chan *chan)
 {
-       /* TODO: Write */
-}
-
-static void d40_tx_submit_phy(struct d40_chan *d40c, struct d40_desc *d40d)
-{
-       struct d40_desc *d40d_prev = NULL;
-       int i;
-       u32 val;
-
-       if (!list_empty(&d40c->queue))
-               d40d_prev = d40_last_queued(d40c);
-       else if (!list_empty(&d40c->active))
-               d40d_prev = d40_first_active_get(d40c);
-
-       if (!d40d_prev)
-               return;
-
-       /* Here we try to join this job with previous jobs */
-       val = readl(d40c->base->virtbase + D40_DREG_PCBASE +
-                   d40c->phy_chan->num * D40_DREG_PCDELTA +
-                   D40_CHAN_REG_SSLNK);
-
-       /* Figure out which link we're currently transmitting */
-       for (i = 0; i < d40d_prev->lli_len; i++)
-               if (val == d40d_prev->lli_phy.src[i].reg_lnk)
-                       break;
-
-       val = readl(d40c->base->virtbase + D40_DREG_PCBASE +
-                   d40c->phy_chan->num * D40_DREG_PCDELTA +
-                   D40_CHAN_REG_SSELT) >> D40_SREG_ELEM_LOG_ECNT_POS;
-
-       if (i == (d40d_prev->lli_len - 1) && val > 0) {
-               /* Change the current one */
-               writel(virt_to_phys(d40d->lli_phy.src),
-                      d40c->base->virtbase + D40_DREG_PCBASE +
-                      d40c->phy_chan->num * D40_DREG_PCDELTA +
-                      D40_CHAN_REG_SSLNK);
-               writel(virt_to_phys(d40d->lli_phy.dst),
-                      d40c->base->virtbase + D40_DREG_PCBASE +
-                      d40c->phy_chan->num * D40_DREG_PCDELTA +
-                      D40_CHAN_REG_SDLNK);
-
-               d40d->is_hw_linked = true;
-
-       } else if (i < d40d_prev->lli_len) {
-               (void) dma_unmap_single(d40c->base->dev,
-                                       virt_to_phys(d40d_prev->lli_phy.src),
-                                       d40d_prev->lli_pool.size,
-                                       DMA_TO_DEVICE);
+       unsigned long flags;
+       int ret = 0;
 
-               /* Keep the settings */
-               val = d40d_prev->lli_phy.src[d40d_prev->lli_len - 1].reg_lnk &
-                       ~D40_SREG_LNK_PHYS_LNK_MASK;
-               d40d_prev->lli_phy.src[d40d_prev->lli_len - 1].reg_lnk =
-                       val | virt_to_phys(d40d->lli_phy.src);
+       ret = d40_pause(chan);
+       if (!ret && chan_is_physical(chan))
+               ret = d40_channel_execute_command(chan, D40_DMA_STOP);
 
-               val = d40d_prev->lli_phy.dst[d40d_prev->lli_len - 1].reg_lnk &
-                       ~D40_SREG_LNK_PHYS_LNK_MASK;
-               d40d_prev->lli_phy.dst[d40d_prev->lli_len - 1].reg_lnk =
-                       val | virt_to_phys(d40d->lli_phy.dst);
+       spin_lock_irqsave(&chan->lock, flags);
+       d40_term_all(chan);
+       spin_unlock_irqrestore(&chan->lock, flags);
 
-               (void) dma_map_single(d40c->base->dev,
-                                     d40d_prev->lli_phy.src,
-                                     d40d_prev->lli_pool.size,
-                                     DMA_TO_DEVICE);
-               d40d->is_hw_linked = true;
-       }
+       return ret;
 }
 
 static dma_cookie_t d40_tx_submit(struct dma_async_tx_descriptor *tx)
@@ -907,8 +1062,6 @@ static dma_cookie_t d40_tx_submit(struct dma_async_tx_descriptor *tx)
        struct d40_desc *d40d = container_of(tx, struct d40_desc, txd);
        unsigned long flags;
 
-       (void) d40_pause(&d40c->chan);
-
        spin_lock_irqsave(&d40c->lock, flags);
 
        d40c->chan.cookie++;
@@ -918,17 +1071,10 @@ static dma_cookie_t d40_tx_submit(struct dma_async_tx_descriptor *tx)
 
        d40d->txd.cookie = d40c->chan.cookie;
 
-       if (d40c->log_num == D40_PHY_CHAN)
-               d40_tx_submit_phy(d40c, d40d);
-       else
-               d40_tx_submit_log(d40c, d40d);
-
        d40_desc_queue(d40c, d40d);
 
        spin_unlock_irqrestore(&d40c->lock, flags);
 
-       (void) d40_resume(&d40c->chan);
-
        return tx->cookie;
 }
 
@@ -937,7 +1083,7 @@ static int d40_start(struct d40_chan *d40c)
        if (d40c->base->rev == 0) {
                int err;
 
-               if (d40c->log_num != D40_PHY_CHAN) {
+               if (chan_is_logical(d40c)) {
                        err = d40_channel_execute_command(d40c,
                                                          D40_DMA_SUSPEND_REQ);
                        if (err)
@@ -945,7 +1091,7 @@ static int d40_start(struct d40_chan *d40c)
                }
        }
 
-       if (d40c->log_num != D40_PHY_CHAN)
+       if (chan_is_logical(d40c))
                d40_config_set_event(d40c, true);
 
        return d40_channel_execute_command(d40c, D40_DMA_RUN);
@@ -968,21 +1114,14 @@ static struct d40_desc *d40_queue_start(struct d40_chan *d40c)
                /* Add to active queue */
                d40_desc_submit(d40c, d40d);
 
-               /*
-                * If this job is already linked in hw,
-                * do not submit it.
-                */
-
-               if (!d40d->is_hw_linked) {
-                       /* Initiate DMA job */
-                       d40_desc_load(d40c, d40d);
+               /* Initiate DMA job */
+               d40_desc_load(d40c, d40d);
 
-                       /* Start dma job */
-                       err = d40_start(d40c);
+               /* Start dma job */
+               err = d40_start(d40c);
 
-                       if (err)
-                               return NULL;
-               }
+               if (err)
+                       return NULL;
        }
 
        return d40d;
@@ -999,17 +1138,36 @@ static void dma_tc_handle(struct d40_chan *d40c)
        if (d40d == NULL)
                return;
 
-       d40_lcla_free_all(d40c, d40d);
+       if (d40d->cyclic) {
+               /*
+                * If this was a paritially loaded list, we need to reloaded
+                * it, and only when the list is completed.  We need to check
+                * for done because the interrupt will hit for every link, and
+                * not just the last one.
+                */
+               if (d40d->lli_current < d40d->lli_len
+                   && !d40_tx_is_linked(d40c)
+                   && !d40_residue(d40c)) {
+                       d40_lcla_free_all(d40c, d40d);
+                       d40_desc_load(d40c, d40d);
+                       (void) d40_start(d40c);
 
-       if (d40d->lli_current < d40d->lli_len) {
-               d40_desc_load(d40c, d40d);
-               /* Start dma job */
-               (void) d40_start(d40c);
-               return;
-       }
+                       if (d40d->lli_current == d40d->lli_len)
+                               d40d->lli_current = 0;
+               }
+       } else {
+               d40_lcla_free_all(d40c, d40d);
+
+               if (d40d->lli_current < d40d->lli_len) {
+                       d40_desc_load(d40c, d40d);
+                       /* Start dma job */
+                       (void) d40_start(d40c);
+                       return;
+               }
 
-       if (d40_queue_start(d40c) == NULL)
-               d40c->busy = false;
+               if (d40_queue_start(d40c) == NULL)
+                       d40c->busy = false;
+       }
 
        d40c->pending_tx++;
        tasklet_schedule(&d40c->tasklet);
@@ -1028,11 +1186,11 @@ static void dma_tasklet(unsigned long data)
 
        /* Get first active entry from list */
        d40d = d40_first_active_get(d40c);
-
        if (d40d == NULL)
                goto err;
 
-       d40c->completed = d40d->txd.cookie;
+       if (!d40d->cyclic)
+               d40c->completed = d40d->txd.cookie;
 
        /*
         * If terminating a channel pending_tx is set to zero.
@@ -1047,16 +1205,18 @@ static void dma_tasklet(unsigned long data)
        callback = d40d->txd.callback;
        callback_param = d40d->txd.callback_param;
 
-       if (async_tx_test_ack(&d40d->txd)) {
-               d40_pool_lli_free(d40d);
-               d40_desc_remove(d40d);
-               d40_desc_free(d40c, d40d);
-       } else {
-               if (!d40d->is_in_client_list) {
+       if (!d40d->cyclic) {
+               if (async_tx_test_ack(&d40d->txd)) {
+                       d40_pool_lli_free(d40c, d40d);
                        d40_desc_remove(d40d);
-                       d40_lcla_free_all(d40c, d40d);
-                       list_add_tail(&d40d->node, &d40c->client);
-                       d40d->is_in_client_list = true;
+                       d40_desc_free(d40c, d40d);
+               } else {
+                       if (!d40d->is_in_client_list) {
+                               d40_desc_remove(d40d);
+                               d40_lcla_free_all(d40c, d40d);
+                               list_add_tail(&d40d->node, &d40c->client);
+                               d40d->is_in_client_list = true;
+                       }
                }
        }
 
@@ -1073,7 +1233,7 @@ static void dma_tasklet(unsigned long data)
        return;
 
  err:
-       /* Rescue manouver if receiving double interrupts */
+       /* Rescue manoeuvre if receiving double interrupts */
        if (d40c->pending_tx > 0)
                d40c->pending_tx--;
        spin_unlock_irqrestore(&d40c->lock, flags);
@@ -1133,9 +1293,8 @@ static irqreturn_t d40_handle_interrupt(int irq, void *data)
                if (!il[row].is_error)
                        dma_tc_handle(d40c);
                else
-                       dev_err(base->dev,
-                               "[%s] IRQ chan: %ld offset %d idx %d\n",
-                               __func__, chan, il[row].offset, idx);
+                       d40_err(base->dev, "IRQ chan: %ld offset %d idx %d\n",
+                               chan, il[row].offset, idx);
 
                spin_unlock(&d40c->lock);
        }
@@ -1151,12 +1310,10 @@ static int d40_validate_conf(struct d40_chan *d40c,
        int res = 0;
        u32 dst_event_group = D40_TYPE_TO_GROUP(conf->dst_dev_type);
        u32 src_event_group = D40_TYPE_TO_GROUP(conf->src_dev_type);
-       bool is_log = (conf->channel_type & STEDMA40_CHANNEL_IN_OPER_MODE)
-               == STEDMA40_CHANNEL_IN_LOG_MODE;
+       bool is_log = conf->mode == STEDMA40_MODE_LOGICAL;
 
        if (!conf->dir) {
-               dev_err(&d40c->chan.dev->device, "[%s] Invalid direction.\n",
-                       __func__);
+               chan_err(d40c, "Invalid direction.\n");
                res = -EINVAL;
        }
 
@@ -1164,46 +1321,40 @@ static int d40_validate_conf(struct d40_chan *d40c,
            d40c->base->plat_data->dev_tx[conf->dst_dev_type] == 0 &&
            d40c->runtime_addr == 0) {
 
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Invalid TX channel address (%d)\n",
-                       __func__, conf->dst_dev_type);
+               chan_err(d40c, "Invalid TX channel address (%d)\n",
+                        conf->dst_dev_type);
                res = -EINVAL;
        }
 
        if (conf->src_dev_type != STEDMA40_DEV_SRC_MEMORY &&
            d40c->base->plat_data->dev_rx[conf->src_dev_type] == 0 &&
            d40c->runtime_addr == 0) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Invalid RX channel address (%d)\n",
-                       __func__, conf->src_dev_type);
+               chan_err(d40c, "Invalid RX channel address (%d)\n",
+                       conf->src_dev_type);
                res = -EINVAL;
        }
 
        if (conf->dir == STEDMA40_MEM_TO_PERIPH &&
            dst_event_group == STEDMA40_DEV_DST_MEMORY) {
-               dev_err(&d40c->chan.dev->device, "[%s] Invalid dst\n",
-                       __func__);
+               chan_err(d40c, "Invalid dst\n");
                res = -EINVAL;
        }
 
        if (conf->dir == STEDMA40_PERIPH_TO_MEM &&
            src_event_group == STEDMA40_DEV_SRC_MEMORY) {
-               dev_err(&d40c->chan.dev->device, "[%s] Invalid src\n",
-                       __func__);
+               chan_err(d40c, "Invalid src\n");
                res = -EINVAL;
        }
 
        if (src_event_group == STEDMA40_DEV_SRC_MEMORY &&
            dst_event_group == STEDMA40_DEV_DST_MEMORY && is_log) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] No event line\n", __func__);
+               chan_err(d40c, "No event line\n");
                res = -EINVAL;
        }
 
        if (conf->dir == STEDMA40_PERIPH_TO_PERIPH &&
            (src_event_group != dst_event_group)) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Invalid event group\n", __func__);
+               chan_err(d40c, "Invalid event group\n");
                res = -EINVAL;
        }
 
@@ -1212,9 +1363,20 @@ static int d40_validate_conf(struct d40_chan *d40c,
                 * DMAC HW supports it. Will be added to this driver,
                 * in case any dma client requires it.
                 */
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] periph to periph not supported\n",
-                       __func__);
+               chan_err(d40c, "periph to periph not supported\n");
+               res = -EINVAL;
+       }
+
+       if (d40_psize_2_burst_size(is_log, conf->src_info.psize) *
+           (1 << conf->src_info.data_width) !=
+           d40_psize_2_burst_size(is_log, conf->dst_info.psize) *
+           (1 << conf->dst_info.data_width)) {
+               /*
+                * The DMAC hardware only supports
+                * src (burst x width) == dst (burst x width)
+                */
+
+               chan_err(d40c, "src (burst x width) != dst (burst x width)\n");
                res = -EINVAL;
        }
 
@@ -1316,10 +1478,7 @@ static int d40_allocate_channel(struct d40_chan *d40c)
        int j;
        int log_num;
        bool is_src;
-       bool is_log = (d40c->dma_cfg.channel_type &
-                      STEDMA40_CHANNEL_IN_OPER_MODE)
-               == STEDMA40_CHANNEL_IN_LOG_MODE;
-
+       bool is_log = d40c->dma_cfg.mode == STEDMA40_MODE_LOGICAL;
 
        phys = d40c->base->phy_res;
 
@@ -1420,8 +1579,7 @@ static int d40_config_memcpy(struct d40_chan *d40c)
                   dma_has_cap(DMA_SLAVE, cap)) {
                d40c->dma_cfg = *d40c->base->plat_data->memcpy_conf_phy;
        } else {
-               dev_err(&d40c->chan.dev->device, "[%s] No memcpy\n",
-                       __func__);
+               chan_err(d40c, "No memcpy\n");
                return -EINVAL;
        }
 
@@ -1446,21 +1604,19 @@ static int d40_free_dma(struct d40_chan *d40c)
        /* Release client owned descriptors */
        if (!list_empty(&d40c->client))
                list_for_each_entry_safe(d, _d, &d40c->client, node) {
-                       d40_pool_lli_free(d);
+                       d40_pool_lli_free(d40c, d);
                        d40_desc_remove(d);
                        d40_desc_free(d40c, d);
                }
 
        if (phy == NULL) {
-               dev_err(&d40c->chan.dev->device, "[%s] phy == null\n",
-                       __func__);
+               chan_err(d40c, "phy == null\n");
                return -EINVAL;
        }
 
        if (phy->allocated_src == D40_ALLOC_FREE &&
            phy->allocated_dst == D40_ALLOC_FREE) {
-               dev_err(&d40c->chan.dev->device, "[%s] channel already free\n",
-                       __func__);
+               chan_err(d40c, "channel already free\n");
                return -EINVAL;
        }
 
@@ -1472,19 +1628,17 @@ static int d40_free_dma(struct d40_chan *d40c)
                event = D40_TYPE_TO_EVENT(d40c->dma_cfg.src_dev_type);
                is_src = true;
        } else {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Unknown direction\n", __func__);
+               chan_err(d40c, "Unknown direction\n");
                return -EINVAL;
        }
 
        res = d40_channel_execute_command(d40c, D40_DMA_SUSPEND_REQ);
        if (res) {
-               dev_err(&d40c->chan.dev->device, "[%s] suspend failed\n",
-                       __func__);
+               chan_err(d40c, "suspend failed\n");
                return res;
        }
 
-       if (d40c->log_num != D40_PHY_CHAN) {
+       if (chan_is_logical(d40c)) {
                /* Release logical channel, deactivate the event line */
 
                d40_config_set_event(d40c, false);
@@ -1500,9 +1654,8 @@ static int d40_free_dma(struct d40_chan *d40c)
                                res = d40_channel_execute_command(d40c,
                                                                  D40_DMA_RUN);
                                if (res) {
-                                       dev_err(&d40c->chan.dev->device,
-                                               "[%s] Executing RUN command\n",
-                                               __func__);
+                                       chan_err(d40c,
+                                               "Executing RUN command\n");
                                        return res;
                                }
                        }
@@ -1515,8 +1668,7 @@ static int d40_free_dma(struct d40_chan *d40c)
        /* Release physical channel */
        res = d40_channel_execute_command(d40c, D40_DMA_STOP);
        if (res) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Failed to stop channel\n", __func__);
+               chan_err(d40c, "Failed to stop channel\n");
                return res;
        }
        d40c->phy_chan = NULL;
@@ -1528,6 +1680,7 @@ static int d40_free_dma(struct d40_chan *d40c)
 
 static bool d40_is_paused(struct d40_chan *d40c)
 {
+       void __iomem *chanbase = chan_base(d40c);
        bool is_paused = false;
        unsigned long flags;
        void __iomem *active_reg;
@@ -1536,7 +1689,7 @@ static bool d40_is_paused(struct d40_chan *d40c)
 
        spin_lock_irqsave(&d40c->lock, flags);
 
-       if (d40c->log_num == D40_PHY_CHAN) {
+       if (chan_is_physical(d40c)) {
                if (d40c->phy_chan->num % 2 == 0)
                        active_reg = d40c->base->virtbase + D40_DREG_ACTIVE;
                else
@@ -1554,17 +1707,12 @@ static bool d40_is_paused(struct d40_chan *d40c)
        if (d40c->dma_cfg.dir == STEDMA40_MEM_TO_PERIPH ||
            d40c->dma_cfg.dir == STEDMA40_MEM_TO_MEM) {
                event = D40_TYPE_TO_EVENT(d40c->dma_cfg.dst_dev_type);
-               status = readl(d40c->base->virtbase + D40_DREG_PCBASE +
-                              d40c->phy_chan->num * D40_DREG_PCDELTA +
-                              D40_CHAN_REG_SDLNK);
+               status = readl(chanbase + D40_CHAN_REG_SDLNK);
        } else if (d40c->dma_cfg.dir == STEDMA40_PERIPH_TO_MEM) {
                event = D40_TYPE_TO_EVENT(d40c->dma_cfg.src_dev_type);
-               status = readl(d40c->base->virtbase + D40_DREG_PCBASE +
-                              d40c->phy_chan->num * D40_DREG_PCDELTA +
-                              D40_CHAN_REG_SSLNK);
+               status = readl(chanbase + D40_CHAN_REG_SSLNK);
        } else {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Unknown direction\n", __func__);
+               chan_err(d40c, "Unknown direction\n");
                goto _exit;
        }
 
@@ -1594,102 +1742,184 @@ static u32 stedma40_residue(struct dma_chan *chan)
        return bytes_left;
 }
 
-struct dma_async_tx_descriptor *stedma40_memcpy_sg(struct dma_chan *chan,
-                                                  struct scatterlist *sgl_dst,
-                                                  struct scatterlist *sgl_src,
-                                                  unsigned int sgl_len,
-                                                  unsigned long dma_flags)
+static int
+d40_prep_sg_log(struct d40_chan *chan, struct d40_desc *desc,
+               struct scatterlist *sg_src, struct scatterlist *sg_dst,
+               unsigned int sg_len, dma_addr_t src_dev_addr,
+               dma_addr_t dst_dev_addr)
 {
-       int res;
-       struct d40_desc *d40d;
-       struct d40_chan *d40c = container_of(chan, struct d40_chan,
-                                            chan);
-       unsigned long flags;
+       struct stedma40_chan_cfg *cfg = &chan->dma_cfg;
+       struct stedma40_half_channel_info *src_info = &cfg->src_info;
+       struct stedma40_half_channel_info *dst_info = &cfg->dst_info;
+       int ret;
 
-       if (d40c->phy_chan == NULL) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Unallocated channel.\n", __func__);
-               return ERR_PTR(-EINVAL);
-       }
+       ret = d40_log_sg_to_lli(sg_src, sg_len,
+                               src_dev_addr,
+                               desc->lli_log.src,
+                               chan->log_def.lcsp1,
+                               src_info->data_width,
+                               dst_info->data_width);
 
-       spin_lock_irqsave(&d40c->lock, flags);
-       d40d = d40_desc_get(d40c);
+       ret = d40_log_sg_to_lli(sg_dst, sg_len,
+                               dst_dev_addr,
+                               desc->lli_log.dst,
+                               chan->log_def.lcsp3,
+                               dst_info->data_width,
+                               src_info->data_width);
 
-       if (d40d == NULL)
+       return ret < 0 ? ret : 0;
+}
+
+static int
+d40_prep_sg_phy(struct d40_chan *chan, struct d40_desc *desc,
+               struct scatterlist *sg_src, struct scatterlist *sg_dst,
+               unsigned int sg_len, dma_addr_t src_dev_addr,
+               dma_addr_t dst_dev_addr)
+{
+       struct stedma40_chan_cfg *cfg = &chan->dma_cfg;
+       struct stedma40_half_channel_info *src_info = &cfg->src_info;
+       struct stedma40_half_channel_info *dst_info = &cfg->dst_info;
+       unsigned long flags = 0;
+       int ret;
+
+       if (desc->cyclic)
+               flags |= LLI_CYCLIC | LLI_TERM_INT;
+
+       ret = d40_phy_sg_to_lli(sg_src, sg_len, src_dev_addr,
+                               desc->lli_phy.src,
+                               virt_to_phys(desc->lli_phy.src),
+                               chan->src_def_cfg,
+                               src_info, dst_info, flags);
+
+       ret = d40_phy_sg_to_lli(sg_dst, sg_len, dst_dev_addr,
+                               desc->lli_phy.dst,
+                               virt_to_phys(desc->lli_phy.dst),
+                               chan->dst_def_cfg,
+                               dst_info, src_info, flags);
+
+       dma_sync_single_for_device(chan->base->dev, desc->lli_pool.dma_addr,
+                                  desc->lli_pool.size, DMA_TO_DEVICE);
+
+       return ret < 0 ? ret : 0;
+}
+
+
+static struct d40_desc *
+d40_prep_desc(struct d40_chan *chan, struct scatterlist *sg,
+             unsigned int sg_len, unsigned long dma_flags)
+{
+       struct stedma40_chan_cfg *cfg = &chan->dma_cfg;
+       struct d40_desc *desc;
+       int ret;
+
+       desc = d40_desc_get(chan);
+       if (!desc)
+               return NULL;
+
+       desc->lli_len = d40_sg_2_dmalen(sg, sg_len, cfg->src_info.data_width,
+                                       cfg->dst_info.data_width);
+       if (desc->lli_len < 0) {
+               chan_err(chan, "Unaligned size\n");
                goto err;
+       }
 
-       d40d->lli_len = sgl_len;
-       d40d->lli_current = 0;
-       d40d->txd.flags = dma_flags;
+       ret = d40_pool_lli_alloc(chan, desc, desc->lli_len);
+       if (ret < 0) {
+               chan_err(chan, "Could not allocate lli\n");
+               goto err;
+       }
 
-       if (d40c->log_num != D40_PHY_CHAN) {
 
-               if (d40_pool_lli_alloc(d40d, sgl_len, true) < 0) {
-                       dev_err(&d40c->chan.dev->device,
-                               "[%s] Out of memory\n", __func__);
-                       goto err;
-               }
+       desc->lli_current = 0;
+       desc->txd.flags = dma_flags;
+       desc->txd.tx_submit = d40_tx_submit;
 
-               (void) d40_log_sg_to_lli(sgl_src,
-                                        sgl_len,
-                                        d40d->lli_log.src,
-                                        d40c->log_def.lcsp1,
-                                        d40c->dma_cfg.src_info.data_width);
-
-               (void) d40_log_sg_to_lli(sgl_dst,
-                                        sgl_len,
-                                        d40d->lli_log.dst,
-                                        d40c->log_def.lcsp3,
-                                        d40c->dma_cfg.dst_info.data_width);
-       } else {
-               if (d40_pool_lli_alloc(d40d, sgl_len, false) < 0) {
-                       dev_err(&d40c->chan.dev->device,
-                               "[%s] Out of memory\n", __func__);
-                       goto err;
-               }
+       dma_async_tx_descriptor_init(&desc->txd, &chan->chan);
 
-               res = d40_phy_sg_to_lli(sgl_src,
-                                       sgl_len,
-                                       0,
-                                       d40d->lli_phy.src,
-                                       virt_to_phys(d40d->lli_phy.src),
-                                       d40c->src_def_cfg,
-                                       d40c->dma_cfg.src_info.data_width,
-                                       d40c->dma_cfg.src_info.psize);
+       return desc;
 
-               if (res < 0)
-                       goto err;
+err:
+       d40_desc_free(chan, desc);
+       return NULL;
+}
 
-               res = d40_phy_sg_to_lli(sgl_dst,
-                                       sgl_len,
-                                       0,
-                                       d40d->lli_phy.dst,
-                                       virt_to_phys(d40d->lli_phy.dst),
-                                       d40c->dst_def_cfg,
-                                       d40c->dma_cfg.dst_info.data_width,
-                                       d40c->dma_cfg.dst_info.psize);
+static dma_addr_t
+d40_get_dev_addr(struct d40_chan *chan, enum dma_data_direction direction)
+{
+       struct stedma40_platform_data *plat = chan->base->plat_data;
+       struct stedma40_chan_cfg *cfg = &chan->dma_cfg;
+       dma_addr_t addr = 0;
 
-               if (res < 0)
-                       goto err;
+       if (chan->runtime_addr)
+               return chan->runtime_addr;
 
-               (void) dma_map_single(d40c->base->dev, d40d->lli_phy.src,
-                                     d40d->lli_pool.size, DMA_TO_DEVICE);
+       if (direction == DMA_FROM_DEVICE)
+               addr = plat->dev_rx[cfg->src_dev_type];
+       else if (direction == DMA_TO_DEVICE)
+               addr = plat->dev_tx[cfg->dst_dev_type];
+
+       return addr;
+}
+
+static struct dma_async_tx_descriptor *
+d40_prep_sg(struct dma_chan *dchan, struct scatterlist *sg_src,
+           struct scatterlist *sg_dst, unsigned int sg_len,
+           enum dma_data_direction direction, unsigned long dma_flags)
+{
+       struct d40_chan *chan = container_of(dchan, struct d40_chan, chan);
+       dma_addr_t src_dev_addr = 0;
+       dma_addr_t dst_dev_addr = 0;
+       struct d40_desc *desc;
+       unsigned long flags;
+       int ret;
+
+       if (!chan->phy_chan) {
+               chan_err(chan, "Cannot prepare unallocated channel\n");
+               return NULL;
        }
 
-       dma_async_tx_descriptor_init(&d40d->txd, chan);
 
-       d40d->txd.tx_submit = d40_tx_submit;
+       spin_lock_irqsave(&chan->lock, flags);
 
-       spin_unlock_irqrestore(&d40c->lock, flags);
+       desc = d40_prep_desc(chan, sg_src, sg_len, dma_flags);
+       if (desc == NULL)
+               goto err;
+
+       if (sg_next(&sg_src[sg_len - 1]) == sg_src)
+               desc->cyclic = true;
+
+       if (direction != DMA_NONE) {
+               dma_addr_t dev_addr = d40_get_dev_addr(chan, direction);
+
+               if (direction == DMA_FROM_DEVICE)
+                       src_dev_addr = dev_addr;
+               else if (direction == DMA_TO_DEVICE)
+                       dst_dev_addr = dev_addr;
+       }
+
+       if (chan_is_logical(chan))
+               ret = d40_prep_sg_log(chan, desc, sg_src, sg_dst,
+                                     sg_len, src_dev_addr, dst_dev_addr);
+       else
+               ret = d40_prep_sg_phy(chan, desc, sg_src, sg_dst,
+                                     sg_len, src_dev_addr, dst_dev_addr);
+
+       if (ret) {
+               chan_err(chan, "Failed to prepare %s sg job: %d\n",
+                        chan_is_logical(chan) ? "log" : "phy", ret);
+               goto err;
+       }
+
+       spin_unlock_irqrestore(&chan->lock, flags);
+
+       return &desc->txd;
 
-       return &d40d->txd;
 err:
-       if (d40d)
-               d40_desc_free(d40c, d40d);
-       spin_unlock_irqrestore(&d40c->lock, flags);
+       if (desc)
+               d40_desc_free(chan, desc);
+       spin_unlock_irqrestore(&chan->lock, flags);
        return NULL;
 }
-EXPORT_SYMBOL(stedma40_memcpy_sg);
 
 bool stedma40_filter(struct dma_chan *chan, void *data)
 {
@@ -1712,6 +1942,38 @@ bool stedma40_filter(struct dma_chan *chan, void *data)
 }
 EXPORT_SYMBOL(stedma40_filter);
 
+static void __d40_set_prio_rt(struct d40_chan *d40c, int dev_type, bool src)
+{
+       bool realtime = d40c->dma_cfg.realtime;
+       bool highprio = d40c->dma_cfg.high_priority;
+       u32 prioreg = highprio ? D40_DREG_PSEG1 : D40_DREG_PCEG1;
+       u32 rtreg = realtime ? D40_DREG_RSEG1 : D40_DREG_RCEG1;
+       u32 event = D40_TYPE_TO_EVENT(dev_type);
+       u32 group = D40_TYPE_TO_GROUP(dev_type);
+       u32 bit = 1 << event;
+
+       /* Destination event lines are stored in the upper halfword */
+       if (!src)
+               bit <<= 16;
+
+       writel(bit, d40c->base->virtbase + prioreg + group * 4);
+       writel(bit, d40c->base->virtbase + rtreg + group * 4);
+}
+
+static void d40_set_prio_realtime(struct d40_chan *d40c)
+{
+       if (d40c->base->rev < 3)
+               return;
+
+       if ((d40c->dma_cfg.dir ==  STEDMA40_PERIPH_TO_MEM) ||
+           (d40c->dma_cfg.dir == STEDMA40_PERIPH_TO_PERIPH))
+               __d40_set_prio_rt(d40c, d40c->dma_cfg.src_dev_type, true);
+
+       if ((d40c->dma_cfg.dir ==  STEDMA40_MEM_TO_PERIPH) ||
+           (d40c->dma_cfg.dir == STEDMA40_PERIPH_TO_PERIPH))
+               __d40_set_prio_rt(d40c, d40c->dma_cfg.dst_dev_type, false);
+}
+
 /* DMA ENGINE functions */
 static int d40_alloc_chan_resources(struct dma_chan *chan)
 {
@@ -1728,9 +1990,7 @@ static int d40_alloc_chan_resources(struct dma_chan *chan)
        if (!d40c->configured) {
                err = d40_config_memcpy(d40c);
                if (err) {
-                       dev_err(&d40c->chan.dev->device,
-                               "[%s] Failed to configure memcpy channel\n",
-                               __func__);
+                       chan_err(d40c, "Failed to configure memcpy channel\n");
                        goto fail;
                }
        }
@@ -1738,16 +1998,17 @@ static int d40_alloc_chan_resources(struct dma_chan *chan)
 
        err = d40_allocate_channel(d40c);
        if (err) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Failed to allocate channel\n", __func__);
+               chan_err(d40c, "Failed to allocate channel\n");
                goto fail;
        }
 
        /* Fill in basic CFG register values */
        d40_phy_cfg(&d40c->dma_cfg, &d40c->src_def_cfg,
-                   &d40c->dst_def_cfg, d40c->log_num != D40_PHY_CHAN);
+                   &d40c->dst_def_cfg, chan_is_logical(d40c));
+
+       d40_set_prio_realtime(d40c);
 
-       if (d40c->log_num != D40_PHY_CHAN) {
+       if (chan_is_logical(d40c)) {
                d40_log_cfg(&d40c->dma_cfg,
                            &d40c->log_def.lcsp1, &d40c->log_def.lcsp3);
 
@@ -1780,8 +2041,7 @@ static void d40_free_chan_resources(struct dma_chan *chan)
        unsigned long flags;
 
        if (d40c->phy_chan == NULL) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Cannot free unallocated channel\n", __func__);
+               chan_err(d40c, "Cannot free unallocated channel\n");
                return;
        }
 
@@ -1791,8 +2051,7 @@ static void d40_free_chan_resources(struct dma_chan *chan)
        err = d40_free_dma(d40c);
 
        if (err)
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Failed to free channel\n", __func__);
+               chan_err(d40c, "Failed to free channel\n");
        spin_unlock_irqrestore(&d40c->lock, flags);
 }
 
@@ -1802,214 +2061,31 @@ static struct dma_async_tx_descriptor *d40_prep_memcpy(struct dma_chan *chan,
                                                       size_t size,
                                                       unsigned long dma_flags)
 {
-       struct d40_desc *d40d;
-       struct d40_chan *d40c = container_of(chan, struct d40_chan,
-                                            chan);
-       unsigned long flags;
-       int err = 0;
+       struct scatterlist dst_sg;
+       struct scatterlist src_sg;
 
-       if (d40c->phy_chan == NULL) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Channel is not allocated.\n", __func__);
-               return ERR_PTR(-EINVAL);
-       }
-
-       spin_lock_irqsave(&d40c->lock, flags);
-       d40d = d40_desc_get(d40c);
+       sg_init_table(&dst_sg, 1);
+       sg_init_table(&src_sg, 1);
 
-       if (d40d == NULL) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Descriptor is NULL\n", __func__);
-               goto err;
-       }
+       sg_dma_address(&dst_sg) = dst;
+       sg_dma_address(&src_sg) = src;
 
-       d40d->txd.flags = dma_flags;
-
-       dma_async_tx_descriptor_init(&d40d->txd, chan);
-
-       d40d->txd.tx_submit = d40_tx_submit;
-
-       if (d40c->log_num != D40_PHY_CHAN) {
-
-               if (d40_pool_lli_alloc(d40d, 1, true) < 0) {
-                       dev_err(&d40c->chan.dev->device,
-                               "[%s] Out of memory\n", __func__);
-                       goto err;
-               }
-               d40d->lli_len = 1;
-               d40d->lli_current = 0;
-
-               d40_log_fill_lli(d40d->lli_log.src,
-                                src,
-                                size,
-                                d40c->log_def.lcsp1,
-                                d40c->dma_cfg.src_info.data_width,
-                                true);
-
-               d40_log_fill_lli(d40d->lli_log.dst,
-                                dst,
-                                size,
-                                d40c->log_def.lcsp3,
-                                d40c->dma_cfg.dst_info.data_width,
-                                true);
-
-       } else {
-
-               if (d40_pool_lli_alloc(d40d, 1, false) < 0) {
-                       dev_err(&d40c->chan.dev->device,
-                               "[%s] Out of memory\n", __func__);
-                       goto err;
-               }
-
-               err = d40_phy_fill_lli(d40d->lli_phy.src,
-                                      src,
-                                      size,
-                                      d40c->dma_cfg.src_info.psize,
-                                      0,
-                                      d40c->src_def_cfg,
-                                      true,
-                                      d40c->dma_cfg.src_info.data_width,
-                                      false);
-               if (err)
-                       goto err_fill_lli;
-
-               err = d40_phy_fill_lli(d40d->lli_phy.dst,
-                                      dst,
-                                      size,
-                                      d40c->dma_cfg.dst_info.psize,
-                                      0,
-                                      d40c->dst_def_cfg,
-                                      true,
-                                      d40c->dma_cfg.dst_info.data_width,
-                                      false);
+       sg_dma_len(&dst_sg) = size;
+       sg_dma_len(&src_sg) = size;
 
-               if (err)
-                       goto err_fill_lli;
-
-               (void) dma_map_single(d40c->base->dev, d40d->lli_phy.src,
-                                     d40d->lli_pool.size, DMA_TO_DEVICE);
-       }
-
-       spin_unlock_irqrestore(&d40c->lock, flags);
-       return &d40d->txd;
-
-err_fill_lli:
-       dev_err(&d40c->chan.dev->device,
-               "[%s] Failed filling in PHY LLI\n", __func__);
-err:
-       if (d40d)
-               d40_desc_free(d40c, d40d);
-       spin_unlock_irqrestore(&d40c->lock, flags);
-       return NULL;
+       return d40_prep_sg(chan, &src_sg, &dst_sg, 1, DMA_NONE, dma_flags);
 }
 
-static int d40_prep_slave_sg_log(struct d40_desc *d40d,
-                                struct d40_chan *d40c,
-                                struct scatterlist *sgl,
-                                unsigned int sg_len,
-                                enum dma_data_direction direction,
-                                unsigned long dma_flags)
+static struct dma_async_tx_descriptor *
+d40_prep_memcpy_sg(struct dma_chan *chan,
+                  struct scatterlist *dst_sg, unsigned int dst_nents,
+                  struct scatterlist *src_sg, unsigned int src_nents,
+                  unsigned long dma_flags)
 {
-       dma_addr_t dev_addr = 0;
-       int total_size;
-
-       if (d40_pool_lli_alloc(d40d, sg_len, true) < 0) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Out of memory\n", __func__);
-               return -ENOMEM;
-       }
-
-       d40d->lli_len = sg_len;
-       d40d->lli_current = 0;
-
-       if (direction == DMA_FROM_DEVICE)
-               if (d40c->runtime_addr)
-                       dev_addr = d40c->runtime_addr;
-               else
-                       dev_addr = d40c->base->plat_data->dev_rx[d40c->dma_cfg.src_dev_type];
-       else if (direction == DMA_TO_DEVICE)
-               if (d40c->runtime_addr)
-                       dev_addr = d40c->runtime_addr;
-               else
-                       dev_addr = d40c->base->plat_data->dev_tx[d40c->dma_cfg.dst_dev_type];
-
-       else
-               return -EINVAL;
-
-       total_size = d40_log_sg_to_dev(sgl, sg_len,
-                                      &d40d->lli_log,
-                                      &d40c->log_def,
-                                      d40c->dma_cfg.src_info.data_width,
-                                      d40c->dma_cfg.dst_info.data_width,
-                                      direction,
-                                      dev_addr);
-
-       if (total_size < 0)
-               return -EINVAL;
-
-       return 0;
-}
-
-static int d40_prep_slave_sg_phy(struct d40_desc *d40d,
-                                struct d40_chan *d40c,
-                                struct scatterlist *sgl,
-                                unsigned int sgl_len,
-                                enum dma_data_direction direction,
-                                unsigned long dma_flags)
-{
-       dma_addr_t src_dev_addr;
-       dma_addr_t dst_dev_addr;
-       int res;
-
-       if (d40_pool_lli_alloc(d40d, sgl_len, false) < 0) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Out of memory\n", __func__);
-               return -ENOMEM;
-       }
-
-       d40d->lli_len = sgl_len;
-       d40d->lli_current = 0;
-
-       if (direction == DMA_FROM_DEVICE) {
-               dst_dev_addr = 0;
-               if (d40c->runtime_addr)
-                       src_dev_addr = d40c->runtime_addr;
-               else
-                       src_dev_addr = d40c->base->plat_data->dev_rx[d40c->dma_cfg.src_dev_type];
-       } else if (direction == DMA_TO_DEVICE) {
-               if (d40c->runtime_addr)
-                       dst_dev_addr = d40c->runtime_addr;
-               else
-                       dst_dev_addr = d40c->base->plat_data->dev_tx[d40c->dma_cfg.dst_dev_type];
-               src_dev_addr = 0;
-       } else
-               return -EINVAL;
-
-       res = d40_phy_sg_to_lli(sgl,
-                               sgl_len,
-                               src_dev_addr,
-                               d40d->lli_phy.src,
-                               virt_to_phys(d40d->lli_phy.src),
-                               d40c->src_def_cfg,
-                               d40c->dma_cfg.src_info.data_width,
-                               d40c->dma_cfg.src_info.psize);
-       if (res < 0)
-               return res;
-
-       res = d40_phy_sg_to_lli(sgl,
-                               sgl_len,
-                               dst_dev_addr,
-                               d40d->lli_phy.dst,
-                               virt_to_phys(d40d->lli_phy.dst),
-                               d40c->dst_def_cfg,
-                               d40c->dma_cfg.dst_info.data_width,
-                               d40c->dma_cfg.dst_info.psize);
-       if (res < 0)
-               return res;
+       if (dst_nents != src_nents)
+               return NULL;
 
-       (void) dma_map_single(d40c->base->dev, d40d->lli_phy.src,
-                             d40d->lli_pool.size, DMA_TO_DEVICE);
-       return 0;
+       return d40_prep_sg(chan, src_sg, dst_sg, src_nents, DMA_NONE, dma_flags);
 }
 
 static struct dma_async_tx_descriptor *d40_prep_slave_sg(struct dma_chan *chan,
@@ -2018,52 +2094,40 @@ static struct dma_async_tx_descriptor *d40_prep_slave_sg(struct dma_chan *chan,
                                                         enum dma_data_direction direction,
                                                         unsigned long dma_flags)
 {
-       struct d40_desc *d40d;
-       struct d40_chan *d40c = container_of(chan, struct d40_chan,
-                                            chan);
-       unsigned long flags;
-       int err;
-
-       if (d40c->phy_chan == NULL) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Cannot prepare unallocated channel\n", __func__);
-               return ERR_PTR(-EINVAL);
-       }
+       if (direction != DMA_FROM_DEVICE && direction != DMA_TO_DEVICE)
+               return NULL;
 
-       spin_lock_irqsave(&d40c->lock, flags);
-       d40d = d40_desc_get(d40c);
+       return d40_prep_sg(chan, sgl, sgl, sg_len, direction, dma_flags);
+}
 
-       if (d40d == NULL)
-               goto err;
+static struct dma_async_tx_descriptor *
+dma40_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t dma_addr,
+                    size_t buf_len, size_t period_len,
+                    enum dma_data_direction direction)
+{
+       unsigned int periods = buf_len / period_len;
+       struct dma_async_tx_descriptor *txd;
+       struct scatterlist *sg;
+       int i;
 
-       if (d40c->log_num != D40_PHY_CHAN)
-               err = d40_prep_slave_sg_log(d40d, d40c, sgl, sg_len,
-                                           direction, dma_flags);
-       else
-               err = d40_prep_slave_sg_phy(d40d, d40c, sgl, sg_len,
-                                           direction, dma_flags);
-       if (err) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Failed to prepare %s slave sg job: %d\n",
-                       __func__,
-                       d40c->log_num != D40_PHY_CHAN ? "log" : "phy", err);
-               goto err;
+       sg = kcalloc(periods + 1, sizeof(struct scatterlist), GFP_KERNEL);
+       for (i = 0; i < periods; i++) {
+               sg_dma_address(&sg[i]) = dma_addr;
+               sg_dma_len(&sg[i]) = period_len;
+               dma_addr += period_len;
        }
 
-       d40d->txd.flags = dma_flags;
+       sg[periods].offset = 0;
+       sg[periods].length = 0;
+       sg[periods].page_link =
+               ((unsigned long)sg | 0x01) & ~0x02;
 
-       dma_async_tx_descriptor_init(&d40d->txd, chan);
+       txd = d40_prep_sg(chan, sg, sg, periods, direction,
+                         DMA_PREP_INTERRUPT);
 
-       d40d->txd.tx_submit = d40_tx_submit;
+       kfree(sg);
 
-       spin_unlock_irqrestore(&d40c->lock, flags);
-       return &d40d->txd;
-
-err:
-       if (d40d)
-               d40_desc_free(d40c, d40d);
-       spin_unlock_irqrestore(&d40c->lock, flags);
-       return NULL;
+       return txd;
 }
 
 static enum dma_status d40_tx_status(struct dma_chan *chan,
@@ -2076,9 +2140,7 @@ static enum dma_status d40_tx_status(struct dma_chan *chan,
        int ret;
 
        if (d40c->phy_chan == NULL) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Cannot read status of unallocated channel\n",
-                       __func__);
+               chan_err(d40c, "Cannot read status of unallocated channel\n");
                return -EINVAL;
        }
 
@@ -2102,14 +2164,15 @@ static void d40_issue_pending(struct dma_chan *chan)
        unsigned long flags;
 
        if (d40c->phy_chan == NULL) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Channel is not allocated!\n", __func__);
+               chan_err(d40c, "Channel is not allocated!\n");
                return;
        }
 
        spin_lock_irqsave(&d40c->lock, flags);
 
-       /* Busy means that pending jobs are already being processed */
+       list_splice_tail_init(&d40c->pending_queue, &d40c->queue);
+
+       /* Busy means that queued jobs are already being processed */
        if (!d40c->busy)
                (void) d40_queue_start(d40c);
 
@@ -2196,7 +2259,7 @@ static void d40_set_runtime_config(struct dma_chan *chan,
                return;
        }
 
-       if (d40c->log_num != D40_PHY_CHAN) {
+       if (chan_is_logical(d40c)) {
                if (config_maxburst >= 16)
                        psize = STEDMA40_PSIZE_LOG_16;
                else if (config_maxburst >= 8)
@@ -2212,6 +2275,8 @@ static void d40_set_runtime_config(struct dma_chan *chan,
                        psize = STEDMA40_PSIZE_PHY_8;
                else if (config_maxburst >= 4)
                        psize = STEDMA40_PSIZE_PHY_4;
+               else if (config_maxburst >= 2)
+                       psize = STEDMA40_PSIZE_PHY_2;
                else
                        psize = STEDMA40_PSIZE_PHY_1;
        }
@@ -2219,15 +2284,15 @@ static void d40_set_runtime_config(struct dma_chan *chan,
        /* Set up all the endpoint configs */
        cfg->src_info.data_width = addr_width;
        cfg->src_info.psize = psize;
-       cfg->src_info.endianess = STEDMA40_LITTLE_ENDIAN;
+       cfg->src_info.big_endian = false;
        cfg->src_info.flow_ctrl = STEDMA40_NO_FLOW_CTRL;
        cfg->dst_info.data_width = addr_width;
        cfg->dst_info.psize = psize;
-       cfg->dst_info.endianess = STEDMA40_LITTLE_ENDIAN;
+       cfg->dst_info.big_endian = false;
        cfg->dst_info.flow_ctrl = STEDMA40_NO_FLOW_CTRL;
 
        /* Fill in register values */
-       if (d40c->log_num != D40_PHY_CHAN)
+       if (chan_is_logical(d40c))
                d40_log_cfg(cfg, &d40c->log_def.lcsp1, &d40c->log_def.lcsp3);
        else
                d40_phy_cfg(cfg, &d40c->src_def_cfg,
@@ -2248,25 +2313,20 @@ static void d40_set_runtime_config(struct dma_chan *chan,
 static int d40_control(struct dma_chan *chan, enum dma_ctrl_cmd cmd,
                       unsigned long arg)
 {
-       unsigned long flags;
        struct d40_chan *d40c = container_of(chan, struct d40_chan, chan);
 
        if (d40c->phy_chan == NULL) {
-               dev_err(&d40c->chan.dev->device,
-                       "[%s] Channel is not allocated!\n", __func__);
+               chan_err(d40c, "Channel is not allocated!\n");
                return -EINVAL;
        }
 
        switch (cmd) {
        case DMA_TERMINATE_ALL:
-               spin_lock_irqsave(&d40c->lock, flags);
-               d40_term_all(d40c);
-               spin_unlock_irqrestore(&d40c->lock, flags);
-               return 0;
+               return d40_terminate_all(d40c);
        case DMA_PAUSE:
-               return d40_pause(chan);
+               return d40_pause(d40c);
        case DMA_RESUME:
-               return d40_resume(chan);
+               return d40_resume(d40c);
        case DMA_SLAVE_CONFIG:
                d40_set_runtime_config(chan,
                        (struct dma_slave_config *) arg);
@@ -2301,6 +2361,7 @@ static void __init d40_chan_init(struct d40_base *base, struct dma_device *dma,
 
                INIT_LIST_HEAD(&d40c->active);
                INIT_LIST_HEAD(&d40c->queue);
+               INIT_LIST_HEAD(&d40c->pending_queue);
                INIT_LIST_HEAD(&d40c->client);
 
                tasklet_init(&d40c->tasklet, dma_tasklet,
@@ -2311,6 +2372,35 @@ static void __init d40_chan_init(struct d40_base *base, struct dma_device *dma,
        }
 }
 
+static void d40_ops_init(struct d40_base *base, struct dma_device *dev)
+{
+       if (dma_has_cap(DMA_SLAVE, dev->cap_mask))
+               dev->device_prep_slave_sg = d40_prep_slave_sg;
+
+       if (dma_has_cap(DMA_MEMCPY, dev->cap_mask)) {
+               dev->device_prep_dma_memcpy = d40_prep_memcpy;
+
+               /*
+                * This controller can only access address at even
+                * 32bit boundaries, i.e. 2^2
+                */
+               dev->copy_align = 2;
+       }
+
+       if (dma_has_cap(DMA_SG, dev->cap_mask))
+               dev->device_prep_dma_sg = d40_prep_memcpy_sg;
+
+       if (dma_has_cap(DMA_CYCLIC, dev->cap_mask))
+               dev->device_prep_dma_cyclic = dma40_prep_dma_cyclic;
+
+       dev->device_alloc_chan_resources = d40_alloc_chan_resources;
+       dev->device_free_chan_resources = d40_free_chan_resources;
+       dev->device_issue_pending = d40_issue_pending;
+       dev->device_tx_status = d40_tx_status;
+       dev->device_control = d40_control;
+       dev->dev = base->dev;
+}
+
 static int __init d40_dmaengine_init(struct d40_base *base,
                                     int num_reserved_chans)
 {
@@ -2321,22 +2411,14 @@ static int __init d40_dmaengine_init(struct d40_base *base,
 
        dma_cap_zero(base->dma_slave.cap_mask);
        dma_cap_set(DMA_SLAVE, base->dma_slave.cap_mask);
+       dma_cap_set(DMA_CYCLIC, base->dma_slave.cap_mask);
 
-       base->dma_slave.device_alloc_chan_resources = d40_alloc_chan_resources;
-       base->dma_slave.device_free_chan_resources = d40_free_chan_resources;
-       base->dma_slave.device_prep_dma_memcpy = d40_prep_memcpy;
-       base->dma_slave.device_prep_slave_sg = d40_prep_slave_sg;
-       base->dma_slave.device_tx_status = d40_tx_status;
-       base->dma_slave.device_issue_pending = d40_issue_pending;
-       base->dma_slave.device_control = d40_control;
-       base->dma_slave.dev = base->dev;
+       d40_ops_init(base, &base->dma_slave);
 
        err = dma_async_device_register(&base->dma_slave);
 
        if (err) {
-               dev_err(base->dev,
-                       "[%s] Failed to register slave channels\n",
-                       __func__);
+               d40_err(base->dev, "Failed to register slave channels\n");
                goto failure1;
        }
 
@@ -2345,27 +2427,15 @@ static int __init d40_dmaengine_init(struct d40_base *base,
 
        dma_cap_zero(base->dma_memcpy.cap_mask);
        dma_cap_set(DMA_MEMCPY, base->dma_memcpy.cap_mask);
+       dma_cap_set(DMA_SG, base->dma_memcpy.cap_mask);
 
-       base->dma_memcpy.device_alloc_chan_resources = d40_alloc_chan_resources;
-       base->dma_memcpy.device_free_chan_resources = d40_free_chan_resources;
-       base->dma_memcpy.device_prep_dma_memcpy = d40_prep_memcpy;
-       base->dma_memcpy.device_prep_slave_sg = d40_prep_slave_sg;
-       base->dma_memcpy.device_tx_status = d40_tx_status;
-       base->dma_memcpy.device_issue_pending = d40_issue_pending;
-       base->dma_memcpy.device_control = d40_control;
-       base->dma_memcpy.dev = base->dev;
-       /*
-        * This controller can only access address at even
-        * 32bit boundaries, i.e. 2^2
-        */
-       base->dma_memcpy.copy_align = 2;
+       d40_ops_init(base, &base->dma_memcpy);
 
        err = dma_async_device_register(&base->dma_memcpy);
 
        if (err) {
-               dev_err(base->dev,
-                       "[%s] Failed to regsiter memcpy only channels\n",
-                       __func__);
+               d40_err(base->dev,
+                       "Failed to regsiter memcpy only channels\n");
                goto failure2;
        }
 
@@ -2375,22 +2445,15 @@ static int __init d40_dmaengine_init(struct d40_base *base,
        dma_cap_zero(base->dma_both.cap_mask);
        dma_cap_set(DMA_SLAVE, base->dma_both.cap_mask);
        dma_cap_set(DMA_MEMCPY, base->dma_both.cap_mask);
+       dma_cap_set(DMA_SG, base->dma_both.cap_mask);
+       dma_cap_set(DMA_CYCLIC, base->dma_slave.cap_mask);
 
-       base->dma_both.device_alloc_chan_resources = d40_alloc_chan_resources;
-       base->dma_both.device_free_chan_resources = d40_free_chan_resources;
-       base->dma_both.device_prep_dma_memcpy = d40_prep_memcpy;
-       base->dma_both.device_prep_slave_sg = d40_prep_slave_sg;
-       base->dma_both.device_tx_status = d40_tx_status;
-       base->dma_both.device_issue_pending = d40_issue_pending;
-       base->dma_both.device_control = d40_control;
-       base->dma_both.dev = base->dev;
-       base->dma_both.copy_align = 2;
+       d40_ops_init(base, &base->dma_both);
        err = dma_async_device_register(&base->dma_both);
 
        if (err) {
-               dev_err(base->dev,
-                       "[%s] Failed to register logical and physical capable channels\n",
-                       __func__);
+               d40_err(base->dev,
+                       "Failed to register logical and physical capable channels\n");
                goto failure3;
        }
        return 0;
@@ -2466,9 +2529,10 @@ static struct d40_base * __init d40_hw_detect_init(struct platform_device *pdev)
                { .reg = D40_DREG_PERIPHID1, .val = 0x0000},
                /*
                 * D40_DREG_PERIPHID2 Depends on HW revision:
-                *  MOP500/HREF ED has 0x0008,
+                *  DB8500ed has 0x0008,
                 *  ? has 0x0018,
-                *  HREF V1 has 0x0028
+                *  DB8500v1 has 0x0028
+                *  DB8500v2 has 0x0038
                 */
                { .reg = D40_DREG_PERIPHID3, .val = 0x0000},
 
@@ -2492,8 +2556,7 @@ static struct d40_base * __init d40_hw_detect_init(struct platform_device *pdev)
        clk = clk_get(&pdev->dev, NULL);
 
        if (IS_ERR(clk)) {
-               dev_err(&pdev->dev, "[%s] No matching clock found\n",
-                       __func__);
+               d40_err(&pdev->dev, "No matching clock found\n");
                goto failure;
        }
 
@@ -2516,9 +2579,8 @@ static struct d40_base * __init d40_hw_detect_init(struct platform_device *pdev)
        for (i = 0; i < ARRAY_SIZE(dma_id_regs); i++) {
                if (dma_id_regs[i].val !=
                    readl(virtbase + dma_id_regs[i].reg)) {
-                       dev_err(&pdev->dev,
-                               "[%s] Unknown hardware! Expected 0x%x at 0x%x but got 0x%x\n",
-                               __func__,
+                       d40_err(&pdev->dev,
+                               "Unknown hardware! Expected 0x%x at 0x%x but got 0x%x\n",
                                dma_id_regs[i].val,
                                dma_id_regs[i].reg,
                                readl(virtbase + dma_id_regs[i].reg));
@@ -2531,9 +2593,8 @@ static struct d40_base * __init d40_hw_detect_init(struct platform_device *pdev)
 
        if ((val & D40_DREG_PERIPHID2_DESIGNER_MASK) !=
            D40_HW_DESIGNER) {
-               dev_err(&pdev->dev,
-                       "[%s] Unknown designer! Got %x wanted %x\n",
-                       __func__, val & D40_DREG_PERIPHID2_DESIGNER_MASK,
+               d40_err(&pdev->dev, "Unknown designer! Got %x wanted %x\n",
+                       val & D40_DREG_PERIPHID2_DESIGNER_MASK,
                        D40_HW_DESIGNER);
                goto failure;
        }
@@ -2563,7 +2624,7 @@ static struct d40_base * __init d40_hw_detect_init(struct platform_device *pdev)
                       sizeof(struct d40_chan), GFP_KERNEL);
 
        if (base == NULL) {
-               dev_err(&pdev->dev, "[%s] Out of memory\n", __func__);
+               d40_err(&pdev->dev, "Out of memory\n");
                goto failure;
        }
 
@@ -2710,6 +2771,7 @@ static void __init d40_hw_init(struct d40_base *base)
 
 static int __init d40_lcla_allocate(struct d40_base *base)
 {
+       struct d40_lcla_pool *pool = &base->lcla_pool;
        unsigned long *page_list;
        int i, j;
        int ret = 0;
@@ -2735,9 +2797,8 @@ static int __init d40_lcla_allocate(struct d40_base *base)
                                                base->lcla_pool.pages);
                if (!page_list[i]) {
 
-                       dev_err(base->dev,
-                               "[%s] Failed to allocate %d pages.\n",
-                               __func__, base->lcla_pool.pages);
+                       d40_err(base->dev, "Failed to allocate %d pages.\n",
+                               base->lcla_pool.pages);
 
                        for (j = 0; j < i; j++)
                                free_pages(page_list[j], base->lcla_pool.pages);
@@ -2775,6 +2836,15 @@ static int __init d40_lcla_allocate(struct d40_base *base)
                                                 LCLA_ALIGNMENT);
        }
 
+       pool->dma_addr = dma_map_single(base->dev, pool->base,
+                                       SZ_1K * base->num_phy_chans,
+                                       DMA_TO_DEVICE);
+       if (dma_mapping_error(base->dev, pool->dma_addr)) {
+               pool->dma_addr = 0;
+               ret = -ENOMEM;
+               goto failure;
+       }
+
        writel(virt_to_phys(base->lcla_pool.base),
               base->virtbase + D40_DREG_LCLA);
 failure:
@@ -2807,9 +2877,7 @@ static int __init d40_probe(struct platform_device *pdev)
        res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lcpa");
        if (!res) {
                ret = -ENOENT;
-               dev_err(&pdev->dev,
-                       "[%s] No \"lcpa\" memory resource\n",
-                       __func__);
+               d40_err(&pdev->dev, "No \"lcpa\" memory resource\n");
                goto failure;
        }
        base->lcpa_size = resource_size(res);
@@ -2818,9 +2886,9 @@ static int __init d40_probe(struct platform_device *pdev)
        if (request_mem_region(res->start, resource_size(res),
                               D40_NAME " I/O lcpa") == NULL) {
                ret = -EBUSY;
-               dev_err(&pdev->dev,
-                       "[%s] Failed to request LCPA region 0x%x-0x%x\n",
-                       __func__, res->start, res->end);
+               d40_err(&pdev->dev,
+                       "Failed to request LCPA region 0x%x-0x%x\n",
+                       res->start, res->end);
                goto failure;
        }
 
@@ -2836,16 +2904,13 @@ static int __init d40_probe(struct platform_device *pdev)
        base->lcpa_base = ioremap(res->start, resource_size(res));
        if (!base->lcpa_base) {
                ret = -ENOMEM;
-               dev_err(&pdev->dev,
-                       "[%s] Failed to ioremap LCPA region\n",
-                       __func__);
+               d40_err(&pdev->dev, "Failed to ioremap LCPA region\n");
                goto failure;
        }
 
        ret = d40_lcla_allocate(base);
        if (ret) {
-               dev_err(&pdev->dev, "[%s] Failed to allocate LCLA area\n",
-                       __func__);
+               d40_err(&pdev->dev, "Failed to allocate LCLA area\n");
                goto failure;
        }
 
@@ -2854,9 +2919,8 @@ static int __init d40_probe(struct platform_device *pdev)
        base->irq = platform_get_irq(pdev, 0);
 
        ret = request_irq(base->irq, d40_handle_interrupt, 0, D40_NAME, base);
-
        if (ret) {
-               dev_err(&pdev->dev, "[%s] No IRQ defined\n", __func__);
+               d40_err(&pdev->dev, "No IRQ defined\n");
                goto failure;
        }
 
@@ -2875,6 +2939,12 @@ failure:
                        kmem_cache_destroy(base->desc_slab);
                if (base->virtbase)
                        iounmap(base->virtbase);
+
+               if (base->lcla_pool.dma_addr)
+                       dma_unmap_single(base->dev, base->lcla_pool.dma_addr,
+                                        SZ_1K * base->num_phy_chans,
+                                        DMA_TO_DEVICE);
+
                if (!base->lcla_pool.base_unaligned && base->lcla_pool.base)
                        free_pages((unsigned long)base->lcla_pool.base,
                                   base->lcla_pool.pages);
@@ -2899,7 +2969,7 @@ failure:
                kfree(base);
        }
 
-       dev_err(&pdev->dev, "[%s] probe failed\n", __func__);
+       d40_err(&pdev->dev, "probe failed\n");
        return ret;
 }
 
@@ -2910,8 +2980,8 @@ static struct platform_driver d40_driver = {
        },
 };
 
-int __init stedma40_init(void)
+static int __init stedma40_init(void)
 {
        return platform_driver_probe(&d40_driver, d40_probe);
 }
-arch_initcall(stedma40_init);
+subsys_initcall(stedma40_init);