ALSA: isight: fix packet requeueing
[linux-2.6.git] / sound / firewire / isight.c
1 /*
2  * Apple iSight audio driver
3  *
4  * Copyright (c) Clemens Ladisch <clemens@ladisch.de>
5  * Licensed under the terms of the GNU General Public License, version 2.
6  */
7
8 #include <linux/delay.h>
9 #include <linux/device.h>
10 #include <linux/firewire.h>
11 #include <linux/firewire-constants.h>
12 #include <linux/module.h>
13 #include <linux/mod_devicetable.h>
14 #include <linux/mutex.h>
15 #include <linux/string.h>
16 #include <sound/control.h>
17 #include <sound/core.h>
18 #include <sound/initval.h>
19 #include <sound/pcm.h>
20 #include <sound/tlv.h>
21 #include "lib.h"
22 #include "iso-resources.h"
23 #include "packets-buffer.h"
24
25 #define OUI_APPLE               0x000a27
26 #define MODEL_APPLE_ISIGHT      0x000008
27 #define SW_ISIGHT_AUDIO         0x000010
28
29 #define REG_AUDIO_ENABLE        0x000
30 #define  AUDIO_ENABLE           0x80000000
31 #define REG_DEF_AUDIO_GAIN      0x204
32 #define REG_GAIN_RAW_START      0x210
33 #define REG_GAIN_RAW_END        0x214
34 #define REG_GAIN_DB_START       0x218
35 #define REG_GAIN_DB_END         0x21c
36 #define REG_SAMPLE_RATE_INQUIRY 0x280
37 #define REG_ISO_TX_CONFIG       0x300
38 #define  SPEED_SHIFT            16
39 #define REG_SAMPLE_RATE         0x400
40 #define  RATE_48000             0x80000000
41 #define REG_GAIN                0x500
42 #define REG_MUTE                0x504
43
44 #define MAX_FRAMES_PER_PACKET   475
45
46 #define QUEUE_LENGTH            20
47
48 struct isight {
49         struct snd_card *card;
50         struct fw_unit *unit;
51         struct fw_device *device;
52         u64 audio_base;
53         struct fw_address_handler iris_handler;
54         struct snd_pcm_substream *pcm;
55         struct mutex mutex;
56         struct iso_packets_buffer buffer;
57         struct fw_iso_resources resources;
58         struct fw_iso_context *context;
59         bool pcm_active;
60         bool pcm_running;
61         bool first_packet;
62         int packet_index;
63         u32 total_samples;
64         unsigned int buffer_pointer;
65         unsigned int period_counter;
66         s32 gain_min, gain_max;
67         unsigned int gain_tlv[4];
68 };
69
70 struct audio_payload {
71         __be32 sample_count;
72         __be32 signature;
73         __be32 sample_total;
74         __be32 reserved;
75         __be16 samples[2 * MAX_FRAMES_PER_PACKET];
76 };
77
78 MODULE_DESCRIPTION("iSight audio driver");
79 MODULE_AUTHOR("Clemens Ladisch <clemens@ladisch.de>");
80 MODULE_LICENSE("GPL v2");
81
82 static struct fw_iso_packet audio_packet = {
83         .payload_length = sizeof(struct audio_payload),
84         .interrupt = 1,
85 };
86
87 static void isight_update_pointers(struct isight *isight, unsigned int count)
88 {
89         struct snd_pcm_runtime *runtime = isight->pcm->runtime;
90         unsigned int ptr;
91
92         smp_wmb(); /* update buffer data before buffer pointer */
93
94         ptr = isight->buffer_pointer;
95         ptr += count;
96         if (ptr >= runtime->buffer_size)
97                 ptr -= runtime->buffer_size;
98         ACCESS_ONCE(isight->buffer_pointer) = ptr;
99
100         isight->period_counter += count;
101         if (isight->period_counter >= runtime->period_size) {
102                 isight->period_counter -= runtime->period_size;
103                 snd_pcm_period_elapsed(isight->pcm);
104         }
105 }
106
107 static void isight_samples(struct isight *isight,
108                            const __be16 *samples, unsigned int count)
109 {
110         struct snd_pcm_runtime *runtime;
111         unsigned int count1;
112
113         if (!ACCESS_ONCE(isight->pcm_running))
114                 return;
115
116         runtime = isight->pcm->runtime;
117         if (isight->buffer_pointer + count <= runtime->buffer_size) {
118                 memcpy(runtime->dma_area + isight->buffer_pointer * 4,
119                        samples, count * 4);
120         } else {
121                 count1 = runtime->buffer_size - isight->buffer_pointer;
122                 memcpy(runtime->dma_area + isight->buffer_pointer * 4,
123                        samples, count1 * 4);
124                 samples += count1 * 2;
125                 memcpy(runtime->dma_area, samples, (count - count1) * 4);
126         }
127
128         isight_update_pointers(isight, count);
129 }
130
131 static void isight_pcm_abort(struct isight *isight)
132 {
133         unsigned long flags;
134
135         if (ACCESS_ONCE(isight->pcm_active)) {
136                 snd_pcm_stream_lock_irqsave(isight->pcm, flags);
137                 if (snd_pcm_running(isight->pcm))
138                         snd_pcm_stop(isight->pcm, SNDRV_PCM_STATE_XRUN);
139                 snd_pcm_stream_unlock_irqrestore(isight->pcm, flags);
140         }
141 }
142
143 static void isight_dropped_samples(struct isight *isight, unsigned int total)
144 {
145         struct snd_pcm_runtime *runtime;
146         u32 dropped;
147         unsigned int count1;
148
149         if (!ACCESS_ONCE(isight->pcm_running))
150                 return;
151
152         runtime = isight->pcm->runtime;
153         dropped = total - isight->total_samples;
154         if (dropped < runtime->buffer_size) {
155                 if (isight->buffer_pointer + dropped <= runtime->buffer_size) {
156                         memset(runtime->dma_area + isight->buffer_pointer * 4,
157                                0, dropped * 4);
158                 } else {
159                         count1 = runtime->buffer_size - isight->buffer_pointer;
160                         memset(runtime->dma_area + isight->buffer_pointer * 4,
161                                0, count1 * 4);
162                         memset(runtime->dma_area, 0, (dropped - count1) * 4);
163                 }
164                 isight_update_pointers(isight, dropped);
165         } else {
166                 isight_pcm_abort(isight);
167         }
168 }
169
170 static void isight_packet(struct fw_iso_context *context, u32 cycle,
171                           size_t header_length, void *header, void *data)
172 {
173         struct isight *isight = data;
174         const struct audio_payload *payload;
175         unsigned int index, length, count, total;
176         int err;
177
178         if (isight->packet_index < 0)
179                 return;
180         index = isight->packet_index;
181         payload = isight->buffer.packets[index].buffer;
182         length = be32_to_cpup(header) >> 16;
183
184         if (likely(length >= 16 &&
185                    payload->signature == cpu_to_be32(0x73676874/*"sght"*/))) {
186                 count = be32_to_cpu(payload->sample_count);
187                 if (likely(count <= (length - 16) / 4)) {
188                         total = be32_to_cpu(payload->sample_total);
189                         if (unlikely(total != isight->total_samples)) {
190                                 if (!isight->first_packet)
191                                         isight_dropped_samples(isight, total);
192                                 isight->first_packet = false;
193                                 isight->total_samples = total;
194                         }
195
196                         isight_samples(isight, payload->samples, count);
197                         isight->total_samples += count;
198                 }
199         }
200
201         err = fw_iso_context_queue(isight->context, &audio_packet,
202                                    &isight->buffer.iso_buffer,
203                                    isight->buffer.packets[index].offset);
204         if (err < 0) {
205                 dev_err(&isight->unit->device, "queueing error: %d\n", err);
206                 isight_pcm_abort(isight);
207                 isight->packet_index = -1;
208                 return;
209         }
210
211         if (++index >= QUEUE_LENGTH)
212                 index = 0;
213         isight->packet_index = index;
214 }
215
216 static int isight_connect(struct isight *isight)
217 {
218         int ch, err, rcode, errors = 0;
219         __be32 value;
220
221 retry_after_bus_reset:
222         ch = fw_iso_resources_allocate(&isight->resources,
223                                        sizeof(struct audio_payload),
224                                        isight->device->max_speed);
225         if (ch < 0) {
226                 err = ch;
227                 goto error;
228         }
229
230         value = cpu_to_be32(ch | (isight->device->max_speed << SPEED_SHIFT));
231         for (;;) {
232                 rcode = fw_run_transaction(
233                                 isight->device->card,
234                                 TCODE_WRITE_QUADLET_REQUEST,
235                                 isight->device->node_id,
236                                 isight->resources.generation,
237                                 isight->device->max_speed,
238                                 isight->audio_base + REG_ISO_TX_CONFIG,
239                                 &value, 4);
240                 if (rcode == RCODE_COMPLETE) {
241                         return 0;
242                 } else if (rcode == RCODE_GENERATION) {
243                         fw_iso_resources_free(&isight->resources);
244                         goto retry_after_bus_reset;
245                 } else if (rcode_is_permanent_error(rcode) || ++errors >= 3) {
246                         err = -EIO;
247                         goto err_resources;
248                 }
249                 msleep(5);
250         }
251
252 err_resources:
253         fw_iso_resources_free(&isight->resources);
254 error:
255         return err;
256 }
257
258 static int isight_open(struct snd_pcm_substream *substream)
259 {
260         static const struct snd_pcm_hardware hardware = {
261                 .info = SNDRV_PCM_INFO_MMAP |
262                         SNDRV_PCM_INFO_MMAP_VALID |
263                         SNDRV_PCM_INFO_BATCH |
264                         SNDRV_PCM_INFO_INTERLEAVED |
265                         SNDRV_PCM_INFO_BLOCK_TRANSFER,
266                 .formats = SNDRV_PCM_FMTBIT_S16_BE,
267                 .rates = SNDRV_PCM_RATE_48000,
268                 .rate_min = 48000,
269                 .rate_max = 48000,
270                 .channels_min = 2,
271                 .channels_max = 2,
272                 .buffer_bytes_max = 4 * 1024 * 1024,
273                 .period_bytes_min = MAX_FRAMES_PER_PACKET * 4,
274                 .period_bytes_max = 1024 * 1024,
275                 .periods_min = 2,
276                 .periods_max = UINT_MAX,
277         };
278         struct isight *isight = substream->private_data;
279
280         substream->runtime->hw = hardware;
281
282         return iso_packets_buffer_init(&isight->buffer, isight->unit,
283                                        QUEUE_LENGTH,
284                                        sizeof(struct audio_payload),
285                                        DMA_FROM_DEVICE);
286 }
287
288 static int isight_close(struct snd_pcm_substream *substream)
289 {
290         struct isight *isight = substream->private_data;
291
292         iso_packets_buffer_destroy(&isight->buffer, isight->unit);
293
294         return 0;
295 }
296
297 static int isight_hw_params(struct snd_pcm_substream *substream,
298                             struct snd_pcm_hw_params *hw_params)
299 {
300         struct isight *isight = substream->private_data;
301         int err;
302
303         err = snd_pcm_lib_alloc_vmalloc_buffer(substream,
304                                                params_buffer_bytes(hw_params));
305         if (err < 0)
306                 return err;
307
308         ACCESS_ONCE(isight->pcm_active) = true;
309
310         return 0;
311 }
312
313 static void isight_stop_streaming(struct isight *isight)
314 {
315         __be32 value;
316
317         if (!isight->context)
318                 return;
319
320         fw_iso_context_stop(isight->context);
321         fw_iso_context_destroy(isight->context);
322         isight->context = NULL;
323
324         value = 0;
325         snd_fw_transaction(isight->unit, TCODE_WRITE_QUADLET_REQUEST,
326                            isight->audio_base + REG_AUDIO_ENABLE,
327                            &value, 4);
328
329         fw_iso_resources_free(&isight->resources);
330 }
331
332 static int isight_hw_free(struct snd_pcm_substream *substream)
333 {
334         struct isight *isight = substream->private_data;
335
336         ACCESS_ONCE(isight->pcm_active) = false;
337
338         mutex_lock(&isight->mutex);
339         isight_stop_streaming(isight);
340         mutex_unlock(&isight->mutex);
341
342         return snd_pcm_lib_free_vmalloc_buffer(substream);
343 }
344
345 static int isight_start_streaming(struct isight *isight)
346 {
347         __be32 sample_rate;
348         unsigned int i;
349         int err;
350
351         if (isight->context) {
352                 if (isight->packet_index < 0)
353                         isight_stop_streaming(isight);
354                 else
355                         return 0;
356         }
357
358         sample_rate = cpu_to_be32(RATE_48000);
359         err = snd_fw_transaction(isight->unit, TCODE_WRITE_QUADLET_REQUEST,
360                                  isight->audio_base + REG_SAMPLE_RATE,
361                                  &sample_rate, 4);
362         if (err < 0)
363                 return err;
364
365         err = isight_connect(isight);
366         if (err < 0)
367                 goto error;
368
369         isight->context = fw_iso_context_create(isight->device->card,
370                                                 FW_ISO_CONTEXT_RECEIVE,
371                                                 isight->resources.channel,
372                                                 isight->device->max_speed,
373                                                 4, isight_packet, isight);
374         if (IS_ERR(isight->context)) {
375                 err = PTR_ERR(isight->context);
376                 isight->context = NULL;
377                 goto err_resources;
378         }
379
380         for (i = 0; i < QUEUE_LENGTH; ++i) {
381                 err = fw_iso_context_queue(isight->context, &audio_packet,
382                                            &isight->buffer.iso_buffer,
383                                            isight->buffer.packets[i].offset);
384                 if (err < 0)
385                         goto err_context;
386         }
387
388         isight->first_packet = true;
389         isight->packet_index = 0;
390
391         err = fw_iso_context_start(isight->context, -1, 0,
392                                    FW_ISO_CONTEXT_MATCH_ALL_TAGS/*?*/);
393         if (err < 0)
394                 goto err_context;
395
396         return 0;
397
398 err_context:
399         fw_iso_context_destroy(isight->context);
400         isight->context = NULL;
401 err_resources:
402         fw_iso_resources_free(&isight->resources);
403 error:
404         return err;
405 }
406
407 static int isight_prepare(struct snd_pcm_substream *substream)
408 {
409         struct isight *isight = substream->private_data;
410         int err;
411
412         isight->buffer_pointer = 0;
413         isight->period_counter = 0;
414
415         mutex_lock(&isight->mutex);
416         err = isight_start_streaming(isight);
417         mutex_unlock(&isight->mutex);
418
419         return err;
420 }
421
422 static int isight_trigger(struct snd_pcm_substream *substream, int cmd)
423 {
424         struct isight *isight = substream->private_data;
425
426         switch (cmd) {
427         case SNDRV_PCM_TRIGGER_START:
428                 ACCESS_ONCE(isight->pcm_running) = true;
429                 break;
430         case SNDRV_PCM_TRIGGER_STOP:
431                 ACCESS_ONCE(isight->pcm_running) = false;
432                 break;
433         default:
434                 return -EINVAL;
435         }
436         return 0;
437 }
438
439 static snd_pcm_uframes_t isight_pointer(struct snd_pcm_substream *substream)
440 {
441         struct isight *isight = substream->private_data;
442
443         return ACCESS_ONCE(isight->buffer_pointer);
444 }
445
446 static int isight_create_pcm(struct isight *isight)
447 {
448         static struct snd_pcm_ops ops = {
449                 .open      = isight_open,
450                 .close     = isight_close,
451                 .ioctl     = snd_pcm_lib_ioctl,
452                 .hw_params = isight_hw_params,
453                 .hw_free   = isight_hw_free,
454                 .prepare   = isight_prepare,
455                 .trigger   = isight_trigger,
456                 .pointer   = isight_pointer,
457                 .page      = snd_pcm_lib_get_vmalloc_page,
458                 .mmap      = snd_pcm_lib_mmap_vmalloc,
459         };
460         struct snd_pcm *pcm;
461         int err;
462
463         err = snd_pcm_new(isight->card, "iSight", 0, 0, 1, &pcm);
464         if (err < 0)
465                 return err;
466         pcm->private_data = isight;
467         strcpy(pcm->name, "iSight");
468         isight->pcm = pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream;
469         isight->pcm->ops = &ops;
470
471         return 0;
472 }
473
474 static int isight_gain_info(struct snd_kcontrol *ctl,
475                             struct snd_ctl_elem_info *info)
476 {
477         struct isight *isight = ctl->private_data;
478
479         info->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
480         info->count = 1;
481         info->value.integer.min = isight->gain_min;
482         info->value.integer.max = isight->gain_max;
483
484         return 0;
485 }
486
487 static int isight_gain_get(struct snd_kcontrol *ctl,
488                            struct snd_ctl_elem_value *value)
489 {
490         struct isight *isight = ctl->private_data;
491         __be32 gain;
492         int err;
493
494         err = snd_fw_transaction(isight->unit, TCODE_READ_QUADLET_REQUEST,
495                                  isight->audio_base + REG_GAIN, &gain, 4);
496         if (err < 0)
497                 return err;
498
499         value->value.integer.value[0] = (s32)be32_to_cpu(gain);
500
501         return 0;
502 }
503
504 static int isight_gain_put(struct snd_kcontrol *ctl,
505                            struct snd_ctl_elem_value *value)
506 {
507         struct isight *isight = ctl->private_data;
508         __be32 gain;
509
510         if (value->value.integer.value[0] < isight->gain_min ||
511             value->value.integer.value[0] > isight->gain_max)
512                 return -EINVAL;
513
514         gain = cpu_to_be32(value->value.integer.value[0]);
515         return snd_fw_transaction(isight->unit, TCODE_WRITE_QUADLET_REQUEST,
516                                   isight->audio_base + REG_GAIN, &gain, 4);
517 }
518
519 static int isight_mute_get(struct snd_kcontrol *ctl,
520                            struct snd_ctl_elem_value *value)
521 {
522         struct isight *isight = ctl->private_data;
523         __be32 mute;
524         int err;
525
526         err = snd_fw_transaction(isight->unit, TCODE_READ_QUADLET_REQUEST,
527                                  isight->audio_base + REG_MUTE, &mute, 4);
528         if (err < 0)
529                 return err;
530
531         value->value.integer.value[0] = !mute;
532
533         return 0;
534 }
535
536 static int isight_mute_put(struct snd_kcontrol *ctl,
537                            struct snd_ctl_elem_value *value)
538 {
539         struct isight *isight = ctl->private_data;
540         __be32 mute;
541
542         mute = (__force __be32)!value->value.integer.value[0];
543         return snd_fw_transaction(isight->unit, TCODE_WRITE_QUADLET_REQUEST,
544                                   isight->audio_base + REG_MUTE, &mute, 4);
545 }
546
547 static int isight_create_mixer(struct isight *isight)
548 {
549         static const struct snd_kcontrol_new gain_control = {
550                 .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
551                 .name = "Mic Capture Volume",
552                 .access = SNDRV_CTL_ELEM_ACCESS_READWRITE |
553                           SNDRV_CTL_ELEM_ACCESS_TLV_READ,
554                 .info = isight_gain_info,
555                 .get = isight_gain_get,
556                 .put = isight_gain_put,
557         };
558         static const struct snd_kcontrol_new mute_control = {
559                 .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
560                 .name = "Mic Capture Switch",
561                 .info = snd_ctl_boolean_mono_info,
562                 .get = isight_mute_get,
563                 .put = isight_mute_put,
564         };
565         __be32 value;
566         struct snd_kcontrol *ctl;
567         int err;
568
569         err = snd_fw_transaction(isight->unit, TCODE_READ_QUADLET_REQUEST,
570                                  isight->audio_base + REG_GAIN_RAW_START,
571                                  &value, 4);
572         if (err < 0)
573                 return err;
574         isight->gain_min = be32_to_cpu(value);
575
576         err = snd_fw_transaction(isight->unit, TCODE_READ_QUADLET_REQUEST,
577                                  isight->audio_base + REG_GAIN_RAW_END,
578                                  &value, 4);
579         if (err < 0)
580                 return err;
581         isight->gain_max = be32_to_cpu(value);
582
583         isight->gain_tlv[0] = SNDRV_CTL_TLVT_DB_MINMAX;
584         isight->gain_tlv[1] = 2 * sizeof(unsigned int);
585         err = snd_fw_transaction(isight->unit, TCODE_READ_QUADLET_REQUEST,
586                                  isight->audio_base + REG_GAIN_DB_START,
587                                  &value, 4);
588         if (err < 0)
589                 return err;
590         isight->gain_tlv[2] = (s32)be32_to_cpu(value) * 100;
591         err = snd_fw_transaction(isight->unit, TCODE_READ_QUADLET_REQUEST,
592                                  isight->audio_base + REG_GAIN_DB_END,
593                                  &value, 4);
594         if (err < 0)
595                 return err;
596         isight->gain_tlv[3] = (s32)be32_to_cpu(value) * 100;
597
598         ctl = snd_ctl_new1(&gain_control, isight);
599         if (ctl)
600                 ctl->tlv.p = isight->gain_tlv;
601         err = snd_ctl_add(isight->card, ctl);
602         if (err < 0)
603                 return err;
604
605         err = snd_ctl_add(isight->card, snd_ctl_new1(&mute_control, isight));
606         if (err < 0)
607                 return err;
608
609         return 0;
610 }
611
612 static void isight_card_free(struct snd_card *card)
613 {
614         struct isight *isight = card->private_data;
615
616         fw_iso_resources_destroy(&isight->resources);
617         fw_unit_put(isight->unit);
618         fw_device_put(isight->device);
619         mutex_destroy(&isight->mutex);
620 }
621
622 static u64 get_unit_base(struct fw_unit *unit)
623 {
624         struct fw_csr_iterator i;
625         int key, value;
626
627         fw_csr_iterator_init(&i, unit->directory);
628         while (fw_csr_iterator_next(&i, &key, &value))
629                 if (key == CSR_OFFSET)
630                         return CSR_REGISTER_BASE + value * 4;
631         return 0;
632 }
633
634 static int isight_probe(struct device *unit_dev)
635 {
636         struct fw_unit *unit = fw_unit(unit_dev);
637         struct fw_device *fw_dev = fw_parent_device(unit);
638         struct snd_card *card;
639         struct isight *isight;
640         int err;
641
642         err = snd_card_create(-1, NULL, THIS_MODULE, sizeof(*isight), &card);
643         if (err < 0)
644                 return err;
645         snd_card_set_dev(card, unit_dev);
646
647         isight = card->private_data;
648         isight->card = card;
649         mutex_init(&isight->mutex);
650         isight->unit = fw_unit_get(unit);
651         isight->device = fw_device_get(fw_dev);
652         isight->audio_base = get_unit_base(unit);
653         if (!isight->audio_base) {
654                 dev_err(&unit->device, "audio unit base not found\n");
655                 err = -ENXIO;
656                 goto err_unit;
657         }
658         fw_iso_resources_init(&isight->resources, unit);
659
660         card->private_free = isight_card_free;
661
662         strcpy(card->driver, "iSight");
663         strcpy(card->shortname, "Apple iSight");
664         snprintf(card->longname, sizeof(card->longname),
665                  "Apple iSight (GUID %08x%08x) at %s, S%d",
666                  fw_dev->config_rom[3], fw_dev->config_rom[4],
667                  dev_name(&unit->device), 100 << fw_dev->max_speed);
668         strcpy(card->mixername, "iSight");
669
670         err = isight_create_pcm(isight);
671         if (err < 0)
672                 goto error;
673
674         err = isight_create_mixer(isight);
675         if (err < 0)
676                 goto error;
677
678         err = snd_card_register(card);
679         if (err < 0)
680                 goto error;
681
682         dev_set_drvdata(unit_dev, isight);
683
684         return 0;
685
686 err_unit:
687         fw_unit_put(isight->unit);
688         fw_device_put(isight->device);
689         mutex_destroy(&isight->mutex);
690 error:
691         snd_card_free(card);
692         return err;
693 }
694
695 static int isight_remove(struct device *dev)
696 {
697         struct isight *isight = dev_get_drvdata(dev);
698
699         snd_card_disconnect(isight->card);
700
701         mutex_lock(&isight->mutex);
702         isight_pcm_abort(isight);
703         isight_stop_streaming(isight);
704         mutex_unlock(&isight->mutex);
705
706         snd_card_free_when_closed(isight->card);
707
708         return 0;
709 }
710
711 static void isight_bus_reset(struct fw_unit *unit)
712 {
713         struct isight *isight = dev_get_drvdata(&unit->device);
714
715         mutex_lock(&isight->mutex);
716         if (fw_iso_resources_update(&isight->resources) < 0) {
717                 isight_pcm_abort(isight);
718                 isight_stop_streaming(isight);
719         }
720         mutex_unlock(&isight->mutex);
721 }
722
723 static const struct ieee1394_device_id isight_id_table[] = {
724         {
725                 .match_flags  = IEEE1394_MATCH_SPECIFIER_ID |
726                                 IEEE1394_MATCH_VERSION,
727                 .specifier_id = OUI_APPLE,
728                 .version      = SW_ISIGHT_AUDIO,
729         },
730         { }
731 };
732 MODULE_DEVICE_TABLE(ieee1394, isight_id_table);
733
734 static struct fw_driver isight_driver = {
735         .driver   = {
736                 .owner  = THIS_MODULE,
737                 .name   = KBUILD_MODNAME,
738                 .bus    = &fw_bus_type,
739                 .probe  = isight_probe,
740                 .remove = isight_remove,
741         },
742         .update   = isight_bus_reset,
743         .id_table = isight_id_table,
744 };
745
746 static int __init alsa_isight_init(void)
747 {
748         return driver_register(&isight_driver.driver);
749 }
750
751 static void __exit alsa_isight_exit(void)
752 {
753         driver_unregister(&isight_driver.driver);
754 }
755
756 module_init(alsa_isight_init);
757 module_exit(alsa_isight_exit);