checkpatch: prefer __printf over __attribute__((format(printf,...)))
[linux-2.6.git] / scripts / checkpatch.pl
1 #!/usr/bin/perl -w
2 # (c) 2001, Dave Jones. (the file handling bit)
3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
5 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
6 # Licensed under the terms of the GNU GPL License version 2
7
8 use strict;
9
10 my $P = $0;
11 $P =~ s@.*/@@g;
12
13 my $V = '0.32';
14
15 use Getopt::Long qw(:config no_auto_abbrev);
16
17 my $quiet = 0;
18 my $tree = 1;
19 my $chk_signoff = 1;
20 my $chk_patch = 1;
21 my $tst_only;
22 my $emacs = 0;
23 my $terse = 0;
24 my $file = 0;
25 my $check = 0;
26 my $summary = 1;
27 my $mailback = 0;
28 my $summary_file = 0;
29 my $show_types = 0;
30 my $root;
31 my %debug;
32 my %ignore_type = ();
33 my @ignore = ();
34 my $help = 0;
35 my $configuration_file = ".checkpatch.conf";
36
37 sub help {
38         my ($exitcode) = @_;
39
40         print << "EOM";
41 Usage: $P [OPTION]... [FILE]...
42 Version: $V
43
44 Options:
45   -q, --quiet                quiet
46   --no-tree                  run without a kernel tree
47   --no-signoff               do not check for 'Signed-off-by' line
48   --patch                    treat FILE as patchfile (default)
49   --emacs                    emacs compile window format
50   --terse                    one line per report
51   -f, --file                 treat FILE as regular source file
52   --subjective, --strict     enable more subjective tests
53   --ignore TYPE(,TYPE2...)   ignore various comma separated message types
54   --show-types               show the message "types" in the output
55   --root=PATH                PATH to the kernel tree root
56   --no-summary               suppress the per-file summary
57   --mailback                 only produce a report in case of warnings/errors
58   --summary-file             include the filename in summary
59   --debug KEY=[0|1]          turn on/off debugging of KEY, where KEY is one of
60                              'values', 'possible', 'type', and 'attr' (default
61                              is all off)
62   --test-only=WORD           report only warnings/errors containing WORD
63                              literally
64   -h, --help, --version      display this help and exit
65
66 When FILE is - read standard input.
67 EOM
68
69         exit($exitcode);
70 }
71
72 my $conf = which_conf($configuration_file);
73 if (-f $conf) {
74         my @conf_args;
75         open(my $conffile, '<', "$conf")
76             or warn "$P: Can't find a readable $configuration_file file $!\n";
77
78         while (<$conffile>) {
79                 my $line = $_;
80
81                 $line =~ s/\s*\n?$//g;
82                 $line =~ s/^\s*//g;
83                 $line =~ s/\s+/ /g;
84
85                 next if ($line =~ m/^\s*#/);
86                 next if ($line =~ m/^\s*$/);
87
88                 my @words = split(" ", $line);
89                 foreach my $word (@words) {
90                         last if ($word =~ m/^#/);
91                         push (@conf_args, $word);
92                 }
93         }
94         close($conffile);
95         unshift(@ARGV, @conf_args) if @conf_args;
96 }
97
98 GetOptions(
99         'q|quiet+'      => \$quiet,
100         'tree!'         => \$tree,
101         'signoff!'      => \$chk_signoff,
102         'patch!'        => \$chk_patch,
103         'emacs!'        => \$emacs,
104         'terse!'        => \$terse,
105         'f|file!'       => \$file,
106         'subjective!'   => \$check,
107         'strict!'       => \$check,
108         'ignore=s'      => \@ignore,
109         'show-types!'   => \$show_types,
110         'root=s'        => \$root,
111         'summary!'      => \$summary,
112         'mailback!'     => \$mailback,
113         'summary-file!' => \$summary_file,
114
115         'debug=s'       => \%debug,
116         'test-only=s'   => \$tst_only,
117         'h|help'        => \$help,
118         'version'       => \$help
119 ) or help(1);
120
121 help(0) if ($help);
122
123 my $exit = 0;
124
125 if ($#ARGV < 0) {
126         print "$P: no input files\n";
127         exit(1);
128 }
129
130 @ignore = split(/,/, join(',',@ignore));
131 foreach my $word (@ignore) {
132         $word =~ s/\s*\n?$//g;
133         $word =~ s/^\s*//g;
134         $word =~ s/\s+/ /g;
135         $word =~ tr/[a-z]/[A-Z]/;
136
137         next if ($word =~ m/^\s*#/);
138         next if ($word =~ m/^\s*$/);
139
140         $ignore_type{$word}++;
141 }
142
143 my $dbg_values = 0;
144 my $dbg_possible = 0;
145 my $dbg_type = 0;
146 my $dbg_attr = 0;
147 for my $key (keys %debug) {
148         ## no critic
149         eval "\${dbg_$key} = '$debug{$key}';";
150         die "$@" if ($@);
151 }
152
153 my $rpt_cleaners = 0;
154
155 if ($terse) {
156         $emacs = 1;
157         $quiet++;
158 }
159
160 if ($tree) {
161         if (defined $root) {
162                 if (!top_of_kernel_tree($root)) {
163                         die "$P: $root: --root does not point at a valid tree\n";
164                 }
165         } else {
166                 if (top_of_kernel_tree('.')) {
167                         $root = '.';
168                 } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
169                                                 top_of_kernel_tree($1)) {
170                         $root = $1;
171                 }
172         }
173
174         if (!defined $root) {
175                 print "Must be run from the top-level dir. of a kernel tree\n";
176                 exit(2);
177         }
178 }
179
180 my $emitted_corrupt = 0;
181
182 our $Ident      = qr{
183                         [A-Za-z_][A-Za-z\d_]*
184                         (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)*
185                 }x;
186 our $Storage    = qr{extern|static|asmlinkage};
187 our $Sparse     = qr{
188                         __user|
189                         __kernel|
190                         __force|
191                         __iomem|
192                         __must_check|
193                         __init_refok|
194                         __kprobes|
195                         __ref|
196                         __rcu
197                 }x;
198
199 # Notes to $Attribute:
200 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
201 our $Attribute  = qr{
202                         const|
203                         __percpu|
204                         __nocast|
205                         __safe|
206                         __bitwise__|
207                         __packed__|
208                         __packed2__|
209                         __naked|
210                         __maybe_unused|
211                         __always_unused|
212                         __noreturn|
213                         __used|
214                         __cold|
215                         __noclone|
216                         __deprecated|
217                         __read_mostly|
218                         __kprobes|
219                         __(?:mem|cpu|dev|)(?:initdata|initconst|init\b)|
220                         ____cacheline_aligned|
221                         ____cacheline_aligned_in_smp|
222                         ____cacheline_internodealigned_in_smp|
223                         __weak
224                   }x;
225 our $Modifier;
226 our $Inline     = qr{inline|__always_inline|noinline};
227 our $Member     = qr{->$Ident|\.$Ident|\[[^]]*\]};
228 our $Lval       = qr{$Ident(?:$Member)*};
229
230 our $Constant   = qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*};
231 our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
232 our $Compare    = qr{<=|>=|==|!=|<|>};
233 our $Operators  = qr{
234                         <=|>=|==|!=|
235                         =>|->|<<|>>|<|>|!|~|
236                         &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%
237                   }x;
238
239 our $NonptrType;
240 our $Type;
241 our $Declare;
242
243 our $NON_ASCII_UTF8     = qr{
244         [\xC2-\xDF][\x80-\xBF]               # non-overlong 2-byte
245         |  \xE0[\xA0-\xBF][\x80-\xBF]        # excluding overlongs
246         | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2}  # straight 3-byte
247         |  \xED[\x80-\x9F][\x80-\xBF]        # excluding surrogates
248         |  \xF0[\x90-\xBF][\x80-\xBF]{2}     # planes 1-3
249         | [\xF1-\xF3][\x80-\xBF]{3}          # planes 4-15
250         |  \xF4[\x80-\x8F][\x80-\xBF]{2}     # plane 16
251 }x;
252
253 our $UTF8       = qr{
254         [\x09\x0A\x0D\x20-\x7E]              # ASCII
255         | $NON_ASCII_UTF8
256 }x;
257
258 our $typeTypedefs = qr{(?x:
259         (?:__)?(?:u|s|be|le)(?:8|16|32|64)|
260         atomic_t
261 )};
262
263 our $logFunctions = qr{(?x:
264         printk(?:_ratelimited|_once|)|
265         [a-z0-9]+_(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
266         WARN(?:_RATELIMIT|_ONCE|)|
267         panic|
268         MODULE_[A-Z_]+
269 )};
270
271 our $signature_tags = qr{(?xi:
272         Signed-off-by:|
273         Acked-by:|
274         Tested-by:|
275         Reviewed-by:|
276         Reported-by:|
277         To:|
278         Cc:
279 )};
280
281 our @typeList = (
282         qr{void},
283         qr{(?:unsigned\s+)?char},
284         qr{(?:unsigned\s+)?short},
285         qr{(?:unsigned\s+)?int},
286         qr{(?:unsigned\s+)?long},
287         qr{(?:unsigned\s+)?long\s+int},
288         qr{(?:unsigned\s+)?long\s+long},
289         qr{(?:unsigned\s+)?long\s+long\s+int},
290         qr{unsigned},
291         qr{float},
292         qr{double},
293         qr{bool},
294         qr{struct\s+$Ident},
295         qr{union\s+$Ident},
296         qr{enum\s+$Ident},
297         qr{${Ident}_t},
298         qr{${Ident}_handler},
299         qr{${Ident}_handler_fn},
300 );
301 our @modifierList = (
302         qr{fastcall},
303 );
304
305 our $allowed_asm_includes = qr{(?x:
306         irq|
307         memory
308 )};
309 # memory.h: ARM has a custom one
310
311 sub build_types {
312         my $mods = "(?x:  \n" . join("|\n  ", @modifierList) . "\n)";
313         my $all = "(?x:  \n" . join("|\n  ", @typeList) . "\n)";
314         $Modifier       = qr{(?:$Attribute|$Sparse|$mods)};
315         $NonptrType     = qr{
316                         (?:$Modifier\s+|const\s+)*
317                         (?:
318                                 (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)|
319                                 (?:$typeTypedefs\b)|
320                                 (?:${all}\b)
321                         )
322                         (?:\s+$Modifier|\s+const)*
323                   }x;
324         $Type   = qr{
325                         $NonptrType
326                         (?:[\s\*]+\s*const|[\s\*]+|(?:\s*\[\s*\])+)?
327                         (?:\s+$Inline|\s+$Modifier)*
328                   }x;
329         $Declare        = qr{(?:$Storage\s+)?$Type};
330 }
331 build_types();
332
333 our $match_balanced_parentheses = qr/(\((?:[^\(\)]+|(-1))*\))/;
334
335 our $Typecast   = qr{\s*(\(\s*$NonptrType\s*\)){0,1}\s*};
336 our $LvalOrFunc = qr{($Lval)\s*($match_balanced_parentheses{0,1})\s*};
337
338 sub deparenthesize {
339         my ($string) = @_;
340         return "" if (!defined($string));
341         $string =~ s@^\s*\(\s*@@g;
342         $string =~ s@\s*\)\s*$@@g;
343         $string =~ s@\s+@ @g;
344         return $string;
345 }
346
347 $chk_signoff = 0 if ($file);
348
349 my @dep_includes = ();
350 my @dep_functions = ();
351 my $removal = "Documentation/feature-removal-schedule.txt";
352 if ($tree && -f "$root/$removal") {
353         open(my $REMOVE, '<', "$root/$removal") ||
354                                 die "$P: $removal: open failed - $!\n";
355         while (<$REMOVE>) {
356                 if (/^Check:\s+(.*\S)/) {
357                         for my $entry (split(/[, ]+/, $1)) {
358                                 if ($entry =~ m@include/(.*)@) {
359                                         push(@dep_includes, $1);
360
361                                 } elsif ($entry !~ m@/@) {
362                                         push(@dep_functions, $entry);
363                                 }
364                         }
365                 }
366         }
367         close($REMOVE);
368 }
369
370 my @rawlines = ();
371 my @lines = ();
372 my $vname;
373 for my $filename (@ARGV) {
374         my $FILE;
375         if ($file) {
376                 open($FILE, '-|', "diff -u /dev/null $filename") ||
377                         die "$P: $filename: diff failed - $!\n";
378         } elsif ($filename eq '-') {
379                 open($FILE, '<&STDIN');
380         } else {
381                 open($FILE, '<', "$filename") ||
382                         die "$P: $filename: open failed - $!\n";
383         }
384         if ($filename eq '-') {
385                 $vname = 'Your patch';
386         } else {
387                 $vname = $filename;
388         }
389         while (<$FILE>) {
390                 chomp;
391                 push(@rawlines, $_);
392         }
393         close($FILE);
394         if (!process($filename)) {
395                 $exit = 1;
396         }
397         @rawlines = ();
398         @lines = ();
399 }
400
401 exit($exit);
402
403 sub top_of_kernel_tree {
404         my ($root) = @_;
405
406         my @tree_check = (
407                 "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
408                 "README", "Documentation", "arch", "include", "drivers",
409                 "fs", "init", "ipc", "kernel", "lib", "scripts",
410         );
411
412         foreach my $check (@tree_check) {
413                 if (! -e $root . '/' . $check) {
414                         return 0;
415                 }
416         }
417         return 1;
418     }
419
420 sub parse_email {
421         my ($formatted_email) = @_;
422
423         my $name = "";
424         my $address = "";
425         my $comment = "";
426
427         if ($formatted_email =~ /^(.*)<(\S+\@\S+)>(.*)$/) {
428                 $name = $1;
429                 $address = $2;
430                 $comment = $3 if defined $3;
431         } elsif ($formatted_email =~ /^\s*<(\S+\@\S+)>(.*)$/) {
432                 $address = $1;
433                 $comment = $2 if defined $2;
434         } elsif ($formatted_email =~ /(\S+\@\S+)(.*)$/) {
435                 $address = $1;
436                 $comment = $2 if defined $2;
437                 $formatted_email =~ s/$address.*$//;
438                 $name = $formatted_email;
439                 $name =~ s/^\s+|\s+$//g;
440                 $name =~ s/^\"|\"$//g;
441                 # If there's a name left after stripping spaces and
442                 # leading quotes, and the address doesn't have both
443                 # leading and trailing angle brackets, the address
444                 # is invalid. ie:
445                 #   "joe smith joe@smith.com" bad
446                 #   "joe smith <joe@smith.com" bad
447                 if ($name ne "" && $address !~ /^<[^>]+>$/) {
448                         $name = "";
449                         $address = "";
450                         $comment = "";
451                 }
452         }
453
454         $name =~ s/^\s+|\s+$//g;
455         $name =~ s/^\"|\"$//g;
456         $address =~ s/^\s+|\s+$//g;
457         $address =~ s/^\<|\>$//g;
458
459         if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
460                 $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
461                 $name = "\"$name\"";
462         }
463
464         return ($name, $address, $comment);
465 }
466
467 sub format_email {
468         my ($name, $address) = @_;
469
470         my $formatted_email;
471
472         $name =~ s/^\s+|\s+$//g;
473         $name =~ s/^\"|\"$//g;
474         $address =~ s/^\s+|\s+$//g;
475
476         if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
477                 $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
478                 $name = "\"$name\"";
479         }
480
481         if ("$name" eq "") {
482                 $formatted_email = "$address";
483         } else {
484                 $formatted_email = "$name <$address>";
485         }
486
487         return $formatted_email;
488 }
489
490 sub which_conf {
491         my ($conf) = @_;
492
493         foreach my $path (split(/:/, ".:$ENV{HOME}:.scripts")) {
494                 if (-e "$path/$conf") {
495                         return "$path/$conf";
496                 }
497         }
498
499         return "";
500 }
501
502 sub expand_tabs {
503         my ($str) = @_;
504
505         my $res = '';
506         my $n = 0;
507         for my $c (split(//, $str)) {
508                 if ($c eq "\t") {
509                         $res .= ' ';
510                         $n++;
511                         for (; ($n % 8) != 0; $n++) {
512                                 $res .= ' ';
513                         }
514                         next;
515                 }
516                 $res .= $c;
517                 $n++;
518         }
519
520         return $res;
521 }
522 sub copy_spacing {
523         (my $res = shift) =~ tr/\t/ /c;
524         return $res;
525 }
526
527 sub line_stats {
528         my ($line) = @_;
529
530         # Drop the diff line leader and expand tabs
531         $line =~ s/^.//;
532         $line = expand_tabs($line);
533
534         # Pick the indent from the front of the line.
535         my ($white) = ($line =~ /^(\s*)/);
536
537         return (length($line), length($white));
538 }
539
540 my $sanitise_quote = '';
541
542 sub sanitise_line_reset {
543         my ($in_comment) = @_;
544
545         if ($in_comment) {
546                 $sanitise_quote = '*/';
547         } else {
548                 $sanitise_quote = '';
549         }
550 }
551 sub sanitise_line {
552         my ($line) = @_;
553
554         my $res = '';
555         my $l = '';
556
557         my $qlen = 0;
558         my $off = 0;
559         my $c;
560
561         # Always copy over the diff marker.
562         $res = substr($line, 0, 1);
563
564         for ($off = 1; $off < length($line); $off++) {
565                 $c = substr($line, $off, 1);
566
567                 # Comments we are wacking completly including the begin
568                 # and end, all to $;.
569                 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
570                         $sanitise_quote = '*/';
571
572                         substr($res, $off, 2, "$;$;");
573                         $off++;
574                         next;
575                 }
576                 if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') {
577                         $sanitise_quote = '';
578                         substr($res, $off, 2, "$;$;");
579                         $off++;
580                         next;
581                 }
582                 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '//') {
583                         $sanitise_quote = '//';
584
585                         substr($res, $off, 2, $sanitise_quote);
586                         $off++;
587                         next;
588                 }
589
590                 # A \ in a string means ignore the next character.
591                 if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
592                     $c eq "\\") {
593                         substr($res, $off, 2, 'XX');
594                         $off++;
595                         next;
596                 }
597                 # Regular quotes.
598                 if ($c eq "'" || $c eq '"') {
599                         if ($sanitise_quote eq '') {
600                                 $sanitise_quote = $c;
601
602                                 substr($res, $off, 1, $c);
603                                 next;
604                         } elsif ($sanitise_quote eq $c) {
605                                 $sanitise_quote = '';
606                         }
607                 }
608
609                 #print "c<$c> SQ<$sanitise_quote>\n";
610                 if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
611                         substr($res, $off, 1, $;);
612                 } elsif ($off != 0 && $sanitise_quote eq '//' && $c ne "\t") {
613                         substr($res, $off, 1, $;);
614                 } elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
615                         substr($res, $off, 1, 'X');
616                 } else {
617                         substr($res, $off, 1, $c);
618                 }
619         }
620
621         if ($sanitise_quote eq '//') {
622                 $sanitise_quote = '';
623         }
624
625         # The pathname on a #include may be surrounded by '<' and '>'.
626         if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
627                 my $clean = 'X' x length($1);
628                 $res =~ s@\<.*\>@<$clean>@;
629
630         # The whole of a #error is a string.
631         } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
632                 my $clean = 'X' x length($1);
633                 $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
634         }
635
636         return $res;
637 }
638
639 sub ctx_statement_block {
640         my ($linenr, $remain, $off) = @_;
641         my $line = $linenr - 1;
642         my $blk = '';
643         my $soff = $off;
644         my $coff = $off - 1;
645         my $coff_set = 0;
646
647         my $loff = 0;
648
649         my $type = '';
650         my $level = 0;
651         my @stack = ();
652         my $p;
653         my $c;
654         my $len = 0;
655
656         my $remainder;
657         while (1) {
658                 @stack = (['', 0]) if ($#stack == -1);
659
660                 #warn "CSB: blk<$blk> remain<$remain>\n";
661                 # If we are about to drop off the end, pull in more
662                 # context.
663                 if ($off >= $len) {
664                         for (; $remain > 0; $line++) {
665                                 last if (!defined $lines[$line]);
666                                 next if ($lines[$line] =~ /^-/);
667                                 $remain--;
668                                 $loff = $len;
669                                 $blk .= $lines[$line] . "\n";
670                                 $len = length($blk);
671                                 $line++;
672                                 last;
673                         }
674                         # Bail if there is no further context.
675                         #warn "CSB: blk<$blk> off<$off> len<$len>\n";
676                         if ($off >= $len) {
677                                 last;
678                         }
679                 }
680                 $p = $c;
681                 $c = substr($blk, $off, 1);
682                 $remainder = substr($blk, $off);
683
684                 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
685
686                 # Handle nested #if/#else.
687                 if ($remainder =~ /^#\s*(?:ifndef|ifdef|if)\s/) {
688                         push(@stack, [ $type, $level ]);
689                 } elsif ($remainder =~ /^#\s*(?:else|elif)\b/) {
690                         ($type, $level) = @{$stack[$#stack - 1]};
691                 } elsif ($remainder =~ /^#\s*endif\b/) {
692                         ($type, $level) = @{pop(@stack)};
693                 }
694
695                 # Statement ends at the ';' or a close '}' at the
696                 # outermost level.
697                 if ($level == 0 && $c eq ';') {
698                         last;
699                 }
700
701                 # An else is really a conditional as long as its not else if
702                 if ($level == 0 && $coff_set == 0 &&
703                                 (!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
704                                 $remainder =~ /^(else)(?:\s|{)/ &&
705                                 $remainder !~ /^else\s+if\b/) {
706                         $coff = $off + length($1) - 1;
707                         $coff_set = 1;
708                         #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
709                         #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
710                 }
711
712                 if (($type eq '' || $type eq '(') && $c eq '(') {
713                         $level++;
714                         $type = '(';
715                 }
716                 if ($type eq '(' && $c eq ')') {
717                         $level--;
718                         $type = ($level != 0)? '(' : '';
719
720                         if ($level == 0 && $coff < $soff) {
721                                 $coff = $off;
722                                 $coff_set = 1;
723                                 #warn "CSB: mark coff<$coff>\n";
724                         }
725                 }
726                 if (($type eq '' || $type eq '{') && $c eq '{') {
727                         $level++;
728                         $type = '{';
729                 }
730                 if ($type eq '{' && $c eq '}') {
731                         $level--;
732                         $type = ($level != 0)? '{' : '';
733
734                         if ($level == 0) {
735                                 if (substr($blk, $off + 1, 1) eq ';') {
736                                         $off++;
737                                 }
738                                 last;
739                         }
740                 }
741                 $off++;
742         }
743         # We are truly at the end, so shuffle to the next line.
744         if ($off == $len) {
745                 $loff = $len + 1;
746                 $line++;
747                 $remain--;
748         }
749
750         my $statement = substr($blk, $soff, $off - $soff + 1);
751         my $condition = substr($blk, $soff, $coff - $soff + 1);
752
753         #warn "STATEMENT<$statement>\n";
754         #warn "CONDITION<$condition>\n";
755
756         #print "coff<$coff> soff<$off> loff<$loff>\n";
757
758         return ($statement, $condition,
759                         $line, $remain + 1, $off - $loff + 1, $level);
760 }
761
762 sub statement_lines {
763         my ($stmt) = @_;
764
765         # Strip the diff line prefixes and rip blank lines at start and end.
766         $stmt =~ s/(^|\n)./$1/g;
767         $stmt =~ s/^\s*//;
768         $stmt =~ s/\s*$//;
769
770         my @stmt_lines = ($stmt =~ /\n/g);
771
772         return $#stmt_lines + 2;
773 }
774
775 sub statement_rawlines {
776         my ($stmt) = @_;
777
778         my @stmt_lines = ($stmt =~ /\n/g);
779
780         return $#stmt_lines + 2;
781 }
782
783 sub statement_block_size {
784         my ($stmt) = @_;
785
786         $stmt =~ s/(^|\n)./$1/g;
787         $stmt =~ s/^\s*{//;
788         $stmt =~ s/}\s*$//;
789         $stmt =~ s/^\s*//;
790         $stmt =~ s/\s*$//;
791
792         my @stmt_lines = ($stmt =~ /\n/g);
793         my @stmt_statements = ($stmt =~ /;/g);
794
795         my $stmt_lines = $#stmt_lines + 2;
796         my $stmt_statements = $#stmt_statements + 1;
797
798         if ($stmt_lines > $stmt_statements) {
799                 return $stmt_lines;
800         } else {
801                 return $stmt_statements;
802         }
803 }
804
805 sub ctx_statement_full {
806         my ($linenr, $remain, $off) = @_;
807         my ($statement, $condition, $level);
808
809         my (@chunks);
810
811         # Grab the first conditional/block pair.
812         ($statement, $condition, $linenr, $remain, $off, $level) =
813                                 ctx_statement_block($linenr, $remain, $off);
814         #print "F: c<$condition> s<$statement> remain<$remain>\n";
815         push(@chunks, [ $condition, $statement ]);
816         if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
817                 return ($level, $linenr, @chunks);
818         }
819
820         # Pull in the following conditional/block pairs and see if they
821         # could continue the statement.
822         for (;;) {
823                 ($statement, $condition, $linenr, $remain, $off, $level) =
824                                 ctx_statement_block($linenr, $remain, $off);
825                 #print "C: c<$condition> s<$statement> remain<$remain>\n";
826                 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
827                 #print "C: push\n";
828                 push(@chunks, [ $condition, $statement ]);
829         }
830
831         return ($level, $linenr, @chunks);
832 }
833
834 sub ctx_block_get {
835         my ($linenr, $remain, $outer, $open, $close, $off) = @_;
836         my $line;
837         my $start = $linenr - 1;
838         my $blk = '';
839         my @o;
840         my @c;
841         my @res = ();
842
843         my $level = 0;
844         my @stack = ($level);
845         for ($line = $start; $remain > 0; $line++) {
846                 next if ($rawlines[$line] =~ /^-/);
847                 $remain--;
848
849                 $blk .= $rawlines[$line];
850
851                 # Handle nested #if/#else.
852                 if ($lines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) {
853                         push(@stack, $level);
854                 } elsif ($lines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) {
855                         $level = $stack[$#stack - 1];
856                 } elsif ($lines[$line] =~ /^.\s*#\s*endif\b/) {
857                         $level = pop(@stack);
858                 }
859
860                 foreach my $c (split(//, $lines[$line])) {
861                         ##print "C<$c>L<$level><$open$close>O<$off>\n";
862                         if ($off > 0) {
863                                 $off--;
864                                 next;
865                         }
866
867                         if ($c eq $close && $level > 0) {
868                                 $level--;
869                                 last if ($level == 0);
870                         } elsif ($c eq $open) {
871                                 $level++;
872                         }
873                 }
874
875                 if (!$outer || $level <= 1) {
876                         push(@res, $rawlines[$line]);
877                 }
878
879                 last if ($level == 0);
880         }
881
882         return ($level, @res);
883 }
884 sub ctx_block_outer {
885         my ($linenr, $remain) = @_;
886
887         my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
888         return @r;
889 }
890 sub ctx_block {
891         my ($linenr, $remain) = @_;
892
893         my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
894         return @r;
895 }
896 sub ctx_statement {
897         my ($linenr, $remain, $off) = @_;
898
899         my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
900         return @r;
901 }
902 sub ctx_block_level {
903         my ($linenr, $remain) = @_;
904
905         return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
906 }
907 sub ctx_statement_level {
908         my ($linenr, $remain, $off) = @_;
909
910         return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
911 }
912
913 sub ctx_locate_comment {
914         my ($first_line, $end_line) = @_;
915
916         # Catch a comment on the end of the line itself.
917         my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
918         return $current_comment if (defined $current_comment);
919
920         # Look through the context and try and figure out if there is a
921         # comment.
922         my $in_comment = 0;
923         $current_comment = '';
924         for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
925                 my $line = $rawlines[$linenr - 1];
926                 #warn "           $line\n";
927                 if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
928                         $in_comment = 1;
929                 }
930                 if ($line =~ m@/\*@) {
931                         $in_comment = 1;
932                 }
933                 if (!$in_comment && $current_comment ne '') {
934                         $current_comment = '';
935                 }
936                 $current_comment .= $line . "\n" if ($in_comment);
937                 if ($line =~ m@\*/@) {
938                         $in_comment = 0;
939                 }
940         }
941
942         chomp($current_comment);
943         return($current_comment);
944 }
945 sub ctx_has_comment {
946         my ($first_line, $end_line) = @_;
947         my $cmt = ctx_locate_comment($first_line, $end_line);
948
949         ##print "LINE: $rawlines[$end_line - 1 ]\n";
950         ##print "CMMT: $cmt\n";
951
952         return ($cmt ne '');
953 }
954
955 sub raw_line {
956         my ($linenr, $cnt) = @_;
957
958         my $offset = $linenr - 1;
959         $cnt++;
960
961         my $line;
962         while ($cnt) {
963                 $line = $rawlines[$offset++];
964                 next if (defined($line) && $line =~ /^-/);
965                 $cnt--;
966         }
967
968         return $line;
969 }
970
971 sub cat_vet {
972         my ($vet) = @_;
973         my ($res, $coded);
974
975         $res = '';
976         while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
977                 $res .= $1;
978                 if ($2 ne '') {
979                         $coded = sprintf("^%c", unpack('C', $2) + 64);
980                         $res .= $coded;
981                 }
982         }
983         $res =~ s/$/\$/;
984
985         return $res;
986 }
987
988 my $av_preprocessor = 0;
989 my $av_pending;
990 my @av_paren_type;
991 my $av_pend_colon;
992
993 sub annotate_reset {
994         $av_preprocessor = 0;
995         $av_pending = '_';
996         @av_paren_type = ('E');
997         $av_pend_colon = 'O';
998 }
999
1000 sub annotate_values {
1001         my ($stream, $type) = @_;
1002
1003         my $res;
1004         my $var = '_' x length($stream);
1005         my $cur = $stream;
1006
1007         print "$stream\n" if ($dbg_values > 1);
1008
1009         while (length($cur)) {
1010                 @av_paren_type = ('E') if ($#av_paren_type < 0);
1011                 print " <" . join('', @av_paren_type) .
1012                                 "> <$type> <$av_pending>" if ($dbg_values > 1);
1013                 if ($cur =~ /^(\s+)/o) {
1014                         print "WS($1)\n" if ($dbg_values > 1);
1015                         if ($1 =~ /\n/ && $av_preprocessor) {
1016                                 $type = pop(@av_paren_type);
1017                                 $av_preprocessor = 0;
1018                         }
1019
1020                 } elsif ($cur =~ /^(\(\s*$Type\s*)\)/ && $av_pending eq '_') {
1021                         print "CAST($1)\n" if ($dbg_values > 1);
1022                         push(@av_paren_type, $type);
1023                         $type = 'C';
1024
1025                 } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) {
1026                         print "DECLARE($1)\n" if ($dbg_values > 1);
1027                         $type = 'T';
1028
1029                 } elsif ($cur =~ /^($Modifier)\s*/) {
1030                         print "MODIFIER($1)\n" if ($dbg_values > 1);
1031                         $type = 'T';
1032
1033                 } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
1034                         print "DEFINE($1,$2)\n" if ($dbg_values > 1);
1035                         $av_preprocessor = 1;
1036                         push(@av_paren_type, $type);
1037                         if ($2 ne '') {
1038                                 $av_pending = 'N';
1039                         }
1040                         $type = 'E';
1041
1042                 } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
1043                         print "UNDEF($1)\n" if ($dbg_values > 1);
1044                         $av_preprocessor = 1;
1045                         push(@av_paren_type, $type);
1046
1047                 } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
1048                         print "PRE_START($1)\n" if ($dbg_values > 1);
1049                         $av_preprocessor = 1;
1050
1051                         push(@av_paren_type, $type);
1052                         push(@av_paren_type, $type);
1053                         $type = 'E';
1054
1055                 } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
1056                         print "PRE_RESTART($1)\n" if ($dbg_values > 1);
1057                         $av_preprocessor = 1;
1058
1059                         push(@av_paren_type, $av_paren_type[$#av_paren_type]);
1060
1061                         $type = 'E';
1062
1063                 } elsif ($cur =~ /^(\#\s*(?:endif))/o) {
1064                         print "PRE_END($1)\n" if ($dbg_values > 1);
1065
1066                         $av_preprocessor = 1;
1067
1068                         # Assume all arms of the conditional end as this
1069                         # one does, and continue as if the #endif was not here.
1070                         pop(@av_paren_type);
1071                         push(@av_paren_type, $type);
1072                         $type = 'E';
1073
1074                 } elsif ($cur =~ /^(\\\n)/o) {
1075                         print "PRECONT($1)\n" if ($dbg_values > 1);
1076
1077                 } elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
1078                         print "ATTR($1)\n" if ($dbg_values > 1);
1079                         $av_pending = $type;
1080                         $type = 'N';
1081
1082                 } elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
1083                         print "SIZEOF($1)\n" if ($dbg_values > 1);
1084                         if (defined $2) {
1085                                 $av_pending = 'V';
1086                         }
1087                         $type = 'N';
1088
1089                 } elsif ($cur =~ /^(if|while|for)\b/o) {
1090                         print "COND($1)\n" if ($dbg_values > 1);
1091                         $av_pending = 'E';
1092                         $type = 'N';
1093
1094                 } elsif ($cur =~/^(case)/o) {
1095                         print "CASE($1)\n" if ($dbg_values > 1);
1096                         $av_pend_colon = 'C';
1097                         $type = 'N';
1098
1099                 } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) {
1100                         print "KEYWORD($1)\n" if ($dbg_values > 1);
1101                         $type = 'N';
1102
1103                 } elsif ($cur =~ /^(\()/o) {
1104                         print "PAREN('$1')\n" if ($dbg_values > 1);
1105                         push(@av_paren_type, $av_pending);
1106                         $av_pending = '_';
1107                         $type = 'N';
1108
1109                 } elsif ($cur =~ /^(\))/o) {
1110                         my $new_type = pop(@av_paren_type);
1111                         if ($new_type ne '_') {
1112                                 $type = $new_type;
1113                                 print "PAREN('$1') -> $type\n"
1114                                                         if ($dbg_values > 1);
1115                         } else {
1116                                 print "PAREN('$1')\n" if ($dbg_values > 1);
1117                         }
1118
1119                 } elsif ($cur =~ /^($Ident)\s*\(/o) {
1120                         print "FUNC($1)\n" if ($dbg_values > 1);
1121                         $type = 'V';
1122                         $av_pending = 'V';
1123
1124                 } elsif ($cur =~ /^($Ident\s*):(?:\s*\d+\s*(,|=|;))?/) {
1125                         if (defined $2 && $type eq 'C' || $type eq 'T') {
1126                                 $av_pend_colon = 'B';
1127                         } elsif ($type eq 'E') {
1128                                 $av_pend_colon = 'L';
1129                         }
1130                         print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1);
1131                         $type = 'V';
1132
1133                 } elsif ($cur =~ /^($Ident|$Constant)/o) {
1134                         print "IDENT($1)\n" if ($dbg_values > 1);
1135                         $type = 'V';
1136
1137                 } elsif ($cur =~ /^($Assignment)/o) {
1138                         print "ASSIGN($1)\n" if ($dbg_values > 1);
1139                         $type = 'N';
1140
1141                 } elsif ($cur =~/^(;|{|})/) {
1142                         print "END($1)\n" if ($dbg_values > 1);
1143                         $type = 'E';
1144                         $av_pend_colon = 'O';
1145
1146                 } elsif ($cur =~/^(,)/) {
1147                         print "COMMA($1)\n" if ($dbg_values > 1);
1148                         $type = 'C';
1149
1150                 } elsif ($cur =~ /^(\?)/o) {
1151                         print "QUESTION($1)\n" if ($dbg_values > 1);
1152                         $type = 'N';
1153
1154                 } elsif ($cur =~ /^(:)/o) {
1155                         print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1);
1156
1157                         substr($var, length($res), 1, $av_pend_colon);
1158                         if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') {
1159                                 $type = 'E';
1160                         } else {
1161                                 $type = 'N';
1162                         }
1163                         $av_pend_colon = 'O';
1164
1165                 } elsif ($cur =~ /^(\[)/o) {
1166                         print "CLOSE($1)\n" if ($dbg_values > 1);
1167                         $type = 'N';
1168
1169                 } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
1170                         my $variant;
1171
1172                         print "OPV($1)\n" if ($dbg_values > 1);
1173                         if ($type eq 'V') {
1174                                 $variant = 'B';
1175                         } else {
1176                                 $variant = 'U';
1177                         }
1178
1179                         substr($var, length($res), 1, $variant);
1180                         $type = 'N';
1181
1182                 } elsif ($cur =~ /^($Operators)/o) {
1183                         print "OP($1)\n" if ($dbg_values > 1);
1184                         if ($1 ne '++' && $1 ne '--') {
1185                                 $type = 'N';
1186                         }
1187
1188                 } elsif ($cur =~ /(^.)/o) {
1189                         print "C($1)\n" if ($dbg_values > 1);
1190                 }
1191                 if (defined $1) {
1192                         $cur = substr($cur, length($1));
1193                         $res .= $type x length($1);
1194                 }
1195         }
1196
1197         return ($res, $var);
1198 }
1199
1200 sub possible {
1201         my ($possible, $line) = @_;
1202         my $notPermitted = qr{(?:
1203                 ^(?:
1204                         $Modifier|
1205                         $Storage|
1206                         $Type|
1207                         DEFINE_\S+
1208                 )$|
1209                 ^(?:
1210                         goto|
1211                         return|
1212                         case|
1213                         else|
1214                         asm|__asm__|
1215                         do
1216                 )(?:\s|$)|
1217                 ^(?:typedef|struct|enum)\b
1218             )}x;
1219         warn "CHECK<$possible> ($line)\n" if ($dbg_possible > 2);
1220         if ($possible !~ $notPermitted) {
1221                 # Check for modifiers.
1222                 $possible =~ s/\s*$Storage\s*//g;
1223                 $possible =~ s/\s*$Sparse\s*//g;
1224                 if ($possible =~ /^\s*$/) {
1225
1226                 } elsif ($possible =~ /\s/) {
1227                         $possible =~ s/\s*$Type\s*//g;
1228                         for my $modifier (split(' ', $possible)) {
1229                                 if ($modifier !~ $notPermitted) {
1230                                         warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible);
1231                                         push(@modifierList, $modifier);
1232                                 }
1233                         }
1234
1235                 } else {
1236                         warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible);
1237                         push(@typeList, $possible);
1238                 }
1239                 build_types();
1240         } else {
1241                 warn "NOTPOSS: $possible ($line)\n" if ($dbg_possible > 1);
1242         }
1243 }
1244
1245 my $prefix = '';
1246
1247 sub show_type {
1248        return !defined $ignore_type{$_[0]};
1249 }
1250
1251 sub report {
1252         if (!show_type($_[1]) ||
1253             (defined $tst_only && $_[2] !~ /\Q$tst_only\E/)) {
1254                 return 0;
1255         }
1256         my $line;
1257         if ($show_types) {
1258                 $line = "$prefix$_[0]:$_[1]: $_[2]\n";
1259         } else {
1260                 $line = "$prefix$_[0]: $_[2]\n";
1261         }
1262         $line = (split('\n', $line))[0] . "\n" if ($terse);
1263
1264         push(our @report, $line);
1265
1266         return 1;
1267 }
1268 sub report_dump {
1269         our @report;
1270 }
1271
1272 sub ERROR {
1273         if (report("ERROR", $_[0], $_[1])) {
1274                 our $clean = 0;
1275                 our $cnt_error++;
1276         }
1277 }
1278 sub WARN {
1279         if (report("WARNING", $_[0], $_[1])) {
1280                 our $clean = 0;
1281                 our $cnt_warn++;
1282         }
1283 }
1284 sub CHK {
1285         if ($check && report("CHECK", $_[0], $_[1])) {
1286                 our $clean = 0;
1287                 our $cnt_chk++;
1288         }
1289 }
1290
1291 sub check_absolute_file {
1292         my ($absolute, $herecurr) = @_;
1293         my $file = $absolute;
1294
1295         ##print "absolute<$absolute>\n";
1296
1297         # See if any suffix of this path is a path within the tree.
1298         while ($file =~ s@^[^/]*/@@) {
1299                 if (-f "$root/$file") {
1300                         ##print "file<$file>\n";
1301                         last;
1302                 }
1303         }
1304         if (! -f _)  {
1305                 return 0;
1306         }
1307
1308         # It is, so see if the prefix is acceptable.
1309         my $prefix = $absolute;
1310         substr($prefix, -length($file)) = '';
1311
1312         ##print "prefix<$prefix>\n";
1313         if ($prefix ne ".../") {
1314                 WARN("USE_RELATIVE_PATH",
1315                      "use relative pathname instead of absolute in changelog text\n" . $herecurr);
1316         }
1317 }
1318
1319 sub process {
1320         my $filename = shift;
1321
1322         my $linenr=0;
1323         my $prevline="";
1324         my $prevrawline="";
1325         my $stashline="";
1326         my $stashrawline="";
1327
1328         my $length;
1329         my $indent;
1330         my $previndent=0;
1331         my $stashindent=0;
1332
1333         our $clean = 1;
1334         my $signoff = 0;
1335         my $is_patch = 0;
1336
1337         my $in_header_lines = 1;
1338         my $in_commit_log = 0;          #Scanning lines before patch
1339
1340         our @report = ();
1341         our $cnt_lines = 0;
1342         our $cnt_error = 0;
1343         our $cnt_warn = 0;
1344         our $cnt_chk = 0;
1345
1346         # Trace the real file/line as we go.
1347         my $realfile = '';
1348         my $realline = 0;
1349         my $realcnt = 0;
1350         my $here = '';
1351         my $in_comment = 0;
1352         my $comment_edge = 0;
1353         my $first_line = 0;
1354         my $p1_prefix = '';
1355
1356         my $prev_values = 'E';
1357
1358         # suppression flags
1359         my %suppress_ifbraces;
1360         my %suppress_whiletrailers;
1361         my %suppress_export;
1362
1363         # Pre-scan the patch sanitizing the lines.
1364         # Pre-scan the patch looking for any __setup documentation.
1365         #
1366         my @setup_docs = ();
1367         my $setup_docs = 0;
1368
1369         sanitise_line_reset();
1370         my $line;
1371         foreach my $rawline (@rawlines) {
1372                 $linenr++;
1373                 $line = $rawline;
1374
1375                 if ($rawline=~/^\+\+\+\s+(\S+)/) {
1376                         $setup_docs = 0;
1377                         if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
1378                                 $setup_docs = 1;
1379                         }
1380                         #next;
1381                 }
1382                 if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1383                         $realline=$1-1;
1384                         if (defined $2) {
1385                                 $realcnt=$3+1;
1386                         } else {
1387                                 $realcnt=1+1;
1388                         }
1389                         $in_comment = 0;
1390
1391                         # Guestimate if this is a continuing comment.  Run
1392                         # the context looking for a comment "edge".  If this
1393                         # edge is a close comment then we must be in a comment
1394                         # at context start.
1395                         my $edge;
1396                         my $cnt = $realcnt;
1397                         for (my $ln = $linenr + 1; $cnt > 0; $ln++) {
1398                                 next if (defined $rawlines[$ln - 1] &&
1399                                          $rawlines[$ln - 1] =~ /^-/);
1400                                 $cnt--;
1401                                 #print "RAW<$rawlines[$ln - 1]>\n";
1402                                 last if (!defined $rawlines[$ln - 1]);
1403                                 if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ &&
1404                                     $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) {
1405                                         ($edge) = $1;
1406                                         last;
1407                                 }
1408                         }
1409                         if (defined $edge && $edge eq '*/') {
1410                                 $in_comment = 1;
1411                         }
1412
1413                         # Guestimate if this is a continuing comment.  If this
1414                         # is the start of a diff block and this line starts
1415                         # ' *' then it is very likely a comment.
1416                         if (!defined $edge &&
1417                             $rawlines[$linenr] =~ m@^.\s*(?:\*\*+| \*)(?:\s|$)@)
1418                         {
1419                                 $in_comment = 1;
1420                         }
1421
1422                         ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
1423                         sanitise_line_reset($in_comment);
1424
1425                 } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
1426                         # Standardise the strings and chars within the input to
1427                         # simplify matching -- only bother with positive lines.
1428                         $line = sanitise_line($rawline);
1429                 }
1430                 push(@lines, $line);
1431
1432                 if ($realcnt > 1) {
1433                         $realcnt-- if ($line =~ /^(?:\+| |$)/);
1434                 } else {
1435                         $realcnt = 0;
1436                 }
1437
1438                 #print "==>$rawline\n";
1439                 #print "-->$line\n";
1440
1441                 if ($setup_docs && $line =~ /^\+/) {
1442                         push(@setup_docs, $line);
1443                 }
1444         }
1445
1446         $prefix = '';
1447
1448         $realcnt = 0;
1449         $linenr = 0;
1450         foreach my $line (@lines) {
1451                 $linenr++;
1452
1453                 my $rawline = $rawlines[$linenr - 1];
1454
1455 #extract the line range in the file after the patch is applied
1456                 if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1457                         $is_patch = 1;
1458                         $first_line = $linenr + 1;
1459                         $realline=$1-1;
1460                         if (defined $2) {
1461                                 $realcnt=$3+1;
1462                         } else {
1463                                 $realcnt=1+1;
1464                         }
1465                         annotate_reset();
1466                         $prev_values = 'E';
1467
1468                         %suppress_ifbraces = ();
1469                         %suppress_whiletrailers = ();
1470                         %suppress_export = ();
1471                         next;
1472
1473 # track the line number as we move through the hunk, note that
1474 # new versions of GNU diff omit the leading space on completely
1475 # blank context lines so we need to count that too.
1476                 } elsif ($line =~ /^( |\+|$)/) {
1477                         $realline++;
1478                         $realcnt-- if ($realcnt != 0);
1479
1480                         # Measure the line length and indent.
1481                         ($length, $indent) = line_stats($rawline);
1482
1483                         # Track the previous line.
1484                         ($prevline, $stashline) = ($stashline, $line);
1485                         ($previndent, $stashindent) = ($stashindent, $indent);
1486                         ($prevrawline, $stashrawline) = ($stashrawline, $rawline);
1487
1488                         #warn "line<$line>\n";
1489
1490                 } elsif ($realcnt == 1) {
1491                         $realcnt--;
1492                 }
1493
1494                 my $hunk_line = ($realcnt != 0);
1495
1496 #make up the handle for any error we report on this line
1497                 $prefix = "$filename:$realline: " if ($emacs && $file);
1498                 $prefix = "$filename:$linenr: " if ($emacs && !$file);
1499
1500                 $here = "#$linenr: " if (!$file);
1501                 $here = "#$realline: " if ($file);
1502
1503                 # extract the filename as it passes
1504                 if ($line =~ /^diff --git.*?(\S+)$/) {
1505                         $realfile = $1;
1506                         $realfile =~ s@^([^/]*)/@@;
1507                         $in_commit_log = 0;
1508                 } elsif ($line =~ /^\+\+\+\s+(\S+)/) {
1509                         $realfile = $1;
1510                         $realfile =~ s@^([^/]*)/@@;
1511                         $in_commit_log = 0;
1512
1513                         $p1_prefix = $1;
1514                         if (!$file && $tree && $p1_prefix ne '' &&
1515                             -e "$root/$p1_prefix") {
1516                                 WARN("PATCH_PREFIX",
1517                                      "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
1518                         }
1519
1520                         if ($realfile =~ m@^include/asm/@) {
1521                                 ERROR("MODIFIED_INCLUDE_ASM",
1522                                       "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
1523                         }
1524                         next;
1525                 }
1526
1527                 $here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
1528
1529                 my $hereline = "$here\n$rawline\n";
1530                 my $herecurr = "$here\n$rawline\n";
1531                 my $hereprev = "$here\n$prevrawline\n$rawline\n";
1532
1533                 $cnt_lines++ if ($realcnt != 0);
1534
1535 # Check for incorrect file permissions
1536                 if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
1537                         my $permhere = $here . "FILE: $realfile\n";
1538                         if ($realfile =~ /(Makefile|Kconfig|\.c|\.h|\.S|\.tmpl)$/) {
1539                                 ERROR("EXECUTE_PERMISSIONS",
1540                                       "do not set execute permissions for source files\n" . $permhere);
1541                         }
1542                 }
1543
1544 # Check the patch for a signoff:
1545                 if ($line =~ /^\s*signed-off-by:/i) {
1546                         $signoff++;
1547                         $in_commit_log = 0;
1548                 }
1549
1550 # Check signature styles
1551                 if (!$in_header_lines &&
1552                     $line =~ /^(\s*)($signature_tags)(\s*)(.*)/) {
1553                         my $space_before = $1;
1554                         my $sign_off = $2;
1555                         my $space_after = $3;
1556                         my $email = $4;
1557                         my $ucfirst_sign_off = ucfirst(lc($sign_off));
1558
1559                         if (defined $space_before && $space_before ne "") {
1560                                 WARN("BAD_SIGN_OFF",
1561                                      "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr);
1562                         }
1563                         if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
1564                                 WARN("BAD_SIGN_OFF",
1565                                      "'$ucfirst_sign_off' is the preferred signature form\n" . $herecurr);
1566                         }
1567                         if (!defined $space_after || $space_after ne " ") {
1568                                 WARN("BAD_SIGN_OFF",
1569                                      "Use a single space after $ucfirst_sign_off\n" . $herecurr);
1570                         }
1571
1572                         my ($email_name, $email_address, $comment) = parse_email($email);
1573                         my $suggested_email = format_email(($email_name, $email_address));
1574                         if ($suggested_email eq "") {
1575                                 ERROR("BAD_SIGN_OFF",
1576                                       "Unrecognized email address: '$email'\n" . $herecurr);
1577                         } else {
1578                                 my $dequoted = $suggested_email;
1579                                 $dequoted =~ s/^"//;
1580                                 $dequoted =~ s/" </ </;
1581                                 # Don't force email to have quotes
1582                                 # Allow just an angle bracketed address
1583                                 if ("$dequoted$comment" ne $email &&
1584                                     "<$email_address>$comment" ne $email &&
1585                                     "$suggested_email$comment" ne $email) {
1586                                         WARN("BAD_SIGN_OFF",
1587                                              "email address '$email' might be better as '$suggested_email$comment'\n" . $herecurr);
1588                                 }
1589                         }
1590                 }
1591
1592 # Check for wrappage within a valid hunk of the file
1593                 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
1594                         ERROR("CORRUPTED_PATCH",
1595                               "patch seems to be corrupt (line wrapped?)\n" .
1596                                 $herecurr) if (!$emitted_corrupt++);
1597                 }
1598
1599 # Check for absolute kernel paths.
1600                 if ($tree) {
1601                         while ($line =~ m{(?:^|\s)(/\S*)}g) {
1602                                 my $file = $1;
1603
1604                                 if ($file =~ m{^(.*?)(?::\d+)+:?$} &&
1605                                     check_absolute_file($1, $herecurr)) {
1606                                         #
1607                                 } else {
1608                                         check_absolute_file($file, $herecurr);
1609                                 }
1610                         }
1611                 }
1612
1613 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
1614                 if (($realfile =~ /^$/ || $line =~ /^\+/) &&
1615                     $rawline !~ m/^$UTF8*$/) {
1616                         my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/);
1617
1618                         my $blank = copy_spacing($rawline);
1619                         my $ptr = substr($blank, 0, length($utf8_prefix)) . "^";
1620                         my $hereptr = "$hereline$ptr\n";
1621
1622                         CHK("INVALID_UTF8",
1623                             "Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
1624                 }
1625
1626 # Check if it's the start of a commit log
1627 # (not a header line and we haven't seen the patch filename)
1628                 if ($in_header_lines && $realfile =~ /^$/ &&
1629                     $rawline !~ /^(commit\b|from\b|[\w-]+:).+$/i) {
1630                         $in_header_lines = 0;
1631                         $in_commit_log = 1;
1632                 }
1633
1634 # Still not yet in a patch, check for any UTF-8
1635                 if ($in_commit_log && $realfile =~ /^$/ &&
1636                     $rawline =~ /$NON_ASCII_UTF8/) {
1637                         CHK("UTF8_BEFORE_PATCH",
1638                             "8-bit UTF-8 used in possible commit log\n" . $herecurr);
1639                 }
1640
1641 # ignore non-hunk lines and lines being removed
1642                 next if (!$hunk_line || $line =~ /^-/);
1643
1644 #trailing whitespace
1645                 if ($line =~ /^\+.*\015/) {
1646                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1647                         ERROR("DOS_LINE_ENDINGS",
1648                               "DOS line endings\n" . $herevet);
1649
1650                 } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
1651                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1652                         ERROR("TRAILING_WHITESPACE",
1653                               "trailing whitespace\n" . $herevet);
1654                         $rpt_cleaners = 1;
1655                 }
1656
1657 # check for Kconfig help text having a real description
1658 # Only applies when adding the entry originally, after that we do not have
1659 # sufficient context to determine whether it is indeed long enough.
1660                 if ($realfile =~ /Kconfig/ &&
1661                     $line =~ /\+\s*(?:---)?help(?:---)?$/) {
1662                         my $length = 0;
1663                         my $cnt = $realcnt;
1664                         my $ln = $linenr + 1;
1665                         my $f;
1666                         my $is_end = 0;
1667                         while ($cnt > 0 && defined $lines[$ln - 1]) {
1668                                 $f = $lines[$ln - 1];
1669                                 $cnt-- if ($lines[$ln - 1] !~ /^-/);
1670                                 $is_end = $lines[$ln - 1] =~ /^\+/;
1671                                 $ln++;
1672
1673                                 next if ($f =~ /^-/);
1674                                 $f =~ s/^.//;
1675                                 $f =~ s/#.*//;
1676                                 $f =~ s/^\s+//;
1677                                 next if ($f =~ /^$/);
1678                                 if ($f =~ /^\s*config\s/) {
1679                                         $is_end = 1;
1680                                         last;
1681                                 }
1682                                 $length++;
1683                         }
1684                         WARN("CONFIG_DESCRIPTION",
1685                              "please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($is_end && $length < 4);
1686                         #print "is_end<$is_end> length<$length>\n";
1687                 }
1688
1689                 if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
1690                     ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
1691                         my $flag = $1;
1692                         my $replacement = {
1693                                 'EXTRA_AFLAGS' =>   'asflags-y',
1694                                 'EXTRA_CFLAGS' =>   'ccflags-y',
1695                                 'EXTRA_CPPFLAGS' => 'cppflags-y',
1696                                 'EXTRA_LDFLAGS' =>  'ldflags-y',
1697                         };
1698
1699                         WARN("DEPRECATED_VARIABLE",
1700                              "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
1701                 }
1702
1703 # check we are in a valid source file if not then ignore this hunk
1704                 next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
1705
1706 #80 column limit
1707                 if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
1708                     $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
1709                     !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ ||
1710                     $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
1711                     $length > 80)
1712                 {
1713                         WARN("LONG_LINE",
1714                              "line over 80 characters\n" . $herecurr);
1715                 }
1716
1717 # check for spaces before a quoted newline
1718                 if ($rawline =~ /^.*\".*\s\\n/) {
1719                         WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE",
1720                              "unnecessary whitespace before a quoted newline\n" . $herecurr);
1721                 }
1722
1723 # check for adding lines without a newline.
1724                 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
1725                         WARN("MISSING_EOF_NEWLINE",
1726                              "adding a line without newline at end of file\n" . $herecurr);
1727                 }
1728
1729 # Blackfin: use hi/lo macros
1730                 if ($realfile =~ m@arch/blackfin/.*\.S$@) {
1731                         if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) {
1732                                 my $herevet = "$here\n" . cat_vet($line) . "\n";
1733                                 ERROR("LO_MACRO",
1734                                       "use the LO() macro, not (... & 0xFFFF)\n" . $herevet);
1735                         }
1736                         if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) {
1737                                 my $herevet = "$here\n" . cat_vet($line) . "\n";
1738                                 ERROR("HI_MACRO",
1739                                       "use the HI() macro, not (... >> 16)\n" . $herevet);
1740                         }
1741                 }
1742
1743 # check we are in a valid source file C or perl if not then ignore this hunk
1744                 next if ($realfile !~ /\.(h|c|pl)$/);
1745
1746 # at the beginning of a line any tabs must come first and anything
1747 # more than 8 must use tabs.
1748                 if ($rawline =~ /^\+\s* \t\s*\S/ ||
1749                     $rawline =~ /^\+\s*        \s*/) {
1750                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1751                         ERROR("CODE_INDENT",
1752                               "code indent should use tabs where possible\n" . $herevet);
1753                         $rpt_cleaners = 1;
1754                 }
1755
1756 # check for space before tabs.
1757                 if ($rawline =~ /^\+/ && $rawline =~ / \t/) {
1758                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1759                         WARN("SPACE_BEFORE_TAB",
1760                              "please, no space before tabs\n" . $herevet);
1761                 }
1762
1763 # check for spaces at the beginning of a line.
1764 # Exceptions:
1765 #  1) within comments
1766 #  2) indented preprocessor commands
1767 #  3) hanging labels
1768                 if ($rawline =~ /^\+ / && $line !~ /\+ *(?:$;|#|$Ident:)/)  {
1769                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1770                         WARN("LEADING_SPACE",
1771                              "please, no spaces at the start of a line\n" . $herevet);
1772                 }
1773
1774 # check we are in a valid C source file if not then ignore this hunk
1775                 next if ($realfile !~ /\.(h|c)$/);
1776
1777 # check for RCS/CVS revision markers
1778                 if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
1779                         WARN("CVS_KEYWORD",
1780                              "CVS style keyword markers, these will _not_ be updated\n". $herecurr);
1781                 }
1782
1783 # Blackfin: don't use __builtin_bfin_[cs]sync
1784                 if ($line =~ /__builtin_bfin_csync/) {
1785                         my $herevet = "$here\n" . cat_vet($line) . "\n";
1786                         ERROR("CSYNC",
1787                               "use the CSYNC() macro in asm/blackfin.h\n" . $herevet);
1788                 }
1789                 if ($line =~ /__builtin_bfin_ssync/) {
1790                         my $herevet = "$here\n" . cat_vet($line) . "\n";
1791                         ERROR("SSYNC",
1792                               "use the SSYNC() macro in asm/blackfin.h\n" . $herevet);
1793                 }
1794
1795 # Check for potential 'bare' types
1796                 my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
1797                     $realline_next);
1798                 if ($realcnt && $line =~ /.\s*\S/) {
1799                         ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
1800                                 ctx_statement_block($linenr, $realcnt, 0);
1801                         $stat =~ s/\n./\n /g;
1802                         $cond =~ s/\n./\n /g;
1803
1804                         # Find the real next line.
1805                         $realline_next = $line_nr_next;
1806                         if (defined $realline_next &&
1807                             (!defined $lines[$realline_next - 1] ||
1808                              substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
1809                                 $realline_next++;
1810                         }
1811
1812                         my $s = $stat;
1813                         $s =~ s/{.*$//s;
1814
1815                         # Ignore goto labels.
1816                         if ($s =~ /$Ident:\*$/s) {
1817
1818                         # Ignore functions being called
1819                         } elsif ($s =~ /^.\s*$Ident\s*\(/s) {
1820
1821                         } elsif ($s =~ /^.\s*else\b/s) {
1822
1823                         # declarations always start with types
1824                         } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
1825                                 my $type = $1;
1826                                 $type =~ s/\s+/ /g;
1827                                 possible($type, "A:" . $s);
1828
1829                         # definitions in global scope can only start with types
1830                         } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b\s*(?!:)/s) {
1831                                 possible($1, "B:" . $s);
1832                         }
1833
1834                         # any (foo ... *) is a pointer cast, and foo is a type
1835                         while ($s =~ /\(($Ident)(?:\s+$Sparse)*[\s\*]+\s*\)/sg) {
1836                                 possible($1, "C:" . $s);
1837                         }
1838
1839                         # Check for any sort of function declaration.
1840                         # int foo(something bar, other baz);
1841                         # void (*store_gdt)(x86_descr_ptr *);
1842                         if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
1843                                 my ($name_len) = length($1);
1844
1845                                 my $ctx = $s;
1846                                 substr($ctx, 0, $name_len + 1, '');
1847                                 $ctx =~ s/\)[^\)]*$//;
1848
1849                                 for my $arg (split(/\s*,\s*/, $ctx)) {
1850                                         if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
1851
1852                                                 possible($1, "D:" . $s);
1853                                         }
1854                                 }
1855                         }
1856
1857                 }
1858
1859 #
1860 # Checks which may be anchored in the context.
1861 #
1862
1863 # Check for switch () and associated case and default
1864 # statements should be at the same indent.
1865                 if ($line=~/\bswitch\s*\(.*\)/) {
1866                         my $err = '';
1867                         my $sep = '';
1868                         my @ctx = ctx_block_outer($linenr, $realcnt);
1869                         shift(@ctx);
1870                         for my $ctx (@ctx) {
1871                                 my ($clen, $cindent) = line_stats($ctx);
1872                                 if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
1873                                                         $indent != $cindent) {
1874                                         $err .= "$sep$ctx\n";
1875                                         $sep = '';
1876                                 } else {
1877                                         $sep = "[...]\n";
1878                                 }
1879                         }
1880                         if ($err ne '') {
1881                                 ERROR("SWITCH_CASE_INDENT_LEVEL",
1882                                       "switch and case should be at the same indent\n$hereline$err");
1883                         }
1884                 }
1885
1886 # if/while/etc brace do not go on next line, unless defining a do while loop,
1887 # or if that brace on the next line is for something else
1888                 if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
1889                         my $pre_ctx = "$1$2";
1890
1891                         my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
1892                         my $ctx_cnt = $realcnt - $#ctx - 1;
1893                         my $ctx = join("\n", @ctx);
1894
1895                         my $ctx_ln = $linenr;
1896                         my $ctx_skip = $realcnt;
1897
1898                         while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt &&
1899                                         defined $lines[$ctx_ln - 1] &&
1900                                         $lines[$ctx_ln - 1] =~ /^-/)) {
1901                                 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
1902                                 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
1903                                 $ctx_ln++;
1904                         }
1905
1906                         #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
1907                         #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
1908
1909                         if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
1910                                 ERROR("OPEN_BRACE",
1911                                       "that open brace { should be on the previous line\n" .
1912                                         "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
1913                         }
1914                         if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
1915                             $ctx =~ /\)\s*\;\s*$/ &&
1916                             defined $lines[$ctx_ln - 1])
1917                         {
1918                                 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
1919                                 if ($nindent > $indent) {
1920                                         WARN("TRAILING_SEMICOLON",
1921                                              "trailing semicolon indicates no statements, indent implies otherwise\n" .
1922                                                 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
1923                                 }
1924                         }
1925                 }
1926
1927 # Check relative indent for conditionals and blocks.
1928                 if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
1929                         my ($s, $c) = ($stat, $cond);
1930
1931                         substr($s, 0, length($c), '');
1932
1933                         # Make sure we remove the line prefixes as we have
1934                         # none on the first line, and are going to readd them
1935                         # where necessary.
1936                         $s =~ s/\n./\n/gs;
1937
1938                         # Find out how long the conditional actually is.
1939                         my @newlines = ($c =~ /\n/gs);
1940                         my $cond_lines = 1 + $#newlines;
1941
1942                         # We want to check the first line inside the block
1943                         # starting at the end of the conditional, so remove:
1944                         #  1) any blank line termination
1945                         #  2) any opening brace { on end of the line
1946                         #  3) any do (...) {
1947                         my $continuation = 0;
1948                         my $check = 0;
1949                         $s =~ s/^.*\bdo\b//;
1950                         $s =~ s/^\s*{//;
1951                         if ($s =~ s/^\s*\\//) {
1952                                 $continuation = 1;
1953                         }
1954                         if ($s =~ s/^\s*?\n//) {
1955                                 $check = 1;
1956                                 $cond_lines++;
1957                         }
1958
1959                         # Also ignore a loop construct at the end of a
1960                         # preprocessor statement.
1961                         if (($prevline =~ /^.\s*#\s*define\s/ ||
1962                             $prevline =~ /\\\s*$/) && $continuation == 0) {
1963                                 $check = 0;
1964                         }
1965
1966                         my $cond_ptr = -1;
1967                         $continuation = 0;
1968                         while ($cond_ptr != $cond_lines) {
1969                                 $cond_ptr = $cond_lines;
1970
1971                                 # If we see an #else/#elif then the code
1972                                 # is not linear.
1973                                 if ($s =~ /^\s*\#\s*(?:else|elif)/) {
1974                                         $check = 0;
1975                                 }
1976
1977                                 # Ignore:
1978                                 #  1) blank lines, they should be at 0,
1979                                 #  2) preprocessor lines, and
1980                                 #  3) labels.
1981                                 if ($continuation ||
1982                                     $s =~ /^\s*?\n/ ||
1983                                     $s =~ /^\s*#\s*?/ ||
1984                                     $s =~ /^\s*$Ident\s*:/) {
1985                                         $continuation = ($s =~ /^.*?\\\n/) ? 1 : 0;
1986                                         if ($s =~ s/^.*?\n//) {
1987                                                 $cond_lines++;
1988                                         }
1989                                 }
1990                         }
1991
1992                         my (undef, $sindent) = line_stats("+" . $s);
1993                         my $stat_real = raw_line($linenr, $cond_lines);
1994
1995                         # Check if either of these lines are modified, else
1996                         # this is not this patch's fault.
1997                         if (!defined($stat_real) ||
1998                             $stat !~ /^\+/ && $stat_real !~ /^\+/) {
1999                                 $check = 0;
2000                         }
2001                         if (defined($stat_real) && $cond_lines > 1) {
2002                                 $stat_real = "[...]\n$stat_real";
2003                         }
2004
2005                         #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
2006
2007                         if ($check && (($sindent % 8) != 0 ||
2008                             ($sindent <= $indent && $s ne ''))) {
2009                                 WARN("SUSPECT_CODE_INDENT",
2010                                      "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
2011                         }
2012                 }
2013
2014                 # Track the 'values' across context and added lines.
2015                 my $opline = $line; $opline =~ s/^./ /;
2016                 my ($curr_values, $curr_vars) =
2017                                 annotate_values($opline . "\n", $prev_values);
2018                 $curr_values = $prev_values . $curr_values;
2019                 if ($dbg_values) {
2020                         my $outline = $opline; $outline =~ s/\t/ /g;
2021                         print "$linenr > .$outline\n";
2022                         print "$linenr > $curr_values\n";
2023                         print "$linenr >  $curr_vars\n";
2024                 }
2025                 $prev_values = substr($curr_values, -1);
2026
2027 #ignore lines not being added
2028                 if ($line=~/^[^\+]/) {next;}
2029
2030 # TEST: allow direct testing of the type matcher.
2031                 if ($dbg_type) {
2032                         if ($line =~ /^.\s*$Declare\s*$/) {
2033                                 ERROR("TEST_TYPE",
2034                                       "TEST: is type\n" . $herecurr);
2035                         } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) {
2036                                 ERROR("TEST_NOT_TYPE",
2037                                       "TEST: is not type ($1 is)\n". $herecurr);
2038                         }
2039                         next;
2040                 }
2041 # TEST: allow direct testing of the attribute matcher.
2042                 if ($dbg_attr) {
2043                         if ($line =~ /^.\s*$Modifier\s*$/) {
2044                                 ERROR("TEST_ATTR",
2045                                       "TEST: is attr\n" . $herecurr);
2046                         } elsif ($dbg_attr > 1 && $line =~ /^.+($Modifier)/) {
2047                                 ERROR("TEST_NOT_ATTR",
2048                                       "TEST: is not attr ($1 is)\n". $herecurr);
2049                         }
2050                         next;
2051                 }
2052
2053 # check for initialisation to aggregates open brace on the next line
2054                 if ($line =~ /^.\s*{/ &&
2055                     $prevline =~ /(?:^|[^=])=\s*$/) {
2056                         ERROR("OPEN_BRACE",
2057                               "that open brace { should be on the previous line\n" . $hereprev);
2058                 }
2059
2060 #
2061 # Checks which are anchored on the added line.
2062 #
2063
2064 # check for malformed paths in #include statements (uses RAW line)
2065                 if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) {
2066                         my $path = $1;
2067                         if ($path =~ m{//}) {
2068                                 ERROR("MALFORMED_INCLUDE",
2069                                       "malformed #include filename\n" .
2070                                         $herecurr);
2071                         }
2072                 }
2073
2074 # no C99 // comments
2075                 if ($line =~ m{//}) {
2076                         ERROR("C99_COMMENTS",
2077                               "do not use C99 // comments\n" . $herecurr);
2078                 }
2079                 # Remove C99 comments.
2080                 $line =~ s@//.*@@;
2081                 $opline =~ s@//.*@@;
2082
2083 # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
2084 # the whole statement.
2085 #print "APW <$lines[$realline_next - 1]>\n";
2086                 if (defined $realline_next &&
2087                     exists $lines[$realline_next - 1] &&
2088                     !defined $suppress_export{$realline_next} &&
2089                     ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
2090                      $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
2091                         # Handle definitions which produce identifiers with
2092                         # a prefix:
2093                         #   XXX(foo);
2094                         #   EXPORT_SYMBOL(something_foo);
2095                         my $name = $1;
2096                         if ($stat =~ /^.([A-Z_]+)\s*\(\s*($Ident)/ &&
2097                             $name =~ /^${Ident}_$2/) {
2098 #print "FOO C name<$name>\n";
2099                                 $suppress_export{$realline_next} = 1;
2100
2101                         } elsif ($stat !~ /(?:
2102                                 \n.}\s*$|
2103                                 ^.DEFINE_$Ident\(\Q$name\E\)|
2104                                 ^.DECLARE_$Ident\(\Q$name\E\)|
2105                                 ^.LIST_HEAD\(\Q$name\E\)|
2106                                 ^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(|
2107                                 \b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\()
2108                             )/x) {
2109 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
2110                                 $suppress_export{$realline_next} = 2;
2111                         } else {
2112                                 $suppress_export{$realline_next} = 1;
2113                         }
2114                 }
2115                 if (!defined $suppress_export{$linenr} &&
2116                     $prevline =~ /^.\s*$/ &&
2117                     ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
2118                      $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
2119 #print "FOO B <$lines[$linenr - 1]>\n";
2120                         $suppress_export{$linenr} = 2;
2121                 }
2122                 if (defined $suppress_export{$linenr} &&
2123                     $suppress_export{$linenr} == 2) {
2124                         WARN("EXPORT_SYMBOL",
2125                              "EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
2126                 }
2127
2128 # check for global initialisers.
2129                 if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) {
2130                         ERROR("GLOBAL_INITIALISERS",
2131                               "do not initialise globals to 0 or NULL\n" .
2132                                 $herecurr);
2133                 }
2134 # check for static initialisers.
2135                 if ($line =~ /\bstatic\s.*=\s*(0|NULL|false)\s*;/) {
2136                         ERROR("INITIALISED_STATIC",
2137                               "do not initialise statics to 0 or NULL\n" .
2138                                 $herecurr);
2139                 }
2140
2141 # check for static const char * arrays.
2142                 if ($line =~ /\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) {
2143                         WARN("STATIC_CONST_CHAR_ARRAY",
2144                              "static const char * array should probably be static const char * const\n" .
2145                                 $herecurr);
2146                }
2147
2148 # check for static char foo[] = "bar" declarations.
2149                 if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) {
2150                         WARN("STATIC_CONST_CHAR_ARRAY",
2151                              "static char array declaration should probably be static const char\n" .
2152                                 $herecurr);
2153                }
2154
2155 # check for declarations of struct pci_device_id
2156                 if ($line =~ /\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) {
2157                         WARN("DEFINE_PCI_DEVICE_TABLE",
2158                              "Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id\n" . $herecurr);
2159                 }
2160
2161 # check for new typedefs, only function parameters and sparse annotations
2162 # make sense.
2163                 if ($line =~ /\btypedef\s/ &&
2164                     $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ &&
2165                     $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ &&
2166                     $line !~ /\b$typeTypedefs\b/ &&
2167                     $line !~ /\b__bitwise(?:__|)\b/) {
2168                         WARN("NEW_TYPEDEFS",
2169                              "do not add new typedefs\n" . $herecurr);
2170                 }
2171
2172 # * goes on variable not on type
2173                 # (char*[ const])
2174                 if ($line =~ m{\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\)}) {
2175                         my ($from, $to) = ($1, $1);
2176
2177                         # Should start with a space.
2178                         $to =~ s/^(\S)/ $1/;
2179                         # Should not end with a space.
2180                         $to =~ s/\s+$//;
2181                         # '*'s should not have spaces between.
2182                         while ($to =~ s/\*\s+\*/\*\*/) {
2183                         }
2184
2185                         #print "from<$from> to<$to>\n";
2186                         if ($from ne $to) {
2187                                 ERROR("POINTER_LOCATION",
2188                                       "\"(foo$from)\" should be \"(foo$to)\"\n" .  $herecurr);
2189                         }
2190                 } elsif ($line =~ m{\b$NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)($Ident)}) {
2191                         my ($from, $to, $ident) = ($1, $1, $2);
2192
2193                         # Should start with a space.
2194                         $to =~ s/^(\S)/ $1/;
2195                         # Should not end with a space.
2196                         $to =~ s/\s+$//;
2197                         # '*'s should not have spaces between.
2198                         while ($to =~ s/\*\s+\*/\*\*/) {
2199                         }
2200                         # Modifiers should have spaces.
2201                         $to =~ s/(\b$Modifier$)/$1 /;
2202
2203                         #print "from<$from> to<$to> ident<$ident>\n";
2204                         if ($from ne $to && $ident !~ /^$Modifier$/) {
2205                                 ERROR("POINTER_LOCATION",
2206                                       "\"foo${from}bar\" should be \"foo${to}bar\"\n" .  $herecurr);
2207                         }
2208                 }
2209
2210 # # no BUG() or BUG_ON()
2211 #               if ($line =~ /\b(BUG|BUG_ON)\b/) {
2212 #                       print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
2213 #                       print "$herecurr";
2214 #                       $clean = 0;
2215 #               }
2216
2217                 if ($line =~ /\bLINUX_VERSION_CODE\b/) {
2218                         WARN("LINUX_VERSION_CODE",
2219                              "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
2220                 }
2221
2222 # check for uses of printk_ratelimit
2223                 if ($line =~ /\bprintk_ratelimit\s*\(/) {
2224                         WARN("PRINTK_RATELIMITED",
2225 "Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit\n" . $herecurr);
2226                 }
2227
2228 # printk should use KERN_* levels.  Note that follow on printk's on the
2229 # same line do not need a level, so we use the current block context
2230 # to try and find and validate the current printk.  In summary the current
2231 # printk includes all preceding printk's which have no newline on the end.
2232 # we assume the first bad printk is the one to report.
2233                 if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
2234                         my $ok = 0;
2235                         for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
2236                                 #print "CHECK<$lines[$ln - 1]\n";
2237                                 # we have a preceding printk if it ends
2238                                 # with "\n" ignore it, else it is to blame
2239                                 if ($lines[$ln - 1] =~ m{\bprintk\(}) {
2240                                         if ($rawlines[$ln - 1] !~ m{\\n"}) {
2241                                                 $ok = 1;
2242                                         }
2243                                         last;
2244                                 }
2245                         }
2246                         if ($ok == 0) {
2247                                 WARN("PRINTK_WITHOUT_KERN_LEVEL",
2248                                      "printk() should include KERN_ facility level\n" . $herecurr);
2249                         }
2250                 }
2251
2252 # function brace can't be on same line, except for #defines of do while,
2253 # or if closed on same line
2254                 if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
2255                     !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) {
2256                         ERROR("OPEN_BRACE",
2257                               "open brace '{' following function declarations go on the next line\n" . $herecurr);
2258                 }
2259
2260 # open braces for enum, union and struct go on the same line.
2261                 if ($line =~ /^.\s*{/ &&
2262                     $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
2263                         ERROR("OPEN_BRACE",
2264                               "open brace '{' following $1 go on the same line\n" . $hereprev);
2265                 }
2266
2267 # missing space after union, struct or enum definition
2268                 if ($line =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?(?:\s+$Ident)?[=\{]/) {
2269                     WARN("SPACING",
2270                          "missing space after $1 definition\n" . $herecurr);
2271                 }
2272
2273 # check for spacing round square brackets; allowed:
2274 #  1. with a type on the left -- int [] a;
2275 #  2. at the beginning of a line for slice initialisers -- [0...10] = 5,
2276 #  3. inside a curly brace -- = { [0...10] = 5 }
2277                 while ($line =~ /(.*?\s)\[/g) {
2278                         my ($where, $prefix) = ($-[1], $1);
2279                         if ($prefix !~ /$Type\s+$/ &&
2280                             ($where != 0 || $prefix !~ /^.\s+$/) &&
2281                             $prefix !~ /{\s+$/) {
2282                                 ERROR("BRACKET_SPACE",
2283                                       "space prohibited before open square bracket '['\n" . $herecurr);
2284                         }
2285                 }
2286
2287 # check for spaces between functions and their parentheses.
2288                 while ($line =~ /($Ident)\s+\(/g) {
2289                         my $name = $1;
2290                         my $ctx_before = substr($line, 0, $-[1]);
2291                         my $ctx = "$ctx_before$name";
2292
2293                         # Ignore those directives where spaces _are_ permitted.
2294                         if ($name =~ /^(?:
2295                                 if|for|while|switch|return|case|
2296                                 volatile|__volatile__|
2297                                 __attribute__|format|__extension__|
2298                                 asm|__asm__)$/x)
2299                         {
2300
2301                         # cpp #define statements have non-optional spaces, ie
2302                         # if there is a space between the name and the open
2303                         # parenthesis it is simply not a parameter group.
2304                         } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
2305
2306                         # cpp #elif statement condition may start with a (
2307                         } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) {
2308
2309                         # If this whole things ends with a type its most
2310                         # likely a typedef for a function.
2311                         } elsif ($ctx =~ /$Type$/) {
2312
2313                         } else {
2314                                 WARN("SPACING",
2315                                      "space prohibited between function name and open parenthesis '('\n" . $herecurr);
2316                         }
2317                 }
2318 # Check operator spacing.
2319                 if (!($line=~/\#\s*include/)) {
2320                         my $ops = qr{
2321                                 <<=|>>=|<=|>=|==|!=|
2322                                 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
2323                                 =>|->|<<|>>|<|>|=|!|~|
2324                                 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
2325                                 \?|:
2326                         }x;
2327                         my @elements = split(/($ops|;)/, $opline);
2328                         my $off = 0;
2329
2330                         my $blank = copy_spacing($opline);
2331
2332                         for (my $n = 0; $n < $#elements; $n += 2) {
2333                                 $off += length($elements[$n]);
2334
2335                                 # Pick up the preceding and succeeding characters.
2336                                 my $ca = substr($opline, 0, $off);
2337                                 my $cc = '';
2338                                 if (length($opline) >= ($off + length($elements[$n + 1]))) {
2339                                         $cc = substr($opline, $off + length($elements[$n + 1]));
2340                                 }
2341                                 my $cb = "$ca$;$cc";
2342
2343                                 my $a = '';
2344                                 $a = 'V' if ($elements[$n] ne '');
2345                                 $a = 'W' if ($elements[$n] =~ /\s$/);
2346                                 $a = 'C' if ($elements[$n] =~ /$;$/);
2347                                 $a = 'B' if ($elements[$n] =~ /(\[|\()$/);
2348                                 $a = 'O' if ($elements[$n] eq '');
2349                                 $a = 'E' if ($ca =~ /^\s*$/);
2350
2351                                 my $op = $elements[$n + 1];
2352
2353                                 my $c = '';
2354                                 if (defined $elements[$n + 2]) {
2355                                         $c = 'V' if ($elements[$n + 2] ne '');
2356                                         $c = 'W' if ($elements[$n + 2] =~ /^\s/);
2357                                         $c = 'C' if ($elements[$n + 2] =~ /^$;/);
2358                                         $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
2359                                         $c = 'O' if ($elements[$n + 2] eq '');
2360                                         $c = 'E' if ($elements[$n + 2] =~ /^\s*\\$/);
2361                                 } else {
2362                                         $c = 'E';
2363                                 }
2364
2365                                 my $ctx = "${a}x${c}";
2366
2367                                 my $at = "(ctx:$ctx)";
2368
2369                                 my $ptr = substr($blank, 0, $off) . "^";
2370                                 my $hereptr = "$hereline$ptr\n";
2371
2372                                 # Pull out the value of this operator.
2373                                 my $op_type = substr($curr_values, $off + 1, 1);
2374
2375                                 # Get the full operator variant.
2376                                 my $opv = $op . substr($curr_vars, $off, 1);
2377
2378                                 # Ignore operators passed as parameters.
2379                                 if ($op_type ne 'V' &&
2380                                     $ca =~ /\s$/ && $cc =~ /^\s*,/) {
2381
2382 #                               # Ignore comments
2383 #                               } elsif ($op =~ /^$;+$/) {
2384
2385                                 # ; should have either the end of line or a space or \ after it
2386                                 } elsif ($op eq ';') {
2387                                         if ($ctx !~ /.x[WEBC]/ &&
2388                                             $cc !~ /^\\/ && $cc !~ /^;/) {
2389                                                 ERROR("SPACING",
2390                                                       "space required after that '$op' $at\n" . $hereptr);
2391                                         }
2392
2393                                 # // is a comment
2394                                 } elsif ($op eq '//') {
2395
2396                                 # No spaces for:
2397                                 #   ->
2398                                 #   :   when part of a bitfield
2399                                 } elsif ($op eq '->' || $opv eq ':B') {
2400                                         if ($ctx =~ /Wx.|.xW/) {
2401                                                 ERROR("SPACING",
2402                                                       "spaces prohibited around that '$op' $at\n" . $hereptr);
2403                                         }
2404
2405                                 # , must have a space on the right.
2406                                 } elsif ($op eq ',') {
2407                                         if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
2408                                                 ERROR("SPACING",
2409                                                       "space required after that '$op' $at\n" . $hereptr);
2410                                         }
2411
2412                                 # '*' as part of a type definition -- reported already.
2413                                 } elsif ($opv eq '*_') {
2414                                         #warn "'*' is part of type\n";
2415
2416                                 # unary operators should have a space before and
2417                                 # none after.  May be left adjacent to another
2418                                 # unary operator, or a cast
2419                                 } elsif ($op eq '!' || $op eq '~' ||
2420                                          $opv eq '*U' || $opv eq '-U' ||
2421                                          $opv eq '&U' || $opv eq '&&U') {
2422                                         if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
2423                                                 ERROR("SPACING",
2424                                                       "space required before that '$op' $at\n" . $hereptr);
2425                                         }
2426                                         if ($op eq '*' && $cc =~/\s*$Modifier\b/) {
2427                                                 # A unary '*' may be const
2428
2429                                         } elsif ($ctx =~ /.xW/) {
2430                                                 ERROR("SPACING",
2431                                                       "space prohibited after that '$op' $at\n" . $hereptr);
2432                                         }
2433
2434                                 # unary ++ and unary -- are allowed no space on one side.
2435                                 } elsif ($op eq '++' or $op eq '--') {
2436                                         if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) {
2437                                                 ERROR("SPACING",
2438                                                       "space required one side of that '$op' $at\n" . $hereptr);
2439                                         }
2440                                         if ($ctx =~ /Wx[BE]/ ||
2441                                             ($ctx =~ /Wx./ && $cc =~ /^;/)) {
2442                                                 ERROR("SPACING",
2443                                                       "space prohibited before that '$op' $at\n" . $hereptr);
2444                                         }
2445                                         if ($ctx =~ /ExW/) {
2446                                                 ERROR("SPACING",
2447                                                       "space prohibited after that '$op' $at\n" . $hereptr);
2448                                         }
2449
2450
2451                                 # << and >> may either have or not have spaces both sides
2452                                 } elsif ($op eq '<<' or $op eq '>>' or
2453                                          $op eq '&' or $op eq '^' or $op eq '|' or
2454                                          $op eq '+' or $op eq '-' or
2455                                          $op eq '*' or $op eq '/' or
2456                                          $op eq '%')
2457                                 {
2458                                         if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
2459                                                 ERROR("SPACING",
2460                                                       "need consistent spacing around '$op' $at\n" .
2461                                                         $hereptr);
2462                                         }
2463
2464                                 # A colon needs no spaces before when it is
2465                                 # terminating a case value or a label.
2466                                 } elsif ($opv eq ':C' || $opv eq ':L') {
2467                                         if ($ctx =~ /Wx./) {
2468                                                 ERROR("SPACING",
2469                                                       "space prohibited before that '$op' $at\n" . $hereptr);
2470                                         }
2471
2472                                 # All the others need spaces both sides.
2473                                 } elsif ($ctx !~ /[EWC]x[CWE]/) {
2474                                         my $ok = 0;
2475
2476                                         # Ignore email addresses <foo@bar>
2477                                         if (($op eq '<' &&
2478                                              $cc =~ /^\S+\@\S+>/) ||
2479                                             ($op eq '>' &&
2480                                              $ca =~ /<\S+\@\S+$/))
2481                                         {
2482                                                 $ok = 1;
2483                                         }
2484
2485                                         # Ignore ?:
2486                                         if (($opv eq ':O' && $ca =~ /\?$/) ||
2487                                             ($op eq '?' && $cc =~ /^:/)) {
2488                                                 $ok = 1;
2489                                         }
2490
2491                                         if ($ok == 0) {
2492                                                 ERROR("SPACING",
2493                                                       "spaces required around that '$op' $at\n" . $hereptr);
2494                                         }
2495                                 }
2496                                 $off += length($elements[$n + 1]);
2497                         }
2498                 }
2499
2500 # check for multiple assignments
2501                 if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
2502                         CHK("MULTIPLE_ASSIGNMENTS",
2503                             "multiple assignments should be avoided\n" . $herecurr);
2504                 }
2505
2506 ## # check for multiple declarations, allowing for a function declaration
2507 ## # continuation.
2508 ##              if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
2509 ##                  $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
2510 ##
2511 ##                      # Remove any bracketed sections to ensure we do not
2512 ##                      # falsly report the parameters of functions.
2513 ##                      my $ln = $line;
2514 ##                      while ($ln =~ s/\([^\(\)]*\)//g) {
2515 ##                      }
2516 ##                      if ($ln =~ /,/) {
2517 ##                              WARN("MULTIPLE_DECLARATION",
2518 ##                                   "declaring multiple variables together should be avoided\n" . $herecurr);
2519 ##                      }
2520 ##              }
2521
2522 #need space before brace following if, while, etc
2523                 if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
2524                     $line =~ /do{/) {
2525                         ERROR("SPACING",
2526                               "space required before the open brace '{'\n" . $herecurr);
2527                 }
2528
2529 # closing brace should have a space following it when it has anything
2530 # on the line
2531                 if ($line =~ /}(?!(?:,|;|\)))\S/) {
2532                         ERROR("SPACING",
2533                               "space required after that close brace '}'\n" . $herecurr);
2534                 }
2535
2536 # check spacing on square brackets
2537                 if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
2538                         ERROR("SPACING",
2539                               "space prohibited after that open square bracket '['\n" . $herecurr);
2540                 }
2541                 if ($line =~ /\s\]/) {
2542                         ERROR("SPACING",
2543                               "space prohibited before that close square bracket ']'\n" . $herecurr);
2544                 }
2545
2546 # check spacing on parentheses
2547                 if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
2548                     $line !~ /for\s*\(\s+;/) {
2549                         ERROR("SPACING",
2550                               "space prohibited after that open parenthesis '('\n" . $herecurr);
2551                 }
2552                 if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ &&
2553                     $line !~ /for\s*\(.*;\s+\)/ &&
2554                     $line !~ /:\s+\)/) {
2555                         ERROR("SPACING",
2556                               "space prohibited before that close parenthesis ')'\n" . $herecurr);
2557                 }
2558
2559 #goto labels aren't indented, allow a single space however
2560                 if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
2561                    !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
2562                         WARN("INDENTED_LABEL",
2563                              "labels should not be indented\n" . $herecurr);
2564                 }
2565
2566 # Return is not a function.
2567                 if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) {
2568                         my $spacing = $1;
2569                         my $value = $2;
2570
2571                         # Flatten any parentheses
2572                         $value =~ s/\(/ \(/g;
2573                         $value =~ s/\)/\) /g;
2574                         while ($value =~ s/\[[^\{\}]*\]/1/ ||
2575                                $value !~ /(?:$Ident|-?$Constant)\s*
2576                                              $Compare\s*
2577                                              (?:$Ident|-?$Constant)/x &&
2578                                $value =~ s/\([^\(\)]*\)/1/) {
2579                         }
2580 #print "value<$value>\n";
2581                         if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
2582                                 ERROR("RETURN_PARENTHESES",
2583                                       "return is not a function, parentheses are not required\n" . $herecurr);
2584
2585                         } elsif ($spacing !~ /\s+/) {
2586                                 ERROR("SPACING",
2587                                       "space required before the open parenthesis '('\n" . $herecurr);
2588                         }
2589                 }
2590 # Return of what appears to be an errno should normally be -'ve
2591                 if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {
2592                         my $name = $1;
2593                         if ($name ne 'EOF' && $name ne 'ERROR') {
2594                                 WARN("USE_NEGATIVE_ERRNO",
2595                                      "return of an errno should typically be -ve (return -$1)\n" . $herecurr);
2596                         }
2597                 }
2598
2599 # typecasts on min/max could be min_t/max_t
2600                 if ($line =~ /^\+(?:.*?)\b(min|max)\s*\($Typecast{0,1}($LvalOrFunc)\s*,\s*$Typecast{0,1}($LvalOrFunc)\s*\)/) {
2601                         if (defined $2 || defined $8) {
2602                                 my $call = $1;
2603                                 my $cast1 = deparenthesize($2);
2604                                 my $arg1 = $3;
2605                                 my $cast2 = deparenthesize($8);
2606                                 my $arg2 = $9;
2607                                 my $cast;
2608
2609                                 if ($cast1 ne "" && $cast2 ne "") {
2610                                         $cast = "$cast1 or $cast2";
2611                                 } elsif ($cast1 ne "") {
2612                                         $cast = $cast1;
2613                                 } else {
2614                                         $cast = $cast2;
2615                                 }
2616                                 WARN("MINMAX",
2617                                      "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
2618                         }
2619                 }
2620
2621 # Need a space before open parenthesis after if, while etc
2622                 if ($line=~/\b(if|while|for|switch)\(/) {
2623                         ERROR("SPACING", "space required before the open parenthesis '('\n" . $herecurr);
2624                 }
2625
2626 # Check for illegal assignment in if conditional -- and check for trailing
2627 # statements after the conditional.
2628                 if ($line =~ /do\s*(?!{)/) {
2629                         my ($stat_next) = ctx_statement_block($line_nr_next,
2630                                                 $remain_next, $off_next);
2631                         $stat_next =~ s/\n./\n /g;
2632                         ##print "stat<$stat> stat_next<$stat_next>\n";
2633
2634                         if ($stat_next =~ /^\s*while\b/) {
2635                                 # If the statement carries leading newlines,
2636                                 # then count those as offsets.
2637                                 my ($whitespace) =
2638                                         ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s);
2639                                 my $offset =
2640                                         statement_rawlines($whitespace) - 1;
2641
2642                                 $suppress_whiletrailers{$line_nr_next +
2643                                                                 $offset} = 1;
2644                         }
2645                 }
2646                 if (!defined $suppress_whiletrailers{$linenr} &&
2647                     $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) {
2648                         my ($s, $c) = ($stat, $cond);
2649
2650                         if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) {
2651                                 ERROR("ASSIGN_IN_IF",
2652                                       "do not use assignment in if condition\n" . $herecurr);
2653                         }
2654
2655                         # Find out what is on the end of the line after the
2656                         # conditional.
2657                         substr($s, 0, length($c), '');
2658                         $s =~ s/\n.*//g;
2659                         $s =~ s/$;//g;  # Remove any comments
2660                         if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ &&
2661                             $c !~ /}\s*while\s*/)
2662                         {
2663                                 # Find out how long the conditional actually is.
2664                                 my @newlines = ($c =~ /\n/gs);
2665                                 my $cond_lines = 1 + $#newlines;
2666                                 my $stat_real = '';
2667
2668                                 $stat_real = raw_line($linenr, $cond_lines)
2669                                                         . "\n" if ($cond_lines);
2670                                 if (defined($stat_real) && $cond_lines > 1) {
2671                                         $stat_real = "[...]\n$stat_real";
2672                                 }
2673
2674                                 ERROR("TRAILING_STATEMENTS",
2675                                       "trailing statements should be on next line\n" . $herecurr . $stat_real);
2676                         }
2677                 }
2678
2679 # Check for bitwise tests written as boolean
2680                 if ($line =~ /
2681                         (?:
2682                                 (?:\[|\(|\&\&|\|\|)
2683                                 \s*0[xX][0-9]+\s*
2684                                 (?:\&\&|\|\|)
2685                         |
2686                                 (?:\&\&|\|\|)
2687                                 \s*0[xX][0-9]+\s*
2688                                 (?:\&\&|\|\||\)|\])
2689                         )/x)
2690                 {
2691                         WARN("HEXADECIMAL_BOOLEAN_TEST",
2692                              "boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
2693                 }
2694
2695 # if and else should not have general statements after it
2696                 if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
2697                         my $s = $1;
2698                         $s =~ s/$;//g;  # Remove any comments
2699                         if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
2700                                 ERROR("TRAILING_STATEMENTS",
2701                                       "trailing statements should be on next line\n" . $herecurr);
2702                         }
2703                 }
2704 # if should not continue a brace
2705                 if ($line =~ /}\s*if\b/) {
2706                         ERROR("TRAILING_STATEMENTS",
2707                               "trailing statements should be on next line\n" .
2708                                 $herecurr);
2709                 }
2710 # case and default should not have general statements after them
2711                 if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
2712                     $line !~ /\G(?:
2713                         (?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$|
2714                         \s*return\s+
2715                     )/xg)
2716                 {
2717                         ERROR("TRAILING_STATEMENTS",
2718                               "trailing statements should be on next line\n" . $herecurr);
2719                 }
2720
2721                 # Check for }<nl>else {, these must be at the same
2722                 # indent level to be relevant to each other.
2723                 if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and
2724                                                 $previndent == $indent) {
2725                         ERROR("ELSE_AFTER_BRACE",
2726                               "else should follow close brace '}'\n" . $hereprev);
2727                 }
2728
2729                 if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and
2730                                                 $previndent == $indent) {
2731                         my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);
2732
2733                         # Find out what is on the end of the line after the
2734                         # conditional.
2735                         substr($s, 0, length($c), '');
2736                         $s =~ s/\n.*//g;
2737
2738                         if ($s =~ /^\s*;/) {
2739                                 ERROR("WHILE_AFTER_BRACE",
2740                                       "while should follow close brace '}'\n" . $hereprev);
2741                         }
2742                 }
2743
2744 #studly caps, commented out until figure out how to distinguish between use of existing and adding new
2745 #               if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) {
2746 #                   print "No studly caps, use _\n";
2747 #                   print "$herecurr";
2748 #                   $clean = 0;
2749 #               }
2750
2751 #no spaces allowed after \ in define
2752                 if ($line=~/\#\s*define.*\\\s$/) {
2753                         WARN("WHITESPACE_AFTER_LINE_CONTINUATION",
2754                              "Whitepspace after \\ makes next lines useless\n" . $herecurr);
2755                 }
2756
2757 #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
2758                 if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
2759                         my $file = "$1.h";
2760                         my $checkfile = "include/linux/$file";
2761                         if (-f "$root/$checkfile" &&
2762                             $realfile ne $checkfile &&
2763                             $1 !~ /$allowed_asm_includes/)
2764                         {
2765                                 if ($realfile =~ m{^arch/}) {
2766                                         CHK("ARCH_INCLUDE_LINUX",
2767                                             "Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
2768                                 } else {
2769                                         WARN("INCLUDE_LINUX",
2770                                              "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
2771                                 }
2772                         }
2773                 }
2774
2775 # multi-statement macros should be enclosed in a do while loop, grab the
2776 # first statement and ensure its the whole macro if its not enclosed
2777 # in a known good container
2778                 if ($realfile !~ m@/vmlinux.lds.h$@ &&
2779                     $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) {
2780                         my $ln = $linenr;
2781                         my $cnt = $realcnt;
2782                         my ($off, $dstat, $dcond, $rest);
2783                         my $ctx = '';
2784
2785                         my $args = defined($1);
2786
2787                         # Find the end of the macro and limit our statement
2788                         # search to that.
2789                         while ($cnt > 0 && defined $lines[$ln - 1] &&
2790                                 $lines[$ln - 1] =~ /^(?:-|..*\\$)/)
2791                         {
2792                                 $ctx .= $rawlines[$ln - 1] . "\n";
2793                                 $cnt-- if ($lines[$ln - 1] !~ /^-/);
2794                                 $ln++;
2795                         }
2796                         $ctx .= $rawlines[$ln - 1];
2797
2798                         ($dstat, $dcond, $ln, $cnt, $off) =
2799                                 ctx_statement_block($linenr, $ln - $linenr + 1, 0);
2800                         #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
2801                         #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
2802
2803                         # Extract the remainder of the define (if any) and
2804                         # rip off surrounding spaces, and trailing \'s.
2805                         $rest = '';
2806                         while ($off != 0 || ($cnt > 0 && $rest =~ /\\\s*$/)) {
2807                                 #print "ADDING cnt<$cnt> $off <" . substr($lines[$ln - 1], $off) . "> rest<$rest>\n";
2808                                 if ($off != 0 || $lines[$ln - 1] !~ /^-/) {
2809                                         $rest .= substr($lines[$ln - 1], $off) . "\n";
2810                                         $cnt--;
2811                                 }
2812                                 $ln++;
2813                                 $off = 0;
2814                         }
2815                         $rest =~ s/\\\n.//g;
2816                         $rest =~ s/^\s*//s;
2817                         $rest =~ s/\s*$//s;
2818
2819                         # Clean up the original statement.
2820                         if ($args) {
2821                                 substr($dstat, 0, length($dcond), '');
2822                         } else {
2823                                 $dstat =~ s/^.\s*\#\s*define\s+$Ident\s*//;
2824                         }
2825                         $dstat =~ s/$;//g;
2826                         $dstat =~ s/\\\n.//g;
2827                         $dstat =~ s/^\s*//s;
2828                         $dstat =~ s/\s*$//s;
2829
2830                         # Flatten any parentheses and braces
2831                         while ($dstat =~ s/\([^\(\)]*\)/1/ ||
2832                                $dstat =~ s/\{[^\{\}]*\}/1/ ||
2833                                $dstat =~ s/\[[^\{\}]*\]/1/)
2834                         {
2835                         }
2836
2837                         my $exceptions = qr{
2838                                 $Declare|
2839                                 module_param_named|
2840                                 MODULE_PARAM_DESC|
2841                                 DECLARE_PER_CPU|
2842                                 DEFINE_PER_CPU|
2843                                 __typeof__\(|
2844                                 union|
2845                                 struct|
2846                                 \.$Ident\s*=\s*|
2847                                 ^\"|\"$
2848                         }x;
2849                         #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
2850                         if ($rest ne '' && $rest ne ',') {
2851                                 if ($rest !~ /while\s*\(/ &&
2852                                     $dstat !~ /$exceptions/)
2853                                 {
2854                                         ERROR("MULTISTATEMENT_MACRO_USE_DO_WHILE",
2855                                               "Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n");
2856                                 }
2857
2858                         } elsif ($ctx !~ /;/) {
2859                                 if ($dstat ne '' &&
2860                                     $dstat !~ /^(?:$Ident|-?$Constant)$/ &&
2861                                     $dstat !~ /$exceptions/ &&
2862                                     $dstat !~ /^\.$Ident\s*=/ &&
2863                                     $dstat =~ /$Operators/)
2864                                 {
2865                                         ERROR("COMPLEX_MACRO",
2866                                               "Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n");
2867                                 }
2868                         }
2869                 }
2870
2871 # make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
2872 # all assignments may have only one of the following with an assignment:
2873 #       .
2874 #       ALIGN(...)
2875 #       VMLINUX_SYMBOL(...)
2876                 if ($realfile eq 'vmlinux.lds.h' && $line =~ /(?:(?:^|\s)$Ident\s*=|=\s*$Ident(?:\s|$))/) {
2877                         WARN("MISSING_VMLINUX_SYMBOL",
2878                              "vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols\n" . $herecurr);
2879                 }
2880
2881 # check for redundant bracing round if etc
2882                 if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
2883                         my ($level, $endln, @chunks) =
2884                                 ctx_statement_full($linenr, $realcnt, 1);
2885                         #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
2886                         #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
2887                         if ($#chunks > 0 && $level == 0) {
2888                                 my $allowed = 0;
2889                                 my $seen = 0;
2890                                 my $herectx = $here . "\n";
2891                                 my $ln = $linenr - 1;
2892                                 for my $chunk (@chunks) {
2893                                         my ($cond, $block) = @{$chunk};
2894
2895                                         # If the condition carries leading newlines, then count those as offsets.
2896                                         my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
2897                                         my $offset = statement_rawlines($whitespace) - 1;
2898
2899                                         #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
2900
2901                                         # We have looked at and allowed this specific line.
2902                                         $suppress_ifbraces{$ln + $offset} = 1;
2903
2904                                         $herectx .= "$rawlines[$ln + $offset]\n[...]\n";
2905                                         $ln += statement_rawlines($block) - 1;
2906
2907                                         substr($block, 0, length($cond), '');
2908
2909                                         $seen++ if ($block =~ /^\s*{/);
2910
2911                                         #print "cond<$cond> block<$block> allowed<$allowed>\n";
2912                                         if (statement_lines($cond) > 1) {
2913                                                 #print "APW: ALLOWED: cond<$cond>\n";
2914                                                 $allowed = 1;
2915                                         }
2916                                         if ($block =~/\b(?:if|for|while)\b/) {
2917                                                 #print "APW: ALLOWED: block<$block>\n";
2918                                                 $allowed = 1;
2919                                         }
2920                                         if (statement_block_size($block) > 1) {
2921                                                 #print "APW: ALLOWED: lines block<$block>\n";
2922                                                 $allowed = 1;
2923                                         }
2924                                 }
2925                                 if ($seen && !$allowed) {
2926                                         WARN("BRACES",
2927                                              "braces {} are not necessary for any arm of this statement\n" . $herectx);
2928                                 }
2929                         }
2930                 }
2931                 if (!defined $suppress_ifbraces{$linenr - 1} &&
2932                                         $line =~ /\b(if|while|for|else)\b/) {
2933                         my $allowed = 0;
2934
2935                         # Check the pre-context.
2936                         if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
2937                                 #print "APW: ALLOWED: pre<$1>\n";
2938                                 $allowed = 1;
2939                         }
2940
2941                         my ($level, $endln, @chunks) =
2942                                 ctx_statement_full($linenr, $realcnt, $-[0]);
2943
2944                         # Check the condition.
2945                         my ($cond, $block) = @{$chunks[0]};
2946                         #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
2947                         if (defined $cond) {
2948                                 substr($block, 0, length($cond), '');
2949                         }
2950                         if (statement_lines($cond) > 1) {
2951                                 #print "APW: ALLOWED: cond<$cond>\n";
2952                                 $allowed = 1;
2953                         }
2954                         if ($block =~/\b(?:if|for|while)\b/) {
2955                                 #print "APW: ALLOWED: block<$block>\n";
2956                                 $allowed = 1;
2957                         }
2958                         if (statement_block_size($block) > 1) {
2959                                 #print "APW: ALLOWED: lines block<$block>\n";
2960                                 $allowed = 1;
2961                         }
2962                         # Check the post-context.
2963                         if (defined $chunks[1]) {
2964                                 my ($cond, $block) = @{$chunks[1]};
2965                                 if (defined $cond) {
2966                                         substr($block, 0, length($cond), '');
2967                                 }
2968                                 if ($block =~ /^\s*\{/) {
2969                                         #print "APW: ALLOWED: chunk-1 block<$block>\n";
2970                                         $allowed = 1;
2971                                 }
2972                         }
2973                         if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
2974                                 my $herectx = $here . "\n";
2975                                 my $cnt = statement_rawlines($block);
2976
2977                                 for (my $n = 0; $n < $cnt; $n++) {
2978                                         $herectx .= raw_line($linenr, $n) . "\n";
2979                                 }
2980
2981                                 WARN("BRACES",
2982                                      "braces {} are not necessary for single statement blocks\n" . $herectx);
2983                         }
2984                 }
2985
2986 # don't include deprecated include files (uses RAW line)
2987                 for my $inc (@dep_includes) {
2988                         if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
2989                                 ERROR("DEPRECATED_INCLUDE",
2990                                       "Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
2991                         }
2992                 }
2993
2994 # don't use deprecated functions
2995                 for my $func (@dep_functions) {
2996                         if ($line =~ /\b$func\b/) {
2997                                 ERROR("DEPRECATED_FUNCTION",
2998                                       "Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
2999                         }
3000                 }
3001
3002 # no volatiles please
3003                 my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
3004                 if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
3005                         WARN("VOLATILE",
3006                              "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
3007                 }
3008
3009 # warn about #if 0
3010                 if ($line =~ /^.\s*\#\s*if\s+0\b/) {
3011                         CHK("REDUNDANT_CODE",
3012                             "if this code is redundant consider removing it\n" .
3013                                 $herecurr);
3014                 }
3015
3016 # check for needless kfree() checks
3017                 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
3018                         my $expr = $1;
3019                         if ($line =~ /\bkfree\(\Q$expr\E\);/) {
3020                                 WARN("NEEDLESS_KFREE",
3021                                      "kfree(NULL) is safe this check is probably not required\n" . $hereprev);
3022                         }
3023                 }
3024 # check for needless usb_free_urb() checks
3025                 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
3026                         my $expr = $1;
3027                         if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) {
3028                                 WARN("NEEDLESS_USB_FREE_URB",
3029                                      "usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev);
3030                         }
3031                 }
3032
3033 # prefer usleep_range over udelay
3034                 if ($line =~ /\budelay\s*\(\s*(\w+)\s*\)/) {
3035                         # ignore udelay's < 10, however
3036                         if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) {
3037                                 CHK("USLEEP_RANGE",
3038                                     "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line);
3039                         }
3040                 }
3041
3042 # warn about unexpectedly long msleep's
3043                 if ($line =~ /\bmsleep\s*\((\d+)\);/) {
3044                         if ($1 < 20) {
3045                                 WARN("MSLEEP",
3046                                      "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $line);
3047                         }
3048                 }
3049
3050 # warn about #ifdefs in C files
3051 #               if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
3052 #                       print "#ifdef in C files should be avoided\n";
3053 #                       print "$herecurr";
3054 #                       $clean = 0;
3055 #               }
3056
3057 # warn about spacing in #ifdefs
3058                 if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
3059                         ERROR("SPACING",
3060                               "exactly one space required after that #$1\n" . $herecurr);
3061                 }
3062
3063 # check for spinlock_t definitions without a comment.
3064                 if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
3065                     $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
3066                         my $which = $1;
3067                         if (!ctx_has_comment($first_line, $linenr)) {
3068                                 CHK("UNCOMMENTED_DEFINITION",
3069                                     "$1 definition without comment\n" . $herecurr);
3070                         }
3071                 }
3072 # check for memory barriers without a comment.
3073                 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
3074                         if (!ctx_has_comment($first_line, $linenr)) {
3075                                 CHK("MEMORY_BARRIER",
3076                                     "memory barrier without comment\n" . $herecurr);
3077                         }
3078                 }
3079 # check of hardware specific defines
3080                 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
3081                         CHK("ARCH_DEFINES",
3082                             "architecture specific defines should be avoided\n" .  $herecurr);
3083                 }
3084
3085 # Check that the storage class is at the beginning of a declaration
3086                 if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
3087                         WARN("STORAGE_CLASS",
3088                              "storage class should be at the beginning of the declaration\n" . $herecurr)
3089                 }
3090
3091 # check the location of the inline attribute, that it is between
3092 # storage class and type.
3093                 if ($line =~ /\b$Type\s+$Inline\b/ ||
3094                     $line =~ /\b$Inline\s+$Storage\b/) {
3095                         ERROR("INLINE_LOCATION",
3096                               "inline keyword should sit between storage class and type\n" . $herecurr);
3097                 }
3098
3099 # Check for __inline__ and __inline, prefer inline
3100                 if ($line =~ /\b(__inline__|__inline)\b/) {
3101                         WARN("INLINE",
3102                              "plain inline is preferred over $1\n" . $herecurr);
3103                 }
3104
3105 # Check for __attribute__ packed, prefer __packed
3106                 if ($line =~ /\b__attribute__\s*\(\s*\(.*\bpacked\b/) {
3107                         WARN("PREFER_PACKED",
3108                              "__packed is preferred over __attribute__((packed))\n" . $herecurr);
3109                 }
3110
3111 # Check for __attribute__ aligned, prefer __aligned
3112                 if ($line =~ /\b__attribute__\s*\(\s*\(.*aligned/) {
3113                         WARN("PREFER_ALIGNED",
3114                              "__aligned(size) is preferred over __attribute__((aligned(size)))\n" . $herecurr);
3115                 }
3116
3117 # Check for __attribute__ format(printf, prefer __printf
3118                 if ($line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf/) {
3119                         WARN("PREFER_PRINTF",
3120                              "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . $herecurr);
3121                 }
3122
3123 # check for sizeof(&)
3124                 if ($line =~ /\bsizeof\s*\(\s*\&/) {
3125                         WARN("SIZEOF_ADDRESS",
3126                              "sizeof(& should be avoided\n" . $herecurr);
3127                 }
3128
3129 # check for line continuations in quoted strings with odd counts of "
3130                 if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) {
3131                         WARN("LINE_CONTINUATIONS",
3132                              "Avoid line continuations in quoted strings\n" . $herecurr);
3133                 }
3134
3135 # check for new externs in .c files.
3136                 if ($realfile =~ /\.c$/ && defined $stat &&
3137                     $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
3138                 {
3139                         my $function_name = $1;
3140                         my $paren_space = $2;
3141
3142                         my $s = $stat;
3143                         if (defined $cond) {
3144                                 substr($s, 0, length($cond), '');
3145                         }
3146                         if ($s =~ /^\s*;/ &&
3147                             $function_name ne 'uninitialized_var')
3148                         {
3149                                 WARN("AVOID_EXTERNS",
3150                                      "externs should be avoided in .c files\n" .  $herecurr);
3151                         }
3152
3153                         if ($paren_space =~ /\n/) {
3154                                 WARN("FUNCTION_ARGUMENTS",
3155                                      "arguments for function declarations should follow identifier\n" . $herecurr);
3156                         }
3157
3158                 } elsif ($realfile =~ /\.c$/ && defined $stat &&
3159                     $stat =~ /^.\s*extern\s+/)
3160                 {
3161                         WARN("AVOID_EXTERNS",
3162                              "externs should be avoided in .c files\n" .  $herecurr);
3163                 }
3164
3165 # checks for new __setup's
3166                 if ($rawline =~ /\b__setup\("([^"]*)"/) {
3167                         my $name = $1;
3168
3169                         if (!grep(/$name/, @setup_docs)) {
3170                                 CHK("UNDOCUMENTED_SETUP",
3171                                     "__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
3172                         }
3173                 }
3174
3175 # check for pointless casting of kmalloc return
3176                 if ($line =~ /\*\s*\)\s*[kv][czm]alloc(_node){0,1}\b/) {
3177                         WARN("UNNECESSARY_CASTS",
3178                              "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
3179                 }
3180
3181 # check for multiple semicolons
3182                 if ($line =~ /;\s*;\s*$/) {
3183                     WARN("ONE_SEMICOLON",
3184                          "Statements terminations use 1 semicolon\n" . $herecurr);
3185                 }
3186
3187 # check for gcc specific __FUNCTION__
3188                 if ($line =~ /__FUNCTION__/) {
3189                         WARN("USE_FUNC",
3190                              "__func__ should be used instead of gcc specific __FUNCTION__\n"  . $herecurr);
3191                 }
3192
3193 # check for semaphores initialized locked
3194                 if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
3195                         WARN("CONSIDER_COMPLETION",
3196                              "consider using a completion\n" . $herecurr);
3197
3198                 }
3199 # recommend kstrto* over simple_strto* and strict_strto*
3200                 if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) {
3201                         WARN("CONSIDER_KSTRTO",
3202                              "$1 is obsolete, use k$3 instead\n" . $herecurr);
3203                 }
3204 # check for __initcall(), use device_initcall() explicitly please
3205                 if ($line =~ /^.\s*__initcall\s*\(/) {
3206                         WARN("USE_DEVICE_INITCALL",
3207                              "please use device_initcall() instead of __initcall()\n" . $herecurr);
3208                 }
3209 # check for various ops structs, ensure they are const.
3210                 my $struct_ops = qr{acpi_dock_ops|
3211                                 address_space_operations|
3212                                 backlight_ops|
3213                                 block_device_operations|
3214                                 dentry_operations|
3215                                 dev_pm_ops|
3216                                 dma_map_ops|
3217                                 extent_io_ops|
3218                                 file_lock_operations|
3219                                 file_operations|
3220                                 hv_ops|
3221                                 ide_dma_ops|
3222                                 intel_dvo_dev_ops|
3223                                 item_operations|
3224                                 iwl_ops|
3225                                 kgdb_arch|
3226                                 kgdb_io|
3227                                 kset_uevent_ops|
3228                                 lock_manager_operations|
3229                                 microcode_ops|
3230                                 mtrr_ops|
3231                                 neigh_ops|
3232                                 nlmsvc_binding|
3233                                 pci_raw_ops|
3234                                 pipe_buf_operations|
3235                                 platform_hibernation_ops|
3236                                 platform_suspend_ops|
3237                                 proto_ops|
3238                                 rpc_pipe_ops|
3239                                 seq_operations|
3240                                 snd_ac97_build_ops|
3241                                 soc_pcmcia_socket_ops|
3242                                 stacktrace_ops|
3243                                 sysfs_ops|
3244                                 tty_operations|
3245                                 usb_mon_operations|
3246                                 wd_ops}x;
3247                 if ($line !~ /\bconst\b/ &&
3248                     $line =~ /\bstruct\s+($struct_ops)\b/) {
3249                         WARN("CONST_STRUCT",
3250                              "struct $1 should normally be const\n" .
3251                                 $herecurr);
3252                 }
3253
3254 # use of NR_CPUS is usually wrong
3255 # ignore definitions of NR_CPUS and usage to define arrays as likely right
3256                 if ($line =~ /\bNR_CPUS\b/ &&
3257                     $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
3258                     $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
3259                     $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
3260                     $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
3261                     $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
3262                 {
3263                         WARN("NR_CPUS",
3264                              "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
3265                 }
3266
3267 # check for %L{u,d,i} in strings
3268                 my $string;
3269                 while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
3270                         $string = substr($rawline, $-[1], $+[1] - $-[1]);
3271                         $string =~ s/%%/__/g;
3272                         if ($string =~ /(?<!%)%L[udi]/) {
3273                                 WARN("PRINTF_L",
3274                                      "\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
3275                                 last;
3276                         }
3277                 }
3278
3279 # whine mightly about in_atomic
3280                 if ($line =~ /\bin_atomic\s*\(/) {
3281                         if ($realfile =~ m@^drivers/@) {
3282                                 ERROR("IN_ATOMIC",
3283                                       "do not use in_atomic in drivers\n" . $herecurr);
3284                         } elsif ($realfile !~ m@^kernel/@) {
3285                                 WARN("IN_ATOMIC",
3286                                      "use of in_atomic() is incorrect outside core kernel code\n" . $herecurr);
3287                         }
3288                 }
3289
3290 # check for lockdep_set_novalidate_class
3291                 if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
3292                     $line =~ /__lockdep_no_validate__\s*\)/ ) {
3293                         if ($realfile !~ m@^kernel/lockdep@ &&
3294                             $realfile !~ m@^include/linux/lockdep@ &&
3295                             $realfile !~ m@^drivers/base/core@) {
3296                                 ERROR("LOCKDEP",
3297                                       "lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
3298                         }
3299                 }
3300
3301                 if ($line =~ /debugfs_create_file.*S_IWUGO/ ||
3302                     $line =~ /DEVICE_ATTR.*S_IWUGO/ ) {
3303                         WARN("EXPORTED_WORLD_WRITABLE",
3304                              "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
3305                 }
3306
3307                 # Check for memset with swapped arguments
3308                 if ($line =~ /memset.*\,(\ |)(0x|)0(\ |0|)\);/) {
3309                         ERROR("MEMSET",
3310                               "memset size is 3rd argument, not the second.\n" . $herecurr);
3311                 }
3312         }
3313
3314         # If we have no input at all, then there is nothing to report on
3315         # so just keep quiet.
3316         if ($#rawlines == -1) {
3317                 exit(0);
3318         }
3319
3320         # In mailback mode only produce a report in the negative, for
3321         # things that appear to be patches.
3322         if ($mailback && ($clean == 1 || !$is_patch)) {
3323                 exit(0);
3324         }
3325
3326         # This is not a patch, and we are are in 'no-patch' mode so
3327         # just keep quiet.
3328         if (!$chk_patch && !$is_patch) {
3329                 exit(0);
3330         }
3331
3332         if (!$is_patch) {
3333                 ERROR("NOT_UNIFIED_DIFF",
3334                       "Does not appear to be a unified-diff format patch\n");
3335         }
3336         if ($is_patch && $chk_signoff && $signoff == 0) {
3337                 ERROR("MISSING_SIGN_OFF",
3338                       "Missing Signed-off-by: line(s)\n");
3339         }
3340
3341         print report_dump();
3342         if ($summary && !($clean == 1 && $quiet == 1)) {
3343                 print "$filename " if ($summary_file);
3344                 print "total: $cnt_error errors, $cnt_warn warnings, " .
3345                         (($check)? "$cnt_chk checks, " : "") .
3346                         "$cnt_lines lines checked\n";
3347                 print "\n" if ($quiet == 0);
3348         }
3349
3350         if ($quiet == 0) {
3351                 # If there were whitespace errors which cleanpatch can fix
3352                 # then suggest that.
3353                 if ($rpt_cleaners) {
3354                         print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n";
3355                         print "      scripts/cleanfile\n\n";
3356                         $rpt_cleaners = 0;
3357                 }
3358         }
3359
3360         if (keys %ignore_type) {
3361             print "NOTE: Ignored message types:";
3362             foreach my $ignore (sort keys %ignore_type) {
3363                 print " $ignore";
3364             }
3365             print "\n";
3366             print "\n" if ($quiet == 0);
3367         }
3368
3369         if ($clean == 1 && $quiet == 0) {
3370                 print "$vname has no obvious style problems and is ready for submission.\n"
3371         }
3372         if ($clean == 0 && $quiet == 0) {
3373                 print << "EOM";
3374 $vname has style problems, please review.
3375
3376 If any of these errors are false positives, please report
3377 them to the maintainer, see CHECKPATCH in MAINTAINERS.
3378 EOM
3379         }
3380
3381         return $clean;
3382 }