checkpatch: handle string concatenation in simple #defines
[linux-2.6.git] / scripts / checkpatch.pl
1 #!/usr/bin/perl -w
2 # (c) 2001, Dave Jones. (the file handling bit)
3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
5 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
6 # Licensed under the terms of the GNU GPL License version 2
7
8 use strict;
9
10 my $P = $0;
11 $P =~ s@.*/@@g;
12
13 my $V = '0.32';
14
15 use Getopt::Long qw(:config no_auto_abbrev);
16
17 my $quiet = 0;
18 my $tree = 1;
19 my $chk_signoff = 1;
20 my $chk_patch = 1;
21 my $tst_only;
22 my $emacs = 0;
23 my $terse = 0;
24 my $file = 0;
25 my $check = 0;
26 my $summary = 1;
27 my $mailback = 0;
28 my $summary_file = 0;
29 my $show_types = 0;
30 my $root;
31 my %debug;
32 my %ignore_type = ();
33 my @ignore = ();
34 my $help = 0;
35 my $configuration_file = ".checkpatch.conf";
36
37 sub help {
38         my ($exitcode) = @_;
39
40         print << "EOM";
41 Usage: $P [OPTION]... [FILE]...
42 Version: $V
43
44 Options:
45   -q, --quiet                quiet
46   --no-tree                  run without a kernel tree
47   --no-signoff               do not check for 'Signed-off-by' line
48   --patch                    treat FILE as patchfile (default)
49   --emacs                    emacs compile window format
50   --terse                    one line per report
51   -f, --file                 treat FILE as regular source file
52   --subjective, --strict     enable more subjective tests
53   --ignore TYPE(,TYPE2...)   ignore various comma separated message types
54   --show-types               show the message "types" in the output
55   --root=PATH                PATH to the kernel tree root
56   --no-summary               suppress the per-file summary
57   --mailback                 only produce a report in case of warnings/errors
58   --summary-file             include the filename in summary
59   --debug KEY=[0|1]          turn on/off debugging of KEY, where KEY is one of
60                              'values', 'possible', 'type', and 'attr' (default
61                              is all off)
62   --test-only=WORD           report only warnings/errors containing WORD
63                              literally
64   -h, --help, --version      display this help and exit
65
66 When FILE is - read standard input.
67 EOM
68
69         exit($exitcode);
70 }
71
72 my $conf = which_conf($configuration_file);
73 if (-f $conf) {
74         my @conf_args;
75         open(my $conffile, '<', "$conf")
76             or warn "$P: Can't find a readable $configuration_file file $!\n";
77
78         while (<$conffile>) {
79                 my $line = $_;
80
81                 $line =~ s/\s*\n?$//g;
82                 $line =~ s/^\s*//g;
83                 $line =~ s/\s+/ /g;
84
85                 next if ($line =~ m/^\s*#/);
86                 next if ($line =~ m/^\s*$/);
87
88                 my @words = split(" ", $line);
89                 foreach my $word (@words) {
90                         last if ($word =~ m/^#/);
91                         push (@conf_args, $word);
92                 }
93         }
94         close($conffile);
95         unshift(@ARGV, @conf_args) if @conf_args;
96 }
97
98 GetOptions(
99         'q|quiet+'      => \$quiet,
100         'tree!'         => \$tree,
101         'signoff!'      => \$chk_signoff,
102         'patch!'        => \$chk_patch,
103         'emacs!'        => \$emacs,
104         'terse!'        => \$terse,
105         'f|file!'       => \$file,
106         'subjective!'   => \$check,
107         'strict!'       => \$check,
108         'ignore=s'      => \@ignore,
109         'show-types!'   => \$show_types,
110         'root=s'        => \$root,
111         'summary!'      => \$summary,
112         'mailback!'     => \$mailback,
113         'summary-file!' => \$summary_file,
114
115         'debug=s'       => \%debug,
116         'test-only=s'   => \$tst_only,
117         'h|help'        => \$help,
118         'version'       => \$help
119 ) or help(1);
120
121 help(0) if ($help);
122
123 my $exit = 0;
124
125 if ($#ARGV < 0) {
126         print "$P: no input files\n";
127         exit(1);
128 }
129
130 @ignore = split(/,/, join(',',@ignore));
131 foreach my $word (@ignore) {
132         $word =~ s/\s*\n?$//g;
133         $word =~ s/^\s*//g;
134         $word =~ s/\s+/ /g;
135         $word =~ tr/[a-z]/[A-Z]/;
136
137         next if ($word =~ m/^\s*#/);
138         next if ($word =~ m/^\s*$/);
139
140         $ignore_type{$word}++;
141 }
142
143 my $dbg_values = 0;
144 my $dbg_possible = 0;
145 my $dbg_type = 0;
146 my $dbg_attr = 0;
147 for my $key (keys %debug) {
148         ## no critic
149         eval "\${dbg_$key} = '$debug{$key}';";
150         die "$@" if ($@);
151 }
152
153 my $rpt_cleaners = 0;
154
155 if ($terse) {
156         $emacs = 1;
157         $quiet++;
158 }
159
160 if ($tree) {
161         if (defined $root) {
162                 if (!top_of_kernel_tree($root)) {
163                         die "$P: $root: --root does not point at a valid tree\n";
164                 }
165         } else {
166                 if (top_of_kernel_tree('.')) {
167                         $root = '.';
168                 } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
169                                                 top_of_kernel_tree($1)) {
170                         $root = $1;
171                 }
172         }
173
174         if (!defined $root) {
175                 print "Must be run from the top-level dir. of a kernel tree\n";
176                 exit(2);
177         }
178 }
179
180 my $emitted_corrupt = 0;
181
182 our $Ident      = qr{
183                         [A-Za-z_][A-Za-z\d_]*
184                         (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)*
185                 }x;
186 our $Storage    = qr{extern|static|asmlinkage};
187 our $Sparse     = qr{
188                         __user|
189                         __kernel|
190                         __force|
191                         __iomem|
192                         __must_check|
193                         __init_refok|
194                         __kprobes|
195                         __ref|
196                         __rcu
197                 }x;
198
199 # Notes to $Attribute:
200 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
201 our $Attribute  = qr{
202                         const|
203                         __percpu|
204                         __nocast|
205                         __safe|
206                         __bitwise__|
207                         __packed__|
208                         __packed2__|
209                         __naked|
210                         __maybe_unused|
211                         __always_unused|
212                         __noreturn|
213                         __used|
214                         __cold|
215                         __noclone|
216                         __deprecated|
217                         __read_mostly|
218                         __kprobes|
219                         __(?:mem|cpu|dev|)(?:initdata|initconst|init\b)|
220                         ____cacheline_aligned|
221                         ____cacheline_aligned_in_smp|
222                         ____cacheline_internodealigned_in_smp|
223                         __weak
224                   }x;
225 our $Modifier;
226 our $Inline     = qr{inline|__always_inline|noinline};
227 our $Member     = qr{->$Ident|\.$Ident|\[[^]]*\]};
228 our $Lval       = qr{$Ident(?:$Member)*};
229
230 our $Constant   = qr{(?i:(?:[0-9]+|0x[0-9a-f]+)[ul]*)};
231 our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
232 our $Compare    = qr{<=|>=|==|!=|<|>};
233 our $Operators  = qr{
234                         <=|>=|==|!=|
235                         =>|->|<<|>>|<|>|!|~|
236                         &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%
237                   }x;
238
239 our $NonptrType;
240 our $Type;
241 our $Declare;
242
243 our $NON_ASCII_UTF8     = qr{
244         [\xC2-\xDF][\x80-\xBF]               # non-overlong 2-byte
245         |  \xE0[\xA0-\xBF][\x80-\xBF]        # excluding overlongs
246         | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2}  # straight 3-byte
247         |  \xED[\x80-\x9F][\x80-\xBF]        # excluding surrogates
248         |  \xF0[\x90-\xBF][\x80-\xBF]{2}     # planes 1-3
249         | [\xF1-\xF3][\x80-\xBF]{3}          # planes 4-15
250         |  \xF4[\x80-\x8F][\x80-\xBF]{2}     # plane 16
251 }x;
252
253 our $UTF8       = qr{
254         [\x09\x0A\x0D\x20-\x7E]              # ASCII
255         | $NON_ASCII_UTF8
256 }x;
257
258 our $typeTypedefs = qr{(?x:
259         (?:__)?(?:u|s|be|le)(?:8|16|32|64)|
260         atomic_t
261 )};
262
263 our $logFunctions = qr{(?x:
264         printk(?:_ratelimited|_once|)|
265         [a-z0-9]+_(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
266         WARN(?:_RATELIMIT|_ONCE|)|
267         panic|
268         MODULE_[A-Z_]+
269 )};
270
271 our $signature_tags = qr{(?xi:
272         Signed-off-by:|
273         Acked-by:|
274         Tested-by:|
275         Reviewed-by:|
276         Reported-by:|
277         To:|
278         Cc:
279 )};
280
281 our @typeList = (
282         qr{void},
283         qr{(?:unsigned\s+)?char},
284         qr{(?:unsigned\s+)?short},
285         qr{(?:unsigned\s+)?int},
286         qr{(?:unsigned\s+)?long},
287         qr{(?:unsigned\s+)?long\s+int},
288         qr{(?:unsigned\s+)?long\s+long},
289         qr{(?:unsigned\s+)?long\s+long\s+int},
290         qr{unsigned},
291         qr{float},
292         qr{double},
293         qr{bool},
294         qr{struct\s+$Ident},
295         qr{union\s+$Ident},
296         qr{enum\s+$Ident},
297         qr{${Ident}_t},
298         qr{${Ident}_handler},
299         qr{${Ident}_handler_fn},
300 );
301 our @modifierList = (
302         qr{fastcall},
303 );
304
305 our $allowed_asm_includes = qr{(?x:
306         irq|
307         memory
308 )};
309 # memory.h: ARM has a custom one
310
311 sub build_types {
312         my $mods = "(?x:  \n" . join("|\n  ", @modifierList) . "\n)";
313         my $all = "(?x:  \n" . join("|\n  ", @typeList) . "\n)";
314         $Modifier       = qr{(?:$Attribute|$Sparse|$mods)};
315         $NonptrType     = qr{
316                         (?:$Modifier\s+|const\s+)*
317                         (?:
318                                 (?:typeof|__typeof__)\s*\([^\)]*\)|
319                                 (?:$typeTypedefs\b)|
320                                 (?:${all}\b)
321                         )
322                         (?:\s+$Modifier|\s+const)*
323                   }x;
324         $Type   = qr{
325                         $NonptrType
326                         (?:[\s\*]+\s*const|[\s\*]+|(?:\s*\[\s*\])+)?
327                         (?:\s+$Inline|\s+$Modifier)*
328                   }x;
329         $Declare        = qr{(?:$Storage\s+)?$Type};
330 }
331 build_types();
332
333
334 our $Typecast   = qr{\s*(\(\s*$NonptrType\s*\)){0,1}\s*};
335
336 # Using $balanced_parens, $LvalOrFunc, or $FuncArg
337 # requires at least perl version v5.10.0
338 # Any use must be runtime checked with $^V
339
340 our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/;
341 our $LvalOrFunc = qr{($Lval)\s*($balanced_parens{0,1})\s*};
342 our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant)};
343
344 sub deparenthesize {
345         my ($string) = @_;
346         return "" if (!defined($string));
347         $string =~ s@^\s*\(\s*@@g;
348         $string =~ s@\s*\)\s*$@@g;
349         $string =~ s@\s+@ @g;
350         return $string;
351 }
352
353 $chk_signoff = 0 if ($file);
354
355 my @dep_includes = ();
356 my @dep_functions = ();
357 my $removal = "Documentation/feature-removal-schedule.txt";
358 if ($tree && -f "$root/$removal") {
359         open(my $REMOVE, '<', "$root/$removal") ||
360                                 die "$P: $removal: open failed - $!\n";
361         while (<$REMOVE>) {
362                 if (/^Check:\s+(.*\S)/) {
363                         for my $entry (split(/[, ]+/, $1)) {
364                                 if ($entry =~ m@include/(.*)@) {
365                                         push(@dep_includes, $1);
366
367                                 } elsif ($entry !~ m@/@) {
368                                         push(@dep_functions, $entry);
369                                 }
370                         }
371                 }
372         }
373         close($REMOVE);
374 }
375
376 my @rawlines = ();
377 my @lines = ();
378 my $vname;
379 for my $filename (@ARGV) {
380         my $FILE;
381         if ($file) {
382                 open($FILE, '-|', "diff -u /dev/null $filename") ||
383                         die "$P: $filename: diff failed - $!\n";
384         } elsif ($filename eq '-') {
385                 open($FILE, '<&STDIN');
386         } else {
387                 open($FILE, '<', "$filename") ||
388                         die "$P: $filename: open failed - $!\n";
389         }
390         if ($filename eq '-') {
391                 $vname = 'Your patch';
392         } else {
393                 $vname = $filename;
394         }
395         while (<$FILE>) {
396                 chomp;
397                 push(@rawlines, $_);
398         }
399         close($FILE);
400         if (!process($filename)) {
401                 $exit = 1;
402         }
403         @rawlines = ();
404         @lines = ();
405 }
406
407 exit($exit);
408
409 sub top_of_kernel_tree {
410         my ($root) = @_;
411
412         my @tree_check = (
413                 "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
414                 "README", "Documentation", "arch", "include", "drivers",
415                 "fs", "init", "ipc", "kernel", "lib", "scripts",
416         );
417
418         foreach my $check (@tree_check) {
419                 if (! -e $root . '/' . $check) {
420                         return 0;
421                 }
422         }
423         return 1;
424     }
425
426 sub parse_email {
427         my ($formatted_email) = @_;
428
429         my $name = "";
430         my $address = "";
431         my $comment = "";
432
433         if ($formatted_email =~ /^(.*)<(\S+\@\S+)>(.*)$/) {
434                 $name = $1;
435                 $address = $2;
436                 $comment = $3 if defined $3;
437         } elsif ($formatted_email =~ /^\s*<(\S+\@\S+)>(.*)$/) {
438                 $address = $1;
439                 $comment = $2 if defined $2;
440         } elsif ($formatted_email =~ /(\S+\@\S+)(.*)$/) {
441                 $address = $1;
442                 $comment = $2 if defined $2;
443                 $formatted_email =~ s/$address.*$//;
444                 $name = $formatted_email;
445                 $name =~ s/^\s+|\s+$//g;
446                 $name =~ s/^\"|\"$//g;
447                 # If there's a name left after stripping spaces and
448                 # leading quotes, and the address doesn't have both
449                 # leading and trailing angle brackets, the address
450                 # is invalid. ie:
451                 #   "joe smith joe@smith.com" bad
452                 #   "joe smith <joe@smith.com" bad
453                 if ($name ne "" && $address !~ /^<[^>]+>$/) {
454                         $name = "";
455                         $address = "";
456                         $comment = "";
457                 }
458         }
459
460         $name =~ s/^\s+|\s+$//g;
461         $name =~ s/^\"|\"$//g;
462         $address =~ s/^\s+|\s+$//g;
463         $address =~ s/^\<|\>$//g;
464
465         if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
466                 $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
467                 $name = "\"$name\"";
468         }
469
470         return ($name, $address, $comment);
471 }
472
473 sub format_email {
474         my ($name, $address) = @_;
475
476         my $formatted_email;
477
478         $name =~ s/^\s+|\s+$//g;
479         $name =~ s/^\"|\"$//g;
480         $address =~ s/^\s+|\s+$//g;
481
482         if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
483                 $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
484                 $name = "\"$name\"";
485         }
486
487         if ("$name" eq "") {
488                 $formatted_email = "$address";
489         } else {
490                 $formatted_email = "$name <$address>";
491         }
492
493         return $formatted_email;
494 }
495
496 sub which_conf {
497         my ($conf) = @_;
498
499         foreach my $path (split(/:/, ".:$ENV{HOME}:.scripts")) {
500                 if (-e "$path/$conf") {
501                         return "$path/$conf";
502                 }
503         }
504
505         return "";
506 }
507
508 sub expand_tabs {
509         my ($str) = @_;
510
511         my $res = '';
512         my $n = 0;
513         for my $c (split(//, $str)) {
514                 if ($c eq "\t") {
515                         $res .= ' ';
516                         $n++;
517                         for (; ($n % 8) != 0; $n++) {
518                                 $res .= ' ';
519                         }
520                         next;
521                 }
522                 $res .= $c;
523                 $n++;
524         }
525
526         return $res;
527 }
528 sub copy_spacing {
529         (my $res = shift) =~ tr/\t/ /c;
530         return $res;
531 }
532
533 sub line_stats {
534         my ($line) = @_;
535
536         # Drop the diff line leader and expand tabs
537         $line =~ s/^.//;
538         $line = expand_tabs($line);
539
540         # Pick the indent from the front of the line.
541         my ($white) = ($line =~ /^(\s*)/);
542
543         return (length($line), length($white));
544 }
545
546 my $sanitise_quote = '';
547
548 sub sanitise_line_reset {
549         my ($in_comment) = @_;
550
551         if ($in_comment) {
552                 $sanitise_quote = '*/';
553         } else {
554                 $sanitise_quote = '';
555         }
556 }
557 sub sanitise_line {
558         my ($line) = @_;
559
560         my $res = '';
561         my $l = '';
562
563         my $qlen = 0;
564         my $off = 0;
565         my $c;
566
567         # Always copy over the diff marker.
568         $res = substr($line, 0, 1);
569
570         for ($off = 1; $off < length($line); $off++) {
571                 $c = substr($line, $off, 1);
572
573                 # Comments we are wacking completly including the begin
574                 # and end, all to $;.
575                 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
576                         $sanitise_quote = '*/';
577
578                         substr($res, $off, 2, "$;$;");
579                         $off++;
580                         next;
581                 }
582                 if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') {
583                         $sanitise_quote = '';
584                         substr($res, $off, 2, "$;$;");
585                         $off++;
586                         next;
587                 }
588                 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '//') {
589                         $sanitise_quote = '//';
590
591                         substr($res, $off, 2, $sanitise_quote);
592                         $off++;
593                         next;
594                 }
595
596                 # A \ in a string means ignore the next character.
597                 if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
598                     $c eq "\\") {
599                         substr($res, $off, 2, 'XX');
600                         $off++;
601                         next;
602                 }
603                 # Regular quotes.
604                 if ($c eq "'" || $c eq '"') {
605                         if ($sanitise_quote eq '') {
606                                 $sanitise_quote = $c;
607
608                                 substr($res, $off, 1, $c);
609                                 next;
610                         } elsif ($sanitise_quote eq $c) {
611                                 $sanitise_quote = '';
612                         }
613                 }
614
615                 #print "c<$c> SQ<$sanitise_quote>\n";
616                 if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
617                         substr($res, $off, 1, $;);
618                 } elsif ($off != 0 && $sanitise_quote eq '//' && $c ne "\t") {
619                         substr($res, $off, 1, $;);
620                 } elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
621                         substr($res, $off, 1, 'X');
622                 } else {
623                         substr($res, $off, 1, $c);
624                 }
625         }
626
627         if ($sanitise_quote eq '//') {
628                 $sanitise_quote = '';
629         }
630
631         # The pathname on a #include may be surrounded by '<' and '>'.
632         if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
633                 my $clean = 'X' x length($1);
634                 $res =~ s@\<.*\>@<$clean>@;
635
636         # The whole of a #error is a string.
637         } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
638                 my $clean = 'X' x length($1);
639                 $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
640         }
641
642         return $res;
643 }
644
645 sub ctx_statement_block {
646         my ($linenr, $remain, $off) = @_;
647         my $line = $linenr - 1;
648         my $blk = '';
649         my $soff = $off;
650         my $coff = $off - 1;
651         my $coff_set = 0;
652
653         my $loff = 0;
654
655         my $type = '';
656         my $level = 0;
657         my @stack = ();
658         my $p;
659         my $c;
660         my $len = 0;
661
662         my $remainder;
663         while (1) {
664                 @stack = (['', 0]) if ($#stack == -1);
665
666                 #warn "CSB: blk<$blk> remain<$remain>\n";
667                 # If we are about to drop off the end, pull in more
668                 # context.
669                 if ($off >= $len) {
670                         for (; $remain > 0; $line++) {
671                                 last if (!defined $lines[$line]);
672                                 next if ($lines[$line] =~ /^-/);
673                                 $remain--;
674                                 $loff = $len;
675                                 $blk .= $lines[$line] . "\n";
676                                 $len = length($blk);
677                                 $line++;
678                                 last;
679                         }
680                         # Bail if there is no further context.
681                         #warn "CSB: blk<$blk> off<$off> len<$len>\n";
682                         if ($off >= $len) {
683                                 last;
684                         }
685                         if ($level == 0 && substr($blk, $off) =~ /^.\s*#\s*define/) {
686                                 $level++;
687                                 $type = '#';
688                         }
689                 }
690                 $p = $c;
691                 $c = substr($blk, $off, 1);
692                 $remainder = substr($blk, $off);
693
694                 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
695
696                 # Handle nested #if/#else.
697                 if ($remainder =~ /^#\s*(?:ifndef|ifdef|if)\s/) {
698                         push(@stack, [ $type, $level ]);
699                 } elsif ($remainder =~ /^#\s*(?:else|elif)\b/) {
700                         ($type, $level) = @{$stack[$#stack - 1]};
701                 } elsif ($remainder =~ /^#\s*endif\b/) {
702                         ($type, $level) = @{pop(@stack)};
703                 }
704
705                 # Statement ends at the ';' or a close '}' at the
706                 # outermost level.
707                 if ($level == 0 && $c eq ';') {
708                         last;
709                 }
710
711                 # An else is really a conditional as long as its not else if
712                 if ($level == 0 && $coff_set == 0 &&
713                                 (!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
714                                 $remainder =~ /^(else)(?:\s|{)/ &&
715                                 $remainder !~ /^else\s+if\b/) {
716                         $coff = $off + length($1) - 1;
717                         $coff_set = 1;
718                         #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
719                         #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
720                 }
721
722                 if (($type eq '' || $type eq '(') && $c eq '(') {
723                         $level++;
724                         $type = '(';
725                 }
726                 if ($type eq '(' && $c eq ')') {
727                         $level--;
728                         $type = ($level != 0)? '(' : '';
729
730                         if ($level == 0 && $coff < $soff) {
731                                 $coff = $off;
732                                 $coff_set = 1;
733                                 #warn "CSB: mark coff<$coff>\n";
734                         }
735                 }
736                 if (($type eq '' || $type eq '{') && $c eq '{') {
737                         $level++;
738                         $type = '{';
739                 }
740                 if ($type eq '{' && $c eq '}') {
741                         $level--;
742                         $type = ($level != 0)? '{' : '';
743
744                         if ($level == 0) {
745                                 if (substr($blk, $off + 1, 1) eq ';') {
746                                         $off++;
747                                 }
748                                 last;
749                         }
750                 }
751                 # Preprocessor commands end at the newline unless escaped.
752                 if ($type eq '#' && $c eq "\n" && $p ne "\\") {
753                         $level--;
754                         $type = '';
755                         $off++;
756                         last;
757                 }
758                 $off++;
759         }
760         # We are truly at the end, so shuffle to the next line.
761         if ($off == $len) {
762                 $loff = $len + 1;
763                 $line++;
764                 $remain--;
765         }
766
767         my $statement = substr($blk, $soff, $off - $soff + 1);
768         my $condition = substr($blk, $soff, $coff - $soff + 1);
769
770         #warn "STATEMENT<$statement>\n";
771         #warn "CONDITION<$condition>\n";
772
773         #print "coff<$coff> soff<$off> loff<$loff>\n";
774
775         return ($statement, $condition,
776                         $line, $remain + 1, $off - $loff + 1, $level);
777 }
778
779 sub statement_lines {
780         my ($stmt) = @_;
781
782         # Strip the diff line prefixes and rip blank lines at start and end.
783         $stmt =~ s/(^|\n)./$1/g;
784         $stmt =~ s/^\s*//;
785         $stmt =~ s/\s*$//;
786
787         my @stmt_lines = ($stmt =~ /\n/g);
788
789         return $#stmt_lines + 2;
790 }
791
792 sub statement_rawlines {
793         my ($stmt) = @_;
794
795         my @stmt_lines = ($stmt =~ /\n/g);
796
797         return $#stmt_lines + 2;
798 }
799
800 sub statement_block_size {
801         my ($stmt) = @_;
802
803         $stmt =~ s/(^|\n)./$1/g;
804         $stmt =~ s/^\s*{//;
805         $stmt =~ s/}\s*$//;
806         $stmt =~ s/^\s*//;
807         $stmt =~ s/\s*$//;
808
809         my @stmt_lines = ($stmt =~ /\n/g);
810         my @stmt_statements = ($stmt =~ /;/g);
811
812         my $stmt_lines = $#stmt_lines + 2;
813         my $stmt_statements = $#stmt_statements + 1;
814
815         if ($stmt_lines > $stmt_statements) {
816                 return $stmt_lines;
817         } else {
818                 return $stmt_statements;
819         }
820 }
821
822 sub ctx_statement_full {
823         my ($linenr, $remain, $off) = @_;
824         my ($statement, $condition, $level);
825
826         my (@chunks);
827
828         # Grab the first conditional/block pair.
829         ($statement, $condition, $linenr, $remain, $off, $level) =
830                                 ctx_statement_block($linenr, $remain, $off);
831         #print "F: c<$condition> s<$statement> remain<$remain>\n";
832         push(@chunks, [ $condition, $statement ]);
833         if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
834                 return ($level, $linenr, @chunks);
835         }
836
837         # Pull in the following conditional/block pairs and see if they
838         # could continue the statement.
839         for (;;) {
840                 ($statement, $condition, $linenr, $remain, $off, $level) =
841                                 ctx_statement_block($linenr, $remain, $off);
842                 #print "C: c<$condition> s<$statement> remain<$remain>\n";
843                 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
844                 #print "C: push\n";
845                 push(@chunks, [ $condition, $statement ]);
846         }
847
848         return ($level, $linenr, @chunks);
849 }
850
851 sub ctx_block_get {
852         my ($linenr, $remain, $outer, $open, $close, $off) = @_;
853         my $line;
854         my $start = $linenr - 1;
855         my $blk = '';
856         my @o;
857         my @c;
858         my @res = ();
859
860         my $level = 0;
861         my @stack = ($level);
862         for ($line = $start; $remain > 0; $line++) {
863                 next if ($rawlines[$line] =~ /^-/);
864                 $remain--;
865
866                 $blk .= $rawlines[$line];
867
868                 # Handle nested #if/#else.
869                 if ($lines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) {
870                         push(@stack, $level);
871                 } elsif ($lines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) {
872                         $level = $stack[$#stack - 1];
873                 } elsif ($lines[$line] =~ /^.\s*#\s*endif\b/) {
874                         $level = pop(@stack);
875                 }
876
877                 foreach my $c (split(//, $lines[$line])) {
878                         ##print "C<$c>L<$level><$open$close>O<$off>\n";
879                         if ($off > 0) {
880                                 $off--;
881                                 next;
882                         }
883
884                         if ($c eq $close && $level > 0) {
885                                 $level--;
886                                 last if ($level == 0);
887                         } elsif ($c eq $open) {
888                                 $level++;
889                         }
890                 }
891
892                 if (!$outer || $level <= 1) {
893                         push(@res, $rawlines[$line]);
894                 }
895
896                 last if ($level == 0);
897         }
898
899         return ($level, @res);
900 }
901 sub ctx_block_outer {
902         my ($linenr, $remain) = @_;
903
904         my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
905         return @r;
906 }
907 sub ctx_block {
908         my ($linenr, $remain) = @_;
909
910         my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
911         return @r;
912 }
913 sub ctx_statement {
914         my ($linenr, $remain, $off) = @_;
915
916         my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
917         return @r;
918 }
919 sub ctx_block_level {
920         my ($linenr, $remain) = @_;
921
922         return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
923 }
924 sub ctx_statement_level {
925         my ($linenr, $remain, $off) = @_;
926
927         return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
928 }
929
930 sub ctx_locate_comment {
931         my ($first_line, $end_line) = @_;
932
933         # Catch a comment on the end of the line itself.
934         my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
935         return $current_comment if (defined $current_comment);
936
937         # Look through the context and try and figure out if there is a
938         # comment.
939         my $in_comment = 0;
940         $current_comment = '';
941         for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
942                 my $line = $rawlines[$linenr - 1];
943                 #warn "           $line\n";
944                 if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
945                         $in_comment = 1;
946                 }
947                 if ($line =~ m@/\*@) {
948                         $in_comment = 1;
949                 }
950                 if (!$in_comment && $current_comment ne '') {
951                         $current_comment = '';
952                 }
953                 $current_comment .= $line . "\n" if ($in_comment);
954                 if ($line =~ m@\*/@) {
955                         $in_comment = 0;
956                 }
957         }
958
959         chomp($current_comment);
960         return($current_comment);
961 }
962 sub ctx_has_comment {
963         my ($first_line, $end_line) = @_;
964         my $cmt = ctx_locate_comment($first_line, $end_line);
965
966         ##print "LINE: $rawlines[$end_line - 1 ]\n";
967         ##print "CMMT: $cmt\n";
968
969         return ($cmt ne '');
970 }
971
972 sub raw_line {
973         my ($linenr, $cnt) = @_;
974
975         my $offset = $linenr - 1;
976         $cnt++;
977
978         my $line;
979         while ($cnt) {
980                 $line = $rawlines[$offset++];
981                 next if (defined($line) && $line =~ /^-/);
982                 $cnt--;
983         }
984
985         return $line;
986 }
987
988 sub cat_vet {
989         my ($vet) = @_;
990         my ($res, $coded);
991
992         $res = '';
993         while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
994                 $res .= $1;
995                 if ($2 ne '') {
996                         $coded = sprintf("^%c", unpack('C', $2) + 64);
997                         $res .= $coded;
998                 }
999         }
1000         $res =~ s/$/\$/;
1001
1002         return $res;
1003 }
1004
1005 my $av_preprocessor = 0;
1006 my $av_pending;
1007 my @av_paren_type;
1008 my $av_pend_colon;
1009
1010 sub annotate_reset {
1011         $av_preprocessor = 0;
1012         $av_pending = '_';
1013         @av_paren_type = ('E');
1014         $av_pend_colon = 'O';
1015 }
1016
1017 sub annotate_values {
1018         my ($stream, $type) = @_;
1019
1020         my $res;
1021         my $var = '_' x length($stream);
1022         my $cur = $stream;
1023
1024         print "$stream\n" if ($dbg_values > 1);
1025
1026         while (length($cur)) {
1027                 @av_paren_type = ('E') if ($#av_paren_type < 0);
1028                 print " <" . join('', @av_paren_type) .
1029                                 "> <$type> <$av_pending>" if ($dbg_values > 1);
1030                 if ($cur =~ /^(\s+)/o) {
1031                         print "WS($1)\n" if ($dbg_values > 1);
1032                         if ($1 =~ /\n/ && $av_preprocessor) {
1033                                 $type = pop(@av_paren_type);
1034                                 $av_preprocessor = 0;
1035                         }
1036
1037                 } elsif ($cur =~ /^(\(\s*$Type\s*)\)/ && $av_pending eq '_') {
1038                         print "CAST($1)\n" if ($dbg_values > 1);
1039                         push(@av_paren_type, $type);
1040                         $type = 'c';
1041
1042                 } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) {
1043                         print "DECLARE($1)\n" if ($dbg_values > 1);
1044                         $type = 'T';
1045
1046                 } elsif ($cur =~ /^($Modifier)\s*/) {
1047                         print "MODIFIER($1)\n" if ($dbg_values > 1);
1048                         $type = 'T';
1049
1050                 } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
1051                         print "DEFINE($1,$2)\n" if ($dbg_values > 1);
1052                         $av_preprocessor = 1;
1053                         push(@av_paren_type, $type);
1054                         if ($2 ne '') {
1055                                 $av_pending = 'N';
1056                         }
1057                         $type = 'E';
1058
1059                 } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
1060                         print "UNDEF($1)\n" if ($dbg_values > 1);
1061                         $av_preprocessor = 1;
1062                         push(@av_paren_type, $type);
1063
1064                 } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
1065                         print "PRE_START($1)\n" if ($dbg_values > 1);
1066                         $av_preprocessor = 1;
1067
1068                         push(@av_paren_type, $type);
1069                         push(@av_paren_type, $type);
1070                         $type = 'E';
1071
1072                 } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
1073                         print "PRE_RESTART($1)\n" if ($dbg_values > 1);
1074                         $av_preprocessor = 1;
1075
1076                         push(@av_paren_type, $av_paren_type[$#av_paren_type]);
1077
1078                         $type = 'E';
1079
1080                 } elsif ($cur =~ /^(\#\s*(?:endif))/o) {
1081                         print "PRE_END($1)\n" if ($dbg_values > 1);
1082
1083                         $av_preprocessor = 1;
1084
1085                         # Assume all arms of the conditional end as this
1086                         # one does, and continue as if the #endif was not here.
1087                         pop(@av_paren_type);
1088                         push(@av_paren_type, $type);
1089                         $type = 'E';
1090
1091                 } elsif ($cur =~ /^(\\\n)/o) {
1092                         print "PRECONT($1)\n" if ($dbg_values > 1);
1093
1094                 } elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
1095                         print "ATTR($1)\n" if ($dbg_values > 1);
1096                         $av_pending = $type;
1097                         $type = 'N';
1098
1099                 } elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
1100                         print "SIZEOF($1)\n" if ($dbg_values > 1);
1101                         if (defined $2) {
1102                                 $av_pending = 'V';
1103                         }
1104                         $type = 'N';
1105
1106                 } elsif ($cur =~ /^(if|while|for)\b/o) {
1107                         print "COND($1)\n" if ($dbg_values > 1);
1108                         $av_pending = 'E';
1109                         $type = 'N';
1110
1111                 } elsif ($cur =~/^(case)/o) {
1112                         print "CASE($1)\n" if ($dbg_values > 1);
1113                         $av_pend_colon = 'C';
1114                         $type = 'N';
1115
1116                 } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) {
1117                         print "KEYWORD($1)\n" if ($dbg_values > 1);
1118                         $type = 'N';
1119
1120                 } elsif ($cur =~ /^(\()/o) {
1121                         print "PAREN('$1')\n" if ($dbg_values > 1);
1122                         push(@av_paren_type, $av_pending);
1123                         $av_pending = '_';
1124                         $type = 'N';
1125
1126                 } elsif ($cur =~ /^(\))/o) {
1127                         my $new_type = pop(@av_paren_type);
1128                         if ($new_type ne '_') {
1129                                 $type = $new_type;
1130                                 print "PAREN('$1') -> $type\n"
1131                                                         if ($dbg_values > 1);
1132                         } else {
1133                                 print "PAREN('$1')\n" if ($dbg_values > 1);
1134                         }
1135
1136                 } elsif ($cur =~ /^($Ident)\s*\(/o) {
1137                         print "FUNC($1)\n" if ($dbg_values > 1);
1138                         $type = 'V';
1139                         $av_pending = 'V';
1140
1141                 } elsif ($cur =~ /^($Ident\s*):(?:\s*\d+\s*(,|=|;))?/) {
1142                         if (defined $2 && $type eq 'C' || $type eq 'T') {
1143                                 $av_pend_colon = 'B';
1144                         } elsif ($type eq 'E') {
1145                                 $av_pend_colon = 'L';
1146                         }
1147                         print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1);
1148                         $type = 'V';
1149
1150                 } elsif ($cur =~ /^($Ident|$Constant)/o) {
1151                         print "IDENT($1)\n" if ($dbg_values > 1);
1152                         $type = 'V';
1153
1154                 } elsif ($cur =~ /^($Assignment)/o) {
1155                         print "ASSIGN($1)\n" if ($dbg_values > 1);
1156                         $type = 'N';
1157
1158                 } elsif ($cur =~/^(;|{|})/) {
1159                         print "END($1)\n" if ($dbg_values > 1);
1160                         $type = 'E';
1161                         $av_pend_colon = 'O';
1162
1163                 } elsif ($cur =~/^(,)/) {
1164                         print "COMMA($1)\n" if ($dbg_values > 1);
1165                         $type = 'C';
1166
1167                 } elsif ($cur =~ /^(\?)/o) {
1168                         print "QUESTION($1)\n" if ($dbg_values > 1);
1169                         $type = 'N';
1170
1171                 } elsif ($cur =~ /^(:)/o) {
1172                         print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1);
1173
1174                         substr($var, length($res), 1, $av_pend_colon);
1175                         if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') {
1176                                 $type = 'E';
1177                         } else {
1178                                 $type = 'N';
1179                         }
1180                         $av_pend_colon = 'O';
1181
1182                 } elsif ($cur =~ /^(\[)/o) {
1183                         print "CLOSE($1)\n" if ($dbg_values > 1);
1184                         $type = 'N';
1185
1186                 } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
1187                         my $variant;
1188
1189                         print "OPV($1)\n" if ($dbg_values > 1);
1190                         if ($type eq 'V') {
1191                                 $variant = 'B';
1192                         } else {
1193                                 $variant = 'U';
1194                         }
1195
1196                         substr($var, length($res), 1, $variant);
1197                         $type = 'N';
1198
1199                 } elsif ($cur =~ /^($Operators)/o) {
1200                         print "OP($1)\n" if ($dbg_values > 1);
1201                         if ($1 ne '++' && $1 ne '--') {
1202                                 $type = 'N';
1203                         }
1204
1205                 } elsif ($cur =~ /(^.)/o) {
1206                         print "C($1)\n" if ($dbg_values > 1);
1207                 }
1208                 if (defined $1) {
1209                         $cur = substr($cur, length($1));
1210                         $res .= $type x length($1);
1211                 }
1212         }
1213
1214         return ($res, $var);
1215 }
1216
1217 sub possible {
1218         my ($possible, $line) = @_;
1219         my $notPermitted = qr{(?:
1220                 ^(?:
1221                         $Modifier|
1222                         $Storage|
1223                         $Type|
1224                         DEFINE_\S+
1225                 )$|
1226                 ^(?:
1227                         goto|
1228                         return|
1229                         case|
1230                         else|
1231                         asm|__asm__|
1232                         do|
1233                         \#|
1234                         \#\#|
1235                 )(?:\s|$)|
1236                 ^(?:typedef|struct|enum)\b
1237             )}x;
1238         warn "CHECK<$possible> ($line)\n" if ($dbg_possible > 2);
1239         if ($possible !~ $notPermitted) {
1240                 # Check for modifiers.
1241                 $possible =~ s/\s*$Storage\s*//g;
1242                 $possible =~ s/\s*$Sparse\s*//g;
1243                 if ($possible =~ /^\s*$/) {
1244
1245                 } elsif ($possible =~ /\s/) {
1246                         $possible =~ s/\s*$Type\s*//g;
1247                         for my $modifier (split(' ', $possible)) {
1248                                 if ($modifier !~ $notPermitted) {
1249                                         warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible);
1250                                         push(@modifierList, $modifier);
1251                                 }
1252                         }
1253
1254                 } else {
1255                         warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible);
1256                         push(@typeList, $possible);
1257                 }
1258                 build_types();
1259         } else {
1260                 warn "NOTPOSS: $possible ($line)\n" if ($dbg_possible > 1);
1261         }
1262 }
1263
1264 my $prefix = '';
1265
1266 sub show_type {
1267        return !defined $ignore_type{$_[0]};
1268 }
1269
1270 sub report {
1271         if (!show_type($_[1]) ||
1272             (defined $tst_only && $_[2] !~ /\Q$tst_only\E/)) {
1273                 return 0;
1274         }
1275         my $line;
1276         if ($show_types) {
1277                 $line = "$prefix$_[0]:$_[1]: $_[2]\n";
1278         } else {
1279                 $line = "$prefix$_[0]: $_[2]\n";
1280         }
1281         $line = (split('\n', $line))[0] . "\n" if ($terse);
1282
1283         push(our @report, $line);
1284
1285         return 1;
1286 }
1287 sub report_dump {
1288         our @report;
1289 }
1290
1291 sub ERROR {
1292         if (report("ERROR", $_[0], $_[1])) {
1293                 our $clean = 0;
1294                 our $cnt_error++;
1295         }
1296 }
1297 sub WARN {
1298         if (report("WARNING", $_[0], $_[1])) {
1299                 our $clean = 0;
1300                 our $cnt_warn++;
1301         }
1302 }
1303 sub CHK {
1304         if ($check && report("CHECK", $_[0], $_[1])) {
1305                 our $clean = 0;
1306                 our $cnt_chk++;
1307         }
1308 }
1309
1310 sub check_absolute_file {
1311         my ($absolute, $herecurr) = @_;
1312         my $file = $absolute;
1313
1314         ##print "absolute<$absolute>\n";
1315
1316         # See if any suffix of this path is a path within the tree.
1317         while ($file =~ s@^[^/]*/@@) {
1318                 if (-f "$root/$file") {
1319                         ##print "file<$file>\n";
1320                         last;
1321                 }
1322         }
1323         if (! -f _)  {
1324                 return 0;
1325         }
1326
1327         # It is, so see if the prefix is acceptable.
1328         my $prefix = $absolute;
1329         substr($prefix, -length($file)) = '';
1330
1331         ##print "prefix<$prefix>\n";
1332         if ($prefix ne ".../") {
1333                 WARN("USE_RELATIVE_PATH",
1334                      "use relative pathname instead of absolute in changelog text\n" . $herecurr);
1335         }
1336 }
1337
1338 sub pos_last_openparen {
1339         my ($line) = @_;
1340
1341         my $pos = 0;
1342
1343         my $opens = $line =~ tr/\(/\(/;
1344         my $closes = $line =~ tr/\)/\)/;
1345
1346         my $last_openparen = 0;
1347
1348         if (($opens == 0) || ($closes >= $opens)) {
1349                 return -1;
1350         }
1351
1352         my $len = length($line);
1353
1354         for ($pos = 0; $pos < $len; $pos++) {
1355                 my $string = substr($line, $pos);
1356                 if ($string =~ /^($FuncArg|$balanced_parens)/) {
1357                         $pos += length($1) - 1;
1358                 } elsif (substr($line, $pos, 1) eq '(') {
1359                         $last_openparen = $pos;
1360                 } elsif (index($string, '(') == -1) {
1361                         last;
1362                 }
1363         }
1364
1365         return $last_openparen + 1;
1366 }
1367
1368 sub process {
1369         my $filename = shift;
1370
1371         my $linenr=0;
1372         my $prevline="";
1373         my $prevrawline="";
1374         my $stashline="";
1375         my $stashrawline="";
1376
1377         my $length;
1378         my $indent;
1379         my $previndent=0;
1380         my $stashindent=0;
1381
1382         our $clean = 1;
1383         my $signoff = 0;
1384         my $is_patch = 0;
1385
1386         my $in_header_lines = 1;
1387         my $in_commit_log = 0;          #Scanning lines before patch
1388
1389         our @report = ();
1390         our $cnt_lines = 0;
1391         our $cnt_error = 0;
1392         our $cnt_warn = 0;
1393         our $cnt_chk = 0;
1394
1395         # Trace the real file/line as we go.
1396         my $realfile = '';
1397         my $realline = 0;
1398         my $realcnt = 0;
1399         my $here = '';
1400         my $in_comment = 0;
1401         my $comment_edge = 0;
1402         my $first_line = 0;
1403         my $p1_prefix = '';
1404
1405         my $prev_values = 'E';
1406
1407         # suppression flags
1408         my %suppress_ifbraces;
1409         my %suppress_whiletrailers;
1410         my %suppress_export;
1411         my $suppress_statement = 0;
1412
1413         # Pre-scan the patch sanitizing the lines.
1414         # Pre-scan the patch looking for any __setup documentation.
1415         #
1416         my @setup_docs = ();
1417         my $setup_docs = 0;
1418
1419         sanitise_line_reset();
1420         my $line;
1421         foreach my $rawline (@rawlines) {
1422                 $linenr++;
1423                 $line = $rawline;
1424
1425                 if ($rawline=~/^\+\+\+\s+(\S+)/) {
1426                         $setup_docs = 0;
1427                         if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
1428                                 $setup_docs = 1;
1429                         }
1430                         #next;
1431                 }
1432                 if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1433                         $realline=$1-1;
1434                         if (defined $2) {
1435                                 $realcnt=$3+1;
1436                         } else {
1437                                 $realcnt=1+1;
1438                         }
1439                         $in_comment = 0;
1440
1441                         # Guestimate if this is a continuing comment.  Run
1442                         # the context looking for a comment "edge".  If this
1443                         # edge is a close comment then we must be in a comment
1444                         # at context start.
1445                         my $edge;
1446                         my $cnt = $realcnt;
1447                         for (my $ln = $linenr + 1; $cnt > 0; $ln++) {
1448                                 next if (defined $rawlines[$ln - 1] &&
1449                                          $rawlines[$ln - 1] =~ /^-/);
1450                                 $cnt--;
1451                                 #print "RAW<$rawlines[$ln - 1]>\n";
1452                                 last if (!defined $rawlines[$ln - 1]);
1453                                 if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ &&
1454                                     $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) {
1455                                         ($edge) = $1;
1456                                         last;
1457                                 }
1458                         }
1459                         if (defined $edge && $edge eq '*/') {
1460                                 $in_comment = 1;
1461                         }
1462
1463                         # Guestimate if this is a continuing comment.  If this
1464                         # is the start of a diff block and this line starts
1465                         # ' *' then it is very likely a comment.
1466                         if (!defined $edge &&
1467                             $rawlines[$linenr] =~ m@^.\s*(?:\*\*+| \*)(?:\s|$)@)
1468                         {
1469                                 $in_comment = 1;
1470                         }
1471
1472                         ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
1473                         sanitise_line_reset($in_comment);
1474
1475                 } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
1476                         # Standardise the strings and chars within the input to
1477                         # simplify matching -- only bother with positive lines.
1478                         $line = sanitise_line($rawline);
1479                 }
1480                 push(@lines, $line);
1481
1482                 if ($realcnt > 1) {
1483                         $realcnt-- if ($line =~ /^(?:\+| |$)/);
1484                 } else {
1485                         $realcnt = 0;
1486                 }
1487
1488                 #print "==>$rawline\n";
1489                 #print "-->$line\n";
1490
1491                 if ($setup_docs && $line =~ /^\+/) {
1492                         push(@setup_docs, $line);
1493                 }
1494         }
1495
1496         $prefix = '';
1497
1498         $realcnt = 0;
1499         $linenr = 0;
1500         foreach my $line (@lines) {
1501                 $linenr++;
1502
1503                 my $rawline = $rawlines[$linenr - 1];
1504
1505 #extract the line range in the file after the patch is applied
1506                 if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1507                         $is_patch = 1;
1508                         $first_line = $linenr + 1;
1509                         $realline=$1-1;
1510                         if (defined $2) {
1511                                 $realcnt=$3+1;
1512                         } else {
1513                                 $realcnt=1+1;
1514                         }
1515                         annotate_reset();
1516                         $prev_values = 'E';
1517
1518                         %suppress_ifbraces = ();
1519                         %suppress_whiletrailers = ();
1520                         %suppress_export = ();
1521                         $suppress_statement = 0;
1522                         next;
1523
1524 # track the line number as we move through the hunk, note that
1525 # new versions of GNU diff omit the leading space on completely
1526 # blank context lines so we need to count that too.
1527                 } elsif ($line =~ /^( |\+|$)/) {
1528                         $realline++;
1529                         $realcnt-- if ($realcnt != 0);
1530
1531                         # Measure the line length and indent.
1532                         ($length, $indent) = line_stats($rawline);
1533
1534                         # Track the previous line.
1535                         ($prevline, $stashline) = ($stashline, $line);
1536                         ($previndent, $stashindent) = ($stashindent, $indent);
1537                         ($prevrawline, $stashrawline) = ($stashrawline, $rawline);
1538
1539                         #warn "line<$line>\n";
1540
1541                 } elsif ($realcnt == 1) {
1542                         $realcnt--;
1543                 }
1544
1545                 my $hunk_line = ($realcnt != 0);
1546
1547 #make up the handle for any error we report on this line
1548                 $prefix = "$filename:$realline: " if ($emacs && $file);
1549                 $prefix = "$filename:$linenr: " if ($emacs && !$file);
1550
1551                 $here = "#$linenr: " if (!$file);
1552                 $here = "#$realline: " if ($file);
1553
1554                 # extract the filename as it passes
1555                 if ($line =~ /^diff --git.*?(\S+)$/) {
1556                         $realfile = $1;
1557                         $realfile =~ s@^([^/]*)/@@;
1558                         $in_commit_log = 0;
1559                 } elsif ($line =~ /^\+\+\+\s+(\S+)/) {
1560                         $realfile = $1;
1561                         $realfile =~ s@^([^/]*)/@@;
1562                         $in_commit_log = 0;
1563
1564                         $p1_prefix = $1;
1565                         if (!$file && $tree && $p1_prefix ne '' &&
1566                             -e "$root/$p1_prefix") {
1567                                 WARN("PATCH_PREFIX",
1568                                      "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
1569                         }
1570
1571                         if ($realfile =~ m@^include/asm/@) {
1572                                 ERROR("MODIFIED_INCLUDE_ASM",
1573                                       "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
1574                         }
1575                         next;
1576                 }
1577
1578                 $here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
1579
1580                 my $hereline = "$here\n$rawline\n";
1581                 my $herecurr = "$here\n$rawline\n";
1582                 my $hereprev = "$here\n$prevrawline\n$rawline\n";
1583
1584                 $cnt_lines++ if ($realcnt != 0);
1585
1586 # Check for incorrect file permissions
1587                 if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
1588                         my $permhere = $here . "FILE: $realfile\n";
1589                         if ($realfile =~ /(Makefile|Kconfig|\.c|\.h|\.S|\.tmpl)$/) {
1590                                 ERROR("EXECUTE_PERMISSIONS",
1591                                       "do not set execute permissions for source files\n" . $permhere);
1592                         }
1593                 }
1594
1595 # Check the patch for a signoff:
1596                 if ($line =~ /^\s*signed-off-by:/i) {
1597                         $signoff++;
1598                         $in_commit_log = 0;
1599                 }
1600
1601 # Check signature styles
1602                 if (!$in_header_lines &&
1603                     $line =~ /^(\s*)($signature_tags)(\s*)(.*)/) {
1604                         my $space_before = $1;
1605                         my $sign_off = $2;
1606                         my $space_after = $3;
1607                         my $email = $4;
1608                         my $ucfirst_sign_off = ucfirst(lc($sign_off));
1609
1610                         if (defined $space_before && $space_before ne "") {
1611                                 WARN("BAD_SIGN_OFF",
1612                                      "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr);
1613                         }
1614                         if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
1615                                 WARN("BAD_SIGN_OFF",
1616                                      "'$ucfirst_sign_off' is the preferred signature form\n" . $herecurr);
1617                         }
1618                         if (!defined $space_after || $space_after ne " ") {
1619                                 WARN("BAD_SIGN_OFF",
1620                                      "Use a single space after $ucfirst_sign_off\n" . $herecurr);
1621                         }
1622
1623                         my ($email_name, $email_address, $comment) = parse_email($email);
1624                         my $suggested_email = format_email(($email_name, $email_address));
1625                         if ($suggested_email eq "") {
1626                                 ERROR("BAD_SIGN_OFF",
1627                                       "Unrecognized email address: '$email'\n" . $herecurr);
1628                         } else {
1629                                 my $dequoted = $suggested_email;
1630                                 $dequoted =~ s/^"//;
1631                                 $dequoted =~ s/" </ </;
1632                                 # Don't force email to have quotes
1633                                 # Allow just an angle bracketed address
1634                                 if ("$dequoted$comment" ne $email &&
1635                                     "<$email_address>$comment" ne $email &&
1636                                     "$suggested_email$comment" ne $email) {
1637                                         WARN("BAD_SIGN_OFF",
1638                                              "email address '$email' might be better as '$suggested_email$comment'\n" . $herecurr);
1639                                 }
1640                         }
1641                 }
1642
1643 # Check for wrappage within a valid hunk of the file
1644                 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
1645                         ERROR("CORRUPTED_PATCH",
1646                               "patch seems to be corrupt (line wrapped?)\n" .
1647                                 $herecurr) if (!$emitted_corrupt++);
1648                 }
1649
1650 # Check for absolute kernel paths.
1651                 if ($tree) {
1652                         while ($line =~ m{(?:^|\s)(/\S*)}g) {
1653                                 my $file = $1;
1654
1655                                 if ($file =~ m{^(.*?)(?::\d+)+:?$} &&
1656                                     check_absolute_file($1, $herecurr)) {
1657                                         #
1658                                 } else {
1659                                         check_absolute_file($file, $herecurr);
1660                                 }
1661                         }
1662                 }
1663
1664 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
1665                 if (($realfile =~ /^$/ || $line =~ /^\+/) &&
1666                     $rawline !~ m/^$UTF8*$/) {
1667                         my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/);
1668
1669                         my $blank = copy_spacing($rawline);
1670                         my $ptr = substr($blank, 0, length($utf8_prefix)) . "^";
1671                         my $hereptr = "$hereline$ptr\n";
1672
1673                         CHK("INVALID_UTF8",
1674                             "Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
1675                 }
1676
1677 # Check if it's the start of a commit log
1678 # (not a header line and we haven't seen the patch filename)
1679                 if ($in_header_lines && $realfile =~ /^$/ &&
1680                     $rawline !~ /^(commit\b|from\b|[\w-]+:).+$/i) {
1681                         $in_header_lines = 0;
1682                         $in_commit_log = 1;
1683                 }
1684
1685 # Still not yet in a patch, check for any UTF-8
1686                 if ($in_commit_log && $realfile =~ /^$/ &&
1687                     $rawline =~ /$NON_ASCII_UTF8/) {
1688                         CHK("UTF8_BEFORE_PATCH",
1689                             "8-bit UTF-8 used in possible commit log\n" . $herecurr);
1690                 }
1691
1692 # ignore non-hunk lines and lines being removed
1693                 next if (!$hunk_line || $line =~ /^-/);
1694
1695 #trailing whitespace
1696                 if ($line =~ /^\+.*\015/) {
1697                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1698                         ERROR("DOS_LINE_ENDINGS",
1699                               "DOS line endings\n" . $herevet);
1700
1701                 } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
1702                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1703                         ERROR("TRAILING_WHITESPACE",
1704                               "trailing whitespace\n" . $herevet);
1705                         $rpt_cleaners = 1;
1706                 }
1707
1708 # check for Kconfig help text having a real description
1709 # Only applies when adding the entry originally, after that we do not have
1710 # sufficient context to determine whether it is indeed long enough.
1711                 if ($realfile =~ /Kconfig/ &&
1712                     $line =~ /.\s*config\s+/) {
1713                         my $length = 0;
1714                         my $cnt = $realcnt;
1715                         my $ln = $linenr + 1;
1716                         my $f;
1717                         my $is_start = 0;
1718                         my $is_end = 0;
1719                         for (; $cnt > 0 && defined $lines[$ln - 1]; $ln++) {
1720                                 $f = $lines[$ln - 1];
1721                                 $cnt-- if ($lines[$ln - 1] !~ /^-/);
1722                                 $is_end = $lines[$ln - 1] =~ /^\+/;
1723
1724                                 next if ($f =~ /^-/);
1725
1726                                 if ($lines[$ln - 1] =~ /.\s*(?:bool|tristate)\s*\"/) {
1727                                         $is_start = 1;
1728                                 } elsif ($lines[$ln - 1] =~ /.\s*(?:---)?help(?:---)?$/) {
1729                                         $length = -1;
1730                                 }
1731
1732                                 $f =~ s/^.//;
1733                                 $f =~ s/#.*//;
1734                                 $f =~ s/^\s+//;
1735                                 next if ($f =~ /^$/);
1736                                 if ($f =~ /^\s*config\s/) {
1737                                         $is_end = 1;
1738                                         last;
1739                                 }
1740                                 $length++;
1741                         }
1742                         WARN("CONFIG_DESCRIPTION",
1743                              "please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($is_start && $is_end && $length < 4);
1744                         #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
1745                 }
1746
1747                 if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
1748                     ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
1749                         my $flag = $1;
1750                         my $replacement = {
1751                                 'EXTRA_AFLAGS' =>   'asflags-y',
1752                                 'EXTRA_CFLAGS' =>   'ccflags-y',
1753                                 'EXTRA_CPPFLAGS' => 'cppflags-y',
1754                                 'EXTRA_LDFLAGS' =>  'ldflags-y',
1755                         };
1756
1757                         WARN("DEPRECATED_VARIABLE",
1758                              "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
1759                 }
1760
1761 # check we are in a valid source file if not then ignore this hunk
1762                 next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
1763
1764 #80 column limit
1765                 if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
1766                     $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
1767                     !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ ||
1768                     $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
1769                     $length > 80)
1770                 {
1771                         WARN("LONG_LINE",
1772                              "line over 80 characters\n" . $herecurr);
1773                 }
1774
1775 # check for spaces before a quoted newline
1776                 if ($rawline =~ /^.*\".*\s\\n/) {
1777                         WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE",
1778                              "unnecessary whitespace before a quoted newline\n" . $herecurr);
1779                 }
1780
1781 # check for adding lines without a newline.
1782                 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
1783                         WARN("MISSING_EOF_NEWLINE",
1784                              "adding a line without newline at end of file\n" . $herecurr);
1785                 }
1786
1787 # Blackfin: use hi/lo macros
1788                 if ($realfile =~ m@arch/blackfin/.*\.S$@) {
1789                         if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) {
1790                                 my $herevet = "$here\n" . cat_vet($line) . "\n";
1791                                 ERROR("LO_MACRO",
1792                                       "use the LO() macro, not (... & 0xFFFF)\n" . $herevet);
1793                         }
1794                         if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) {
1795                                 my $herevet = "$here\n" . cat_vet($line) . "\n";
1796                                 ERROR("HI_MACRO",
1797                                       "use the HI() macro, not (... >> 16)\n" . $herevet);
1798                         }
1799                 }
1800
1801 # check we are in a valid source file C or perl if not then ignore this hunk
1802                 next if ($realfile !~ /\.(h|c|pl)$/);
1803
1804 # at the beginning of a line any tabs must come first and anything
1805 # more than 8 must use tabs.
1806                 if ($rawline =~ /^\+\s* \t\s*\S/ ||
1807                     $rawline =~ /^\+\s*        \s*/) {
1808                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1809                         ERROR("CODE_INDENT",
1810                               "code indent should use tabs where possible\n" . $herevet);
1811                         $rpt_cleaners = 1;
1812                 }
1813
1814 # check for space before tabs.
1815                 if ($rawline =~ /^\+/ && $rawline =~ / \t/) {
1816                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1817                         WARN("SPACE_BEFORE_TAB",
1818                              "please, no space before tabs\n" . $herevet);
1819                 }
1820
1821 # check for && or || at the start of a line
1822                 if ($rawline =~ /^\+\s*(&&|\|\|)/) {
1823                         CHK("LOGICAL_CONTINUATIONS",
1824                             "Logical continuations should be on the previous line\n" . $hereprev);
1825                 }
1826
1827 # check multi-line statement indentation matches previous line
1828                 if ($^V && $^V ge 5.10.0 &&
1829                     $prevline =~ /^\+(\t*)(if \(|$Ident\().*(\&\&|\|\||,)\s*$/) {
1830                         $prevline =~ /^\+(\t*)(.*)$/;
1831                         my $oldindent = $1;
1832                         my $rest = $2;
1833
1834                         my $pos = pos_last_openparen($rest);
1835                         if ($pos >= 0) {
1836                                 $line =~ /^\+([ \t]*)/;
1837                                 my $newindent = $1;
1838
1839                                 my $goodtabindent = $oldindent .
1840                                         "\t" x ($pos / 8) .
1841                                         " "  x ($pos % 8);
1842                                 my $goodspaceindent = $oldindent . " "  x $pos;
1843
1844                                 if ($newindent ne $goodtabindent &&
1845                                     $newindent ne $goodspaceindent) {
1846                                         CHK("PARENTHESIS_ALIGNMENT",
1847                                             "Alignment should match open parenthesis\n" . $hereprev);
1848                                 }
1849                         }
1850                 }
1851
1852 # check for spaces at the beginning of a line.
1853 # Exceptions:
1854 #  1) within comments
1855 #  2) indented preprocessor commands
1856 #  3) hanging labels
1857                 if ($rawline =~ /^\+ / && $line !~ /\+ *(?:$;|#|$Ident:)/)  {
1858                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1859                         WARN("LEADING_SPACE",
1860                              "please, no spaces at the start of a line\n" . $herevet);
1861                 }
1862
1863 # check we are in a valid C source file if not then ignore this hunk
1864                 next if ($realfile !~ /\.(h|c)$/);
1865
1866 # check for RCS/CVS revision markers
1867                 if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
1868                         WARN("CVS_KEYWORD",
1869                              "CVS style keyword markers, these will _not_ be updated\n". $herecurr);
1870                 }
1871
1872 # Blackfin: don't use __builtin_bfin_[cs]sync
1873                 if ($line =~ /__builtin_bfin_csync/) {
1874                         my $herevet = "$here\n" . cat_vet($line) . "\n";
1875                         ERROR("CSYNC",
1876                               "use the CSYNC() macro in asm/blackfin.h\n" . $herevet);
1877                 }
1878                 if ($line =~ /__builtin_bfin_ssync/) {
1879                         my $herevet = "$here\n" . cat_vet($line) . "\n";
1880                         ERROR("SSYNC",
1881                               "use the SSYNC() macro in asm/blackfin.h\n" . $herevet);
1882                 }
1883
1884 # Check for potential 'bare' types
1885                 my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
1886                     $realline_next);
1887 #print "LINE<$line>\n";
1888                 if ($linenr >= $suppress_statement &&
1889                     $realcnt && $line =~ /.\s*\S/) {
1890                         ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
1891                                 ctx_statement_block($linenr, $realcnt, 0);
1892                         $stat =~ s/\n./\n /g;
1893                         $cond =~ s/\n./\n /g;
1894
1895 #print "linenr<$linenr> <$stat>\n";
1896                         # If this statement has no statement boundaries within
1897                         # it there is no point in retrying a statement scan
1898                         # until we hit end of it.
1899                         my $frag = $stat; $frag =~ s/;+\s*$//;
1900                         if ($frag !~ /(?:{|;)/) {
1901 #print "skip<$line_nr_next>\n";
1902                                 $suppress_statement = $line_nr_next;
1903                         }
1904
1905                         # Find the real next line.
1906                         $realline_next = $line_nr_next;
1907                         if (defined $realline_next &&
1908                             (!defined $lines[$realline_next - 1] ||
1909                              substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
1910                                 $realline_next++;
1911                         }
1912
1913                         my $s = $stat;
1914                         $s =~ s/{.*$//s;
1915
1916                         # Ignore goto labels.
1917                         if ($s =~ /$Ident:\*$/s) {
1918
1919                         # Ignore functions being called
1920                         } elsif ($s =~ /^.\s*$Ident\s*\(/s) {
1921
1922                         } elsif ($s =~ /^.\s*else\b/s) {
1923
1924                         # declarations always start with types
1925                         } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
1926                                 my $type = $1;
1927                                 $type =~ s/\s+/ /g;
1928                                 possible($type, "A:" . $s);
1929
1930                         # definitions in global scope can only start with types
1931                         } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b\s*(?!:)/s) {
1932                                 possible($1, "B:" . $s);
1933                         }
1934
1935                         # any (foo ... *) is a pointer cast, and foo is a type
1936                         while ($s =~ /\(($Ident)(?:\s+$Sparse)*[\s\*]+\s*\)/sg) {
1937                                 possible($1, "C:" . $s);
1938                         }
1939
1940                         # Check for any sort of function declaration.
1941                         # int foo(something bar, other baz);
1942                         # void (*store_gdt)(x86_descr_ptr *);
1943                         if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
1944                                 my ($name_len) = length($1);
1945
1946                                 my $ctx = $s;
1947                                 substr($ctx, 0, $name_len + 1, '');
1948                                 $ctx =~ s/\)[^\)]*$//;
1949
1950                                 for my $arg (split(/\s*,\s*/, $ctx)) {
1951                                         if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
1952
1953                                                 possible($1, "D:" . $s);
1954                                         }
1955                                 }
1956                         }
1957
1958                 }
1959
1960 #
1961 # Checks which may be anchored in the context.
1962 #
1963
1964 # Check for switch () and associated case and default
1965 # statements should be at the same indent.
1966                 if ($line=~/\bswitch\s*\(.*\)/) {
1967                         my $err = '';
1968                         my $sep = '';
1969                         my @ctx = ctx_block_outer($linenr, $realcnt);
1970                         shift(@ctx);
1971                         for my $ctx (@ctx) {
1972                                 my ($clen, $cindent) = line_stats($ctx);
1973                                 if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
1974                                                         $indent != $cindent) {
1975                                         $err .= "$sep$ctx\n";
1976                                         $sep = '';
1977                                 } else {
1978                                         $sep = "[...]\n";
1979                                 }
1980                         }
1981                         if ($err ne '') {
1982                                 ERROR("SWITCH_CASE_INDENT_LEVEL",
1983                                       "switch and case should be at the same indent\n$hereline$err");
1984                         }
1985                 }
1986
1987 # if/while/etc brace do not go on next line, unless defining a do while loop,
1988 # or if that brace on the next line is for something else
1989                 if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
1990                         my $pre_ctx = "$1$2";
1991
1992                         my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
1993
1994                         if ($line =~ /^\+\t{6,}/) {
1995                                 WARN("DEEP_INDENTATION",
1996                                      "Too many leading tabs - consider code refactoring\n" . $herecurr);
1997                         }
1998
1999                         my $ctx_cnt = $realcnt - $#ctx - 1;
2000                         my $ctx = join("\n", @ctx);
2001
2002                         my $ctx_ln = $linenr;
2003                         my $ctx_skip = $realcnt;
2004
2005                         while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt &&
2006                                         defined $lines[$ctx_ln - 1] &&
2007                                         $lines[$ctx_ln - 1] =~ /^-/)) {
2008                                 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
2009                                 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
2010                                 $ctx_ln++;
2011                         }
2012
2013                         #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
2014                         #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
2015
2016                         if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
2017                                 ERROR("OPEN_BRACE",
2018                                       "that open brace { should be on the previous line\n" .
2019                                         "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
2020                         }
2021                         if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
2022                             $ctx =~ /\)\s*\;\s*$/ &&
2023                             defined $lines[$ctx_ln - 1])
2024                         {
2025                                 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
2026                                 if ($nindent > $indent) {
2027                                         WARN("TRAILING_SEMICOLON",
2028                                              "trailing semicolon indicates no statements, indent implies otherwise\n" .
2029                                                 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
2030                                 }
2031                         }
2032                 }
2033
2034 # Check relative indent for conditionals and blocks.
2035                 if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
2036                         ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
2037                                 ctx_statement_block($linenr, $realcnt, 0)
2038                                         if (!defined $stat);
2039                         my ($s, $c) = ($stat, $cond);
2040
2041                         substr($s, 0, length($c), '');
2042
2043                         # Make sure we remove the line prefixes as we have
2044                         # none on the first line, and are going to readd them
2045                         # where necessary.
2046                         $s =~ s/\n./\n/gs;
2047
2048                         # Find out how long the conditional actually is.
2049                         my @newlines = ($c =~ /\n/gs);
2050                         my $cond_lines = 1 + $#newlines;
2051
2052                         # We want to check the first line inside the block
2053                         # starting at the end of the conditional, so remove:
2054                         #  1) any blank line termination
2055                         #  2) any opening brace { on end of the line
2056                         #  3) any do (...) {
2057                         my $continuation = 0;
2058                         my $check = 0;
2059                         $s =~ s/^.*\bdo\b//;
2060                         $s =~ s/^\s*{//;
2061                         if ($s =~ s/^\s*\\//) {
2062                                 $continuation = 1;
2063                         }
2064                         if ($s =~ s/^\s*?\n//) {
2065                                 $check = 1;
2066                                 $cond_lines++;
2067                         }
2068
2069                         # Also ignore a loop construct at the end of a
2070                         # preprocessor statement.
2071                         if (($prevline =~ /^.\s*#\s*define\s/ ||
2072                             $prevline =~ /\\\s*$/) && $continuation == 0) {
2073                                 $check = 0;
2074                         }
2075
2076                         my $cond_ptr = -1;
2077                         $continuation = 0;
2078                         while ($cond_ptr != $cond_lines) {
2079                                 $cond_ptr = $cond_lines;
2080
2081                                 # If we see an #else/#elif then the code
2082                                 # is not linear.
2083                                 if ($s =~ /^\s*\#\s*(?:else|elif)/) {
2084                                         $check = 0;
2085                                 }
2086
2087                                 # Ignore:
2088                                 #  1) blank lines, they should be at 0,
2089                                 #  2) preprocessor lines, and
2090                                 #  3) labels.
2091                                 if ($continuation ||
2092                                     $s =~ /^\s*?\n/ ||
2093                                     $s =~ /^\s*#\s*?/ ||
2094                                     $s =~ /^\s*$Ident\s*:/) {
2095                                         $continuation = ($s =~ /^.*?\\\n/) ? 1 : 0;
2096                                         if ($s =~ s/^.*?\n//) {
2097                                                 $cond_lines++;
2098                                         }
2099                                 }
2100                         }
2101
2102                         my (undef, $sindent) = line_stats("+" . $s);
2103                         my $stat_real = raw_line($linenr, $cond_lines);
2104
2105                         # Check if either of these lines are modified, else
2106                         # this is not this patch's fault.
2107                         if (!defined($stat_real) ||
2108                             $stat !~ /^\+/ && $stat_real !~ /^\+/) {
2109                                 $check = 0;
2110                         }
2111                         if (defined($stat_real) && $cond_lines > 1) {
2112                                 $stat_real = "[...]\n$stat_real";
2113                         }
2114
2115                         #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
2116
2117                         if ($check && (($sindent % 8) != 0 ||
2118                             ($sindent <= $indent && $s ne ''))) {
2119                                 WARN("SUSPECT_CODE_INDENT",
2120                                      "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
2121                         }
2122                 }
2123
2124                 # Track the 'values' across context and added lines.
2125                 my $opline = $line; $opline =~ s/^./ /;
2126                 my ($curr_values, $curr_vars) =
2127                                 annotate_values($opline . "\n", $prev_values);
2128                 $curr_values = $prev_values . $curr_values;
2129                 if ($dbg_values) {
2130                         my $outline = $opline; $outline =~ s/\t/ /g;
2131                         print "$linenr > .$outline\n";
2132                         print "$linenr > $curr_values\n";
2133                         print "$linenr >  $curr_vars\n";
2134                 }
2135                 $prev_values = substr($curr_values, -1);
2136
2137 #ignore lines not being added
2138                 if ($line=~/^[^\+]/) {next;}
2139
2140 # TEST: allow direct testing of the type matcher.
2141                 if ($dbg_type) {
2142                         if ($line =~ /^.\s*$Declare\s*$/) {
2143                                 ERROR("TEST_TYPE",
2144                                       "TEST: is type\n" . $herecurr);
2145                         } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) {
2146                                 ERROR("TEST_NOT_TYPE",
2147                                       "TEST: is not type ($1 is)\n". $herecurr);
2148                         }
2149                         next;
2150                 }
2151 # TEST: allow direct testing of the attribute matcher.
2152                 if ($dbg_attr) {
2153                         if ($line =~ /^.\s*$Modifier\s*$/) {
2154                                 ERROR("TEST_ATTR",
2155                                       "TEST: is attr\n" . $herecurr);
2156                         } elsif ($dbg_attr > 1 && $line =~ /^.+($Modifier)/) {
2157                                 ERROR("TEST_NOT_ATTR",
2158                                       "TEST: is not attr ($1 is)\n". $herecurr);
2159                         }
2160                         next;
2161                 }
2162
2163 # check for initialisation to aggregates open brace on the next line
2164                 if ($line =~ /^.\s*{/ &&
2165                     $prevline =~ /(?:^|[^=])=\s*$/) {
2166                         ERROR("OPEN_BRACE",
2167                               "that open brace { should be on the previous line\n" . $hereprev);
2168                 }
2169
2170 #
2171 # Checks which are anchored on the added line.
2172 #
2173
2174 # check for malformed paths in #include statements (uses RAW line)
2175                 if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) {
2176                         my $path = $1;
2177                         if ($path =~ m{//}) {
2178                                 ERROR("MALFORMED_INCLUDE",
2179                                       "malformed #include filename\n" .
2180                                         $herecurr);
2181                         }
2182                 }
2183
2184 # no C99 // comments
2185                 if ($line =~ m{//}) {
2186                         ERROR("C99_COMMENTS",
2187                               "do not use C99 // comments\n" . $herecurr);
2188                 }
2189                 # Remove C99 comments.
2190                 $line =~ s@//.*@@;
2191                 $opline =~ s@//.*@@;
2192
2193 # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
2194 # the whole statement.
2195 #print "APW <$lines[$realline_next - 1]>\n";
2196                 if (defined $realline_next &&
2197                     exists $lines[$realline_next - 1] &&
2198                     !defined $suppress_export{$realline_next} &&
2199                     ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
2200                      $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
2201                         # Handle definitions which produce identifiers with
2202                         # a prefix:
2203                         #   XXX(foo);
2204                         #   EXPORT_SYMBOL(something_foo);
2205                         my $name = $1;
2206                         if ($stat =~ /^(?:.\s*}\s*\n)?.([A-Z_]+)\s*\(\s*($Ident)/ &&
2207                             $name =~ /^${Ident}_$2/) {
2208 #print "FOO C name<$name>\n";
2209                                 $suppress_export{$realline_next} = 1;
2210
2211                         } elsif ($stat !~ /(?:
2212                                 \n.}\s*$|
2213                                 ^.DEFINE_$Ident\(\Q$name\E\)|
2214                                 ^.DECLARE_$Ident\(\Q$name\E\)|
2215                                 ^.LIST_HEAD\(\Q$name\E\)|
2216                                 ^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(|
2217                                 \b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\()
2218                             )/x) {
2219 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
2220                                 $suppress_export{$realline_next} = 2;
2221                         } else {
2222                                 $suppress_export{$realline_next} = 1;
2223                         }
2224                 }
2225                 if (!defined $suppress_export{$linenr} &&
2226                     $prevline =~ /^.\s*$/ &&
2227                     ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
2228                      $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
2229 #print "FOO B <$lines[$linenr - 1]>\n";
2230                         $suppress_export{$linenr} = 2;
2231                 }
2232                 if (defined $suppress_export{$linenr} &&
2233                     $suppress_export{$linenr} == 2) {
2234                         WARN("EXPORT_SYMBOL",
2235                              "EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
2236                 }
2237
2238 # check for global initialisers.
2239                 if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) {
2240                         ERROR("GLOBAL_INITIALISERS",
2241                               "do not initialise globals to 0 or NULL\n" .
2242                                 $herecurr);
2243                 }
2244 # check for static initialisers.
2245                 if ($line =~ /\bstatic\s.*=\s*(0|NULL|false)\s*;/) {
2246                         ERROR("INITIALISED_STATIC",
2247                               "do not initialise statics to 0 or NULL\n" .
2248                                 $herecurr);
2249                 }
2250
2251 # check for static const char * arrays.
2252                 if ($line =~ /\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) {
2253                         WARN("STATIC_CONST_CHAR_ARRAY",
2254                              "static const char * array should probably be static const char * const\n" .
2255                                 $herecurr);
2256                }
2257
2258 # check for static char foo[] = "bar" declarations.
2259                 if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) {
2260                         WARN("STATIC_CONST_CHAR_ARRAY",
2261                              "static char array declaration should probably be static const char\n" .
2262                                 $herecurr);
2263                }
2264
2265 # check for declarations of struct pci_device_id
2266                 if ($line =~ /\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) {
2267                         WARN("DEFINE_PCI_DEVICE_TABLE",
2268                              "Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id\n" . $herecurr);
2269                 }
2270
2271 # check for new typedefs, only function parameters and sparse annotations
2272 # make sense.
2273                 if ($line =~ /\btypedef\s/ &&
2274                     $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ &&
2275                     $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ &&
2276                     $line !~ /\b$typeTypedefs\b/ &&
2277                     $line !~ /\b__bitwise(?:__|)\b/) {
2278                         WARN("NEW_TYPEDEFS",
2279                              "do not add new typedefs\n" . $herecurr);
2280                 }
2281
2282 # * goes on variable not on type
2283                 # (char*[ const])
2284                 while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) {
2285                         #print "AA<$1>\n";
2286                         my ($from, $to) = ($2, $2);
2287
2288                         # Should start with a space.
2289                         $to =~ s/^(\S)/ $1/;
2290                         # Should not end with a space.
2291                         $to =~ s/\s+$//;
2292                         # '*'s should not have spaces between.
2293                         while ($to =~ s/\*\s+\*/\*\*/) {
2294                         }
2295
2296                         #print "from<$from> to<$to>\n";
2297                         if ($from ne $to) {
2298                                 ERROR("POINTER_LOCATION",
2299                                       "\"(foo$from)\" should be \"(foo$to)\"\n" .  $herecurr);
2300                         }
2301                 }
2302                 while ($line =~ m{(\b$NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)($Ident))}g) {
2303                         #print "BB<$1>\n";
2304                         my ($from, $to, $ident) = ($2, $2, $3);
2305
2306                         # Should start with a space.
2307                         $to =~ s/^(\S)/ $1/;
2308                         # Should not end with a space.
2309                         $to =~ s/\s+$//;
2310                         # '*'s should not have spaces between.
2311                         while ($to =~ s/\*\s+\*/\*\*/) {
2312                         }
2313                         # Modifiers should have spaces.
2314                         $to =~ s/(\b$Modifier$)/$1 /;
2315
2316                         #print "from<$from> to<$to> ident<$ident>\n";
2317                         if ($from ne $to && $ident !~ /^$Modifier$/) {
2318                                 ERROR("POINTER_LOCATION",
2319                                       "\"foo${from}bar\" should be \"foo${to}bar\"\n" .  $herecurr);
2320                         }
2321                 }
2322
2323 # # no BUG() or BUG_ON()
2324 #               if ($line =~ /\b(BUG|BUG_ON)\b/) {
2325 #                       print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
2326 #                       print "$herecurr";
2327 #                       $clean = 0;
2328 #               }
2329
2330                 if ($line =~ /\bLINUX_VERSION_CODE\b/) {
2331                         WARN("LINUX_VERSION_CODE",
2332                              "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
2333                 }
2334
2335 # check for uses of printk_ratelimit
2336                 if ($line =~ /\bprintk_ratelimit\s*\(/) {
2337                         WARN("PRINTK_RATELIMITED",
2338 "Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit\n" . $herecurr);
2339                 }
2340
2341 # printk should use KERN_* levels.  Note that follow on printk's on the
2342 # same line do not need a level, so we use the current block context
2343 # to try and find and validate the current printk.  In summary the current
2344 # printk includes all preceding printk's which have no newline on the end.
2345 # we assume the first bad printk is the one to report.
2346                 if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
2347                         my $ok = 0;
2348                         for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
2349                                 #print "CHECK<$lines[$ln - 1]\n";
2350                                 # we have a preceding printk if it ends
2351                                 # with "\n" ignore it, else it is to blame
2352                                 if ($lines[$ln - 1] =~ m{\bprintk\(}) {
2353                                         if ($rawlines[$ln - 1] !~ m{\\n"}) {
2354                                                 $ok = 1;
2355                                         }
2356                                         last;
2357                                 }
2358                         }
2359                         if ($ok == 0) {
2360                                 WARN("PRINTK_WITHOUT_KERN_LEVEL",
2361                                      "printk() should include KERN_ facility level\n" . $herecurr);
2362                         }
2363                 }
2364
2365 # function brace can't be on same line, except for #defines of do while,
2366 # or if closed on same line
2367                 if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
2368                     !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) {
2369                         ERROR("OPEN_BRACE",
2370                               "open brace '{' following function declarations go on the next line\n" . $herecurr);
2371                 }
2372
2373 # open braces for enum, union and struct go on the same line.
2374                 if ($line =~ /^.\s*{/ &&
2375                     $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
2376                         ERROR("OPEN_BRACE",
2377                               "open brace '{' following $1 go on the same line\n" . $hereprev);
2378                 }
2379
2380 # missing space after union, struct or enum definition
2381                 if ($line =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?(?:\s+$Ident)?[=\{]/) {
2382                     WARN("SPACING",
2383                          "missing space after $1 definition\n" . $herecurr);
2384                 }
2385
2386 # check for spacing round square brackets; allowed:
2387 #  1. with a type on the left -- int [] a;
2388 #  2. at the beginning of a line for slice initialisers -- [0...10] = 5,
2389 #  3. inside a curly brace -- = { [0...10] = 5 }
2390                 while ($line =~ /(.*?\s)\[/g) {
2391                         my ($where, $prefix) = ($-[1], $1);
2392                         if ($prefix !~ /$Type\s+$/ &&
2393                             ($where != 0 || $prefix !~ /^.\s+$/) &&
2394                             $prefix !~ /[{,]\s+$/) {
2395                                 ERROR("BRACKET_SPACE",
2396                                       "space prohibited before open square bracket '['\n" . $herecurr);
2397                         }
2398                 }
2399
2400 # check for spaces between functions and their parentheses.
2401                 while ($line =~ /($Ident)\s+\(/g) {
2402                         my $name = $1;
2403                         my $ctx_before = substr($line, 0, $-[1]);
2404                         my $ctx = "$ctx_before$name";
2405
2406                         # Ignore those directives where spaces _are_ permitted.
2407                         if ($name =~ /^(?:
2408                                 if|for|while|switch|return|case|
2409                                 volatile|__volatile__|
2410                                 __attribute__|format|__extension__|
2411                                 asm|__asm__)$/x)
2412                         {
2413
2414                         # cpp #define statements have non-optional spaces, ie
2415                         # if there is a space between the name and the open
2416                         # parenthesis it is simply not a parameter group.
2417                         } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
2418
2419                         # cpp #elif statement condition may start with a (
2420                         } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) {
2421
2422                         # If this whole things ends with a type its most
2423                         # likely a typedef for a function.
2424                         } elsif ($ctx =~ /$Type$/) {
2425
2426                         } else {
2427                                 WARN("SPACING",
2428                                      "space prohibited between function name and open parenthesis '('\n" . $herecurr);
2429                         }
2430                 }
2431 # Check operator spacing.
2432                 if (!($line=~/\#\s*include/)) {
2433                         my $ops = qr{
2434                                 <<=|>>=|<=|>=|==|!=|
2435                                 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
2436                                 =>|->|<<|>>|<|>|=|!|~|
2437                                 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
2438                                 \?|:
2439                         }x;
2440                         my @elements = split(/($ops|;)/, $opline);
2441                         my $off = 0;
2442
2443                         my $blank = copy_spacing($opline);
2444
2445                         for (my $n = 0; $n < $#elements; $n += 2) {
2446                                 $off += length($elements[$n]);
2447
2448                                 # Pick up the preceding and succeeding characters.
2449                                 my $ca = substr($opline, 0, $off);
2450                                 my $cc = '';
2451                                 if (length($opline) >= ($off + length($elements[$n + 1]))) {
2452                                         $cc = substr($opline, $off + length($elements[$n + 1]));
2453                                 }
2454                                 my $cb = "$ca$;$cc";
2455
2456                                 my $a = '';
2457                                 $a = 'V' if ($elements[$n] ne '');
2458                                 $a = 'W' if ($elements[$n] =~ /\s$/);
2459                                 $a = 'C' if ($elements[$n] =~ /$;$/);
2460                                 $a = 'B' if ($elements[$n] =~ /(\[|\()$/);
2461                                 $a = 'O' if ($elements[$n] eq '');
2462                                 $a = 'E' if ($ca =~ /^\s*$/);
2463
2464                                 my $op = $elements[$n + 1];
2465
2466                                 my $c = '';
2467                                 if (defined $elements[$n + 2]) {
2468                                         $c = 'V' if ($elements[$n + 2] ne '');
2469                                         $c = 'W' if ($elements[$n + 2] =~ /^\s/);
2470                                         $c = 'C' if ($elements[$n + 2] =~ /^$;/);
2471                                         $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
2472                                         $c = 'O' if ($elements[$n + 2] eq '');
2473                                         $c = 'E' if ($elements[$n + 2] =~ /^\s*\\$/);
2474                                 } else {
2475                                         $c = 'E';
2476                                 }
2477
2478                                 my $ctx = "${a}x${c}";
2479
2480                                 my $at = "(ctx:$ctx)";
2481
2482                                 my $ptr = substr($blank, 0, $off) . "^";
2483                                 my $hereptr = "$hereline$ptr\n";
2484
2485                                 # Pull out the value of this operator.
2486                                 my $op_type = substr($curr_values, $off + 1, 1);
2487
2488                                 # Get the full operator variant.
2489                                 my $opv = $op . substr($curr_vars, $off, 1);
2490
2491                                 # Ignore operators passed as parameters.
2492                                 if ($op_type ne 'V' &&
2493                                     $ca =~ /\s$/ && $cc =~ /^\s*,/) {
2494
2495 #                               # Ignore comments
2496 #                               } elsif ($op =~ /^$;+$/) {
2497
2498                                 # ; should have either the end of line or a space or \ after it
2499                                 } elsif ($op eq ';') {
2500                                         if ($ctx !~ /.x[WEBC]/ &&
2501                                             $cc !~ /^\\/ && $cc !~ /^;/) {
2502                                                 ERROR("SPACING",
2503                                                       "space required after that '$op' $at\n" . $hereptr);
2504                                         }
2505
2506                                 # // is a comment
2507                                 } elsif ($op eq '//') {
2508
2509                                 # No spaces for:
2510                                 #   ->
2511                                 #   :   when part of a bitfield
2512                                 } elsif ($op eq '->' || $opv eq ':B') {
2513                                         if ($ctx =~ /Wx.|.xW/) {
2514                                                 ERROR("SPACING",
2515                                                       "spaces prohibited around that '$op' $at\n" . $hereptr);
2516                                         }
2517
2518                                 # , must have a space on the right.
2519                                 } elsif ($op eq ',') {
2520                                         if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
2521                                                 ERROR("SPACING",
2522                                                       "space required after that '$op' $at\n" . $hereptr);
2523                                         }
2524
2525                                 # '*' as part of a type definition -- reported already.
2526                                 } elsif ($opv eq '*_') {
2527                                         #warn "'*' is part of type\n";
2528
2529                                 # unary operators should have a space before and
2530                                 # none after.  May be left adjacent to another
2531                                 # unary operator, or a cast
2532                                 } elsif ($op eq '!' || $op eq '~' ||
2533                                          $opv eq '*U' || $opv eq '-U' ||
2534                                          $opv eq '&U' || $opv eq '&&U') {
2535                                         if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
2536                                                 ERROR("SPACING",
2537                                                       "space required before that '$op' $at\n" . $hereptr);
2538                                         }
2539                                         if ($op eq '*' && $cc =~/\s*$Modifier\b/) {
2540                                                 # A unary '*' may be const
2541
2542                                         } elsif ($ctx =~ /.xW/) {
2543                                                 ERROR("SPACING",
2544                                                       "space prohibited after that '$op' $at\n" . $hereptr);
2545                                         }
2546
2547                                 # unary ++ and unary -- are allowed no space on one side.
2548                                 } elsif ($op eq '++' or $op eq '--') {
2549                                         if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) {
2550                                                 ERROR("SPACING",
2551                                                       "space required one side of that '$op' $at\n" . $hereptr);
2552                                         }
2553                                         if ($ctx =~ /Wx[BE]/ ||
2554                                             ($ctx =~ /Wx./ && $cc =~ /^;/)) {
2555                                                 ERROR("SPACING",
2556                                                       "space prohibited before that '$op' $at\n" . $hereptr);
2557                                         }
2558                                         if ($ctx =~ /ExW/) {
2559                                                 ERROR("SPACING",
2560                                                       "space prohibited after that '$op' $at\n" . $hereptr);
2561                                         }
2562
2563
2564                                 # << and >> may either have or not have spaces both sides
2565                                 } elsif ($op eq '<<' or $op eq '>>' or
2566                                          $op eq '&' or $op eq '^' or $op eq '|' or
2567                                          $op eq '+' or $op eq '-' or
2568                                          $op eq '*' or $op eq '/' or
2569                                          $op eq '%')
2570                                 {
2571                                         if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
2572                                                 ERROR("SPACING",
2573                                                       "need consistent spacing around '$op' $at\n" .
2574                                                         $hereptr);
2575                                         }
2576
2577                                 # A colon needs no spaces before when it is
2578                                 # terminating a case value or a label.
2579                                 } elsif ($opv eq ':C' || $opv eq ':L') {
2580                                         if ($ctx =~ /Wx./) {
2581                                                 ERROR("SPACING",
2582                                                       "space prohibited before that '$op' $at\n" . $hereptr);
2583                                         }
2584
2585                                 # All the others need spaces both sides.
2586                                 } elsif ($ctx !~ /[EWC]x[CWE]/) {
2587                                         my $ok = 0;
2588
2589                                         # Ignore email addresses <foo@bar>
2590                                         if (($op eq '<' &&
2591                                              $cc =~ /^\S+\@\S+>/) ||
2592                                             ($op eq '>' &&
2593                                              $ca =~ /<\S+\@\S+$/))
2594                                         {
2595                                                 $ok = 1;
2596                                         }
2597
2598                                         # Ignore ?:
2599                                         if (($opv eq ':O' && $ca =~ /\?$/) ||
2600                                             ($op eq '?' && $cc =~ /^:/)) {
2601                                                 $ok = 1;
2602                                         }
2603
2604                                         if ($ok == 0) {
2605                                                 ERROR("SPACING",
2606                                                       "spaces required around that '$op' $at\n" . $hereptr);
2607                                         }
2608                                 }
2609                                 $off += length($elements[$n + 1]);
2610                         }
2611                 }
2612
2613 # check for multiple assignments
2614                 if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
2615                         CHK("MULTIPLE_ASSIGNMENTS",
2616                             "multiple assignments should be avoided\n" . $herecurr);
2617                 }
2618
2619 ## # check for multiple declarations, allowing for a function declaration
2620 ## # continuation.
2621 ##              if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
2622 ##                  $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
2623 ##
2624 ##                      # Remove any bracketed sections to ensure we do not
2625 ##                      # falsly report the parameters of functions.
2626 ##                      my $ln = $line;
2627 ##                      while ($ln =~ s/\([^\(\)]*\)//g) {
2628 ##                      }
2629 ##                      if ($ln =~ /,/) {
2630 ##                              WARN("MULTIPLE_DECLARATION",
2631 ##                                   "declaring multiple variables together should be avoided\n" . $herecurr);
2632 ##                      }
2633 ##              }
2634
2635 #need space before brace following if, while, etc
2636                 if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
2637                     $line =~ /do{/) {
2638                         ERROR("SPACING",
2639                               "space required before the open brace '{'\n" . $herecurr);
2640                 }
2641
2642 # closing brace should have a space following it when it has anything
2643 # on the line
2644                 if ($line =~ /}(?!(?:,|;|\)))\S/) {
2645                         ERROR("SPACING",
2646                               "space required after that close brace '}'\n" . $herecurr);
2647                 }
2648
2649 # check spacing on square brackets
2650                 if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
2651                         ERROR("SPACING",
2652                               "space prohibited after that open square bracket '['\n" . $herecurr);
2653                 }
2654                 if ($line =~ /\s\]/) {
2655                         ERROR("SPACING",
2656                               "space prohibited before that close square bracket ']'\n" . $herecurr);
2657                 }
2658
2659 # check spacing on parentheses
2660                 if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
2661                     $line !~ /for\s*\(\s+;/) {
2662                         ERROR("SPACING",
2663                               "space prohibited after that open parenthesis '('\n" . $herecurr);
2664                 }
2665                 if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ &&
2666                     $line !~ /for\s*\(.*;\s+\)/ &&
2667                     $line !~ /:\s+\)/) {
2668                         ERROR("SPACING",
2669                               "space prohibited before that close parenthesis ')'\n" . $herecurr);
2670                 }
2671
2672 #goto labels aren't indented, allow a single space however
2673                 if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
2674                    !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
2675                         WARN("INDENTED_LABEL",
2676                              "labels should not be indented\n" . $herecurr);
2677                 }
2678
2679 # Return is not a function.
2680                 if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) {
2681                         my $spacing = $1;
2682                         my $value = $2;
2683
2684                         # Flatten any parentheses
2685                         $value =~ s/\(/ \(/g;
2686                         $value =~ s/\)/\) /g;
2687                         while ($value =~ s/\[[^\[\]]*\]/1/ ||
2688                                $value !~ /(?:$Ident|-?$Constant)\s*
2689                                              $Compare\s*
2690                                              (?:$Ident|-?$Constant)/x &&
2691                                $value =~ s/\([^\(\)]*\)/1/) {
2692                         }
2693 #print "value<$value>\n";
2694                         if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
2695                                 ERROR("RETURN_PARENTHESES",
2696                                       "return is not a function, parentheses are not required\n" . $herecurr);
2697
2698                         } elsif ($spacing !~ /\s+/) {
2699                                 ERROR("SPACING",
2700                                       "space required before the open parenthesis '('\n" . $herecurr);
2701                         }
2702                 }
2703 # Return of what appears to be an errno should normally be -'ve
2704                 if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {
2705                         my $name = $1;
2706                         if ($name ne 'EOF' && $name ne 'ERROR') {
2707                                 WARN("USE_NEGATIVE_ERRNO",
2708                                      "return of an errno should typically be -ve (return -$1)\n" . $herecurr);
2709                         }
2710                 }
2711
2712 # Need a space before open parenthesis after if, while etc
2713                 if ($line=~/\b(if|while|for|switch)\(/) {
2714                         ERROR("SPACING", "space required before the open parenthesis '('\n" . $herecurr);
2715                 }
2716
2717 # Check for illegal assignment in if conditional -- and check for trailing
2718 # statements after the conditional.
2719                 if ($line =~ /do\s*(?!{)/) {
2720                         ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
2721                                 ctx_statement_block($linenr, $realcnt, 0)
2722                                         if (!defined $stat);
2723                         my ($stat_next) = ctx_statement_block($line_nr_next,
2724                                                 $remain_next, $off_next);
2725                         $stat_next =~ s/\n./\n /g;
2726                         ##print "stat<$stat> stat_next<$stat_next>\n";
2727
2728                         if ($stat_next =~ /^\s*while\b/) {
2729                                 # If the statement carries leading newlines,
2730                                 # then count those as offsets.
2731                                 my ($whitespace) =
2732                                         ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s);
2733                                 my $offset =
2734                                         statement_rawlines($whitespace) - 1;
2735
2736                                 $suppress_whiletrailers{$line_nr_next +
2737                                                                 $offset} = 1;
2738                         }
2739                 }
2740                 if (!defined $suppress_whiletrailers{$linenr} &&
2741                     $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) {
2742                         my ($s, $c) = ($stat, $cond);
2743
2744                         if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) {
2745                                 ERROR("ASSIGN_IN_IF",
2746                                       "do not use assignment in if condition\n" . $herecurr);
2747                         }
2748
2749                         # Find out what is on the end of the line after the
2750                         # conditional.
2751                         substr($s, 0, length($c), '');
2752                         $s =~ s/\n.*//g;
2753                         $s =~ s/$;//g;  # Remove any comments
2754                         if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ &&
2755                             $c !~ /}\s*while\s*/)
2756                         {
2757                                 # Find out how long the conditional actually is.
2758                                 my @newlines = ($c =~ /\n/gs);
2759                                 my $cond_lines = 1 + $#newlines;
2760                                 my $stat_real = '';
2761
2762                                 $stat_real = raw_line($linenr, $cond_lines)
2763                                                         . "\n" if ($cond_lines);
2764                                 if (defined($stat_real) && $cond_lines > 1) {
2765                                         $stat_real = "[...]\n$stat_real";
2766                                 }
2767
2768                                 ERROR("TRAILING_STATEMENTS",
2769                                       "trailing statements should be on next line\n" . $herecurr . $stat_real);
2770                         }
2771                 }
2772
2773 # Check for bitwise tests written as boolean
2774                 if ($line =~ /
2775                         (?:
2776                                 (?:\[|\(|\&\&|\|\|)
2777                                 \s*0[xX][0-9]+\s*
2778                                 (?:\&\&|\|\|)
2779                         |
2780                                 (?:\&\&|\|\|)
2781                                 \s*0[xX][0-9]+\s*
2782                                 (?:\&\&|\|\||\)|\])
2783                         )/x)
2784                 {
2785                         WARN("HEXADECIMAL_BOOLEAN_TEST",
2786                              "boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
2787                 }
2788
2789 # if and else should not have general statements after it
2790                 if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
2791                         my $s = $1;
2792                         $s =~ s/$;//g;  # Remove any comments
2793                         if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
2794                                 ERROR("TRAILING_STATEMENTS",
2795                                       "trailing statements should be on next line\n" . $herecurr);
2796                         }
2797                 }
2798 # if should not continue a brace
2799                 if ($line =~ /}\s*if\b/) {
2800                         ERROR("TRAILING_STATEMENTS",
2801                               "trailing statements should be on next line\n" .
2802                                 $herecurr);
2803                 }
2804 # case and default should not have general statements after them
2805                 if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
2806                     $line !~ /\G(?:
2807                         (?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$|
2808                         \s*return\s+
2809                     )/xg)
2810                 {
2811                         ERROR("TRAILING_STATEMENTS",
2812                               "trailing statements should be on next line\n" . $herecurr);
2813                 }
2814
2815                 # Check for }<nl>else {, these must be at the same
2816                 # indent level to be relevant to each other.
2817                 if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and
2818                                                 $previndent == $indent) {
2819                         ERROR("ELSE_AFTER_BRACE",
2820                               "else should follow close brace '}'\n" . $hereprev);
2821                 }
2822
2823                 if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and
2824                                                 $previndent == $indent) {
2825                         my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);
2826
2827                         # Find out what is on the end of the line after the
2828                         # conditional.
2829                         substr($s, 0, length($c), '');
2830                         $s =~ s/\n.*//g;
2831
2832                         if ($s =~ /^\s*;/) {
2833                                 ERROR("WHILE_AFTER_BRACE",
2834                                       "while should follow close brace '}'\n" . $hereprev);
2835                         }
2836                 }
2837
2838 #studly caps, commented out until figure out how to distinguish between use of existing and adding new
2839 #               if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) {
2840 #                   print "No studly caps, use _\n";
2841 #                   print "$herecurr";
2842 #                   $clean = 0;
2843 #               }
2844
2845 #no spaces allowed after \ in define
2846                 if ($line=~/\#\s*define.*\\\s$/) {
2847                         WARN("WHITESPACE_AFTER_LINE_CONTINUATION",
2848                              "Whitepspace after \\ makes next lines useless\n" . $herecurr);
2849                 }
2850
2851 #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
2852                 if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
2853                         my $file = "$1.h";
2854                         my $checkfile = "include/linux/$file";
2855                         if (-f "$root/$checkfile" &&
2856                             $realfile ne $checkfile &&
2857                             $1 !~ /$allowed_asm_includes/)
2858                         {
2859                                 if ($realfile =~ m{^arch/}) {
2860                                         CHK("ARCH_INCLUDE_LINUX",
2861                                             "Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
2862                                 } else {
2863                                         WARN("INCLUDE_LINUX",
2864                                              "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
2865                                 }
2866                         }
2867                 }
2868
2869 # multi-statement macros should be enclosed in a do while loop, grab the
2870 # first statement and ensure its the whole macro if its not enclosed
2871 # in a known good container
2872                 if ($realfile !~ m@/vmlinux.lds.h$@ &&
2873                     $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) {
2874                         my $ln = $linenr;
2875                         my $cnt = $realcnt;
2876                         my ($off, $dstat, $dcond, $rest);
2877                         my $ctx = '';
2878                         ($dstat, $dcond, $ln, $cnt, $off) =
2879                                 ctx_statement_block($linenr, $realcnt, 0);
2880                         $ctx = $dstat;
2881                         #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
2882                         #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
2883
2884                         $dstat =~ s/^.\s*\#\s*define\s+$Ident(?:\([^\)]*\))?\s*//;
2885                         $dstat =~ s/$;//g;
2886                         $dstat =~ s/\\\n.//g;
2887                         $dstat =~ s/^\s*//s;
2888                         $dstat =~ s/\s*$//s;
2889
2890                         # Flatten any parentheses and braces
2891                         while ($dstat =~ s/\([^\(\)]*\)/1/ ||
2892                                $dstat =~ s/\{[^\{\}]*\}/1/ ||
2893                                $dstat =~ s/\[[^\[\]]*\]/1/)
2894                         {
2895                         }
2896
2897                         # Flatten any obvious string concatentation.
2898                         while ($dstat =~ s/("X*")\s*$Ident/$1/ ||
2899                                $dstat =~ s/$Ident\s*("X*")/$1/)
2900                         {
2901                         }
2902
2903                         my $exceptions = qr{
2904                                 $Declare|
2905                                 module_param_named|
2906                                 MODULE_PARAM_DESC|
2907                                 DECLARE_PER_CPU|
2908                                 DEFINE_PER_CPU|
2909                                 __typeof__\(|
2910                                 union|
2911                                 struct|
2912                                 \.$Ident\s*=\s*|
2913                                 ^\"|\"$
2914                         }x;
2915                         #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
2916                         if ($dstat ne '' &&
2917                             $dstat !~ /^(?:$Ident|-?$Constant),$/ &&                    # 10, // foo(),
2918                             $dstat !~ /^(?:$Ident|-?$Constant);$/ &&                    # foo();
2919                             $dstat !~ /^(?:$Ident|-?$Constant)$/ &&                     # 10 // foo()
2920                             $dstat !~ /^'X'$/ &&                                        # character constants
2921                             $dstat !~ /$exceptions/ &&
2922                             $dstat !~ /^\.$Ident\s*=/ &&                                # .foo =
2923                             $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ &&       # do {...} while (...); // do {...} while (...)
2924                             $dstat !~ /^for\s*$Constant$/ &&                            # for (...)
2925                             $dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ &&   # for (...) bar()
2926                             $dstat !~ /^do\s*{/ &&                                      # do {...
2927                             $dstat !~ /^\({/)                                           # ({...
2928                         {
2929                                 $ctx =~ s/\n*$//;
2930                                 my $herectx = $here . "\n";
2931                                 my $cnt = statement_rawlines($ctx);
2932
2933                                 for (my $n = 0; $n < $cnt; $n++) {
2934                                         $herectx .= raw_line($linenr, $n) . "\n";
2935                                 }
2936
2937                                 if ($dstat =~ /;/) {
2938                                         ERROR("MULTISTATEMENT_MACRO_USE_DO_WHILE",
2939                                               "Macros with multiple statements should be enclosed in a do - while loop\n" . "$herectx");
2940                                 } else {
2941                                         ERROR("COMPLEX_MACRO",
2942                                               "Macros with complex values should be enclosed in parenthesis\n" . "$herectx");
2943                                 }
2944                         }
2945                 }
2946
2947 # make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
2948 # all assignments may have only one of the following with an assignment:
2949 #       .
2950 #       ALIGN(...)
2951 #       VMLINUX_SYMBOL(...)
2952                 if ($realfile eq 'vmlinux.lds.h' && $line =~ /(?:(?:^|\s)$Ident\s*=|=\s*$Ident(?:\s|$))/) {
2953                         WARN("MISSING_VMLINUX_SYMBOL",
2954                              "vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols\n" . $herecurr);
2955                 }
2956
2957 # check for redundant bracing round if etc
2958                 if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
2959                         my ($level, $endln, @chunks) =
2960                                 ctx_statement_full($linenr, $realcnt, 1);
2961                         #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
2962                         #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
2963                         if ($#chunks > 0 && $level == 0) {
2964                                 my $allowed = 0;
2965                                 my $seen = 0;
2966                                 my $herectx = $here . "\n";
2967                                 my $ln = $linenr - 1;
2968                                 for my $chunk (@chunks) {
2969                                         my ($cond, $block) = @{$chunk};
2970
2971                                         # If the condition carries leading newlines, then count those as offsets.
2972                                         my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
2973                                         my $offset = statement_rawlines($whitespace) - 1;
2974
2975                                         #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
2976
2977                                         # We have looked at and allowed this specific line.
2978                                         $suppress_ifbraces{$ln + $offset} = 1;
2979
2980                                         $herectx .= "$rawlines[$ln + $offset]\n[...]\n";
2981                                         $ln += statement_rawlines($block) - 1;
2982
2983                                         substr($block, 0, length($cond), '');
2984
2985                                         $seen++ if ($block =~ /^\s*{/);
2986
2987                                         #print "cond<$cond> block<$block> allowed<$allowed>\n";
2988                                         if (statement_lines($cond) > 1) {
2989                                                 #print "APW: ALLOWED: cond<$cond>\n";
2990                                                 $allowed = 1;
2991                                         }
2992                                         if ($block =~/\b(?:if|for|while)\b/) {
2993                                                 #print "APW: ALLOWED: block<$block>\n";
2994                                                 $allowed = 1;
2995                                         }
2996                                         if (statement_block_size($block) > 1) {
2997                                                 #print "APW: ALLOWED: lines block<$block>\n";
2998                                                 $allowed = 1;
2999                                         }
3000                                 }
3001                                 if ($seen && !$allowed) {
3002                                         WARN("BRACES",
3003                                              "braces {} are not necessary for any arm of this statement\n" . $herectx);
3004                                 }
3005                         }
3006                 }
3007                 if (!defined $suppress_ifbraces{$linenr - 1} &&
3008                                         $line =~ /\b(if|while|for|else)\b/) {
3009                         my $allowed = 0;
3010
3011                         # Check the pre-context.
3012                         if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
3013                                 #print "APW: ALLOWED: pre<$1>\n";
3014                                 $allowed = 1;
3015                         }
3016
3017                         my ($level, $endln, @chunks) =
3018                                 ctx_statement_full($linenr, $realcnt, $-[0]);
3019
3020                         # Check the condition.
3021                         my ($cond, $block) = @{$chunks[0]};
3022                         #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
3023                         if (defined $cond) {
3024                                 substr($block, 0, length($cond), '');
3025                         }
3026                         if (statement_lines($cond) > 1) {
3027                                 #print "APW: ALLOWED: cond<$cond>\n";
3028                                 $allowed = 1;
3029                         }
3030                         if ($block =~/\b(?:if|for|while)\b/) {
3031                                 #print "APW: ALLOWED: block<$block>\n";
3032                                 $allowed = 1;
3033                         }
3034                         if (statement_block_size($block) > 1) {
3035                                 #print "APW: ALLOWED: lines block<$block>\n";
3036                                 $allowed = 1;
3037                         }
3038                         # Check the post-context.
3039                         if (defined $chunks[1]) {
3040                                 my ($cond, $block) = @{$chunks[1]};
3041                                 if (defined $cond) {
3042                                         substr($block, 0, length($cond), '');
3043                                 }
3044                                 if ($block =~ /^\s*\{/) {
3045                                         #print "APW: ALLOWED: chunk-1 block<$block>\n";
3046                                         $allowed = 1;
3047                                 }
3048                         }
3049                         if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
3050                                 my $herectx = $here . "\n";
3051                                 my $cnt = statement_rawlines($block);
3052
3053                                 for (my $n = 0; $n < $cnt; $n++) {
3054                                         $herectx .= raw_line($linenr, $n) . "\n";
3055                                 }
3056
3057                                 WARN("BRACES",
3058                                      "braces {} are not necessary for single statement blocks\n" . $herectx);
3059                         }
3060                 }
3061
3062 # don't include deprecated include files (uses RAW line)
3063                 for my $inc (@dep_includes) {
3064                         if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
3065                                 ERROR("DEPRECATED_INCLUDE",
3066                                       "Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
3067                         }
3068                 }
3069
3070 # don't use deprecated functions
3071                 for my $func (@dep_functions) {
3072                         if ($line =~ /\b$func\b/) {
3073                                 ERROR("DEPRECATED_FUNCTION",
3074                                       "Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
3075                         }
3076                 }
3077
3078 # no volatiles please
3079                 my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
3080                 if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
3081                         WARN("VOLATILE",
3082                              "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
3083                 }
3084
3085 # warn about #if 0
3086                 if ($line =~ /^.\s*\#\s*if\s+0\b/) {
3087                         CHK("REDUNDANT_CODE",
3088                             "if this code is redundant consider removing it\n" .
3089                                 $herecurr);
3090                 }
3091
3092 # check for needless kfree() checks
3093                 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
3094                         my $expr = $1;
3095                         if ($line =~ /\bkfree\(\Q$expr\E\);/) {
3096                                 WARN("NEEDLESS_KFREE",
3097                                      "kfree(NULL) is safe this check is probably not required\n" . $hereprev);
3098                         }
3099                 }
3100 # check for needless usb_free_urb() checks
3101                 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
3102                         my $expr = $1;
3103                         if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) {
3104                                 WARN("NEEDLESS_USB_FREE_URB",
3105                                      "usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev);
3106                         }
3107                 }
3108
3109 # prefer usleep_range over udelay
3110                 if ($line =~ /\budelay\s*\(\s*(\w+)\s*\)/) {
3111                         # ignore udelay's < 10, however
3112                         if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) {
3113                                 CHK("USLEEP_RANGE",
3114                                     "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line);
3115                         }
3116                 }
3117
3118 # warn about unexpectedly long msleep's
3119                 if ($line =~ /\bmsleep\s*\((\d+)\);/) {
3120                         if ($1 < 20) {
3121                                 WARN("MSLEEP",
3122                                      "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $line);
3123                         }
3124                 }
3125
3126 # warn about #ifdefs in C files
3127 #               if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
3128 #                       print "#ifdef in C files should be avoided\n";
3129 #                       print "$herecurr";
3130 #                       $clean = 0;
3131 #               }
3132
3133 # warn about spacing in #ifdefs
3134                 if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
3135                         ERROR("SPACING",
3136                               "exactly one space required after that #$1\n" . $herecurr);
3137                 }
3138
3139 # check for spinlock_t definitions without a comment.
3140                 if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
3141                     $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
3142                         my $which = $1;
3143                         if (!ctx_has_comment($first_line, $linenr)) {
3144                                 CHK("UNCOMMENTED_DEFINITION",
3145                                     "$1 definition without comment\n" . $herecurr);
3146                         }
3147                 }
3148 # check for memory barriers without a comment.
3149                 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
3150                         if (!ctx_has_comment($first_line, $linenr)) {
3151                                 CHK("MEMORY_BARRIER",
3152                                     "memory barrier without comment\n" . $herecurr);
3153                         }
3154                 }
3155 # check of hardware specific defines
3156                 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
3157                         CHK("ARCH_DEFINES",
3158                             "architecture specific defines should be avoided\n" .  $herecurr);
3159                 }
3160
3161 # Check that the storage class is at the beginning of a declaration
3162                 if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
3163                         WARN("STORAGE_CLASS",
3164                              "storage class should be at the beginning of the declaration\n" . $herecurr)
3165                 }
3166
3167 # check the location of the inline attribute, that it is between
3168 # storage class and type.
3169                 if ($line =~ /\b$Type\s+$Inline\b/ ||
3170                     $line =~ /\b$Inline\s+$Storage\b/) {
3171                         ERROR("INLINE_LOCATION",
3172                               "inline keyword should sit between storage class and type\n" . $herecurr);
3173                 }
3174
3175 # Check for __inline__ and __inline, prefer inline
3176                 if ($line =~ /\b(__inline__|__inline)\b/) {
3177                         WARN("INLINE",
3178                              "plain inline is preferred over $1\n" . $herecurr);
3179                 }
3180
3181 # Check for __attribute__ packed, prefer __packed
3182                 if ($line =~ /\b__attribute__\s*\(\s*\(.*\bpacked\b/) {
3183                         WARN("PREFER_PACKED",
3184                              "__packed is preferred over __attribute__((packed))\n" . $herecurr);
3185                 }
3186
3187 # Check for __attribute__ aligned, prefer __aligned
3188                 if ($line =~ /\b__attribute__\s*\(\s*\(.*aligned/) {
3189                         WARN("PREFER_ALIGNED",
3190                              "__aligned(size) is preferred over __attribute__((aligned(size)))\n" . $herecurr);
3191                 }
3192
3193 # Check for __attribute__ format(printf, prefer __printf
3194                 if ($line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf/) {
3195                         WARN("PREFER_PRINTF",
3196                              "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . $herecurr);
3197                 }
3198
3199 # Check for __attribute__ format(scanf, prefer __scanf
3200                 if ($line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\b/) {
3201                         WARN("PREFER_SCANF",
3202                              "__scanf(string-index, first-to-check) is preferred over __attribute__((format(scanf, string-index, first-to-check)))\n" . $herecurr);
3203                 }
3204
3205 # check for sizeof(&)
3206                 if ($line =~ /\bsizeof\s*\(\s*\&/) {
3207                         WARN("SIZEOF_ADDRESS",
3208                              "sizeof(& should be avoided\n" . $herecurr);
3209                 }
3210
3211 # check for line continuations in quoted strings with odd counts of "
3212                 if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) {
3213                         WARN("LINE_CONTINUATIONS",
3214                              "Avoid line continuations in quoted strings\n" . $herecurr);
3215                 }
3216
3217 # Check for misused memsets
3218                 if ($^V && $^V ge 5.10.0 &&
3219                     defined $stat &&
3220                     $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*$FuncArg\s*\)/s) {
3221
3222                         my $ms_addr = $2;
3223                         my $ms_val = $7;
3224                         my $ms_size = $12;
3225
3226                         if ($ms_size =~ /^(0x|)0$/i) {
3227                                 ERROR("MEMSET",
3228                                       "memset to 0's uses 0 as the 2nd argument, not the 3rd\n" . "$here\n$stat\n");
3229                         } elsif ($ms_size =~ /^(0x|)1$/i) {
3230                                 WARN("MEMSET",
3231                                      "single byte memset is suspicious. Swapped 2nd/3rd argument?\n" . "$here\n$stat\n");
3232                         }
3233                 }
3234
3235 # typecasts on min/max could be min_t/max_t
3236                 if ($^V && $^V ge 5.10.0 &&
3237                     defined $stat &&
3238                     $stat =~ /^\+(?:.*?)\b(min|max)\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\)/) {
3239                         if (defined $2 || defined $7) {
3240                                 my $call = $1;
3241                                 my $cast1 = deparenthesize($2);
3242                                 my $arg1 = $3;
3243                                 my $cast2 = deparenthesize($7);
3244                                 my $arg2 = $8;
3245                                 my $cast;
3246
3247                                 if ($cast1 ne "" && $cast2 ne "" && $cast1 ne $cast2) {
3248                                         $cast = "$cast1 or $cast2";
3249                                 } elsif ($cast1 ne "") {
3250                                         $cast = $cast1;
3251                                 } else {
3252                                         $cast = $cast2;
3253                                 }
3254                                 WARN("MINMAX",
3255                                      "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . "$here\n$stat\n");
3256                         }
3257                 }
3258
3259 # check for new externs in .c files.
3260                 if ($realfile =~ /\.c$/ && defined $stat &&
3261                     $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
3262                 {
3263                         my $function_name = $1;
3264                         my $paren_space = $2;
3265
3266                         my $s = $stat;
3267                         if (defined $cond) {
3268                                 substr($s, 0, length($cond), '');
3269                         }
3270                         if ($s =~ /^\s*;/ &&
3271                             $function_name ne 'uninitialized_var')
3272                         {
3273                                 WARN("AVOID_EXTERNS",
3274                                      "externs should be avoided in .c files\n" .  $herecurr);
3275                         }
3276
3277                         if ($paren_space =~ /\n/) {
3278                                 WARN("FUNCTION_ARGUMENTS",
3279                                      "arguments for function declarations should follow identifier\n" . $herecurr);
3280                         }
3281
3282                 } elsif ($realfile =~ /\.c$/ && defined $stat &&
3283                     $stat =~ /^.\s*extern\s+/)
3284                 {
3285                         WARN("AVOID_EXTERNS",
3286                              "externs should be avoided in .c files\n" .  $herecurr);
3287                 }
3288
3289 # checks for new __setup's
3290                 if ($rawline =~ /\b__setup\("([^"]*)"/) {
3291                         my $name = $1;
3292
3293                         if (!grep(/$name/, @setup_docs)) {
3294                                 CHK("UNDOCUMENTED_SETUP",
3295                                     "__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
3296                         }
3297                 }
3298
3299 # check for pointless casting of kmalloc return
3300                 if ($line =~ /\*\s*\)\s*[kv][czm]alloc(_node){0,1}\b/) {
3301                         WARN("UNNECESSARY_CASTS",
3302                              "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
3303                 }
3304
3305 # check for multiple semicolons
3306                 if ($line =~ /;\s*;\s*$/) {
3307                     WARN("ONE_SEMICOLON",
3308                          "Statements terminations use 1 semicolon\n" . $herecurr);
3309                 }
3310
3311 # check for gcc specific __FUNCTION__
3312                 if ($line =~ /__FUNCTION__/) {
3313                         WARN("USE_FUNC",
3314                              "__func__ should be used instead of gcc specific __FUNCTION__\n"  . $herecurr);
3315                 }
3316
3317 # check for semaphores initialized locked
3318                 if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
3319                         WARN("CONSIDER_COMPLETION",
3320                              "consider using a completion\n" . $herecurr);
3321
3322                 }
3323 # recommend kstrto* over simple_strto* and strict_strto*
3324                 if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) {
3325                         WARN("CONSIDER_KSTRTO",
3326                              "$1 is obsolete, use k$3 instead\n" . $herecurr);
3327                 }
3328 # check for __initcall(), use device_initcall() explicitly please
3329                 if ($line =~ /^.\s*__initcall\s*\(/) {
3330                         WARN("USE_DEVICE_INITCALL",
3331                              "please use device_initcall() instead of __initcall()\n" . $herecurr);
3332                 }
3333 # check for various ops structs, ensure they are const.
3334                 my $struct_ops = qr{acpi_dock_ops|
3335                                 address_space_operations|
3336                                 backlight_ops|
3337                                 block_device_operations|
3338                                 dentry_operations|
3339                                 dev_pm_ops|
3340                                 dma_map_ops|
3341                                 extent_io_ops|
3342                                 file_lock_operations|
3343                                 file_operations|
3344                                 hv_ops|
3345                                 ide_dma_ops|
3346                                 intel_dvo_dev_ops|
3347                                 item_operations|
3348                                 iwl_ops|
3349                                 kgdb_arch|
3350                                 kgdb_io|
3351                                 kset_uevent_ops|
3352                                 lock_manager_operations|
3353                                 microcode_ops|
3354                                 mtrr_ops|
3355                                 neigh_ops|
3356                                 nlmsvc_binding|
3357                                 pci_raw_ops|
3358                                 pipe_buf_operations|
3359                                 platform_hibernation_ops|
3360                                 platform_suspend_ops|
3361                                 proto_ops|
3362                                 rpc_pipe_ops|
3363                                 seq_operations|
3364                                 snd_ac97_build_ops|
3365                                 soc_pcmcia_socket_ops|
3366                                 stacktrace_ops|
3367                                 sysfs_ops|
3368                                 tty_operations|
3369                                 usb_mon_operations|
3370                                 wd_ops}x;
3371                 if ($line !~ /\bconst\b/ &&
3372                     $line =~ /\bstruct\s+($struct_ops)\b/) {
3373                         WARN("CONST_STRUCT",
3374                              "struct $1 should normally be const\n" .
3375                                 $herecurr);
3376                 }
3377
3378 # use of NR_CPUS is usually wrong
3379 # ignore definitions of NR_CPUS and usage to define arrays as likely right
3380                 if ($line =~ /\bNR_CPUS\b/ &&
3381                     $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
3382                     $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
3383                     $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
3384                     $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
3385                     $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
3386                 {
3387                         WARN("NR_CPUS",
3388                              "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
3389                 }
3390
3391 # check for %L{u,d,i} in strings
3392                 my $string;
3393                 while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
3394                         $string = substr($rawline, $-[1], $+[1] - $-[1]);
3395                         $string =~ s/%%/__/g;
3396                         if ($string =~ /(?<!%)%L[udi]/) {
3397                                 WARN("PRINTF_L",
3398                                      "\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
3399                                 last;
3400                         }
3401                 }
3402
3403 # whine mightly about in_atomic
3404                 if ($line =~ /\bin_atomic\s*\(/) {
3405                         if ($realfile =~ m@^drivers/@) {
3406                                 ERROR("IN_ATOMIC",
3407                                       "do not use in_atomic in drivers\n" . $herecurr);
3408                         } elsif ($realfile !~ m@^kernel/@) {
3409                                 WARN("IN_ATOMIC",
3410                                      "use of in_atomic() is incorrect outside core kernel code\n" . $herecurr);
3411                         }
3412                 }
3413
3414 # check for lockdep_set_novalidate_class
3415                 if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
3416                     $line =~ /__lockdep_no_validate__\s*\)/ ) {
3417                         if ($realfile !~ m@^kernel/lockdep@ &&
3418                             $realfile !~ m@^include/linux/lockdep@ &&
3419                             $realfile !~ m@^drivers/base/core@) {
3420                                 ERROR("LOCKDEP",
3421                                       "lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
3422                         }
3423                 }
3424
3425                 if ($line =~ /debugfs_create_file.*S_IWUGO/ ||
3426                     $line =~ /DEVICE_ATTR.*S_IWUGO/ ) {
3427                         WARN("EXPORTED_WORLD_WRITABLE",
3428                              "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
3429                 }
3430         }
3431
3432         # If we have no input at all, then there is nothing to report on
3433         # so just keep quiet.
3434         if ($#rawlines == -1) {
3435                 exit(0);
3436         }
3437
3438         # In mailback mode only produce a report in the negative, for
3439         # things that appear to be patches.
3440         if ($mailback && ($clean == 1 || !$is_patch)) {
3441                 exit(0);
3442         }
3443
3444         # This is not a patch, and we are are in 'no-patch' mode so
3445         # just keep quiet.
3446         if (!$chk_patch && !$is_patch) {
3447                 exit(0);
3448         }
3449
3450         if (!$is_patch) {
3451                 ERROR("NOT_UNIFIED_DIFF",
3452                       "Does not appear to be a unified-diff format patch\n");
3453         }
3454         if ($is_patch && $chk_signoff && $signoff == 0) {
3455                 ERROR("MISSING_SIGN_OFF",
3456                       "Missing Signed-off-by: line(s)\n");
3457         }
3458
3459         print report_dump();
3460         if ($summary && !($clean == 1 && $quiet == 1)) {
3461                 print "$filename " if ($summary_file);
3462                 print "total: $cnt_error errors, $cnt_warn warnings, " .
3463                         (($check)? "$cnt_chk checks, " : "") .
3464                         "$cnt_lines lines checked\n";
3465                 print "\n" if ($quiet == 0);
3466         }
3467
3468         if ($quiet == 0) {
3469
3470                 if ($^V lt 5.10.0) {
3471                         print("NOTE: perl $^V is not modern enough to detect all possible issues.\n");
3472                         print("An upgrade to at least perl v5.10.0 is suggested.\n\n");
3473                 }
3474
3475                 # If there were whitespace errors which cleanpatch can fix
3476                 # then suggest that.
3477                 if ($rpt_cleaners) {
3478                         print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n";
3479                         print "      scripts/cleanfile\n\n";
3480                         $rpt_cleaners = 0;
3481                 }
3482         }
3483
3484         if ($quiet == 0 && keys %ignore_type) {
3485             print "NOTE: Ignored message types:";
3486             foreach my $ignore (sort keys %ignore_type) {
3487                 print " $ignore";
3488             }
3489             print "\n\n";
3490         }
3491
3492         if ($clean == 1 && $quiet == 0) {
3493                 print "$vname has no obvious style problems and is ready for submission.\n"
3494         }
3495         if ($clean == 0 && $quiet == 0) {
3496                 print << "EOM";
3497 $vname has style problems, please review.
3498
3499 If any of these errors are false positives, please report
3500 them to the maintainer, see CHECKPATCH in MAINTAINERS.
3501 EOM
3502         }
3503
3504         return $clean;
3505 }